@khanacademy/perseus 19.1.2 → 19.1.3

package/package.json

@@ -3,7 +3,7 @@
     "description": "Core Perseus API (includes renderers and widgets)",
     "author": "Khan Academy",
     "license": "MIT",
-    "version": "19.1.2",
+    "version": "19.1.3",
     "publishConfig": {
         "access": "public"
     },
@@ -24,7 +24,7 @@
     "dependencies": {
         "@khanacademy/kas": "^0.3.7",
         "@khanacademy/kmath": "^0.1.10",
-        "@khanacademy/math-input": "^17.0.1",
+        "@khanacademy/math-input": "^17.0.2",
         "@khanacademy/perseus-core": "1.4.1",
         "@khanacademy/perseus-linter": "^0.3.10",
         "@khanacademy/pure-markdown": "^0.2.13",

package/src/__tests__/init.test.ts

@@ -0,0 +1,10 @@
+import init from "../init";
+import {getWidget} from "../widgets";
+
+describe("init", () => {
+    it("should correctly replace the transformer widget", async () => {
+        await init({skipMathJax: true});
+
+        expect(getWidget("transformer")).not.toBeNull();
+    });
+});

package/src/init.ts

@@ -21,10 +21,7 @@ const init = function (options: PerseusOptions): Promise<undefined> {
     Widgets.registerWidgets(basicWidgets);
     Widgets.registerWidgets(extraWidgets);
 
-    // This section replaces widgets
-    // When it's time to replace the transformer widget
-    // uncomment this line
-    // Widgets.replaceWidget("transformer", "deprecated-standin");
+    Widgets.replaceWidget("transformer", "deprecated-standin");
 
     // Pass skipMathJax: true if MathJax is already loaded and configured.
     const skipMathJax = options.skipMathJax;

package/src/types.ts

@@ -411,9 +411,13 @@ export type WidgetExports<
 > = Readonly<{
     name: string;
     displayName: string;
+
+    // Widgets should provide _one_ of these two properties only!
     // TODO: figure out how to ensure that the component returned supports
     // the `validate` method.
     getWidget?: () => T;
+    widget: T;
+
     accessible?: boolean | ((props: any) => boolean);
     /** Supresses widget from showing up in the dropdown in the content editor */
     hidden?: boolean;
@@ -449,8 +453,6 @@ export type WidgetExports<
     propUpgrades?: {
         [key: string]: (arg1: any) => any;
     }; // OldProps => NewProps,
-
-    widget: T;
 }>;
 
 export type PerseusWidgetMap = {

package/src/widgets/__tests__/__snapshots__/input-number.test.ts.snap

@@ -182,7 +182,7 @@ exports[`rendering supports mobile rendering: mobile render 1`] = `
                   class="mq-textarea"
                 >
                   <span
-                    aria-label="Math Input:"
+                    aria-label="Math input box:"
                   />
                 </span>
                 <span

package/src/widgets/__tests__/__snapshots__/numeric-input.test.ts.snap

@@ -44,7 +44,7 @@ exports[`Numeric input widget styles differently on mobile: mobile render 1`] =
                   class="mq-textarea"
                 >
                   <span
-                    aria-label="Math Input:"
+                    aria-label="Math input box:"
                   />
                 </span>
                 <span

package/src/widgets/label-image/marker.tsx

@@ -7,6 +7,7 @@
 
 import Color from "@khanacademy/wonder-blocks-color";
 import {View, type StyleType} from "@khanacademy/wonder-blocks-core";
+import * as i18n from "@khanacademy/wonder-blocks-i18n";
 import {StyleSheet} from "aphrodite";
 import * as React from "react";
 
@@ -127,6 +128,7 @@ export default class Marker extends React.Component<Props> {
             answerStyles,
             hovered,
             focused,
+            label,
         } = this.props;
 
         // We cannot make dropdown openers untabbable, so we isolate tabbing
@@ -141,6 +143,8 @@ export default class Marker extends React.Component<Props> {
                         styles.marker,
                         active && !markerDisabled && styles.markerActive,
                     ]}
+                    // already translated in: /widgets/graded-group.tsx
+                    aria-label={markerDisabled ? i18n._("Correct!") : label}
                 >
                     {this.renderIcon()}
                 </View>

package/src/widgets/label-image.tsx

@@ -598,16 +598,11 @@ export class LabelImage extends React.Component<
                         }
                         // cannot change answer choices once question is answered
                         disabled={disabled}
-                        opener={({opened, text}) => (
+                        opener={({opened}) => (
                             <Clickable
                                 role="button"
+                                aria-expanded={opened}
                                 key={`marker-${marker.x}.${marker.y}`}
-                                aria-label={
-                                    // already translated in: /widgets/graded-group.tsx
-                                    showCorrectness === "correct"
-                                        ? i18n._("Correct!")
-                                        : marker.label
-                                }
                             >
                                 {({hovered, focused, pressed}) => (
                                     <Marker

package/src/widgets.ts

@@ -170,7 +170,10 @@ export const upgradeWidgetInfoToLatestVersion = (
     oldWidgetInfo: PerseusWidget,
 ): PerseusWidget => {
     const type = oldWidgetInfo.type;
-    // TODO(LP-10707): Remove unnecessary type checking (`type` is a string)
+    // NOTE(jeremy): This looks like it could be replaced by fixing types so
+    // that `type` is non-optional. But we're seeing this in Sentry today so I
+    // suspect we have legacy data (potentially unpublished) and we should
+    // figure that out before depending solely on types.
     if (!_.isString(type)) {
         throw new PerseusError(
             "widget type must be a string, but was: " + type,