@khanacademy/perseus 1.3.2 → 1.3.4

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @khanacademy/perseus
 
+## 1.3.4
+
+### Patch Changes
+
+-   5a565227: bugfix for Radio editor selection and deletion
+
+## 1.3.3
+
+### Patch Changes
+
+-   47d2afc0: Force radio text to be dark for contrast
+
 ## 1.3.2
 
 ### Patch Changes

package/dist/es/index.css

@@ -1527,16 +1527,16 @@ body.mobile ul.inequalities-one-line-radios > li {
   font-family: inherit;
   font-size: 14px;
   line-height: 1.25;
-  color: #888D93;
+  color: #21242C;
 }
 .framework-perseus:not(.perseus-article):not(.perseus-mobile) .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph {
   font-family: inherit;
   font-size: 14px;
   line-height: 1.25;
-  color: #888D93;
+  color: #21242C;
 }
 .framework-perseus:not(.perseus-article):not(.perseus-mobile) .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph .katex {
-  color: #888D93;
+  color: #21242C;
 }
 .bibliotron-article.framework-perseus.perseus-article.perseus-mobile :not(blockquote) > div.paragraph,
 .framework-perseus:not(.perseus-article).perseus-mobile :not(blockquote) > div.paragraph {
@@ -1696,18 +1696,18 @@ body.mobile ul.inequalities-one-line-radios > li {
     font-family: inherit;
     font-size: 16px;
     line-height: 1.25;
-    color: #888D93;
+    color: #21242C;
   }
   .bibliotron-article.framework-perseus.perseus-article.perseus-mobile .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph,
   .framework-perseus:not(.perseus-article).perseus-mobile .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph {
     font-family: inherit;
     font-size: 16px;
     line-height: 1.25;
-    color: #888D93;
+    color: #21242C;
   }
   .bibliotron-article.framework-perseus.perseus-article.perseus-mobile .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph .katex,
   .framework-perseus:not(.perseus-article).perseus-mobile .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph .katex {
-    color: #888D93;
+    color: #21242C;
   }
   .bibliotron-article.framework-perseus.perseus-article.perseus-mobile .perseus-image-caption .paragraph .paragraph,
   .framework-perseus:not(.perseus-article).perseus-mobile .perseus-image-caption .paragraph .paragraph {
@@ -1859,18 +1859,18 @@ body.mobile ul.inequalities-one-line-radios > li {
     font-family: inherit;
     font-size: 18px;
     line-height: 1.25;
-    color: #888D93;
+    color: #21242C;
   }
   .bibliotron-article.framework-perseus.perseus-article.perseus-mobile .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph,
   .framework-perseus:not(.perseus-article).perseus-mobile .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph {
     font-family: inherit;
     font-size: 18px;
     line-height: 1.25;
-    color: #888D93;
+    color: #21242C;
   }
   .bibliotron-article.framework-perseus.perseus-article.perseus-mobile .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph .katex,
   .framework-perseus:not(.perseus-article).perseus-mobile .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph .katex {
-    color: #888D93;
+    color: #21242C;
   }
   .bibliotron-article.framework-perseus.perseus-article.perseus-mobile .perseus-image-caption .paragraph .paragraph,
   .framework-perseus:not(.perseus-article).perseus-mobile .perseus-image-caption .paragraph .paragraph {
@@ -2022,18 +2022,18 @@ body.mobile ul.inequalities-one-line-radios > li {
     font-family: inherit;
     font-size: 20px;
     line-height: 1.25;
-    color: #888D93;
+    color: #21242C;
   }
   .bibliotron-article.framework-perseus.perseus-article.perseus-mobile .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph,
   .framework-perseus:not(.perseus-article).perseus-mobile .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph {
     font-family: inherit;
     font-size: 20px;
     line-height: 1.25;
-    color: #888D93;
+    color: #21242C;
   }
   .bibliotron-article.framework-perseus.perseus-article.perseus-mobile .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph .katex,
   .framework-perseus:not(.perseus-article).perseus-mobile .perseus-radio-rationale-content .perseus-renderer > .paragraph .paragraph .katex {
-    color: #888D93;
+    color: #21242C;
   }
   .bibliotron-article.framework-perseus.perseus-article.perseus-mobile .perseus-image-caption .paragraph .paragraph,
   .framework-perseus:not(.perseus-article).perseus-mobile .perseus-image-caption .paragraph .paragraph {

package/dist/es/index.js

@@ -19447,7 +19447,7 @@ class Renderer extends React.Component {
         // look like a widget ID (ie. `widget-type \d+`). I can't figure
         // out how to trigger this line of code though.
 
-        /* istanbul ignore next line */
+        /* c8 ignore next line */
         return {};
       }
 
@@ -19786,7 +19786,7 @@ class Renderer extends React.Component {
           // reached. As noted above, these are always QuestionParagraphs
           // now.
 
-          /* istanbul ignore if */
+          /* c8 ignore if */
 
           if (typeof nodeOut === "string" && lastWasString) {
             /**
@@ -22484,12 +22484,12 @@ class Expression extends React.Component {
     });
 
     _defineProperty(this, "_handleFocus", () => {
-      /* istanbul ignore next */
+      /* c8 ignore next */
       this.props.onFocus([]);
     });
 
     _defineProperty(this, "_handleBlur", () => {
-      /* istanbul ignore next */
+      /* c8 ignore next */
       this.props.onBlur([]);
     });
 
@@ -22523,12 +22523,12 @@ class Expression extends React.Component {
       // The widget itself is an input, so we return a single empty list to
       // indicate this.
 
-      /* istanbul ignore next */
+      /* c8 ignore next */
       return [[]];
     });
 
     _defineProperty(this, "getGrammarTypeForPath", inputPath => {
-      /* istanbul ignore next */
+      /* c8 ignore next */
       return "expression";
     });
 
@@ -22578,7 +22578,7 @@ class Expression extends React.Component {
       // in the function variables list for the expression.
 
       if (!expression.parsed) {
-        /* istanbul ignore next */
+        /* c8 ignore next */
         Log.error("Unable to parse solution answer for expression", Errors.InvalidInput, {
           loggedMetadata: {
             rubric: JSON.stringify(rubric)
@@ -22884,7 +22884,7 @@ var keypadConfigurationForProps = widgetOptions => {
 };
 
 var propUpgrades$2 = {
-  /* istanbul ignore next */
+  /* c8 ignore next */
   "1": v0props => ({
     times: v0props.times,
     buttonSets: v0props.buttonSets,
@@ -23155,12 +23155,12 @@ class InputNumber extends React.Component {
       // The widget itself is an input, so we return a single empty list to
       // indicate this.
 
-      /* istanbul ignore next */
+      /* c8 ignore next */
       return [[]];
     });
 
     _defineProperty(this, "getGrammarTypeForPath", path => {
-      /* istanbul ignore next */
+      /* c8 ignore next */
       return "number";
     });
 
@@ -23221,7 +23221,7 @@ class InputNumber extends React.Component {
     var correct = null;
     var answerBlurb = null; // SAT is deprecated and not testable
 
-    /* istanbul ignore if */
+    /* c8 ignore if */
 
     if (this.props.apiOptions.satStyling && rubric) {
       var score = this.simpleValidate(rubric);
@@ -23265,7 +23265,7 @@ class InputNumber extends React.Component {
       linterContext: this.props.linterContext
     }); // SAT is deprecated, answer blurb is an SAT feature
 
-    /* istanbul ignore if */
+    /* c8 ignore if */
 
     if (answerBlurb) {
       return /*#__PURE__*/React.createElement("span", {
@@ -23426,7 +23426,7 @@ class NumericInput extends React.Component {
       var answerBlurb;
       /* Ignore this block because SAT is deprecated */
 
-      /* istanbul ignore next */
+      /* c8 ignore next */
 
       if (this.props.apiOptions.satStyling && rubric) {
         var score = this.simpleValidate(rubric);
@@ -23525,17 +23525,17 @@ class NumericInput extends React.Component {
       // The widget itself is an input, so we return a single empty list to
       // indicate this.
 
-      /* istanbul ignore next */
+      /* c8 ignore next */
       return [[]];
     });
 
     _defineProperty(this, "getGrammarTypeForPath", inputPath => {
-      /* istanbul ignore next */
+      /* c8 ignore next */
       return "number";
     });
 
     _defineProperty(this, "setInputValue", (path, newValue, cb) => {
-      /* istanbul ignore next */
+      /* c8 ignore next */
       this.props.onChange({
         currentValue: newValue
       }, cb);
@@ -23744,7 +23744,7 @@ class NumericInput extends React.Component {
     });
     /* This only gets used with SAT Content */
 
-    /* istanbul ignore next if */
+    /* c8 ignore next if */
 
     if (answerBlurb) {
       return /*#__PURE__*/React.createElement("span", {
@@ -26976,8 +26976,8 @@ function LibraryChoiceIcon(props) {
   }, /*#__PURE__*/React.createElement("div", {
     style: dynamicStyles,
     "data-test-id": "choice-icon__library-choice-icon",
-    className: css(styles$r.circle, showCorrectness && correct && styles$r.circleCorrect, showCorrectness && !correct && styles$r.circleIncorrect, showCorrectness && !correct && (checked || previouslyAnswered) && styles$r.circleIncorrectAnswered) // used in BaseRadio to check if we actually clicked on the
-    // radio icon
+    className: css(styles$r.circle, showCorrectness && correct && styles$r.circleCorrect, showCorrectness && !correct && styles$r.circleIncorrect, showCorrectness && !correct && (checked || previouslyAnswered) && styles$r.circleIncorrectAnswered) // used in BaseRadio editMode to check
+    // if we actually clicked on the radio icon
     ,
     "data-is-radio-icon": true
   }, /*#__PURE__*/React.createElement("div", {
@@ -27402,7 +27402,8 @@ function Choice(props) {
     },
     disabled: disabled || apiOptions.staticRender || apiOptions.readOnly,
     style: {
-      flex: 1
+      flex: 1,
+      color: Color.offBlack
     },
     ref: forwardedRef,
     "aria-hidden": "true"
@@ -27762,7 +27763,7 @@ function BaseRadio(props) {
     style: {
       listStyle: "none"
     }
-  }, choices.map(function (choice, i) {
+  }, choices.map((choice, i) => {
     var Element = Choice$1;
     var ref = /*#__PURE__*/React.createRef();
     choiceRefs.current[i] = ref;
@@ -27781,6 +27782,11 @@ function BaseRadio(props) {
       showRationale: choice.hasRationale && (reviewMode || choice.showRationale),
       pos: i,
       onChange: newValues => {
+        // editMode selection is handled in clickHandler
+        if (editMode) {
+          return;
+        }
+
         updateChoice(i, newValues);
       },
       ref
@@ -27838,7 +27844,7 @@ function BaseRadio(props) {
           // radio icon, then we want to trigger the
           // check by flipping the choice of the icon.
           if (elem.getAttribute("data-is-radio-icon")) {
-            this.updateChoice(i, {
+            updateChoice(i, {
               checked: !choice.checked,
               crossedOut: choice.crossedOut
             });
@@ -27862,7 +27868,7 @@ function BaseRadio(props) {
       onClick: clickHandler,
       onTouchStart: !labelWrap ? null : captureScratchpadTouchStart$2
     }, /*#__PURE__*/React.createElement(Element, elementProps));
-  }, this))); // Allow for horizontal scrolling if content is too wide, which may be
+  }))); // Allow for horizontal scrolling if content is too wide, which may be
   // an issue especially on phones.
   // This is disabled in SAT, since it conflicts with their theming.
 
@@ -28208,7 +28214,7 @@ class Radio$1 extends React.Component {
         noneOfTheAboveSelected
       }; // Support legacy choiceState implementation
     }
-    /* istanbul ignore if - props.values is deprecated */
+    /* c8 ignore if - props.values is deprecated */
 
 
     var {
@@ -28303,7 +28309,7 @@ class Radio$1 extends React.Component {
     } else if (this.props.values) {
       // Support legacy choiceStates implementation
 
-      /* istanbul ignore next - props.values is deprecated */
+      /* c8 ignore next - props.values is deprecated */
       choiceStates = this.props.values.map(val => ({
         selected: val,
         crossedOut: false,
@@ -28686,7 +28692,7 @@ _defineProperty(Categorizer, "defaultProps", {
 
 var pageMargin = 16; // Stylesheets aren't directly testable
 
-/* istanbul ignore next */
+/* c8 ignore next */
 
 var styles$m = StyleSheet.create({
   mobileTable: {