@khanacademy/perseus-linter 0.4.0 → 1.1.0

package/dist/index.js

@@ -2,7 +2,6 @@
 
 Object.defineProperty(exports, '__esModule', { value: true });
 
-var perseusError = require('@khanacademy/perseus-error');
 var perseusCore = require('@khanacademy/perseus-core');
 var PropTypes = require('prop-types');
 
@@ -29,7 +28,7 @@ class Selector {
    * subclasses must provide an implementation of this method.
    */
   match(state) {
-    throw new perseusError.PerseusError("Selector subclasses must implement match()", perseusError.Errors.NotAllowed);
+    throw new perseusCore.PerseusError("Selector subclasses must implement match()", perseusCore.Errors.NotAllowed);
   }
 
   /**
@@ -561,7 +560,7 @@ class Rule {
   constructor(name, severity, selector, pattern, lint, applies) {
     var _this = this;
     if (!selector && !pattern) {
-      throw new perseusError.PerseusError("Lint rules must have a selector or pattern", perseusError.Errors.InvalidInput, {
+      throw new perseusCore.PerseusError("Lint rules must have a selector or pattern", perseusCore.Errors.InvalidInput, {
         metadata: {
           name
         }
@@ -1159,12 +1158,25 @@ nested lists are hard to read on mobile devices;
 do not use additional indentation.`
 });
 
-var Profanity = Rule.makeRule({
-  name: "profanity",
-  // This list could obviously be expanded a lot, but I figured we
-  // could start with https://en.wikipedia.org/wiki/Seven_dirty_words
-  pattern: /\b(shit|piss|fuck|cunt|cocksucker|motherfucker|tits)\b/i,
-  message: "Avoid profanity"
+var StaticWidgetInQuestionStem = Rule.makeRule({
+  name: "static-widget-in-question-stem",
+  severity: Rule.Severity.WARNING,
+  selector: "widget",
+  lint: (state, content, nodes, match, context) => {
+    if (context.contentType !== "exercise") {
+      return;
+    }
+    if (context.stack.includes("hint")) {
+      return;
+    }
+    const widget = context?.widgets?.[state.currentNode().id];
+    if (!widget) {
+      return;
+    }
+    if (widget.static) {
+      return `Widget in question stem is static (non-interactive).`;
+    }
+  }
 });
 
 var TableMissingCells = Rule.makeRule({
@@ -1214,7 +1226,7 @@ do not put widgets inside of tables.`
 });
 
 // TODO(davidflanagan):
-var AllRules = [AbsoluteUrl, BlockquotedMath, BlockquotedWidget, DoubleSpacingAfterTerminal, ExtraContentSpacing, HeadingLevel1, HeadingLevelSkip, HeadingSentenceCase, HeadingTitleCase, ImageAltText, ImageInTable, LinkClickHere, LongParagraph, MathAdjacent, MathAlignExtraBreak, MathAlignLinebreaks, MathEmpty, MathFontSize, MathFrac, MathNested, MathStartsWithSpace, MathTextEmpty, NestedLists, TableMissingCells, UnescapedDollar, WidgetInTable, Profanity, MathWithoutDollars, UnbalancedCodeDelimiters, ImageSpacesAroundUrls, ImageWidget];
+var AllRules = [AbsoluteUrl, BlockquotedMath, BlockquotedWidget, DoubleSpacingAfterTerminal, ExtraContentSpacing, HeadingLevel1, HeadingLevelSkip, HeadingSentenceCase, HeadingTitleCase, ImageAltText, ImageInTable, LinkClickHere, LongParagraph, MathAdjacent, MathAlignExtraBreak, MathAlignLinebreaks, MathEmpty, MathFontSize, MathFrac, MathNested, MathStartsWithSpace, MathTextEmpty, NestedLists, StaticWidgetInQuestionStem, TableMissingCells, UnescapedDollar, WidgetInTable, MathWithoutDollars, UnbalancedCodeDelimiters, ImageSpacesAroundUrls, ImageWidget];
 
 /**
  * TreeTransformer is a class for traversing and transforming trees.  Create a
@@ -1571,7 +1583,7 @@ class TraversalState {
   replace() {
     const parent = this._containers.top();
     if (!parent) {
-      throw new perseusError.PerseusError("Can't replace the root of the tree", perseusError.Errors.Internal);
+      throw new perseusCore.PerseusError("Can't replace the root of the tree", perseusCore.Errors.Internal);
     }
 
     // The top of the container stack is either an array or an object
@@ -1624,7 +1636,7 @@ class TraversalState {
    */
   goToPreviousSibling() {
     if (!this.hasPreviousSibling()) {
-      throw new perseusError.PerseusError("goToPreviousSibling(): node has no previous sibling", perseusError.Errors.Internal);
+      throw new perseusCore.PerseusError("goToPreviousSibling(): node has no previous sibling", perseusCore.Errors.Internal);
     }
     this._currentNode = this.previousSibling();
     // Since we know that we have a previous sibling, we know that
@@ -1654,7 +1666,7 @@ class TraversalState {
    */
   goToParent() {
     if (!this.hasParent()) {
-      throw new perseusError.PerseusError("goToParent(): node has no ancestor", perseusError.Errors.NotAllowed);
+      throw new perseusCore.PerseusError("goToParent(): node has no ancestor", perseusCore.Errors.NotAllowed);
     }
     this._currentNode = this._ancestors.pop();
 
@@ -1761,7 +1773,7 @@ class Stack {
 
 // This file is processed by a Rollup plugin (replace) to inject the production
 const libName = "@khanacademy/perseus-linter";
-const libVersion = "0.4.0";
+const libVersion = "1.1.0";
 perseusCore.addLibraryVersionToPerseusDebug(libName, libVersion);
 
 // Define the shape of the linter context object that is passed through the