@khanacademy/perseus-linter 0.3.0 → 0.3.2

package/dist/index.js

@@ -600,7 +600,7 @@ class Rule {
       const lastSlash = pattern.lastIndexOf("/");
       const expression = pattern.substring(1, lastSlash);
       const flags = pattern.substring(lastSlash + 1);
-      // @ts-expect-error [FEI-5003] - TS2713 - Cannot access 'RegExp.flags' because 'RegExp' is a type, but not a namespace. Did you mean to retrieve the type of the property 'flags' in 'RegExp' with 'RegExp["flags"]'?
+      // @ts-expect-error - TS2713 - Cannot access 'RegExp.flags' because 'RegExp' is a type, but not a namespace. Did you mean to retrieve the type of the property 'flags' in 'RegExp' with 'RegExp["flags"]'?
       return new RegExp(expression, flags);
     }
     return new RegExp(pattern);
@@ -1124,11 +1124,9 @@ class TreeTransformer {
       // Record the node's text content if it has any.
       // Usually this is for nodes with a type property of "text",
       // but other nodes types like "math" may also have content.
-      // TODO(mdr): We found a new Flow error when upgrading:
-      //     "node.content (property `content` is missing in `TreeNode` [1].)"
-      // @ts-expect-error [FEI-5003] - TS2339 - Property 'content' does not exist on type 'TreeNode'.
+      // @ts-expect-error - TS2339 - Property 'content' does not exist on type 'TreeNode'.
       if (typeof node.content === "string") {
-        // @ts-expect-error [FEI-5003] - TS2339 - Property 'content' does not exist on type 'TreeNode'.
+        // @ts-expect-error - TS2339 - Property 'content' does not exist on type 'TreeNode'.
         content = node.content;
       }
 
@@ -1193,7 +1191,7 @@ class TreeTransformer {
       while (index < nodes.length) {
         state._indexes.push(index);
         content += this._traverse(nodes[index], state, f);
-        // Casting to convince Flow that this is a number
+        // Casting to convince TypeScript that this is a number
         index = state._indexes.pop() + 1;
       }
 
@@ -1220,7 +1218,7 @@ class TreeTransformer {
  * for that traversal, and the instance is passed to the traversal callback
  * function for each node that is traversed. This class is not intended to be
  * instantiated directly, but is exported so that its type can be used for
- * Flow annotaions.
+ * type annotaions.
  **/
 class TraversalState {
   // The root node of the tree being traversed
@@ -1229,8 +1227,8 @@ class TraversalState {
   // below instead of using these properties directly. Note that the
   // _containers and _indexes stacks can have two different types of
   // elements, depending on whether we just recursed on an array or on a
-  // node. This is hard for Flow to deal with, so you'll see a number of
-  // Flow casts through the any type when working with these two properties.
+  // node. This is hard for TypeScript to deal with, so you'll see a number of
+  // type casts through the any type when working with these two properties.
 
   // The constructor just stores the root node and creates empty stacks.
   constructor(root) {
@@ -1369,7 +1367,7 @@ class TraversalState {
 
     // The top of the container stack is either an array or an object
     // and the top of the indexes stack is a corresponding array index
-    // or object property. This is hard for Flow, so we have to do some
+    // or object property. This is hard for TypeScript, so we have to do some
     // unsafe casting and be careful when we use which cast version
     for (var _len = arguments.length, replacements = new Array(_len), _key = 0; _key < _len; _key++) {
       replacements[_key] = arguments[_key];
@@ -1422,7 +1420,7 @@ class TraversalState {
     this._currentNode = this.previousSibling();
     // Since we know that we have a previous sibling, we know that
     // the value on top of the stack is a number, but we have to do
-    // this unsafe cast because Flow doesn't know that.
+    // this unsafe cast because TypeScript doesn't know that.
     const index = this._indexes.pop();
     this._indexes.push(index - 1);
   }
@@ -1455,10 +1453,7 @@ class TraversalState {
     // and more as needed until we restore the invariant that
     // this._containers.top()[this.indexes.top()] === this._currentNode
     //
-    while (this._containers.size() &&
-    // This is safe, but easier to just disable flow than do casts
-    // $FlowFixMe[incompatible-use]
-    this._containers.top()[this._indexes.top()] !== this._currentNode) {
+    while (this._containers.size() && this._containers.top()[this._indexes.top()] !== this._currentNode) {
       this._containers.pop();
       this._indexes.pop();
     }
@@ -1509,7 +1504,7 @@ class Stack {
 
   /** Pop a value off of the stack. */
   pop() {
-    // @ts-expect-error [FEI-5003] - TS2322 - Type 'T | undefined' is not assignable to type 'T'.
+    // @ts-expect-error - TS2322 - Type 'T | undefined' is not assignable to type 'T'.
     return this.stack.pop();
   }
 
@@ -1606,7 +1601,7 @@ function runLinter(tree, context, highlight) {
     if (TreeTransformer.isTextNode(node)) {
       let next = state.nextSibling();
       while (TreeTransformer.isTextNode(next)) {
-        // @ts-expect-error [FEI-5003] - TS2339 - Property 'content' does not exist on type 'TreeNode'. | TS2533 - Object is possibly 'null' or 'undefined'. | TS2339 - Property 'content' does not exist on type 'TreeNode'.
+        // @ts-expect-error - TS2339 - Property 'content' does not exist on type 'TreeNode'. | TS2533 - Object is possibly 'null' or 'undefined'. | TS2339 - Property 'content' does not exist on type 'TreeNode'.
         node.content += next.content;
         state.removeNextSibling();
         next = state.nextSibling();
@@ -1708,7 +1703,7 @@ function runLinter(tree, context, highlight) {
     // this node, then we need to save the warnings for display
     // on the table itself
     if (insideTable && nodeWarnings.length) {
-      // @ts-expect-error [FEI-5003] - TS2345 - Argument of type 'any' is not assignable to parameter of type 'never'.
+      // @ts-expect-error - TS2345 - Argument of type 'any' is not assignable to parameter of type 'never'.
       tableWarnings.push(...nodeWarnings);
     }
 
@@ -1735,7 +1730,7 @@ function runLinter(tree, context, highlight) {
         // node under a new lint node and put the warnings there.
         state.replace({
           type: "lint",
-          // @ts-expect-error [FEI-5003] - TS2345 - Argument of type '{ type: string; content: TreeNode; message: string; ruleName: any; blockHighlight: any; insideTable: boolean; severity: any; }' is not assignable to parameter of type 'TreeNode'.
+          // @ts-expect-error - TS2345 - Argument of type '{ type: string; content: TreeNode; message: string; ruleName: any; blockHighlight: any; insideTable: boolean; severity: any; }' is not assignable to parameter of type 'TreeNode'.
           content: node,
           message: nodeWarnings.map(w => w.message).join("\n\n"),
           ruleName: nodeWarnings[0].rule,
@@ -1769,7 +1764,7 @@ function runLinter(tree, context, highlight) {
         // single line, so keeping them combined in that case might
         // be the best thing, anyway.
         //
-        // @ts-expect-error [FEI-5003] - TS2339 - Property 'content' does not exist on type 'TreeNode'.
+        // @ts-expect-error - TS2339 - Property 'content' does not exist on type 'TreeNode'.
         const content = node.content; // Text nodes have content
         const warning = nodeWarnings[0]; // There is only one warning.
         // These are the lint boundaries within the content