@khanacademy/perseus-linter 0.0.0-PR973-20240214213540 → 0.0.0-PR992-20240214202318

package/src/index.ts

@@ -1,281 +0,0 @@
-import Rule from "./rule";
-import AllRules from "./rules/all-rules";
-import TreeTransformer from "./tree-transformer";
-
-export {libVersion} from "./version";
-
-export {linterContextProps, linterContextDefault} from "./proptypes";
-export type {LinterContextProps} from "./types";
-
-const allLintRules: ReadonlyArray<any> = AllRules.filter(
-    (r) => r.severity < Rule.Severity.BULK_WARNING,
-);
-
-export {Rule, allLintRules as rules};
-
-/**
- * Run the Perseus linter over the specified markdown parse tree,
- * with the specified context object, and
- * return a (possibly empty) array of lint warning objects.  If the
- * highlight argument is true, this function also modifies the parse
- * tree to add "lint" nodes that can be visually rendered,
- * highlighting the problems for the user. The optional rules argument
- * is an array of Rule objects specifying which lint rules should be
- * applied to this parse tree. When omitted, a default set of rules is used.
- *
- * The context object may have additional properties that some lint
- * rules require:
- *
- *   context.content is the source content string that was parsed to create
- *   the parse tree.
- *
- *   context.widgets is the widgets object associated
- *   with the content string
- *
- * TODO: to make this even more general, allow the first argument to be
- * a string and run the parser over it in that case? (but ignore highlight
- * in that case). This would allow the one function to be used for both
- * online linting and batch linting.
- */
-export function runLinter(
-    tree: any,
-    context: any,
-    highlight: boolean,
-    rules: ReadonlyArray<any> = allLintRules,
-): ReadonlyArray<any> {
-    const warnings: Array<any> = [];
-    const tt = new TreeTransformer(tree);
-
-    // The markdown parser often outputs adjacent text nodes. We
-    // coalesce them before linting for efficiency and accuracy.
-    tt.traverse((node, state, content) => {
-        if (TreeTransformer.isTextNode(node)) {
-            let next = state.nextSibling();
-            while (TreeTransformer.isTextNode(next)) {
-                // @ts-expect-error - TS2339 - Property 'content' does not exist on type 'TreeNode'. | TS2533 - Object is possibly 'null' or 'undefined'. | TS2339 - Property 'content' does not exist on type 'TreeNode'.
-                node.content += next.content;
-                state.removeNextSibling();
-                next = state.nextSibling();
-            }
-        }
-    });
-
-    // HTML tables are complicated, and the CSS we use in
-    // ../components/lint.jsx to display lint does not work to
-    // correctly position the lint indicators in the margin when the
-    // lint is inside a table. So as a workaround we keep track of all
-    // the lint that appears within a table and move it up to the
-    // table element itself.
-    //
-    // It is not ideal to have to do this here,
-    // but it is cleaner here than fixing up the lint during rendering
-    // in perseus-markdown.jsx. If our lint display was simpler and
-    // did not require indicators in the margin, this wouldn't be a
-    // problem. Or, if we modified the lint display stuff so that
-    // indicator positioning and tooltip display were both handled
-    // with JavaScript (instead of pure CSS), then we could avoid this
-    // issue too. But using JavaScript has its own downsides: there is
-    // risk that the linter JavaScript would interfere with
-    // widget-related Javascript.
-    let tableWarnings: Array<never> = [];
-    let insideTable = false;
-
-    // Traverse through the nodes of the parse tree. At each node, loop
-    // through the array of lint rules and check whether there is a
-    // lint violation at that node.
-    tt.traverse((node, state, content) => {
-        const nodeWarnings: Array<any> = [];
-
-        // If our rule is only designed to be tested against a particular
-        // content type and we're not in that content type, we don't need to
-        // consider that rule.
-        const applicableRules = rules.filter((r) => r.applies(context));
-
-        // Generate a stack so we can identify our position in the tree in
-        // lint rules
-        const stack = [...context.stack];
-        stack.push(node.type);
-
-        const nodeContext = {
-            ...context,
-            stack: stack.join("."),
-        } as const;
-
-        applicableRules.forEach((rule) => {
-            const warning = rule.check(node, state, content, nodeContext);
-            if (warning) {
-                // The start and end locations are relative to this
-                // particular node, and so are not generally very useful.
-                // TODO: When the markdown parser saves the node
-                // locations in the source string then we can add
-                // these numbers to that one and get and absolute
-                // character range that will be useful
-                if (warning.start || warning.end) {
-                    warning.target = content.substring(
-                        warning.start,
-                        warning.end,
-                    );
-                }
-
-                // Add the warning to the list of all lint we've found
-                warnings.push(warning);
-
-                // If we're going to be highlighting lint, then we also
-                // need to keep track of warnings specific to this node.
-                if (highlight) {
-                    nodeWarnings.push(warning);
-                }
-            }
-        });
-
-        // If we're not highlighting lint in the tree, then we're done
-        // traversing this node.
-        if (!highlight) {
-            return;
-        }
-
-        // If the node we are currently at is a table, and there was lint
-        // inside the table, then we want to add that lint here
-        if (node.type === "table") {
-            if (tableWarnings.length) {
-                nodeWarnings.push(...tableWarnings);
-            }
-
-            // We're not in a table anymore, and don't have to remember
-            // the warnings for the table
-            insideTable = false;
-            tableWarnings = [];
-        } else if (!insideTable) {
-            // Otherwise, if we are not already inside a table, check
-            // to see if we've entered one. Because this is a post-order
-            // traversal we'll see the table contents before the table itself.
-            // Note that once we're inside the table, we don't have to
-            // do this check each time... We can just wait until we ascend
-            // up to the table, then we'll know we're out of it.
-            insideTable = state.ancestors().some((n) => n.type === "table");
-        }
-
-        // If we are inside a table and there were any warnings on
-        // this node, then we need to save the warnings for display
-        // on the table itself
-        if (insideTable && nodeWarnings.length) {
-            // @ts-expect-error - TS2345 - Argument of type 'any' is not assignable to parameter of type 'never'.
-            tableWarnings.push(...nodeWarnings);
-        }
-
-        // If there were any warnings on this node, and if we're highlighting
-        // lint, then reparent the node so we can highlight it. Note that
-        // a single node can have multiple warnings. If this happends we
-        // concatenate the warnings and newline separate them. (The lint.jsx
-        // component that displays the warnings may want to convert the
-        // newlines into <br> tags.) We also provide a lint rule name
-        // so that lint.jsx can link to a document that provides more details
-        // on that particular lint rule. If there is more than one warning
-        // we only link to the first rule, however.
-        //
-        // Note that even if we're inside a table, we still reparent the
-        // linty node so that it can be highlighted. We just make a note
-        // of whether this lint is inside a table or not.
-        if (nodeWarnings.length) {
-            nodeWarnings.sort((a, b) => {
-                return a.severity - b.severity;
-            });
-
-            if (node.type !== "text" || nodeWarnings.length > 1) {
-                // If the linty node is not a text node, or if there is more
-                // than one warning on a text node, then reparent the entire
-                // node under a new lint node and put the warnings there.
-                state.replace({
-                    type: "lint",
-                    // @ts-expect-error - TS2345 - Argument of type '{ type: string; content: TreeNode; message: string; ruleName: any; blockHighlight: any; insideTable: boolean; severity: any; }' is not assignable to parameter of type 'TreeNode'.
-                    content: node,
-                    message: nodeWarnings.map((w) => w.message).join("\n\n"),
-                    ruleName: nodeWarnings[0].rule,
-                    blockHighlight: nodeContext.blockHighlight,
-                    insideTable: insideTable,
-                    severity: nodeWarnings[0].severity,
-                });
-            } else {
-                //
-                // Otherwise, it is a single warning on a text node, and we
-                // only want to highlight the actual linty part of that string
-                // of text. So we want to replace the text node with (in the
-                // general case) three nodes:
-                //
-                // 1) A new text node that holds the non-linty prefix
-                //
-                // 2) A lint node that is the parent of a new text node
-                // that holds the linty part
-                //
-                // 3) A new text node that holds the non-linty suffix
-                //
-                // If the lint begins and/or ends at the boundaries of the
-                // original text node, then nodes 1 and/or 3 won't exist, of
-                // course.
-                //
-                // Note that we could generalize this to work with multple
-                // warnings on a text node as long as the warnings are
-                // non-overlapping. Hopefully, though, multiple warnings in a
-                // single text node will be rare in practice. Also, we don't
-                // have a good way to display multiple lint indicators on a
-                // single line, so keeping them combined in that case might
-                // be the best thing, anyway.
-                //
-                // @ts-expect-error - TS2339 - Property 'content' does not exist on type 'TreeNode'.
-                const content = node.content; // Text nodes have content
-                const warning = nodeWarnings[0]; // There is only one warning.
-                // These are the lint boundaries within the content
-                const start = warning.start || 0;
-                const end = warning.end || content.length;
-                const prefix = content.substring(0, start);
-                const lint = content.substring(start, end);
-                const suffix = content.substring(end);
-                // TODO(FEI-5003): Give this a real type.
-                const replacements: any[] = []; // What we'll replace the node with
-
-                // The prefix text node, if there is one
-                if (prefix) {
-                    replacements.push({
-                        type: "text",
-                        content: prefix,
-                    });
-                }
-
-                // The lint node wrapped around the linty text
-                replacements.push({
-                    type: "lint",
-                    content: {
-                        type: "text",
-                        content: lint,
-                    },
-                    message: warning.message,
-                    ruleName: warning.rule,
-                    insideTable: insideTable,
-                    severity: warning.severity,
-                });
-
-                // The suffix node, if there is one
-                if (suffix) {
-                    replacements.push({
-                        type: "text",
-                        content: suffix,
-                    });
-                }
-
-                // Now replace the lint text node with the one to three
-                // nodes in the replacement array
-                state.replace(...replacements);
-            }
-        }
-    });
-
-    return warnings;
-}
-
-export function pushContextStack(context: any, name: string): any {
-    const stack = context.stack || [];
-    return {
-        ...context,
-        stack: stack.concat(name),
-    };
-}

package/src/proptypes.ts

@@ -1,19 +0,0 @@
-// Define the shape of the linter context object that is passed through the
-// tree with additional information about what we are checking.
-import PropTypes from "prop-types";
-
-import type {LinterContextProps} from "./types";
-
-export const linterContextProps = PropTypes.shape({
-    contentType: PropTypes.string,
-    highlightLint: PropTypes.bool,
-    paths: PropTypes.arrayOf(PropTypes.string),
-    stack: PropTypes.arrayOf(PropTypes.string),
-});
-
-export const linterContextDefault: LinterContextProps = {
-    contentType: "",
-    highlightLint: false,
-    paths: [] as ReadonlyArray<any>,
-    stack: [] as ReadonlyArray<any>,
-};