@khanacademy/perseus-editor 2.6.0 → 2.6.2

package/src/widgets/interactive-graph-editor.tsx

@@ -6,11 +6,8 @@ import {
     InteractiveGraphWidget,
     SizingUtils,
     Util,
-    PerseusImageBackground,
-    PerseusInteractiveGraphWidgetOptions,
-    APIOptionsWithDefaults,
 } from "@khanacademy/perseus";
-import {StyleType, View} from "@khanacademy/wonder-blocks-core";
+import {View} from "@khanacademy/wonder-blocks-core";
 import Spacing from "@khanacademy/wonder-blocks-spacing";
 import * as Typography from "@khanacademy/wonder-blocks-typography";
 import * as React from "react";
@@ -22,6 +19,13 @@ import GraphTypeSelector from "../components/graph-type-selector";
 import SegmentCountSelector from "../components/segment-count-selector";
 import {parsePointCount} from "../util/points";
 
+import type {
+    PerseusImageBackground,
+    PerseusInteractiveGraphWidgetOptions,
+    APIOptionsWithDefaults,
+} from "@khanacademy/perseus";
+import type {StyleType} from "@khanacademy/wonder-blocks-core";
+
 const {InfoTip} = components;
 const {containerSizeClass, getInteractiveBoxFromSizeClass} = SizingUtils;
 const DeprecationMixin = Util.DeprecationMixin;
@@ -168,7 +172,7 @@ class InteractiveGraphEditor extends React.Component<Props> {
                 trackInteraction: function () {},
                 onChange: (newProps: InteractiveGraphProps) => {
                     let correct = this.props.correct;
-                    // @ts-expect-error [FEI-5003] - TS2532 - Object is possibly 'undefined'.
+                    // @ts-expect-error - TS2532 - Object is possibly 'undefined'.
                     if (correct.type === newProps.graph.type) {
                         correct = _.extend({}, correct, newProps.graph);
                     } else {
@@ -182,7 +186,7 @@ class InteractiveGraphEditor extends React.Component<Props> {
                 // There are a bunch of props that renderer.jsx passes to widgets via
                 // getWidgetProps() and widget-container.jsx that the editors don't
                 // bother passing.
-                // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
+                // @ts-expect-error - TS2769 - No overload matches this call.
                 <InteractiveGraph
                     {...graphProps}
                     containerSizeClass={sizeClass}
@@ -194,7 +198,7 @@ class InteractiveGraphEditor extends React.Component<Props> {
             );
             // TODO(kevinb): Update getEquationString to only accept the data it actually
             // needs to compute the equation string.
-            // @ts-expect-error [FEI-5003] - TS2345 - Argument of type '{ readonly ref: "graph"; readonly box: any; readonly range: any; readonly labels: any; readonly step: any; readonly gridStep: any; readonly snapStep: any; readonly graph: any; readonly backgroundImage: any; ... 6 more ...; readonly onChange: (newProps: Pick<...> & ... 1 more ... & InexactPartial<...>) => void; }' is not assignable to parameter of type 'Props'.
+            // @ts-expect-error - TS2345 - Argument of type '{ readonly ref: "graph"; readonly box: any; readonly range: any; readonly labels: any; readonly step: any; readonly gridStep: any; readonly snapStep: any; readonly graph: any; readonly backgroundImage: any; ... 6 more ...; readonly onChange: (newProps: Pick<...> & ... 1 more ... & InexactPartial<...>) => void; }' is not assignable to parameter of type 'Props'.
             equationString = InteractiveGraph.getEquationString(graphProps);
         } else {
             graph = <div className="perseus-error">{this.props.valid}</div>;
@@ -556,7 +560,7 @@ class InteractiveGraphEditor extends React.Component<Props> {
                 ],
                 function (key) {
                     if (_.has(correct, key)) {
-                        // @ts-expect-error [FEI-5003] - TS2339 - Property 'graph' does not exist on type 'Pick<any, "step" | "range" | "backgroundImage" | "snapStep" | "labels" | "showTooltips" | "markings" | "gridStep" | "showProtractor" | "showRuler" | "rulerLabel" | "rulerTicks">'.
+                        // @ts-expect-error - TS2339 - Property 'graph' does not exist on type 'Pick<any, "step" | "range" | "backgroundImage" | "snapStep" | "labels" | "showTooltips" | "markings" | "gridStep" | "showProtractor" | "showRuler" | "rulerLabel" | "rulerTicks">'.
                         json.graph[key] = correct[key];
                     }
                 },

package/src/widgets/label-image/marker.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable @khanacademy/ts-no-error-suppressions */
 /* eslint-disable react/no-unsafe */
 /**
  * Controlled editor image marker on the question image.
@@ -162,7 +163,7 @@ export default class Marker extends React.Component<Props, State> {
                             <OptionGroup
                                 onSelected={this.handleSelectAnswer}
                                 // TODO(WB-1096): make selectedValues immutable in wonder-blocks
-                                // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
+                                // @ts-expect-error - TS2769 - No overload matches this call.
                                 selectedValues={answers}
                             >
                                 {choices.map((choice) => (

package/src/widgets/label-image/question-markers.tsx

@@ -33,7 +33,7 @@ export default class QuestionMarkers extends React.Component<Props> {
         // Open answer selection dropdown for each of the specified markers.
         indices.forEach((index) => {
             if (this._markers[index]) {
-                // @ts-expect-error [FEI-5003] - TS2533 - Object is possibly 'null' or 'undefined'.
+                // @ts-expect-error - TS2533 - Object is possibly 'null' or 'undefined'.
                 this._markers[index].openDropdown();
             }
         });

package/src/widgets/lights-puzzle-editor.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable @khanacademy/ts-no-error-suppressions */
 /* eslint-disable react/sort-comp */
 import {components, Changeable, EditorJsonify} from "@khanacademy/perseus";
 import PropTypes from "prop-types";
@@ -191,7 +192,7 @@ class LightsPuzzleEditor extends React.Component<LightsPuzzleEditorProps> {
                     Flip pattern:
                     <select
                         value={this.props.flipPattern}
-                        // @ts-expect-error [FEI-5003] - TS2322 - Type '(arg1: ChangeEvent<HTMLInputElement>) => void' is not assignable to type 'ChangeEventHandler<HTMLSelectElement>'.
+                        // @ts-expect-error - TS2322 - Type '(arg1: ChangeEvent<HTMLInputElement>) => void' is not assignable to type 'ChangeEventHandler<HTMLSelectElement>'.
                         onChange={this._handlePatternChange}
                     >
                         {_.map(_.keys(PATTERNS), (pattern, i) => {
@@ -229,7 +230,7 @@ class LightsPuzzleEditor extends React.Component<LightsPuzzleEditorProps> {
 
     _handlePatternChange: (arg1: React.ChangeEvent<HTMLInputElement>) => void =
         (e) => {
-            // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 2.
+            // @ts-expect-error - TS2554 - Expected 3 arguments, but got 2.
             this.change("flipPattern", e.target.value);
         };
 
@@ -256,7 +257,7 @@ class LightsPuzzleEditor extends React.Component<LightsPuzzleEditorProps> {
             });
         });
 
-        // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+        // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
         this.change({startCells: newCells});
     };
 
@@ -265,7 +266,7 @@ class LightsPuzzleEditor extends React.Component<LightsPuzzleEditorProps> {
             return y === tileY && x === tileX;
         });
 
-        // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+        // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
         this.change({startCells: newCells});
     };
 

package/src/widgets/matrix-editor.tsx

@@ -99,7 +99,7 @@ class MatrixEditor extends React.Component<Props> {
                         content={this.props.prefix}
                         widgetEnabled={false}
                         onChange={(newProps) => {
-                            // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+                            // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
                             this.change({prefix: newProps.content});
                         }}
                     />
@@ -114,7 +114,7 @@ class MatrixEditor extends React.Component<Props> {
                         content={this.props.suffix}
                         widgetEnabled={false}
                         onChange={(newProps) => {
-                            // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+                            // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
                             this.change({suffix: newProps.content});
                         }}
                     />

package/src/widgets/measurer-editor.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable @khanacademy/ts-no-error-suppressions */
 /* eslint-disable react/sort-comp */
 import {components, Changeable, EditorJsonify} from "@khanacademy/perseus";
 import PropTypes from "prop-types";
@@ -94,7 +95,7 @@ class MeasurerEditor extends React.Component<Props> {
                 <div>
                     Containing area [width, height]:{" "}
                     <RangeInput
-                        // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+                        // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
                         onChange={this.change("box")}
                         value={this.props.box}
                         useArrowKeys={true}
@@ -124,7 +125,7 @@ class MeasurerEditor extends React.Component<Props> {
                                 Ruler label:{" "}
                                 <select
                                     onChange={(e) =>
-                                        // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 2.
+                                        // @ts-expect-error - TS2554 - Expected 3 arguments, but got 2.
                                         this.change(
                                             "rulerLabel",
                                             e.target.value,
@@ -158,7 +159,7 @@ class MeasurerEditor extends React.Component<Props> {
                                 Ruler ticks:{" "}
                                 <select
                                     onChange={(e) =>
-                                        // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 2.
+                                        // @ts-expect-error - TS2554 - Expected 3 arguments, but got 2.
                                         this.change(
                                             "rulerTicks",
                                             +e.target.value,
@@ -181,7 +182,7 @@ class MeasurerEditor extends React.Component<Props> {
                                 Ruler pixels per unit:{" "}
                                 <NumberInput
                                     placeholder={40}
-                                    // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+                                    // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
                                     onChange={this.change("rulerPixels")}
                                     value={this.props.rulerPixels}
                                     useArrowKeys={true}
@@ -193,7 +194,7 @@ class MeasurerEditor extends React.Component<Props> {
                                 Ruler length in units:{" "}
                                 <NumberInput
                                     placeholder={10}
-                                    // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+                                    // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
                                     onChange={this.change("rulerLength")}
                                     value={this.props.rulerLength}
                                     useArrowKeys={true}
@@ -225,7 +226,7 @@ class MeasurerEditor extends React.Component<Props> {
     _changeImage: (arg1: string, arg2: any) => void = (subProp, newValue) => {
         const image = _.clone(this.props.image);
         image[subProp] = newValue;
-        // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 2.
+        // @ts-expect-error - TS2554 - Expected 3 arguments, but got 2.
         this.change("image", image);
     };
 

package/src/widgets/molecule-editor.tsx

@@ -20,12 +20,12 @@ class MoleculeWidgetEditor extends React.Component<Props> {
     };
 
     updateMolecule: (arg1: string) => void = (newValue) => {
-        // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+        // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
         this.change({smiles: newValue});
     };
 
     updateRotation: (arg1: string) => void = (newValue) => {
-        // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+        // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
         this.change({rotationAngle: newValue});
     };
 

package/src/widgets/number-line-editor.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable @khanacademy/ts-no-error-suppressions */
 import {number as knumber} from "@khanacademy/kmath";
 import {components, EditorJsonify} from "@khanacademy/perseus";
 import PropTypes from "prop-types";
@@ -211,7 +212,7 @@ class NumberLineEditor extends React.Component<Props> {
                     Correct x{" "}
                     <select
                         value={this.props.correctRel}
-                        // @ts-expect-error [FEI-5003] - TS2322 - Type '(arg1: ChangeEvent<HTMLInputElement>) => void' is not assignable to type 'ChangeEventHandler<HTMLSelectElement>'.
+                        // @ts-expect-error - TS2322 - Type '(arg1: ChangeEvent<HTMLInputElement>) => void' is not assignable to type 'ChangeEventHandler<HTMLSelectElement>'.
                         onChange={this.onChangeRelation}
                     >
                         <option value="eq"> = </option>

package/src/widgets/numeric-input-editor.tsx

@@ -508,7 +508,7 @@ const NumericInputEditor: any = createReactClass({
         // TODO(emily): This doesn't actually work, because the value is either
         // null or undefined when undefined, probably.
         if (_.contains(_.pluck(this.props.answers, "value"), "")) {
-            // @ts-expect-error [FEI-5003] - TS2345 - Argument of type 'string' is not assignable to parameter of type 'never'.
+            // @ts-expect-error - TS2345 - Argument of type 'string' is not assignable to parameter of type 'never'.
             warnings.push("One or more answers is empty");
         }
         this.props.answers.forEach((answer, i) => {
@@ -517,7 +517,7 @@ const NumericInputEditor: any = createReactClass({
                 (!answer.answerForms || answer.answerForms.length === 0);
             if (formatError) {
                 warnings.push(
-                    // @ts-expect-error [FEI-5003] - TS2345 - Argument of type 'string' is not assignable to parameter of type 'never'.
+                    // @ts-expect-error - TS2345 - Argument of type 'string' is not assignable to parameter of type 'never'.
                     `Answer ${i + 1} is set to string format ` +
                         "matching, but no format was selected",
                 );

package/src/widgets/orderer-editor.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable @khanacademy/ts-no-error-suppressions */
 /* eslint-disable one-var, react/forbid-prop-types, react/sort-comp */
 import {components} from "@khanacademy/perseus";
 import PropTypes from "prop-types";
@@ -73,7 +74,7 @@ class OrdererEditor extends React.Component<Props> {
                         Layout:{" "}
                         <select
                             value={this.props.layout}
-                            // @ts-expect-error [FEI-5003] - TS2322 - Type '(arg1: ChangeEvent<HTMLInputElement>) => void' is not assignable to type 'ChangeEventHandler<HTMLSelectElement>'.
+                            // @ts-expect-error - TS2322 - Type '(arg1: ChangeEvent<HTMLInputElement>) => void' is not assignable to type 'ChangeEventHandler<HTMLSelectElement>'.
                             onChange={this.onLayoutChange}
                         >
                             <option value={HORIZONTAL}>Horizontal</option>
@@ -94,7 +95,7 @@ class OrdererEditor extends React.Component<Props> {
                         Height:{" "}
                         <select
                             value={this.props.height}
-                            // @ts-expect-error [FEI-5003] - TS2322 - Type '(arg1: ChangeEvent<HTMLInputElement>) => void' is not assignable to type 'ChangeEventHandler<HTMLSelectElement>'.
+                            // @ts-expect-error - TS2322 - Type '(arg1: ChangeEvent<HTMLInputElement>) => void' is not assignable to type 'ChangeEventHandler<HTMLSelectElement>'.
                             onChange={this.onHeightChange}
                         >
                             <option value={NORMAL}>Normal</option>

package/src/widgets/passage-editor.tsx

@@ -45,7 +45,7 @@ class PassageEditor extends React.Component<Props> {
                 widgetEnabled={false}
                 placeholder="Type passage here..."
                 onChange={(newProps) => {
-                    // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+                    // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
                     this.change({passageText: newProps.content});
                 }}
                 showWordCount={true}
@@ -60,7 +60,7 @@ class PassageEditor extends React.Component<Props> {
                 widgetEnabled={false}
                 placeholder="Type footnotes here..."
                 onChange={(newProps) => {
-                    // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+                    // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
                     this.change({footnotes: newProps.content});
                 }}
             />
@@ -88,7 +88,7 @@ class PassageEditor extends React.Component<Props> {
                             type="text"
                             defaultValue={this.props.passageTitle}
                             onChange={(e) => {
-                                // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+                                // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
                                 this.change({passageTitle: e.target.value});
                             }}
                         />

package/src/widgets/passage-ref-editor.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable @khanacademy/ts-no-error-suppressions */
 import {components, Changeable, EditorJsonify} from "@khanacademy/perseus";
 import PropTypes from "prop-types";
 import * as React from "react";
@@ -38,7 +39,7 @@ class PassageRefEditor extends React.Component<Props> {
                         {"Passage Number: "}
                         <NumberInput
                             value={this.props.passageNumber}
-                            // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+                            // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
                             onChange={this.change("passageNumber")}
                         />
                     </label>
@@ -48,7 +49,7 @@ class PassageRefEditor extends React.Component<Props> {
                         {"Reference Number: "}
                         <NumberInput
                             value={this.props.referenceNumber}
-                            // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+                            // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
                             onChange={this.change("referenceNumber")}
                         />
                     </label>
@@ -58,7 +59,7 @@ class PassageRefEditor extends React.Component<Props> {
                         {"Summary Text: "}
                         <TextInput
                             value={this.props.summaryText}
-                            // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+                            // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
                             onChange={this.change("summaryText")}
                         />
                         <InfoTip>

package/src/widgets/passage-ref-target-editor.tsx

@@ -24,7 +24,7 @@ class PassageRefTargetEditor extends React.Component<Props> {
     handleContentChange: (arg1: React.ChangeEvent<HTMLInputElement>) => void = (
         e,
     ) => {
-        // @ts-expect-error [FEI-5003] - TS2554 - Expected 3 arguments, but got 1.
+        // @ts-expect-error - TS2554 - Expected 3 arguments, but got 1.
         this.change({content: e.target.value});
     };