@khanacademy/perseus-editor 2.0.1 → 2.0.2

package/package.json

@@ -3,7 +3,7 @@
     "description": "Perseus editors",
     "author": "Khan Academy",
     "license": "MIT",
-    "version": "2.0.1",
+    "version": "2.0.2",
     "publishConfig": {
         "access": "public"
     },
@@ -23,7 +23,7 @@
     "dependencies": {
         "@khanacademy/kas": "^0.3.1",
         "@khanacademy/kmath": "^0.1.1",
-        "@khanacademy/perseus": "^4.0.1"
+        "@khanacademy/perseus": "^4.0.2"
     },
     "devDependencies": {
         "@khanacademy/wonder-blocks-button": "^4.0.8",

package/src/article-editor.tsx

@@ -60,7 +60,6 @@ export default class ArticleEditor extends React.Component<
 > {
     static defaultProps: DefaultProps = {
         contentPaths: [],
-        // $FlowFixMe[incompatible-exact]
         json: [{}],
         mode: "edit",
         screen: "desktop",

package/src/components/dropdown-option.tsx

@@ -113,9 +113,6 @@ class Option extends React.Component<OptionProps> {
 
         return (
             <button
-                // TODO(mdr): We found a new Flow error when upgrading:
-                //     "node (null) This type is incompatible with this.node (HTMLDivElement)"
-                // $FlowFixMe[incompatible-type](0.52.0->0.53.0)
                 // @ts-expect-error [FEI-5003] - TS2322 - Type 'HTMLButtonElement | null' is not assignable to type 'HTMLDivElement'.
                 ref={(node) => (this.node = node)}
                 value={value}
@@ -129,11 +126,6 @@ class Option extends React.Component<OptionProps> {
                 // @ts-expect-error [FEI-5003] - TS2322 - Type '(value: string) => void' is not assignable to type 'MouseEventHandler<HTMLButtonElement>'.
                 onClick={(value: string) => {
                     if (!disabled && onClick) {
-                        // TODO(mdr): We found a new Flow error here when upgrading
-                        //     from 0.35.0 to 0.52.0: "value (unused function
-                        //     argument)". This comment was automatically added to
-                        //     this file, to suppress the error for now. Please
-                        //     consider fixing!
                         // @ts-expect-error [FEI-5003] - TS2554 - Expected 0 arguments, but got 1.
                         onClick(value);
                     }

package/src/diffs/text-diff.tsx

@@ -49,7 +49,6 @@ class ImageDiffSide extends React.Component<any> {
                     return (
                         <div key={index}>
                             <div className={className}>
-                                {/* $FlowFixMe[prop-missing]: the alt prop is missing */}
                                 {/* @ts-expect-error [FEI-5003] - TS2741 - Property 'alt' is missing in type '{ src: any; title: any; }' but required in type 'Pick<Readonly<Props> & Readonly<{ children?: ReactNode; }>, "children" | "height" | "width" | "title" | "alt" | "trackInteraction" | "preloader" | "allowFullBleed" | "extraGraphie" | "overrideAriaHidden">'. */}
                                 <SvgImage
                                     src={entry.value}

package/src/diffs/widget-diff.tsx

@@ -227,7 +227,6 @@ class ImageWidgetDiff extends React.Component<any> {
                                 "image-removed": beforeSrc !== afterSrc,
                             })}
                         >
-                            {/* $FlowFixMe[prop-missing]: the alt props is missing */}
                             {/* @ts-expect-error [FEI-5003] - TS2741 - Property 'alt' is missing in type '{ src: any; title: any; }' but required in type 'Pick<Readonly<Props> & Readonly<{ children?: ReactNode; }>, "children" | "height" | "width" | "title" | "alt" | "trackInteraction" | "preloader" | "allowFullBleed" | "extraGraphie" | "overrideAriaHidden">'. */}
                             <SvgImage src={beforeSrc} title={beforeSrc} />
                         </div>
@@ -242,7 +241,6 @@ class ImageWidgetDiff extends React.Component<any> {
                                 "image-added": beforeSrc !== afterSrc,
                             })}
                         >
-                            {/* $FlowFixMe[prop-missing]: the alt props is missing */}
                             {/* @ts-expect-error [FEI-5003] - TS2741 - Property 'alt' is missing in type '{ src: any; title: any; }' but required in type 'Pick<Readonly<Props> & Readonly<{ children?: ReactNode; }>, "children" | "height" | "width" | "title" | "alt" | "trackInteraction" | "preloader" | "allowFullBleed" | "extraGraphie" | "overrideAriaHidden">'. */}
                             <SvgImage src={afterSrc} title={afterSrc} />
                         </div>

package/src/editor.tsx

@@ -983,7 +983,6 @@ class Editor extends React.Component<EditorProps, EditorState> {
             function () {
                 Util.textarea.moveCursor(
                     // findDOMNode can return Text but we know this is Element
-                    // $FlowFixMe[incompatible-call]
                     // @ts-expect-error [FEI-5003] - TS2345 - Argument of type 'Element | Text | null' is not assignable to parameter of type 'HTMLTextAreaElement'.
                     textarea,
                     // We want to put the cursor after the widget

package/src/multirenderer-editor.tsx

@@ -70,7 +70,7 @@ class ModeDropdown extends React.Component<ModeDropdownProps> {
     _handleSelectMode = (event: React.ChangeEvent<HTMLSelectElement>) => {
         if (this.props.onChange) {
             // event.target.value corresponds to the options' values below which
-            // are limited to EditorMode, but flow doesn't know that so we have
+            // are limited to EditorMode, but TypeScript doesn't know that so we have
             // to cast through any here.
             const value = event.target.value as EditorMode;
             this.props.onChange(value);
@@ -409,7 +409,7 @@ const NodeContent = (props: NodePropTypes) => {
 
     // All uses of `data` have been cast through any which isn't safe. This was
     // done to avoid introducing new logic which may have resulted in a change
-    // of behavior.  Also, there doesn't appear to be a way to tell flow the
+    // of behavior.  Also, there doesn't appear to be a way to tell TypeScript the
     // difference between and `TagsNode` and `ItemArrayNode`, see
     // perseus-all-package/multi-items/item-types.js.
     if (shape.type === "content") {
@@ -520,12 +520,6 @@ const withStickiness = <
 
         render(): React.ReactNode {
             return (
-                /**
-                 * $FlowFixMe[incompatible-exact]
-                 * TODO(somewhatabstract, JIRA-XXXX):
-                 * Cannot create WrappedComponent element because inexact props
-                 * [1] is incompatible with exact WithStickiness [2].
-                 */
                 // @ts-expect-error [FEI-5003] - TS2322 - Type 'Readonly<Config> & { sticky: boolean; children?: ReactNode; }' is not assignable to type 'IntrinsicAttributes & LibraryManagedAttributes<Component, PropsWithChildren<WithStickiness<Config>>>'.
                 <WrappedComponent {...this.props} sticky={this.state.sticky} />
             );
@@ -548,9 +542,6 @@ const ItemNodeContent = withStickiness(
                         <div className={css(sticky && styles.sticky)}>
                             {/* TODO(CP-4852): only pass the props to Editor that it uses. */}
                             {
-                                // $FlowFixMe[incompatible-exact]: {...data} pass too many props
-                                // $FlowFixMe[incompatible-type]
-                                // $FlowFixMe[prop-missing]
                                 // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
                                 <Editor
                                     {...data}
@@ -585,13 +576,6 @@ const HintNodeContent = withStickiness(
             <div className={css(styles.row)}>
                 <div className={css(styles.columnLeft)}>
                     <div className={css(sticky && styles.sticky)}>
-                        {/**
-                         * $FlowFixMe[incompatible-exact]
-                         * TODO(somewhatabstract, JIRA-XXXX):
-                         * Cannot create WrappedComponent element because
-                         * inexact props [1] is incompatible with exact
-                         * WithStickiness [2].
-                         */}
                         <HintEditor
                             {...data}
                             className={css(styles.hintEditor)}
@@ -673,8 +657,6 @@ const ArrayNodeContent = (props: NodePropTypes<ArrayShape, ItemArrayNode>) => {
                     </SimpleButton>
                 </div>
             ),
-            // $FlowFixMe[unsafe-addition]
-            // $FlowFixMe[prop-missing]
             i < data.length - 1 && (
                 <div key="moveArrayElementDown" className={css(styles.control)}>
                     <SimpleButton

package/src/widgets/__stories__/label-image-editor.stories.tsx

@@ -85,9 +85,6 @@ class WithState extends React.Component<Empty, State> {
                             ...props,
                         })
                     }
-                    // TODO(mdr): We found a new Flow error when upgrading:
-                    //     "widget (null) This type is incompatible with this._widget (LabelImageEditor)"
-                    // $FlowFixMe[incompatible-type](0.52.0->0.53.0)
                     // @ts-expect-error [FEI-5003] - TS2322 - Type 'LabelImageEditor | null' is not assignable to type 'LabelImageEditor'.
                     ref={(widget) => (this._widget = widget)}
                 />

package/src/widgets/__stories__/radio-editor.stories.tsx

@@ -102,7 +102,6 @@ class WithState extends React.Component<Empty, PerseusRadioWidgetOptions> {
                             ...props,
                         })
                     }
-                    // $FlowFixMe[incompatible-type] - can be null
                     // @ts-expect-error [FEI-5003] - TS2322 - Type 'RadioEditor | null' is not assignable to type 'RadioEditor'.
                     ref={(widget) => (this._widget = widget)}
                 />

package/src/widgets/categorizer-editor.tsx

@@ -84,7 +84,6 @@ class CategorizerEditor extends React.Component<Props> {
                 {/* There are a bunch of props that renderer.jsx passes to each widget
                     via widget-container.jsx that we aren't passing to Categorizer here.
                     See perseus-all-package/types.js#WidgetProps for details. */}
-                {/* $FlowFixMe[prop-missing] */}
                 {/* @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call. */}
                 <Categorizer
                     apiOptions={this.props.apiOptions}

package/src/widgets/cs-program-editor.tsx

@@ -53,7 +53,6 @@ class PairEditor extends React.Component<any> {
                     Name:{" "}
                     <BlurInput
                         value={this.props.name}
-                        // $FlowFixMe[incompatible-type] single-param call returns a callback
                         onChange={this.change("name")}
                     />
                 </label>
@@ -62,7 +61,6 @@ class PairEditor extends React.Component<any> {
                     Value:{" "}
                     <BlurInput
                         value={this.props.value}
-                        // $FlowFixMe[incompatible-type] single-param call returns a callback
                         onChange={this.change("value")}
                     />
                 </label>

package/src/widgets/expression-editor.tsx

@@ -223,8 +223,6 @@ class ExpressionEditor extends React.Component<any, any> {
                         className="math-input-buttons"
                         sets={this.props.buttonSets}
                         convertDotToTimes={this.props.times}
-                        // onInsert is typed as `(string | ((input: $FlowFixMe) => void)) => void`
-                        // $FlowFixMe[incompatible-type]
                         onInsert={this.handleTexInsert}
                     />
                 )}

package/src/widgets/grapher-editor.tsx

@@ -68,7 +68,6 @@ class GrapherEditor extends React.Component<Props> {
                 // NOTE(jeremy): This editor doesn't pass in a bunch of
                 // standard props that the Renderer provides normally (eg.
                 // alignment, findWidgets, etc).
-                // $FlowFixMe[prop-missing]
                 // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
                 <Grapher
                     {...graphProps}

package/src/widgets/iframe-editor.tsx

@@ -36,7 +36,6 @@ class PairEditor extends React.Component<PairEditorProps> {
                     Name:
                     <BlurInput
                         value={this.props.name}
-                        // $FlowFixMe[incompatible-type] single-param call returns a callback
                         onChange={this.change("name")}
                     />
                 </label>
@@ -44,7 +43,6 @@ class PairEditor extends React.Component<PairEditorProps> {
                     Value:
                     <BlurInput
                         value={this.props.value}
-                        // $FlowFixMe[incompatible-type] single-param call returns a callback
                         onChange={this.change("value")}
                     />
                 </label>

package/src/widgets/input-number-editor.tsx

@@ -204,7 +204,6 @@ class InputNumberEditor extends React.Component<Props> {
                             onBlur={(e) => {
                                 const ans =
                                     "" +
-                                    // $FlowFixMe[incompatible-type]
                                     (Util.firstNumericalParse(e.target.value) ||
                                         0);
                                 e.target.value = ans;

package/src/widgets/interaction-editor.tsx

@@ -964,7 +964,6 @@ class InteractionEditor extends React.Component<
                         markings={this.props.graph.markings}
                         onChange={this._updateGraphProps}
                     />
-                    {/* $FlowFixMe[incompatible-type] */}
                     {this.props.graph.valid !== true && (
                         <div>{this.props.graph.valid}</div>
                     )}

package/src/widgets/interactive-graph-editor.tsx

@@ -122,7 +122,6 @@ const InteractiveGraphEditor: any = createReactClass({
                 // There are a bunch of props that renderer.jsx passes to widgets via
                 // getWidgetProps() and widget-container.jsx that the editors don't
                 // bother passing.
-                // $FlowFixMe[prop-missing]
                 // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
                 <InteractiveGraph
                     {...graphProps}

package/src/widgets/label-image/marker.tsx

@@ -162,7 +162,6 @@ export default class Marker extends React.Component<MarkerProps, MarkerState> {
                             <OptionGroup
                                 onSelected={this.handleSelectAnswer}
                                 // TODO(WB-1096): make selectedValues immutable in wonder-blocks
-                                // $FlowFixMe[incompatible-type]
                                 // @ts-expect-error [FEI-5003] - TS2769 - No overload matches this call.
                                 selectedValues={answers}
                             >

package/src/widgets/transformer-editor.tsx

@@ -852,7 +852,6 @@ class TransformationsShapeEditor extends React.Component<any> {
 
     updateCoords = () => {
         this.props.onChange({
-            // $FlowFixMe[prop-missing]
             // @ts-expect-error [FEI-5003] - TS2339 - Property 'shape' does not exist on type 'TransformationsShapeEditor'.
             shape: this.shape.toJSON(),
         });