@kevinburke/flot 5.0.0 → 5.1.1

package/CHANGELOG.md

@@ -5,6 +5,135 @@ All notable changes to this project will be documented in this file.
 Starting with 5.0.0, this changelog tracks the @kevinburke/flot fork.
 For earlier upstream history, see the [flot/flot repository](https://github.com/flot/flot).
 
+## [5.1.1] - 2026-04-15
+
+### Fixed
+
+All bug fixes in this release are ports or re-implementations of
+existing upstream work. Thanks to the reporters and submitters
+credited below.
+
+- `jquery.flot.js`: skip the `extraDec` branch in `setupTickGeneration`
+  when `axis.delta` is zero. Previously, a second `setupGrid()` call
+  (for example from the resize plugin) on an axis with `min === max`
+  and another axis using `alignTicksWithAxis` produced
+  `extraDec = +Infinity`, left `axis.tickDecimals` as `Infinity`, and
+  could throw `RangeError: toFixed() digits argument must be between
+  0 and 100` during tick formatting. Ports
+  [flot/flot#1870](https://github.com/flot/flot/pull/1870)
+  (@LYarnall) for
+  [flot/flot#1869](https://github.com/flot/flot/issues/1869).
+- `jquery.flot.js`: enforce `mouseActiveRadius` in `findNearbyPoint`
+  even when the pre-filter is disabled. Previously, seeding
+  `smallestDistance` with `+Infinity` meant the hover radius was only
+  enforced via the `maxx`/`maxy` coordinate-space pre-filter, which
+  is explicitly skipped for axes with `transform` /
+  `inverseTransform`. As a result, hovering anywhere in the plot
+  could highlight an arbitrarily distant point. Seed with
+  `maxDistance` (or its square, matching the default squared-distance
+  metric) so the radius is always an upper bound. Ports
+  [flot/flot#1872](https://github.com/flot/flot/pull/1872)
+  (@ErikSievers) for
+  [flot/flot#1871](https://github.com/flot/flot/issues/1871).
+- `jquery.flot.js`: guard `getColorOrGradient` against non-finite
+  coordinates. `ctx.createLinearGradient(0, top, 0, bottom)` throws
+  `Uncaught TypeError: Argument 4 is not finite floating-point value`
+  when `top` or `bottom` is `NaN` or `±Infinity`, which can happen
+  when the plot container has zero size or when bogus axis bounds
+  flow in. Fall back to `defaultColor` in that case. Fixes upstream
+  [flot/flot#1867](https://github.com/flot/flot/issues/1867)
+  (reported by @jzabate).
+- `jquery.flot.navigate.js`: panning on the y-axis with
+  `panRange` set no longer clamps the axis origin to
+  `panRange[0]`. Screen y coordinates run opposite to data y, so
+  the `minD` / `maxD` clamp bounds in `plot.pan` and `plot.smartPan`
+  needed to be swapped for y-axes. Fixes upstream
+  [flot/flot#1789](https://github.com/flot/flot/issues/1789)
+  (reported by @mjmlopes, diagnosed by @ecsv); ports the minimal
+  form of [flot/flot#1793](https://github.com/flot/flot/pull/1793)
+  (@netbymatt).
+- `jquery.flot.pie.js`: `drawDonutHole` and `triggerClickHoverEvent`
+  now read `options` via `plot.getOptions()` instead of relying on
+  the closure-scoped value, which is `null` until the
+  `processDatapoints` hook runs. Ports
+  [flot/flot#1559](https://github.com/flot/flot/pull/1559)
+  (@mnofresno; duplicate of
+  [flot/flot#1547](https://github.com/flot/flot/pull/1547)).
+- `jquery.flot.legend.js`: accept a jQuery-wrapped legend container,
+  not just a DOM element. Matches the intent of
+  [flot/flot#1750](https://github.com/flot/flot/pull/1750)
+  (@netbymatt, fixing
+  [flot/flot#1698](https://github.com/flot/flot/issues/1698)) but
+  inlines the unwrap since this fork is jQuery-optional.
+- `jquery.flot.legend.js`: render a fallback "box" icon for plugin-
+  drawn series (e.g. pie, errorbars) that don't turn on
+  `lines.show`, `bars.show`, or `points.show`. Previously these
+  legend entries showed the label with no icon. Ports the
+  substantive half of
+  [flot/flot#1641](https://github.com/flot/flot/pull/1641)
+  (@faizalluthfi, fixing
+  [flot/flot#1640](https://github.com/flot/flot/issues/1640)); the
+  upstream PR also switched the icon-selection chain to `else if`,
+  which would regress series that intentionally overlay (e.g. lines
+  with points) — that part is deliberately not ported.
+- `jquery.canvaswrapper.js`: guard against `positions == null` in
+  the text-cache iteration in `removeText`. Ports
+  [flot/flot#1444](https://github.com/flot/flot/pull/1444)
+  (@andig).
+
+### Changed
+
+- Dev dependency: jQuery 3.7.1 -> 4.0.0.
+- Dev dependency: Biome 1.9.4 -> 2.4.12 (includes config migration
+  to v2 format).
+- Dev dependency: Vitest 2.1.9 -> 4.1.4.
+- Dev dependency: happy-dom 15.11.7 -> 20.9.0.
+- Dev dependency: size-limit 12.0.1 -> 12.1.0,
+  @size-limit/file 12.0.1 -> 12.1.0.
+- CI: actions/checkout v4 -> v6, actions/setup-node v4 -> v6.
+
+### Thanks
+
+Thanks to everyone upstream who investigated, reported, and patched
+these bugs — the fixes in this release are direct ports of their
+work: @LYarnall, @ErikSievers, @jzabate, @mjmlopes, @ecsv,
+@netbymatt, @mnofresno, @faizalluthfi, @andig.
+
+## [5.1.0] - 2026-04-14
+
+### Added
+
+- **TypeScript type definitions.** Hand-written `.d.ts` files now ship
+  with the package. `import { plot, type PlotOptions } from '@kevinburke/flot'`
+  gives full autocomplete and type-checking. The jQuery adapter types
+  augment `JQueryStatic` so `$.plot()` is also typed.
+- Package validation via `publint` in CI.
+- Source code type-checking via TypeScript `checkJs` mode with a
+  ratchet (`.tsc-baseline`) that enforces the error count doesn't
+  grow.
+
+### Fixed
+
+- `jquery.canvaswrapper.js`: replace bare `hasOwnProperty.call(...)`
+  with `Object.prototype.hasOwnProperty.call(...)`. The bare form
+  would `ReferenceError` in strict mode — a latent bug in the SVG
+  text rendering path.
+- `jquery.flot.composeImages.js`: drop the ignored `"utf-8"` argument
+  from `new TextEncoder()`.
+- `jquery.flot.browser.js`: cache `window.top` and null-check it
+  before accessing browser-detection properties.
+- `jquery.flot.js`: add null guard after the `options.grid.markings`
+  callback in case the user returns `null`/`undefined`.
+- Remove dead arguments from a few internal function calls.
+
+### Internal
+
+- Added GitHub Actions Dependabot configuration.
+- Added `RELEASING.md` documenting the release process.
+- Removed `TEST-PORTING.md` (test migration plan completed with v5.0.0).
+- Suppressed benign Rollup missing-global warnings on standalone
+  plugin builds.
+
 ## [5.0.0] - 2026-04-14
 
 First stable release of the @kevinburke/flot fork. The plotting API is

package/README.md

@@ -42,7 +42,7 @@ plot(document.getElementById('placeholder'), data, options);
 Or via `<script>` tag from a CDN:
 
 ```html
-<script src="https://unpkg.com/@kevinburke/flot@5.0.0/dist/flot.min.js"></script>
+<script src="https://unpkg.com/@kevinburke/flot@5.1.0/dist/flot.min.js"></script>
 <script>
   Flot.plot(document.getElementById('placeholder'), data, options);
 </script>
@@ -52,7 +52,7 @@ Or via `<script>` tag from a CDN:
 
 ```html
 <script src="https://unpkg.com/jquery@3/dist/jquery.min.js"></script>
-<script src="https://unpkg.com/@kevinburke/flot@5.0.0/dist/jquery.flot.min.js"></script>
+<script src="https://unpkg.com/@kevinburke/flot@5.1.0/dist/jquery.flot.min.js"></script>
 <script>
   $.plot("#placeholder", data, options);
 </script>

package/dist/flot.js

@@ -1,4 +1,4 @@
-/*! @kevinburke/flot v5.0.0 | MIT License | https://github.com/kevinburke/flot */
+/*! @kevinburke/flot v5.1.1 | MIT License | https://github.com/kevinburke/flot */
 var Flot = (function (exports) {
     'use strict';
 
@@ -22,7 +22,9 @@ var Flot = (function (exports) {
         },
 
         isSafari: function() {
-            return /constructor/i.test(window.top.HTMLElement) || (function (p) { return p.toString() === "[object SafariRemoteNotification]"; })(!window.top['safari'] || (typeof window.top.safari !== 'undefined' && window.top.safari.pushNotification));
+            var top = window.top;
+            if (!top) return false;
+            return /constructor/i.test(top.HTMLElement) || (function (p) { return p.toString() === "[object SafariRemoteNotification]"; })(!top['safari'] || (typeof top.safari !== 'undefined' && top.safari.pushNotification));
         },
 
         isMobileSafari: function() {
@@ -30,7 +32,7 @@ var Flot = (function (exports) {
         },
 
         isOpera: function() {
-            return (!!window.opr && !!opr.addons) || !!window.opera || navigator.userAgent.indexOf(' OPR/') >= 0;
+            return (!!window.opr && !!window.opr.addons) || !!window.opera || navigator.userAgent.indexOf(' OPR/') >= 0;
         },
 
         isFirefox: function() {
@@ -348,7 +350,7 @@ var Flot = (function (exports) {
             // already been rendered, and remove those that are no longer active.
 
             for (var layerKey in cache) {
-                if (hasOwnProperty.call(cache, layerKey)) {
+                if (Object.prototype.hasOwnProperty.call(cache, layerKey)) {
                     var layer = this.getSVGLayer(layerKey),
                         layerCache = cache[layerKey];
 
@@ -356,10 +358,10 @@ var Flot = (function (exports) {
                     layer.style.display = 'none';
 
                     for (var styleKey in layerCache) {
-                        if (hasOwnProperty.call(layerCache, styleKey)) {
+                        if (Object.prototype.hasOwnProperty.call(layerCache, styleKey)) {
                             var styleCache = layerCache[styleKey];
                             for (var key in styleCache) {
-                                if (hasOwnProperty.call(styleCache, key)) {
+                                if (Object.prototype.hasOwnProperty.call(styleCache, key)) {
                                     var val = styleCache[key],
                                         positions = val.positions;
 
@@ -713,14 +715,20 @@ var Flot = (function (exports) {
                 var layerCache = this._textCache[layer];
                 if (layerCache != null) {
                     for (var styleKey in layerCache) {
-                        if (hasOwnProperty.call(layerCache, styleKey)) {
+                        if (Object.prototype.hasOwnProperty.call(layerCache, styleKey)) {
                             var styleCache = layerCache[styleKey];
                             for (var key in styleCache) {
-                                if (hasOwnProperty.call(styleCache, key)) {
+                                if (Object.prototype.hasOwnProperty.call(styleCache, key)) {
+                                    // styleCache entries can exist without a
+                                    // positions array (e.g. when a Flot plugin
+                                    // populates the cache outside the normal
+                                    // addText path). Upstream flot/flot#1444.
                                     var positions = styleCache[key].positions;
-                                    positions.forEach(function(position) {
-                                        position.active = false;
-                                    });
+                                    if (positions != null) {
+                                        positions.forEach(function(position) {
+                                            position.active = false;
+                                        });
+                                    }
                                 }
                             }
                         }
@@ -749,7 +757,7 @@ var Flot = (function (exports) {
         Canvas.prototype.clearCache = function() {
             var cache = this._textCache;
             for (var layerKey in cache) {
-                if (hasOwnProperty.call(cache, layerKey)) {
+                if (Object.prototype.hasOwnProperty.call(cache, layerKey)) {
                     var layer = this.getSVGLayer(layerKey);
                     while (layer.firstChild) {
                         layer.removeChild(layer.firstChild);
@@ -3359,8 +3367,11 @@ var Flot = (function (exports) {
                         };
 
                         // we might need an extra decimal since forced
-                        // ticks don't necessarily fit naturally
-                        if (!axis.mode && opts.tickDecimals == null) {
+                        // ticks don't necessarily fit naturally.
+                        // Guard against axis.delta <= 0 (min == max): Math.log(0)
+                        // is -Infinity, so extraDec would be +Infinity and
+                        // toFixed(Infinity) throws. Upstream #1869 / PR #1870.
+                        if (!axis.mode && opts.tickDecimals == null && axis.delta > 0) {
                             var extraDec = Math.max(0, -Math.floor(Math.log(axis.delta) / Math.LN10) + 1),
                                 ts = axis.tickGenerator(axis, plot);
 
@@ -3578,6 +3589,8 @@ var Flot = (function (exports) {
                         markings = markings(axes);
                     }
 
+                    if (!markings) return;
+
                     var i;
                     for (i = 0; i < markings.length; ++i) {
                         var m = markings[i],
@@ -4265,7 +4278,13 @@ var Flot = (function (exports) {
                     maxy = maxDistance / series.yaxis.scale,
                     points = series.datapoints.points,
                     ps = series.datapoints.pointsize,
-                    smallestDistance = Number.POSITIVE_INFINITY;
+                    // Seed with maxDistance (or its square, matching the
+                    // default squared-distance metric) so points outside
+                    // the hover radius are never selected. Without this,
+                    // the maxx/maxy coordinate-space pre-filter is the
+                    // only radius check, and it's disabled for axes with
+                    // inverseTransform — see upstream flot/flot#1871.
+                    smallestDistance = computeDistance ? maxDistance : maxDistance * maxDistance;
 
                 // with inverse transforms, we can't use the maxx/maxy
                 // optimization, sadly
@@ -4465,7 +4484,16 @@ var Flot = (function (exports) {
                 } else {
                     // assume this is a gradient spec; IE currently only
                     // supports a simple vertical gradient properly, so that's
-                    // what we support too
+                    // what we support too.
+                    // createLinearGradient throws if any coordinate is NaN or
+                    // ±Infinity (e.g. when the plot container has zero size
+                    // or the user supplies bogus bounds) — fall back to the
+                    // default solid color instead. Global isFinite coerces
+                    // null → 0 (finite), matching the drawSeriesPoints path
+                    // that passes (null, null). Upstream flot/flot#1867.
+                    if (!isFinite(top) || !isFinite(bottom)) {
+                        return defaultColor;
+                    }
                     var gradient = ctx.createLinearGradient(0, top, 0, bottom);
 
                     for (var i = 0, l = spec.colors.length; i < l; ++i) {
@@ -4493,7 +4521,7 @@ var Flot = (function (exports) {
         // Plugin registry. Plugins push to this array to register themselves.
         var plugins = [];
 
-        var version = "5.0.0";
+        var version = "5.1.1";
 
         // The main plot function.
         function plot(placeholder, data, options) {
@@ -5754,6 +5782,17 @@ var Flot = (function (exports) {
                     var minD = axis.p2c(opts.panRange[0]) - axis.p2c(axis.min);
                     // calc max delta (revealing right edge of plot)
                     var maxD = axis.p2c(opts.panRange[1]) - axis.p2c(axis.max);
+                    // For the y-axis, screen coordinates are inverted
+                    // (p2c(smaller v) > p2c(larger v)), so minD/maxD end up
+                    // with the opposite signs from the x-axis case. Swap
+                    // them so the clamp comparisons below keep their
+                    // x-axis semantics. Upstream flot/flot#1789, ports the
+                    // minimal form of PR #1793.
+                    if (axis.direction === 'y') {
+                        var swap = minD;
+                        minD = maxD;
+                        maxD = swap;
+                    }
                     // limit delta to min or max if enabled
                     if (opts.panRange[0] !== undefined && d >= maxD) d = maxD;
                     if (opts.panRange[1] !== undefined && d <= minD) d = minD;
@@ -5918,6 +5957,13 @@ var Flot = (function (exports) {
                     var minD = p + axis.p2c(opts.panRange[0]) - axis.p2c(axisMin);
                     // calc max delta (revealing right edge of plot)
                     var maxD = p + axis.p2c(opts.panRange[1]) - axis.p2c(axisMax);
+                    // Same y-axis swap as plot.pan — see comment there.
+                    // Upstream flot/flot#1789 / PR #1793.
+                    if (axis.direction === 'y') {
+                        var swap = minD;
+                        minD = maxD;
+                        maxD = swap;
+                    }
                     // limit delta to min or max if enabled
                     if (opts.panRange[0] !== undefined && d >= maxD) d = maxD;
                     if (opts.panRange[1] !== undefined && d <= minD) d = minD;
@@ -9215,7 +9261,7 @@ var Flot = (function (exports) {
 
             // Encode the string as UTF-8 and convert it to a binary string. The UTF-8 encoding is required to
             // capture unicode characters correctly.
-            utf8BinaryString = buildBinaryString(new (TextEncoder || TextEncoderLite)('utf-8').encode(source));
+            utf8BinaryString = buildBinaryString(new (TextEncoder || TextEncoderLite)().encode(source));
 
             data = "data:image/svg+xml;base64," + btoa(utf8BinaryString);
             img.src = data;
@@ -9481,6 +9527,17 @@ var Flot = (function (exports) {
                     shape.strokeWidth = entry.options.points.lineWidth;
                     iconHtml += getEntryIconHtml(shape);
                 }
+                // fallback for plugin-drawn series (pie, errorbars, etc.)
+                // that don't turn on any of lines/bars/points — without
+                // this the legend entry has a label but no icon. Upstream
+                // flot/flot#1641, minus the switch to `else if` so series
+                // that deliberately overlay (e.g. lines + points) keep
+                // rendering both icons.
+                if (iconHtml === '') {
+                    shape.name = 'box';
+                    shape.fillColor = entry.color;
+                    iconHtml += getEntryIconHtml(shape);
+                }
 
                 labelHtml = '<text x="' + shape.xPos + '" y="' + shape.yPos + '" text-anchor="start"><tspan dx="2em" dy="1.2em">' + shape.label + '</tspan></text>';
                 html[j++] = '<g>' + iconHtml + labelHtml + '</g>';
@@ -9520,9 +9577,17 @@ var Flot = (function (exports) {
                 legendEl.style.pointerEvents = 'none';
                 placeholder.appendChild(legendEl);
             } else {
-                options.legend.container.innerHTML = html.join('');
-                options.legend.container.style.width = width + 'px';
-                options.legend.container.style.height = height + 'em';
+                // Accept either a DOM Element or a jQuery-wrapped container.
+                // Upstream flot/flot#1750 switched to `$(container).get(0)` to
+                // always land on the underlying element; since this fork is
+                // jQuery-optional, do the unwrap inline.
+                var container = options.legend.container;
+                if (container && typeof container.get === 'function' && container[0]) {
+                    container = container[0];
+                }
+                container.innerHTML = html.join('');
+                container.style.width = width + 'px';
+                container.style.height = height + 'em';
             }
         }
 
@@ -9616,6 +9681,14 @@ var Flot = (function (exports) {
                         'width="1.5em" height="1.5em"' +
                         '/>';
                     break;
+                case 'box':
+                    html = '<use xlink:href="#box" class="legendIcon" ' +
+                        'x="' + x + '" ' +
+                        'y="' + y + '" ' +
+                        'fill="' + fill + '" ' +
+                        'width="1.5em" height="1.5em"' +
+                        '/>';
+                    break;
                 default:
                     // default is circle
                     html = '<use xlink:href="#circle" class="legendIcon" ' +
@@ -9638,6 +9711,12 @@ var Flot = (function (exports) {
                     '<polyline points="0,15 5,5 10,10 15,0"/>' +
                 '</symbol>' +
 
+                // Fallback icon for plugin-drawn series that don't turn on
+                // any of lines / bars / points. Upstream flot/flot#1641.
+                '<symbol id="box" stroke-width="1" viewBox="-5 -5 25 25">' +
+                    '<rect x="0" y="0" width="15" height="15"/>' +
+                '</symbol>' +
+
                 '<symbol id="area" stroke-width="1" viewBox="-5 -5 25 25">' +
                     '<polyline points="0,15 5,5 10,10 15,0, 15,15, 0,15"/>' +
                 '</symbol>' +