@kernlang/review 3.3.4 → 3.3.6

package/dist/rules/set-setter-collision.d.ts

@@ -0,0 +1,21 @@
+/**
+ * set-setter-collision — warns when a class `setter name=X` and a React
+ * state `state name=X` appear in the same file.
+ *
+ * Why this rule exists:
+ *   KERN has two nearby-but-different primitives that an LLM author can
+ *   reach for by accident:
+ *     - `setter name=X params="v:T"` inside a `class` → emits the JS
+ *       object-style accessor `set X(v: T) { body }`.
+ *     - `set name=X` inside an `on` handler → emits the React hook call
+ *       `setX(value)`, which requires a sibling `state name=X`.
+ *   When both appear in the same file with the same name, the reader loses
+ *   track of which spelling is the right one for the current site. The rule
+ *   fires `warning` on each offending node so the author can either rename
+ *   one of them or consciously accept the overlap.
+ *
+ * Scope: this is a .kern-source lint rule (ships with `reviewKernSource`).
+ * Layer: `kern-source`, severity `warning`, precision `high`.
+ */
+import type { KernSourceRule } from './kern-source.js';
+export declare const setSetterCollision: KernSourceRule;

package/dist/rules/set-setter-collision.js

@@ -0,0 +1,74 @@
+/**
+ * set-setter-collision — warns when a class `setter name=X` and a React
+ * state `state name=X` appear in the same file.
+ *
+ * Why this rule exists:
+ *   KERN has two nearby-but-different primitives that an LLM author can
+ *   reach for by accident:
+ *     - `setter name=X params="v:T"` inside a `class` → emits the JS
+ *       object-style accessor `set X(v: T) { body }`.
+ *     - `set name=X` inside an `on` handler → emits the React hook call
+ *       `setX(value)`, which requires a sibling `state name=X`.
+ *   When both appear in the same file with the same name, the reader loses
+ *   track of which spelling is the right one for the current site. The rule
+ *   fires `warning` on each offending node so the author can either rename
+ *   one of them or consciously accept the overlap.
+ *
+ * Scope: this is a .kern-source lint rule (ships with `reviewKernSource`).
+ * Layer: `kern-source`, severity `warning`, precision `high`.
+ */
+import { finding } from './utils.js';
+function getName(node) {
+    const n = node.props?.name;
+    return typeof n === 'string' ? n : undefined;
+}
+function collectByType(nodes, types, acc = new Map()) {
+    for (const node of nodes) {
+        if (types.has(node.type)) {
+            const n = getName(node);
+            if (n) {
+                const arr = acc.get(n) ?? [];
+                arr.push(node);
+                acc.set(n, arr);
+            }
+        }
+        if (node.children)
+            collectByType(node.children, types, acc);
+    }
+    return acc;
+}
+const SETTER_TYPES = new Set(['setter']);
+const STATE_TYPES = new Set(['state']);
+export const setSetterCollision = (nodes, filePath) => {
+    const setters = collectByType(nodes, SETTER_TYPES);
+    if (setters.size === 0)
+        return [];
+    const states = collectByType(nodes, STATE_TYPES);
+    if (states.size === 0)
+        return [];
+    const findings = [];
+    for (const [name, setterNodes] of setters) {
+        const stateNodes = states.get(name);
+        if (!stateNodes || stateNodes.length === 0)
+            continue;
+        const message = `\`setter name=${name}\` and \`state name=${name}\` both declared in this file — ` +
+            'the class emits `set ' +
+            name +
+            '(v)` while the state emits `set' +
+            name[0].toUpperCase() +
+            name.slice(1) +
+            '(v)`. Rename one side or document the overlap.';
+        for (const setterNode of setterNodes) {
+            findings.push(finding('set-setter-name-collision', 'warning', 'pattern', message, filePath, setterNode.loc?.line ?? 1, setterNode.loc?.col ?? 1, {
+                suggestion: '`setter` defines a JS object accessor (`set X(v)`); `set` inside an `on` handler calls the React setter (`setX(v)`). Pick the spelling that matches author intent and rename the other.',
+            }));
+        }
+        for (const stateNode of stateNodes) {
+            findings.push(finding('set-setter-name-collision', 'warning', 'pattern', message, filePath, stateNode.loc?.line ?? 1, stateNode.loc?.col ?? 1, {
+                suggestion: '`setter` defines a JS object accessor (`set X(v)`); `set` inside an `on` handler calls the React setter (`setX(v)`). Pick the spelling that matches author intent and rename the other.',
+            }));
+        }
+    }
+    return findings;
+};
+//# sourceMappingURL=set-setter-collision.js.map

package/dist/rules/set-setter-collision.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"set-setter-collision.js","sourceRoot":"","sources":["../../src/rules/set-setter-collision.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;GAkBG;AAKH,OAAO,EAAE,OAAO,EAAE,MAAM,YAAY,CAAC;AAErC,SAAS,OAAO,CAAC,IAAY;IAC3B,MAAM,CAAC,GAAG,IAAI,CAAC,KAAK,EAAE,IAAI,CAAC;IAC3B,OAAO,OAAO,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;AAC/C,CAAC;AAED,SAAS,aAAa,CACpB,KAAe,EACf,KAAkB,EAClB,MAA6B,IAAI,GAAG,EAAE;IAEtC,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,IAAI,KAAK,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;YACzB,MAAM,CAAC,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC;YACxB,IAAI,CAAC,EAAE,CAAC;gBACN,MAAM,GAAG,GAAG,GAAG,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;gBAC7B,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;gBACf,GAAG,CAAC,GAAG,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC;YAClB,CAAC;QACH,CAAC;QACD,IAAI,IAAI,CAAC,QAAQ;YAAE,aAAa,CAAC,IAAI,CAAC,QAAQ,EAAE,KAAK,EAAE,GAAG,CAAC,CAAC;IAC9D,CAAC;IACD,OAAO,GAAG,CAAC;AACb,CAAC;AAED,MAAM,YAAY,GAAG,IAAI,GAAG,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC;AACzC,MAAM,WAAW,GAAG,IAAI,GAAG,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC;AAEvC,MAAM,CAAC,MAAM,kBAAkB,GAAmB,CAAC,KAAe,EAAE,QAAgB,EAAmB,EAAE;IACvG,MAAM,OAAO,GAAG,aAAa,CAAC,KAAK,EAAE,YAAY,CAAC,CAAC;IACnD,IAAI,OAAO,CAAC,IAAI,KAAK,CAAC;QAAE,OAAO,EAAE,CAAC;IAClC,MAAM,MAAM,GAAG,aAAa,CAAC,KAAK,EAAE,WAAW,CAAC,CAAC;IACjD,IAAI,MAAM,CAAC,IAAI,KAAK,CAAC;QAAE,OAAO,EAAE,CAAC;IAEjC,MAAM,QAAQ,GAAoB,EAAE,CAAC;IACrC,KAAK,MAAM,CAAC,IAAI,EAAE,WAAW,CAAC,IAAI,OAAO,EAAE,CAAC;QAC1C,MAAM,UAAU,GAAG,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;QACpC,IAAI,CAAC,UAAU,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QAErD,MAAM,OAAO,GACX,iBAAiB,IAAI,uBAAuB,IAAI,kCAAkC;YAClF,uBAAuB;YACvB,IAAI;YACJ,iCAAiC;YACjC,IAAI,CAAC,CAAC,CAAC,CAAC,WAAW,EAAE;YACrB,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC;YACb,gDAAgD,CAAC;QAEnD,KAAK,MAAM,UAAU,IAAI,WAAW,EAAE,CAAC;YACrC,QAAQ,CAAC,IAAI,CACX,OAAO,CACL,2BAA2B,EAC3B,SAAS,EACT,SAAS,EACT,OAAO,EACP,QAAQ,EACR,UAAU,CAAC,GAAG,EAAE,IAAI,IAAI,CAAC,EACzB,UAAU,CAAC,GAAG,EAAE,GAAG,IAAI,CAAC,EACxB;gBACE,UAAU,EACR,yLAAyL;aAC5L,CACF,CACF,CAAC;QACJ,CAAC;QACD,KAAK,MAAM,SAAS,IAAI,UAAU,EAAE,CAAC;YACnC,QAAQ,CAAC,IAAI,CACX,OAAO,CACL,2BAA2B,EAC3B,SAAS,EACT,SAAS,EACT,OAAO,EACP,QAAQ,EACR,SAAS,CAAC,GAAG,EAAE,IAAI,IAAI,CAAC,EACxB,SAAS,CAAC,GAAG,EAAE,GAAG,IAAI,CAAC,EACvB;gBACE,UAAU,EACR,yLAAyL;aAC5L,CACF,CACF,CAAC;QACJ,CAAC;IACH,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC,CAAC"}

package/dist/rules/suggest-kern-primitive.d.ts

@@ -0,0 +1,30 @@
+/**
+ * suggest-kern-primitive — migration rule that flags JS patterns where an
+ * equivalent KERN primitive exists (array methods + fmt + conditional + async).
+ *
+ * Fires as `info` / precision=`experimental` so kern-sight hides it by default.
+ * Opt in with `--rule suggest-kern-primitive` for a one-shot migration scan.
+ *
+ * Covers the 22 shipped array primitives (post PR #93 + #103 + PR C):
+ *   filter, find, some, every, findIndex, reduce, map, flatMap, flat, slice,
+ *   at, sort, reverse, join, includes, indexOf, lastIndexOf, concat, forEach,
+ *   compact, pluck, unique.
+ *
+ * Plus three structural primitives:
+ *   - Template literal in `const` → `fmt name=x template="…"`
+ *   - JSX ternary in `{…}`       → `conditional if="…"` + handler/else
+ *   - async fn with try/catch    → `async name=X` + `recover`/`strategy`
+ *
+ * Special-cased shapes (route to the narrower primitive rather than the generic one):
+ *   - `.filter(Boolean)`              → `compact`
+ *   - `.map(x => x.prop[.chain])`     → `pluck`
+ *   - `[...new Set(coll)]`            → `unique`
+ *
+ * Immutability note: TS `.sort()` and `.reverse()` mutate; KERN emits the
+ * immutable `[...coll].sort(...)` / `[...coll].reverse()` shape. Suggestions
+ * for those two methods include a callout so authors can audit callers before
+ * migrating.
+ */
+import type { ReviewFinding, ReviewRule, RuleContext } from '../types.js';
+export declare function suggestKernPrimitive(ctx: RuleContext): ReviewFinding[];
+export declare const suggestKernPrimitiveRules: ReviewRule[];