@kernlang/review 3.1.8 → 3.2.3

package/dist/rules/react-composition.js

@@ -0,0 +1,360 @@
+/**
+ * React composition rules — catch prop-drilling and "parent rerenders child
+ * that doesn't depend on parent state" antipatterns.
+ *
+ * These rules push toward the `children` prop pattern, which preserves
+ * element identity across parent renders and lets React skip reconciliation
+ * of unchanged subtrees.
+ */
+import { Node, SyntaxKind } from 'ts-morph';
+import { finding, nodeSpan } from './utils.js';
+/** Is this node a React component function? (Capitalized name + returns JSX) */
+function isComponentFunction(node) {
+    let name = '';
+    if (Node.isFunctionDeclaration(node)) {
+        name = node.getName() ?? '';
+    }
+    else {
+        // Arrow/function expression — look at the parent variable declaration
+        const parent = node.getParent();
+        if (parent && Node.isVariableDeclaration(parent)) {
+            const n = parent.getNameNode();
+            if (Node.isIdentifier(n))
+                name = n.getText();
+        }
+    }
+    if (!name || !/^[A-Z]/.test(name))
+        return { name, isComponent: false };
+    // Must contain JSX somewhere in the body
+    const body = node.getBody();
+    if (!body)
+        return { name, isComponent: false };
+    const hasJsx = body.getDescendantsOfKind(SyntaxKind.JsxOpeningElement).length > 0 ||
+        body.getDescendantsOfKind(SyntaxKind.JsxSelfClosingElement).length > 0 ||
+        body.getDescendantsOfKind(SyntaxKind.JsxFragment).length > 0;
+    return { name, isComponent: hasJsx };
+}
+/** Extract destructured prop names from the first parameter of a component function. */
+function getDestructuredPropNames(fn) {
+    const params = fn.getParameters();
+    if (params.length === 0)
+        return undefined;
+    const nameNode = params[0].getNameNode();
+    if (!Node.isObjectBindingPattern(nameNode))
+        return undefined;
+    const names = [];
+    for (const el of nameNode.getElements()) {
+        // Use the property name if aliased, otherwise the binding name
+        const propName = el.getPropertyNameNode()?.getText() ?? el.getNameNode().getText();
+        names.push(propName);
+    }
+    return names;
+}
+function iterComponentFunctions(ctx) {
+    const results = [];
+    for (const fn of ctx.sourceFile.getFunctions()) {
+        const info = isComponentFunction(fn);
+        if (info.isComponent)
+            results.push(fn);
+    }
+    for (const stmt of ctx.sourceFile.getVariableStatements()) {
+        for (const decl of stmt.getDeclarations()) {
+            const init = decl.getInitializer();
+            if (!init)
+                continue;
+            if (Node.isArrowFunction(init) || Node.isFunctionExpression(init)) {
+                const info = isComponentFunction(init);
+                if (info.isComponent)
+                    results.push(init);
+            }
+        }
+    }
+    return results;
+}
+// ── Rule: children-not-used ──────────────────────────────────────────────
+// Component accepts `children` in its destructured props but never renders it.
+function childrenNotUsed(ctx) {
+    const findings = [];
+    for (const fn of iterComponentFunctions(ctx)) {
+        const propNames = getDestructuredPropNames(fn);
+        if (!propNames || !propNames.includes('children'))
+            continue;
+        const body = fn.getBody();
+        if (!body)
+            continue;
+        // Look for any identifier reference to `children` in the body
+        let rendered = false;
+        for (const id of body.getDescendantsOfKind(SyntaxKind.Identifier)) {
+            if (id.getText() !== 'children')
+                continue;
+            // Skip the declaration in the parameter binding — we want usage, not the binding itself
+            const parent = id.getParent();
+            if (parent && Node.isBindingElement(parent))
+                continue;
+            rendered = true;
+            break;
+        }
+        if (!rendered) {
+            const { name } = isComponentFunction(fn);
+            // Autofix: remove the `children` entry from the destructured props
+            // pattern. Only applies when the binding pattern is simple (no renames,
+            // defaults, or rest — those are fine, we just leave them alone here).
+            let autofixAction;
+            const firstParam = fn.getParameters()[0];
+            if (firstParam) {
+                const nameNode = firstParam.getNameNode();
+                if (Node.isObjectBindingPattern(nameNode)) {
+                    const elements = nameNode.getElements();
+                    const remaining = elements.filter((el) => {
+                        const propName = el.getPropertyNameNode()?.getText() ?? el.getNameNode().getText();
+                        return propName !== 'children';
+                    });
+                    // Reconstruct a clean `{ a, b, c }` pattern using each element's
+                    // original text. Preserves renames, defaults, and rest operators.
+                    const rebuilt = `{ ${remaining.map((el) => el.getText()).join(', ')} }`;
+                    autofixAction = {
+                        type: 'replace',
+                        span: nodeSpan(nameNode, ctx.filePath),
+                        replacement: rebuilt,
+                        description: `Remove unused 'children' from the props destructuring`,
+                    };
+                }
+            }
+            findings.push(finding('children-not-used', 'warning', 'pattern', `'${name}' destructures 'children' from props but never renders it — dead API or forgotten {children}`, ctx.filePath, fn.getStartLineNumber(), 1, {
+                suggestion: `Render {children} in the JSX output, or remove 'children' from the props destructuring if the component should not accept children`,
+                ...(autofixAction ? { autofix: autofixAction } : {}),
+            }));
+        }
+    }
+    return findings;
+}
+// ── Rule: prop-drill-passthrough ─────────────────────────────────────────
+// Component receives >= 3 props, body is a single JSX element, and >= 2 of
+// those props are passed unchanged to that element without being read anywhere
+// else. Suggest `children` or context.
+function getSingleReturnedJsx(fn) {
+    const body = fn.getBody();
+    if (!body)
+        return undefined;
+    // Case 1: arrow function with implicit return — body IS the JSX
+    if (Node.isJsxElement(body))
+        return body.getOpeningElement();
+    if (Node.isJsxSelfClosingElement(body))
+        return body;
+    if (Node.isJsxFragment(body))
+        return undefined; // fragments have multiple children
+    // Case 2: block body — look for a single return statement at the top level
+    if (Node.isBlock(body)) {
+        const statements = body.getStatements();
+        // Allow preamble (const x = ..., hook calls) but require the LAST statement to be a return with a single JSX root
+        const ret = statements.find((s) => Node.isReturnStatement(s));
+        if (!ret || !Node.isReturnStatement(ret))
+            return undefined;
+        const expr = ret.getExpression();
+        if (!expr)
+            return undefined;
+        // Walk through parentheses
+        let unwrapped = expr;
+        while (Node.isParenthesizedExpression(unwrapped)) {
+            unwrapped = unwrapped.getExpression();
+        }
+        if (Node.isJsxElement(unwrapped))
+            return unwrapped.getOpeningElement();
+        if (Node.isJsxSelfClosingElement(unwrapped))
+            return unwrapped;
+    }
+    return undefined;
+}
+function propDrillPassthrough(ctx) {
+    const findings = [];
+    for (const fn of iterComponentFunctions(ctx)) {
+        const propNames = getDestructuredPropNames(fn);
+        if (!propNames || propNames.length < 3)
+            continue;
+        const root = getSingleReturnedJsx(fn);
+        if (!root)
+            continue;
+        // The root element must be a custom component (capitalized tag) to be a meaningful passthrough.
+        const tag = root.getTagNameNode().getText();
+        if (!/^[A-Z]/.test(tag))
+            continue;
+        // Collect prop names passed as shorthand attributes to the root child.
+        // Only count attributes where the passed identifier is actually one of
+        // THIS component's destructured props — local variables with matching
+        // names (e.g. `title={title}` where `title` is a local const) are not
+        // drilling.
+        const propSet = new Set(propNames);
+        const passedToChild = new Set();
+        const passedWithShorthand = new Set();
+        for (const attr of root.getAttributes()) {
+            if (!Node.isJsxAttribute(attr))
+                continue;
+            const attrName = attr.getNameNode().getText();
+            const init = attr.getInitializer();
+            if (!init)
+                continue;
+            if (!Node.isJsxExpression(init))
+                continue;
+            const expr = init.getExpression();
+            if (!expr)
+                continue;
+            if (Node.isIdentifier(expr) && expr.getText() === attrName && propSet.has(attrName)) {
+                // Classic shorthand of a destructured prop: <Child user={user} theme={theme} />
+                passedToChild.add(attrName);
+                passedWithShorthand.add(attrName);
+            }
+        }
+        // Count props read OUTSIDE of passing to the root child
+        const body = fn.getBody();
+        if (!body)
+            continue;
+        const bodyText = body.getText();
+        // A prop is "consumed" if it appears somewhere other than as the RHS of an attribute
+        // of the single root child. We approximate: count total identifier refs in the body,
+        // and subtract the passthrough refs.
+        const consumedProps = new Set();
+        for (const propName of propNames) {
+            if (propName === 'children')
+                continue;
+            // Skip counting refs that are literally the attribute value of the root child.
+            // For a shorthand pass like `<Child user={user} />`, the identifier `user`
+            // appears TWICE in the body text: once as the attribute name and once as
+            // the value expression. Subtract 2 per shorthand to compensate.
+            const escaped = propName.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+            const totalRefs = (bodyText.match(new RegExp(`\\b${escaped}\\b`, 'g')) ?? []).length;
+            const passthroughRefs = passedWithShorthand.has(propName) ? 2 : 0;
+            if (totalRefs - passthroughRefs > 0) {
+                consumedProps.add(propName);
+            }
+        }
+        const passthroughCount = [...passedToChild].filter((p) => !consumedProps.has(p)).length;
+        if (passthroughCount >= 2 && propNames.length >= 3) {
+            const info = isComponentFunction(fn);
+            findings.push(finding('prop-drill-passthrough', 'warning', 'pattern', `'${info.name}' passes ${passthroughCount} of ${propNames.length} props through to <${tag}> without reading them — consider 'children' prop or React context`, ctx.filePath, fn.getStartLineNumber(), 1, {
+                suggestion: `Accept <${tag} .../> as the 'children' prop, or move the shared data into a React context. Passing props through an intermediate component forces it to re-render whenever any of them change.`,
+            }));
+        }
+    }
+    return findings;
+}
+// ── Rule: parent-rerender-via-state ──────────────────────────────────────
+// Component holds useState AND renders a child component that receives NEITHER
+// the state variables NOR the setters. That child will re-render on every
+// state change for no reason — lifting it to `children` preserves its element
+// identity and avoids the re-render.
+/**
+ * Get the DIRECT-child JSX elements of the top-level return. Skips nested
+ * descendants, elements inside callbacks (map renderers), and elements deep
+ * in conditional branches. This is the key guard against false positives:
+ * we only care about JSX that the parent component's own render produces
+ * positionally — those are the elements that could be lifted to `children`.
+ */
+function getDirectChildrenOfReturn(root) {
+    // If the root is already a self-closing element, there are no direct JSX children.
+    if (Node.isJsxSelfClosingElement(root))
+        return [root];
+    // Root is a JsxOpeningElement — walk its parent JsxElement children once.
+    const parent = root.getParent();
+    if (!parent || !Node.isJsxElement(parent))
+        return [root];
+    const result = [root];
+    for (const child of parent.getJsxChildren()) {
+        if (Node.isJsxElement(child)) {
+            result.push(child.getOpeningElement());
+        }
+        else if (Node.isJsxSelfClosingElement(child)) {
+            result.push(child);
+        }
+        // Skip JsxExpression / JsxText / JsxFragment content — too dynamic to reason about
+    }
+    return result;
+}
+/**
+ * Does this expression text mention any of the state variables? Wraps each
+ * variable in \b boundaries and tests the combined text. Handles callbacks
+ * too (e.g. onClick={() => setCount(c => c + 1)} — we treat ANY reference
+ * to setCount as a legitimate state dependency).
+ */
+function mentionsStateVars(text, stateVars) {
+    for (const v of stateVars) {
+        if (new RegExp(`\\b${v}\\b`).test(text))
+            return true;
+    }
+    return false;
+}
+function parentRerenderViaState(ctx) {
+    const findings = [];
+    for (const fn of iterComponentFunctions(ctx)) {
+        const body = fn.getBody();
+        if (!body)
+            continue;
+        // Collect state variable names AND setter names from useState/useReducer.
+        // Both the value and the setter count as "state refs" — a child that
+        // receives `setCount` is wiring to state and should NOT be flagged.
+        const stateVars = new Set();
+        for (const decl of body.getDescendantsOfKind(SyntaxKind.VariableDeclaration)) {
+            const init = decl.getInitializer();
+            if (!init || !Node.isCallExpression(init))
+                continue;
+            const calleeText = init.getExpression().getText();
+            const calleeName = calleeText.includes('.') ? calleeText.split('.').pop() : calleeText;
+            if (calleeName !== 'useState' && calleeName !== 'useReducer')
+                continue;
+            const nameNode = decl.getNameNode();
+            if (!Node.isArrayBindingPattern(nameNode))
+                continue;
+            for (const el of nameNode.getElements()) {
+                if (Node.isBindingElement(el)) {
+                    stateVars.add(el.getNameNode().getText());
+                }
+            }
+        }
+        if (stateVars.size === 0)
+            continue;
+        // Already composing with children? Skip — the user is on the correct path.
+        const propNames = getDestructuredPropNames(fn);
+        const alreadyComposesChildren = propNames?.includes('children') ?? false;
+        if (alreadyComposesChildren)
+            continue;
+        // Require a clean single-root returned JSX tree. Fragments, conditional
+        // returns, and dynamic structures are too ambiguous to reason about
+        // without a real dataflow pass — skip them.
+        const root = getSingleReturnedJsx(fn);
+        if (!root)
+            continue;
+        // Only look at the DIRECT children of the returned root. Nested helper
+        // JSX inside map callbacks, conditional branches, or deep descendants
+        // are not flaggable — they may close over state transitively.
+        const candidates = getDirectChildrenOfReturn(root);
+        for (const el of candidates) {
+            const tag = el.getTagNameNode().getText();
+            if (!/^[A-Z]/.test(tag))
+                continue; // HTML element — not a rerender target we care about
+            // Does this child receive any state var (or setter) via attributes?
+            // Scan the entire attribute bag's text in one pass so callback props
+            // like onClick={() => setCount(c => c + 1)} count as state-dependent.
+            const attrsText = el
+                .getAttributes()
+                .map((a) => (Node.isJsxAttribute(a) ? a.getText() : ''))
+                .join(' ');
+            if (mentionsStateVars(attrsText, stateVars))
+                continue;
+            // Is this element inside a JsxExpression that references state (a
+            // conditional render like `{count > 0 && <Child />}` or a map based
+            // on state)? Walk up the JSX container chain.
+            const containingExpr = el.getFirstAncestorByKind(SyntaxKind.JsxExpression);
+            if (containingExpr && mentionsStateVars(containingExpr.getText(), stateVars))
+                continue;
+            // Flag: this direct child never sees state and re-renders unnecessarily.
+            const info = isComponentFunction(fn);
+            findings.push(finding('parent-rerender-via-state', 'info', 'pattern', `<${tag}> is rendered by '${info.name}' but does not receive any of its state variables (${[...stateVars].slice(0, 3).join(', ')}${stateVars.size > 3 ? '…' : ''}) — it re-renders on every state change. Consider lifting it to the 'children' prop so React can reuse the element.`, ctx.filePath, el.getStartLineNumber(), 1, {
+                suggestion: `Accept <${tag}> as the 'children' prop of '${info.name}' and render it with {children}. The caller composes: <${info.name}><${tag} /></${info.name}>. React will reuse the child element across re-renders.`,
+            }));
+            break; // one finding per component is enough — avoid noise
+        }
+    }
+    return findings;
+}
+// ── Exported composition rules ───────────────────────────────────────────
+export const reactCompositionRules = [childrenNotUsed, propDrillPassthrough, parentRerenderViaState];
+//# sourceMappingURL=react-composition.js.map

package/dist/rules/react-composition.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"react-composition.js","sourceRoot":"","sources":["../../src/rules/react-composition.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAUH,OAAO,EAAE,IAAI,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AAE5C,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,MAAM,YAAY,CAAC;AAI/C,gFAAgF;AAChF,SAAS,mBAAmB,CAAC,IAAiB;IAC5C,IAAI,IAAI,GAAG,EAAE,CAAC;IACd,IAAI,IAAI,CAAC,qBAAqB,CAAC,IAAI,CAAC,EAAE,CAAC;QACrC,IAAI,GAAG,IAAI,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC;IAC9B,CAAC;SAAM,CAAC;QACN,sEAAsE;QACtE,MAAM,MAAM,GAAG,IAAI,CAAC,SAAS,EAAE,CAAC;QAChC,IAAI,MAAM,IAAI,IAAI,CAAC,qBAAqB,CAAC,MAAM,CAAC,EAAE,CAAC;YACjD,MAAM,CAAC,GAAG,MAAM,CAAC,WAAW,EAAE,CAAC;YAC/B,IAAI,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC;gBAAE,IAAI,GAAG,CAAC,CAAC,OAAO,EAAE,CAAC;QAC/C,CAAC;IACH,CAAC;IAED,IAAI,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC;QAAE,OAAO,EAAE,IAAI,EAAE,WAAW,EAAE,KAAK,EAAE,CAAC;IAEvE,yCAAyC;IACzC,MAAM,IAAI,GAAG,IAAI,CAAC,OAAO,EAAE,CAAC;IAC5B,IAAI,CAAC,IAAI;QAAE,OAAO,EAAE,IAAI,EAAE,WAAW,EAAE,KAAK,EAAE,CAAC;IAC/C,MAAM,MAAM,GACV,IAAI,CAAC,oBAAoB,CAAC,UAAU,CAAC,iBAAiB,CAAC,CAAC,MAAM,GAAG,CAAC;QAClE,IAAI,CAAC,oBAAoB,CAAC,UAAU,CAAC,qBAAqB,CAAC,CAAC,MAAM,GAAG,CAAC;QACtE,IAAI,CAAC,oBAAoB,CAAC,UAAU,CAAC,WAAW,CAAC,CAAC,MAAM,GAAG,CAAC,CAAC;IAC/D,OAAO,EAAE,IAAI,EAAE,WAAW,EAAE,MAAM,EAAE,CAAC;AACvC,CAAC;AAED,wFAAwF;AACxF,SAAS,wBAAwB,CAAC,EAAe;IAC/C,MAAM,MAAM,GAAG,EAAE,CAAC,aAAa,EAAE,CAAC;IAClC,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,SAAS,CAAC;IAC1C,MAAM,QAAQ,GAAG,MAAM,CAAC,CAAC,CAAC,CAAC,WAAW,EAAE,CAAC;IACzC,IAAI,CAAC,IAAI,CAAC,sBAAsB,CAAC,QAAQ,CAAC;QAAE,OAAO,SAAS,CAAC;IAE7D,MAAM,KAAK,GAAa,EAAE,CAAC;IAC3B,KAAK,MAAM,EAAE,IAAK,QAAiC,CAAC,WAAW,EAAE,EAAE,CAAC;QAClE,+DAA+D;QAC/D,MAAM,QAAQ,GAAG,EAAE,CAAC,mBAAmB,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC,OAAO,EAAE,CAAC;QACnF,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IACvB,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,sBAAsB,CAAC,GAAgB;IAC9C,MAAM,OAAO,GAAkB,EAAE,CAAC;IAClC,KAAK,MAAM,EAAE,IAAI,GAAG,CAAC,UAAU,CAAC,YAAY,EAAE,EAAE,CAAC;QAC/C,MAAM,IAAI,GAAG,mBAAmB,CAAC,EAAE,CAAC,CAAC;QACrC,IAAI,IAAI,CAAC,WAAW;YAAE,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACzC,CAAC;IACD,KAAK,MAAM,IAAI,IAAI,GAAG,CAAC,UAAU,CAAC,qBAAqB,EAAE,EAAE,CAAC;QAC1D,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,eAAe,EAAE,EAAE,CAAC;YAC1C,MAAM,IAAI,GAAG,IAAI,CAAC,cAAc,EAAE,CAAC;YACnC,IAAI,CAAC,IAAI;gBAAE,SAAS;YACpB,IAAI,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,oBAAoB,CAAC,IAAI,CAAC,EAAE,CAAC;gBAClE,MAAM,IAAI,GAAG,mBAAmB,CAAC,IAAI,CAAC,CAAC;gBACvC,IAAI,IAAI,CAAC,WAAW;oBAAE,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC3C,CAAC;QACH,CAAC;IACH,CAAC;IACD,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,4EAA4E;AAC5E,+EAA+E;AAE/E,SAAS,eAAe,CAAC,GAAgB;IACvC,MAAM,QAAQ,GAAoB,EAAE,CAAC;IAErC,KAAK,MAAM,EAAE,IAAI,sBAAsB,CAAC,GAAG,CAAC,EAAE,CAAC;QAC7C,MAAM,SAAS,GAAG,wBAAwB,CAAC,EAAE,CAAC,CAAC;QAC/C,IAAI,CAAC,SAAS,IAAI,CAAC,SAAS,CAAC,QAAQ,CAAC,UAAU,CAAC;YAAE,SAAS;QAE5D,MAAM,IAAI,GAAG,EAAE,CAAC,OAAO,EAAE,CAAC;QAC1B,IAAI,CAAC,IAAI;YAAE,SAAS;QAEpB,8DAA8D;QAC9D,IAAI,QAAQ,GAAG,KAAK,CAAC;QACrB,KAAK,MAAM,EAAE,IAAI,IAAI,CAAC,oBAAoB,CAAC,UAAU,CAAC,UAAU,CAAC,EAAE,CAAC;YAClE,IAAI,EAAE,CAAC,OAAO,EAAE,KAAK,UAAU;gBAAE,SAAS;YAC1C,wFAAwF;YACxF,MAAM,MAAM,GAAG,EAAE,CAAC,SAAS,EAAE,CAAC;YAC9B,IAAI,MAAM,IAAI,IAAI,CAAC,gBAAgB,CAAC,MAAM,CAAC;gBAAE,SAAS;YACtD,QAAQ,GAAG,IAAI,CAAC;YAChB,MAAM;QACR,CAAC;QAED,IAAI,CAAC,QAAQ,EAAE,CAAC;YACd,MAAM,EAAE,IAAI,EAAE,GAAG,mBAAmB,CAAC,EAAE,CAAC,CAAC;YAEzC,mEAAmE;YACnE,wEAAwE;YACxE,sEAAsE;YACtE,IAAI,aAAmD,CAAC;YACxD,MAAM,UAAU,GAAG,EAAE,CAAC,aAAa,EAAE,CAAC,CAAC,CAAC,CAAC;YACzC,IAAI,UAAU,EAAE,CAAC;gBACf,MAAM,QAAQ,GAAG,UAAU,CAAC,WAAW,EAAE,CAAC;gBAC1C,IAAI,IAAI,CAAC,sBAAsB,CAAC,QAAQ,CAAC,EAAE,CAAC;oBAC1C,MAAM,QAAQ,GAAI,QAAiC,CAAC,WAAW,EAAE,CAAC;oBAClE,MAAM,SAAS,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,EAAE,EAAE,EAAE;wBACvC,MAAM,QAAQ,GAAG,EAAE,CAAC,mBAAmB,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC,OAAO,EAAE,CAAC;wBACnF,OAAO,QAAQ,KAAK,UAAU,CAAC;oBACjC,CAAC,CAAC,CAAC;oBACH,iEAAiE;oBACjE,kEAAkE;oBAClE,MAAM,OAAO,GAAG,KAAK,SAAS,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,OAAO,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;oBACxE,aAAa,GAAG;wBACd,IAAI,EAAE,SAAkB;wBACxB,IAAI,EAAE,QAAQ,CAAC,QAAQ,EAAE,GAAG,CAAC,QAAQ,CAAC;wBACtC,WAAW,EAAE,OAAO;wBACpB,WAAW,EAAE,uDAAuD;qBACrE,CAAC;gBACJ,CAAC;YACH,CAAC;YAED,QAAQ,CAAC,IAAI,CACX,OAAO,CACL,mBAAmB,EACnB,SAAS,EACT,SAAS,EACT,IAAI,IAAI,8FAA8F,EACtG,GAAG,CAAC,QAAQ,EACZ,EAAE,CAAC,kBAAkB,EAAE,EACvB,CAAC,EACD;gBACE,UAAU,EAAE,oIAAoI;gBAChJ,GAAG,CAAC,aAAa,CAAC,CAAC,CAAC,EAAE,OAAO,EAAE,aAAa,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;aACrD,CACF,CACF,CAAC;QACJ,CAAC;IACH,CAAC;IACD,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,4EAA4E;AAC5E,2EAA2E;AAC3E,+EAA+E;AAC/E,uCAAuC;AAEvC,SAAS,oBAAoB,CAAC,EAAe;IAC3C,MAAM,IAAI,GAAG,EAAE,CAAC,OAAO,EAAE,CAAC;IAC1B,IAAI,CAAC,IAAI;QAAE,OAAO,SAAS,CAAC;IAE5B,gEAAgE;IAChE,IAAI,IAAI,CAAC,YAAY,CAAC,IAAI,CAAC;QAAE,OAAO,IAAI,CAAC,iBAAiB,EAAE,CAAC;IAC7D,IAAI,IAAI,CAAC,uBAAuB,CAAC,IAAI,CAAC;QAAE,OAAO,IAAI,CAAC;IACpD,IAAI,IAAI,CAAC,aAAa,CAAC,IAAI,CAAC;QAAE,OAAO,SAAS,CAAC,CAAC,mCAAmC;IAEnF,2EAA2E;IAC3E,IAAI,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;QACvB,MAAM,UAAU,GAAG,IAAI,CAAC,aAAa,EAAE,CAAC;QACxC,kHAAkH;QAClH,MAAM,GAAG,GAAG,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC,CAAC,CAAC,CAAC;QAC9D,IAAI,CAAC,GAAG,IAAI,CAAC,IAAI,CAAC,iBAAiB,CAAC,GAAG,CAAC;YAAE,OAAO,SAAS,CAAC;QAC3D,MAAM,IAAI,GAAG,GAAG,CAAC,aAAa,EAAE,CAAC;QACjC,IAAI,CAAC,IAAI;YAAE,OAAO,SAAS,CAAC;QAC5B,2BAA2B;QAC3B,IAAI,SAAS,GAAS,IAAI,CAAC;QAC3B,OAAO,IAAI,CAAC,yBAAyB,CAAC,SAAS,CAAC,EAAE,CAAC;YACjD,SAAS,GAAG,SAAS,CAAC,aAAa,EAAE,CAAC;QACxC,CAAC;QACD,IAAI,IAAI,CAAC,YAAY,CAAC,SAAS,CAAC;YAAE,OAAO,SAAS,CAAC,iBAAiB,EAAE,CAAC;QACvE,IAAI,IAAI,CAAC,uBAAuB,CAAC,SAAS,CAAC;YAAE,OAAO,SAAS,CAAC;IAChE,CAAC;IACD,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,oBAAoB,CAAC,GAAgB;IAC5C,MAAM,QAAQ,GAAoB,EAAE,CAAC;IAErC,KAAK,MAAM,EAAE,IAAI,sBAAsB,CAAC,GAAG,CAAC,EAAE,CAAC;QAC7C,MAAM,SAAS,GAAG,wBAAwB,CAAC,EAAE,CAAC,CAAC;QAC/C,IAAI,CAAC,SAAS,IAAI,SAAS,CAAC,MAAM,GAAG,CAAC;YAAE,SAAS;QAEjD,MAAM,IAAI,GAAG,oBAAoB,CAAC,EAAE,CAAC,CAAC;QACtC,IAAI,CAAC,IAAI;YAAE,SAAS;QAEpB,gGAAgG;QAChG,MAAM,GAAG,GAAG,IAAI,CAAC,cAAc,EAAE,CAAC,OAAO,EAAE,CAAC;QAC5C,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,GAAG,CAAC;YAAE,SAAS;QAElC,uEAAuE;QACvE,uEAAuE;QACvE,sEAAsE;QACtE,sEAAsE;QACtE,YAAY;QACZ,MAAM,OAAO,GAAG,IAAI,GAAG,CAAC,SAAS,CAAC,CAAC;QACnC,MAAM,aAAa,GAAG,IAAI,GAAG,EAAU,CAAC;QACxC,MAAM,mBAAmB,GAAG,IAAI,GAAG,EAAU,CAAC;QAC9C,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,aAAa,EAAE,EAAE,CAAC;YACxC,IAAI,CAAC,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC;gBAAE,SAAS;YACzC,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,EAAE,CAAC,OAAO,EAAE,CAAC;YAC9C,MAAM,IAAI,GAAG,IAAI,CAAC,cAAc,EAAE,CAAC;YACnC,IAAI,CAAC,IAAI;gBAAE,SAAS;YACpB,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC;gBAAE,SAAS;YAC1C,MAAM,IAAI,GAAG,IAAI,CAAC,aAAa,EAAE,CAAC;YAClC,IAAI,CAAC,IAAI;gBAAE,SAAS;YACpB,IAAI,IAAI,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,OAAO,EAAE,KAAK,QAAQ,IAAI,OAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,EAAE,CAAC;gBACpF,gFAAgF;gBAChF,aAAa,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC;gBAC5B,mBAAmB,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC;YACpC,CAAC;QACH,CAAC;QAED,wDAAwD;QACxD,MAAM,IAAI,GAAG,EAAE,CAAC,OAAO,EAAE,CAAC;QAC1B,IAAI,CAAC,IAAI;YAAE,SAAS;QAEpB,MAAM,QAAQ,GAAG,IAAI,CAAC,OAAO,EAAE,CAAC;QAChC,qFAAqF;QACrF,qFAAqF;QACrF,qCAAqC;QACrC,MAAM,aAAa,GAAG,IAAI,GAAG,EAAU,CAAC;QACxC,KAAK,MAAM,QAAQ,IAAI,SAAS,EAAE,CAAC;YACjC,IAAI,QAAQ,KAAK,UAAU;gBAAE,SAAS;YACtC,+EAA+E;YAC/E,2EAA2E;YAC3E,yEAAyE;YACzE,gEAAgE;YAChE,MAAM,OAAO,GAAG,QAAQ,CAAC,OAAO,CAAC,qBAAqB,EAAE,MAAM,CAAC,CAAC;YAChE,MAAM,SAAS,GAAG,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,MAAM,CAAC,MAAM,OAAO,KAAK,EAAE,GAAG,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC;YACrF,MAAM,eAAe,GAAG,mBAAmB,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;YAClE,IAAI,SAAS,GAAG,eAAe,GAAG,CAAC,EAAE,CAAC;gBACpC,aAAa,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC;YAC9B,CAAC;QACH,CAAC;QAED,MAAM,gBAAgB,GAAG,CAAC,GAAG,aAAa,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC;QACxF,IAAI,gBAAgB,IAAI,CAAC,IAAI,SAAS,CAAC,MAAM,IAAI,CAAC,EAAE,CAAC;YACnD,MAAM,IAAI,GAAG,mBAAmB,CAAC,EAAE,CAAC,CAAC;YACrC,QAAQ,CAAC,IAAI,CACX,OAAO,CACL,wBAAwB,EACxB,SAAS,EACT,SAAS,EACT,IAAI,IAAI,CAAC,IAAI,YAAY,gBAAgB,OAAO,SAAS,CAAC,MAAM,sBAAsB,GAAG,oEAAoE,EAC7J,GAAG,CAAC,QAAQ,EACZ,EAAE,CAAC,kBAAkB,EAAE,EACvB,CAAC,EACD;gBACE,UAAU,EAAE,WAAW,GAAG,kLAAkL;aAC7M,CACF,CACF,CAAC;QACJ,CAAC;IACH,CAAC;IACD,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,4EAA4E;AAC5E,+EAA+E;AAC/E,0EAA0E;AAC1E,8EAA8E;AAC9E,qCAAqC;AAErC;;;;;;GAMG;AACH,SAAS,yBAAyB,CAChC,IAA+C;IAE/C,mFAAmF;IACnF,IAAI,IAAI,CAAC,uBAAuB,CAAC,IAAI,CAAC;QAAE,OAAO,CAAC,IAAI,CAAC,CAAC;IAEtD,0EAA0E;IAC1E,MAAM,MAAM,GAAG,IAAI,CAAC,SAAS,EAAE,CAAC;IAChC,IAAI,CAAC,MAAM,IAAI,CAAC,IAAI,CAAC,YAAY,CAAC,MAAM,CAAC;QAAE,OAAO,CAAC,IAAI,CAAC,CAAC;IAEzD,MAAM,MAAM,GAAkD,CAAC,IAAI,CAAC,CAAC;IACrE,KAAK,MAAM,KAAK,IAAI,MAAM,CAAC,cAAc,EAAE,EAAE,CAAC;QAC5C,IAAI,IAAI,CAAC,YAAY,CAAC,KAAK,CAAC,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,iBAAiB,EAAE,CAAC,CAAC;QACzC,CAAC;aAAM,IAAI,IAAI,CAAC,uBAAuB,CAAC,KAAK,CAAC,EAAE,CAAC;YAC/C,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACrB,CAAC;QACD,mFAAmF;IACrF,CAAC;IACD,OAAO,MAAM,CAAC;AAChB,CAAC;AAED;;;;;GAKG;AACH,SAAS,iBAAiB,CAAC,IAAY,EAAE,SAAsB;IAC7D,KAAK,MAAM,CAAC,IAAI,SAAS,EAAE,CAAC;QAC1B,IAAI,IAAI,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;YAAE,OAAO,IAAI,CAAC;IACvD,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,sBAAsB,CAAC,GAAgB;IAC9C,MAAM,QAAQ,GAAoB,EAAE,CAAC;IAErC,KAAK,MAAM,EAAE,IAAI,sBAAsB,CAAC,GAAG,CAAC,EAAE,CAAC;QAC7C,MAAM,IAAI,GAAG,EAAE,CAAC,OAAO,EAAE,CAAC;QAC1B,IAAI,CAAC,IAAI;YAAE,SAAS;QAEpB,0EAA0E;QAC1E,qEAAqE;QACrE,oEAAoE;QACpE,MAAM,SAAS,GAAG,IAAI,GAAG,EAAU,CAAC;QACpC,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,oBAAoB,CAAC,UAAU,CAAC,mBAAmB,CAAC,EAAE,CAAC;YAC7E,MAAM,IAAI,GAAG,IAAI,CAAC,cAAc,EAAE,CAAC;YACnC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,gBAAgB,CAAC,IAAI,CAAC;gBAAE,SAAS;YACpD,MAAM,UAAU,GAAG,IAAI,CAAC,aAAa,EAAE,CAAC,OAAO,EAAE,CAAC;YAClD,MAAM,UAAU,GAAG,UAAU,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,GAAG,EAAE,CAAC,CAAC,CAAC,UAAU,CAAC;YACvF,IAAI,UAAU,KAAK,UAAU,IAAI,UAAU,KAAK,YAAY;gBAAE,SAAS;YACvE,MAAM,QAAQ,GAAG,IAAI,CAAC,WAAW,EAAE,CAAC;YACpC,IAAI,CAAC,IAAI,CAAC,qBAAqB,CAAC,QAAQ,CAAC;gBAAE,SAAS;YACpD,KAAK,MAAM,EAAE,IAAI,QAAQ,CAAC,WAAW,EAAE,EAAE,CAAC;gBACxC,IAAI,IAAI,CAAC,gBAAgB,CAAC,EAAE,CAAC,EAAE,CAAC;oBAC9B,SAAS,CAAC,GAAG,CAAC,EAAE,CAAC,WAAW,EAAE,CAAC,OAAO,EAAE,CAAC,CAAC;gBAC5C,CAAC;YACH,CAAC;QACH,CAAC;QAED,IAAI,SAAS,CAAC,IAAI,KAAK,CAAC;YAAE,SAAS;QAEnC,2EAA2E;QAC3E,MAAM,SAAS,GAAG,wBAAwB,CAAC,EAAE,CAAC,CAAC;QAC/C,MAAM,uBAAuB,GAAG,SAAS,EAAE,QAAQ,CAAC,UAAU,CAAC,IAAI,KAAK,CAAC;QACzE,IAAI,uBAAuB;YAAE,SAAS;QAEtC,wEAAwE;QACxE,oEAAoE;QACpE,4CAA4C;QAC5C,MAAM,IAAI,GAAG,oBAAoB,CAAC,EAAE,CAAC,CAAC;QACtC,IAAI,CAAC,IAAI;YAAE,SAAS;QAEpB,uEAAuE;QACvE,sEAAsE;QACtE,8DAA8D;QAC9D,MAAM,UAAU,GAAG,yBAAyB,CAAC,IAAI,CAAC,CAAC;QAEnD,KAAK,MAAM,EAAE,IAAI,UAAU,EAAE,CAAC;YAC5B,MAAM,GAAG,GAAG,EAAE,CAAC,cAAc,EAAE,CAAC,OAAO,EAAE,CAAC;YAC1C,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,GAAG,CAAC;gBAAE,SAAS,CAAC,qDAAqD;YAExF,oEAAoE;YACpE,qEAAqE;YACrE,sEAAsE;YACtE,MAAM,SAAS,GAAG,EAAE;iBACjB,aAAa,EAAE;iBACf,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;iBACvD,IAAI,CAAC,GAAG,CAAC,CAAC;YACb,IAAI,iBAAiB,CAAC,SAAS,EAAE,SAAS,CAAC;gBAAE,SAAS;YAEtD,kEAAkE;YAClE,oEAAoE;YACpE,8CAA8C;YAC9C,MAAM,cAAc,GAAG,EAAE,CAAC,sBAAsB,CAAC,UAAU,CAAC,aAAa,CAAC,CAAC;YAC3E,IAAI,cAAc,IAAI,iBAAiB,CAAC,cAAc,CAAC,OAAO,EAAE,EAAE,SAAS,CAAC;gBAAE,SAAS;YAEvF,yEAAyE;YACzE,MAAM,IAAI,GAAG,mBAAmB,CAAC,EAAE,CAAC,CAAC;YACrC,QAAQ,CAAC,IAAI,CACX,OAAO,CACL,2BAA2B,EAC3B,MAAM,EACN,SAAS,EACT,IAAI,GAAG,qBAAqB,IAAI,CAAC,IAAI,sDAAsD,CAAC,GAAG,SAAS,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,IAAI,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,qHAAqH,EACrR,GAAG,CAAC,QAAQ,EACZ,EAAE,CAAC,kBAAkB,EAAE,EACvB,CAAC,EACD;gBACE,UAAU,EAAE,WAAW,GAAG,gCAAgC,IAAI,CAAC,IAAI,0DAA0D,IAAI,CAAC,IAAI,KAAK,GAAG,QAAQ,IAAI,CAAC,IAAI,0DAA0D;aAC1N,CACF,CACF,CAAC;YACF,MAAM,CAAC,oDAAoD;QAC7D,CAAC;IACH,CAAC;IACD,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,4EAA4E;AAE5E,MAAM,CAAC,MAAM,qBAAqB,GAAG,CAAC,eAAe,EAAE,oBAAoB,EAAE,sBAAsB,CAAC,CAAC"}

package/dist/rules/react-hooks.d.ts

@@ -0,0 +1,11 @@
+/**
+ * React hooks correctness — Wave 2 net-new rules.
+ *
+ * Intentionally conservative: each rule only fires when the pattern is
+ * unambiguous. eslint-plugin-react-hooks is the authority for exhaustive
+ * correctness; this layer catches the common footguns with high precision.
+ */
+import type { ReviewFinding, RuleContext } from '../types.js';
+declare function exhaustiveDeps(ctx: RuleContext): ReviewFinding[];
+export declare const reactHooksRules: (typeof exhaustiveDeps)[];
+export {};