@kernlang/review 3.1.4 → 3.1.6

package/dist/rules/terminal.js

@@ -0,0 +1,127 @@
+/**
+ * Terminal review rules — active when target = terminal.
+ *
+ * Focused on interactive ANSI / readline terminal apps.
+ * Codex base rules + Claude extras (signal-handler, cursor-restore, unthrottled-render).
+ */
+import { finding } from './utils.js';
+function lineForIndex(text, index) {
+    return text.slice(0, index).split('\n').length;
+}
+function matchLine(text, pattern) {
+    const match = pattern.exec(text);
+    return match ? lineForIndex(text, match.index) : null;
+}
+// ── Rule: terminal-missing-tty-guard (Codex) ────────────────────────────
+function missingTtyGuard(ctx) {
+    const fullText = ctx.sourceFile.getFullText();
+    const interactivePattern = /\b(?:readline\.)?createInterface\s*\(|\b(?:process\.)?stdin\.setRawMode\s*\(\s*true|\b(?:process\.)?stdout\.(?:write|clearLine|cursorTo|clearScreenDown)\s*\(|\?1049h|\x1b\[|\u001b\[/;
+    if (!interactivePattern.test(fullText))
+        return [];
+    if (/\b(?:process\.)?(?:stdout|stdin)\.isTTY\b|\btty\.isatty\s*\(/.test(fullText))
+        return [];
+    const line = matchLine(fullText, interactivePattern) ?? 1;
+    return [finding('terminal-missing-tty-guard', 'warning', 'bug', 'Interactive terminal code runs without a TTY guard — pipes and non-interactive shells will render incorrectly', ctx.filePath, line, 1, { suggestion: 'Guard interactive paths with process.stdout.isTTY / process.stdin.isTTY before enabling ANSI UI features' })];
+}
+// ── Rule: terminal-raw-mode-no-restore (Codex) ──────────────────────────
+function rawModeNoRestore(ctx) {
+    const fullText = ctx.sourceFile.getFullText();
+    const enable = /\.setRawMode\s*\(\s*true\s*\)/g;
+    if (!enable.test(fullText))
+        return [];
+    if (/\.setRawMode\s*\(\s*false\s*\)/.test(fullText))
+        return [];
+    enable.lastIndex = 0;
+    const match = enable.exec(fullText);
+    const line = match ? lineForIndex(fullText, match.index) : 1;
+    return [finding('terminal-raw-mode-no-restore', 'error', 'bug', 'stdin raw mode is enabled without restoring it — the shell can be left in a broken state after exit', ctx.filePath, line, 1, { suggestion: 'Restore raw mode in cleanup handlers with process.stdin.setRawMode(false)' })];
+}
+// ── Rule: terminal-readline-no-close (Codex) ────────────────────────────
+function readlineNoClose(ctx) {
+    const findings = [];
+    const fullText = ctx.sourceFile.getFullText();
+    const decl = /\b(?:const|let|var)\s+(\w+)\s*=\s*(?:readline\.)?createInterface\s*\(/g;
+    let match;
+    while ((match = decl.exec(fullText)) !== null) {
+        const name = match[1];
+        const closePattern = new RegExp(`\\b${name}\\.close\\s*\\(`);
+        if (closePattern.test(fullText))
+            continue;
+        findings.push(finding('terminal-readline-no-close', 'warning', 'bug', `Readline interface '${name}' is never closed — stdin can remain open and keep the process hanging`, ctx.filePath, lineForIndex(fullText, match.index), 1, { suggestion: `Call ${name}.close() in completion and shutdown paths` }));
+    }
+    return findings;
+}
+// ── Rule: terminal-alt-screen-no-restore (Codex) ────────────────────────
+function altScreenNoRestore(ctx) {
+    const fullText = ctx.sourceFile.getFullText();
+    const enter = /\?1049h|\?47h/g;
+    if (!enter.test(fullText))
+        return [];
+    if (/\?1049l|\?47l/.test(fullText))
+        return [];
+    enter.lastIndex = 0;
+    const match = enter.exec(fullText);
+    const line = match ? lineForIndex(fullText, match.index) : 1;
+    return [finding('terminal-alt-screen-no-restore', 'warning', 'bug', 'Terminal app enters the alternate screen without restoring it on exit — users can be left in a blank session', ctx.filePath, line, 1, { suggestion: 'Emit the matching ?1049l / ?47l escape sequence during shutdown and signal cleanup' })];
+}
+// ── Rule: terminal-missing-signal-handler (Claude) ──────────────────────
+function missingSignalHandler(ctx) {
+    const fullText = ctx.sourceFile.getFullText();
+    // Only check files that do terminal-specific work
+    const isTerminal = /\b(setRawMode|cursorTo|clearLine|moveCursor|createInterface|blessed|inquirer|ora|chalk\.)\b/.test(fullText);
+    if (!isTerminal)
+        return [];
+    const hasSigint = /process\.on\s*\(\s*['"`]SIGINT['"`]/.test(fullText);
+    const hasSigterm = /process\.on\s*\(\s*['"`]SIGTERM['"`]/.test(fullText);
+    if (!hasSigint && !hasSigterm) {
+        const termMatch = fullText.match(/\b(setRawMode|cursorTo|clearLine|moveCursor|createInterface)\b/);
+        const line = termMatch ? lineForIndex(fullText, termMatch.index) : 1;
+        return [finding('terminal-missing-signal-handler', 'warning', 'pattern', 'Terminal app has no SIGINT/SIGTERM handler — cleanup code may not run on Ctrl+C', ctx.filePath, line, 1, { suggestion: 'Add process.on("SIGINT", () => { cleanup(); process.exit(130); })' })];
+    }
+    return [];
+}
+// ── Rule: terminal-cursor-not-restored (Claude) ─────────────────────────
+function cursorNotRestored(ctx) {
+    const fullText = ctx.sourceFile.getFullText();
+    const hidesCursor = /\\(?:x1[Bb]|u001[Bb]|e|033)\[\?25l/.test(fullText) ||
+        fullText.includes('cursor(false)') ||
+        fullText.includes('hideCursor') ||
+        fullText.includes('cursor.hide');
+    if (!hidesCursor)
+        return [];
+    const restoresCursor = /\\(?:x1[Bb]|u001[Bb]|e|033)\[\?25h/.test(fullText) ||
+        fullText.includes('cursor(true)') ||
+        fullText.includes('showCursor') ||
+        fullText.includes('cursor.show');
+    if (!restoresCursor) {
+        const match = fullText.match(/(?:hideCursor|cursor\.hide|cursor\(false\)|\?\s*25\s*l)/);
+        const line = match ? lineForIndex(fullText, match.index) : 1;
+        return [finding('terminal-cursor-not-restored', 'warning', 'bug', 'Cursor hidden without restore — cursor will stay invisible after exit', ctx.filePath, line, 1, { suggestion: 'Add process.on("exit", () => process.stdout.write("\\x1B[?25h"))' })];
+    }
+    return [];
+}
+// ── Rule: terminal-unthrottled-render (Claude) ──────────────────────────
+function unthrottledRender(ctx) {
+    const findings = [];
+    const fullText = ctx.sourceFile.getFullText();
+    const intervalRegex = /setInterval\s*\([^,]+,\s*(\d+)\s*\)/g;
+    let match;
+    while ((match = intervalRegex.exec(fullText)) !== null) {
+        const ms = parseInt(match[1], 10);
+        if (ms < 16) {
+            const line = lineForIndex(fullText, match.index);
+            findings.push(finding('terminal-unthrottled-render', 'warning', 'pattern', `setInterval at ${ms}ms (>${Math.round(1000 / ms)}fps) — excessive terminal redraws cause flicker`, ctx.filePath, line, 1, { suggestion: 'Use ≥16ms (60fps) for smooth terminal rendering without excess CPU' }));
+        }
+    }
+    return findings;
+}
+export const terminalRules = [
+    missingTtyGuard,
+    rawModeNoRestore,
+    readlineNoClose,
+    altScreenNoRestore,
+    missingSignalHandler,
+    cursorNotRestored,
+    unthrottledRender,
+];
+//# sourceMappingURL=terminal.js.map

package/dist/rules/terminal.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"terminal.js","sourceRoot":"","sources":["../../src/rules/terminal.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAGH,OAAO,EAAE,OAAO,EAAE,MAAM,YAAY,CAAC;AAErC,SAAS,YAAY,CAAC,IAAY,EAAE,KAAa;IAC/C,OAAO,IAAI,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC;AACjD,CAAC;AAED,SAAS,SAAS,CAAC,IAAY,EAAE,OAAe;IAC9C,MAAM,KAAK,GAAG,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACjC,OAAO,KAAK,CAAC,CAAC,CAAC,YAAY,CAAC,IAAI,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;AACxD,CAAC;AAED,2EAA2E;AAE3E,SAAS,eAAe,CAAC,GAAgB;IACvC,MAAM,QAAQ,GAAG,GAAG,CAAC,UAAU,CAAC,WAAW,EAAE,CAAC;IAC9C,MAAM,kBAAkB,GAAG,uLAAuL,CAAC;IACnN,IAAI,CAAC,kBAAkB,CAAC,IAAI,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IAClD,IAAI,8DAA8D,CAAC,IAAI,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IAE7F,MAAM,IAAI,GAAG,SAAS,CAAC,QAAQ,EAAE,kBAAkB,CAAC,IAAI,CAAC,CAAC;IAC1D,OAAO,CAAC,OAAO,CACb,4BAA4B,EAC5B,SAAS,EACT,KAAK,EACL,+GAA+G,EAC/G,GAAG,CAAC,QAAQ,EACZ,IAAI,EACJ,CAAC,EACD,EAAE,UAAU,EAAE,0GAA0G,EAAE,CAC3H,CAAC,CAAC;AACL,CAAC;AAED,2EAA2E;AAE3E,SAAS,gBAAgB,CAAC,GAAgB;IACxC,MAAM,QAAQ,GAAG,GAAG,CAAC,UAAU,CAAC,WAAW,EAAE,CAAC;IAC9C,MAAM,MAAM,GAAG,gCAAgC,CAAC;IAChD,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IACtC,IAAI,gCAAgC,CAAC,IAAI,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IAE/D,MAAM,CAAC,SAAS,GAAG,CAAC,CAAC;IACrB,MAAM,KAAK,GAAG,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IACpC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,YAAY,CAAC,QAAQ,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;IAC7D,OAAO,CAAC,OAAO,CACb,8BAA8B,EAC9B,OAAO,EACP,KAAK,EACL,qGAAqG,EACrG,GAAG,CAAC,QAAQ,EACZ,IAAI,EACJ,CAAC,EACD,EAAE,UAAU,EAAE,2EAA2E,EAAE,CAC5F,CAAC,CAAC;AACL,CAAC;AAED,2EAA2E;AAE3E,SAAS,eAAe,CAAC,GAAgB;IACvC,MAAM,QAAQ,GAAoB,EAAE,CAAC;IACrC,MAAM,QAAQ,GAAG,GAAG,CAAC,UAAU,CAAC,WAAW,EAAE,CAAC;IAC9C,MAAM,IAAI,GAAG,wEAAwE,CAAC;IACtF,IAAI,KAA6B,CAAC;IAElC,OAAO,CAAC,KAAK,GAAG,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;QAC9C,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;QACtB,MAAM,YAAY,GAAG,IAAI,MAAM,CAAC,MAAM,IAAI,iBAAiB,CAAC,CAAC;QAC7D,IAAI,YAAY,CAAC,IAAI,CAAC,QAAQ,CAAC;YAAE,SAAS;QAE1C,QAAQ,CAAC,IAAI,CAAC,OAAO,CACnB,4BAA4B,EAC5B,SAAS,EACT,KAAK,EACL,uBAAuB,IAAI,wEAAwE,EACnG,GAAG,CAAC,QAAQ,EACZ,YAAY,CAAC,QAAQ,EAAE,KAAK,CAAC,KAAK,CAAC,EACnC,CAAC,EACD,EAAE,UAAU,EAAE,QAAQ,IAAI,2CAA2C,EAAE,CACxE,CAAC,CAAC;IACL,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,2EAA2E;AAE3E,SAAS,kBAAkB,CAAC,GAAgB;IAC1C,MAAM,QAAQ,GAAG,GAAG,CAAC,UAAU,CAAC,WAAW,EAAE,CAAC;IAC9C,MAAM,KAAK,GAAG,gBAAgB,CAAC;IAC/B,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IACrC,IAAI,eAAe,CAAC,IAAI,CAAC,QAAQ,CAAC;QAAE,OAAO,EAAE,CAAC;IAE9C,KAAK,CAAC,SAAS,GAAG,CAAC,CAAC;IACpB,MAAM,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IACnC,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,YAAY,CAAC,QAAQ,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;IAC7D,OAAO,CAAC,OAAO,CACb,gCAAgC,EAChC,SAAS,EACT,KAAK,EACL,8GAA8G,EAC9G,GAAG,CAAC,QAAQ,EACZ,IAAI,EACJ,CAAC,EACD,EAAE,UAAU,EAAE,oFAAoF,EAAE,CACrG,CAAC,CAAC;AACL,CAAC;AAED,2EAA2E;AAE3E,SAAS,oBAAoB,CAAC,GAAgB;IAC5C,MAAM,QAAQ,GAAG,GAAG,CAAC,UAAU,CAAC,WAAW,EAAE,CAAC;IAE9C,kDAAkD;IAClD,MAAM,UAAU,GAAG,6FAA6F,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IAChI,IAAI,CAAC,UAAU;QAAE,OAAO,EAAE,CAAC;IAE3B,MAAM,SAAS,GAAG,qCAAqC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IACvE,MAAM,UAAU,GAAG,sCAAsC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IAEzE,IAAI,CAAC,SAAS,IAAI,CAAC,UAAU,EAAE,CAAC;QAC9B,MAAM,SAAS,GAAG,QAAQ,CAAC,KAAK,CAAC,gEAAgE,CAAC,CAAC;QACnG,MAAM,IAAI,GAAG,SAAS,CAAC,CAAC,CAAC,YAAY,CAAC,QAAQ,EAAE,SAAS,CAAC,KAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;QACtE,OAAO,CAAC,OAAO,CACb,iCAAiC,EACjC,SAAS,EACT,SAAS,EACT,iFAAiF,EACjF,GAAG,CAAC,QAAQ,EACZ,IAAI,EACJ,CAAC,EACD,EAAE,UAAU,EAAE,mEAAmE,EAAE,CACpF,CAAC,CAAC;IACL,CAAC;IAED,OAAO,EAAE,CAAC;AACZ,CAAC;AAED,2EAA2E;AAE3E,SAAS,iBAAiB,CAAC,GAAgB;IACzC,MAAM,QAAQ,GAAG,GAAG,CAAC,UAAU,CAAC,WAAW,EAAE,CAAC;IAE9C,MAAM,WAAW,GAAG,oCAAoC,CAAC,IAAI,CAAC,QAAQ,CAAC;QACnD,QAAQ,CAAC,QAAQ,CAAC,eAAe,CAAC;QAClC,QAAQ,CAAC,QAAQ,CAAC,YAAY,CAAC;QAC/B,QAAQ,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC;IACrD,IAAI,CAAC,WAAW;QAAE,OAAO,EAAE,CAAC;IAE5B,MAAM,cAAc,GAAG,oCAAoC,CAAC,IAAI,CAAC,QAAQ,CAAC;QACnD,QAAQ,CAAC,QAAQ,CAAC,cAAc,CAAC;QACjC,QAAQ,CAAC,QAAQ,CAAC,YAAY,CAAC;QAC/B,QAAQ,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC;IAExD,IAAI,CAAC,cAAc,EAAE,CAAC;QACpB,MAAM,KAAK,GAAG,QAAQ,CAAC,KAAK,CAAC,yDAAyD,CAAC,CAAC;QACxF,MAAM,IAAI,GAAG,KAAK,CAAC,CAAC,CAAC,YAAY,CAAC,QAAQ,EAAE,KAAK,CAAC,KAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;QAC9D,OAAO,CAAC,OAAO,CACb,8BAA8B,EAC9B,SAAS,EACT,KAAK,EACL,uEAAuE,EACvE,GAAG,CAAC,QAAQ,EACZ,IAAI,EACJ,CAAC,EACD,EAAE,UAAU,EAAE,kEAAkE,EAAE,CACnF,CAAC,CAAC;IACL,CAAC;IAED,OAAO,EAAE,CAAC;AACZ,CAAC;AAED,2EAA2E;AAE3E,SAAS,iBAAiB,CAAC,GAAgB;IACzC,MAAM,QAAQ,GAAoB,EAAE,CAAC;IACrC,MAAM,QAAQ,GAAG,GAAG,CAAC,UAAU,CAAC,WAAW,EAAE,CAAC;IAE9C,MAAM,aAAa,GAAG,sCAAsC,CAAC;IAC7D,IAAI,KAAK,CAAC;IACV,OAAO,CAAC,KAAK,GAAG,aAAa,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;QACvD,MAAM,EAAE,GAAG,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;QAClC,IAAI,EAAE,GAAG,EAAE,EAAE,CAAC;YACZ,MAAM,IAAI,GAAG,YAAY,CAAC,QAAQ,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC;YACjD,QAAQ,CAAC,IAAI,CAAC,OAAO,CACnB,6BAA6B,EAC7B,SAAS,EACT,SAAS,EACT,kBAAkB,EAAE,QAAQ,IAAI,CAAC,KAAK,CAAC,IAAI,GAAG,EAAE,CAAC,iDAAiD,EAClG,GAAG,CAAC,QAAQ,EACZ,IAAI,EACJ,CAAC,EACD,EAAE,UAAU,EAAE,oEAAoE,EAAE,CACrF,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,MAAM,CAAC,MAAM,aAAa,GAAiB;IACzC,eAAe;IACf,gBAAgB;IAChB,eAAe;IACf,kBAAkB;IAClB,oBAAoB;IACpB,iBAAiB;IACjB,iBAAiB;CAClB,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kernlang/review",
-  "version": "3.1.4",
+  "version": "3.1.6",
   "description": "Kern Review — scan TS, infer .kern IR, roundtrip diff, report",
   "type": "module",
   "main": "./dist/index.js",
@@ -26,10 +26,10 @@
   "license": "AGPL-3.0",
   "dependencies": {
     "ts-morph": "^27.0.0",
-    "@kernlang/core": "3.1.4"
+    "@kernlang/core": "3.1.6"
   },
   "scripts": {
     "build": "tsc -b",
-    "test": "node --experimental-vm-modules ../../node_modules/jest/bin/jest.js --forceExit --config jest.config.js"
+    "test": "node --experimental-vm-modules ../../node_modules/jest/bin/jest.js --config jest.config.js"
   }
 }