@kernlang/review-python 3.5.2-canary.154.1.c8074966 → 3.5.2

package/dist/mapper/extractors/error.js

@@ -25,7 +25,7 @@ export function extractErrorHandle(root, source, filePath, nodes) {
     // except clauses
     walkNodes(root, 'except_clause', (node) => {
         const block = node.children.find((c) => c.type === 'block');
-        const disposition = classifyPythonDisposition(block, source);
+        const disposition = classifyPythonDisposition(node, block, source);
         const errorVar = extractExceptVar(node);
         nodes.push({
             id: conceptId(filePath, 'error_handle', node.startIndex),
@@ -43,22 +43,29 @@ export function extractErrorHandle(root, source, filePath, nodes) {
         });
     });
 }
-function classifyPythonDisposition(block, source) {
+function classifyPythonDisposition(exceptNode, block, source) {
     if (!block)
         return { type: 'ignored', confidence: 1.0 };
     const children = block.namedChildren;
     // except: pass → ignored
     if (children.length === 1 && children[0].type === 'pass_statement') {
+        if (isIntentionalNoopExcept(exceptNode, source))
+            return { type: 'wrapped', confidence: 0.55 };
         return { type: 'ignored', confidence: 1.0 };
     }
     // except: ... (ellipsis) → ignored
     if (children.length === 1 && children[0].type === 'expression_statement') {
         const text = source.substring(children[0].startIndex, children[0].endIndex).trim();
-        if (text === '...')
+        if (text === '...') {
+            if (isIntentionalNoopExcept(exceptNode, source))
+                return { type: 'wrapped', confidence: 0.55 };
             return { type: 'ignored', confidence: 1.0 };
+        }
     }
     // Empty block
     if (children.length === 0) {
+        if (isIntentionalNoopExcept(exceptNode, source))
+            return { type: 'wrapped', confidence: 0.55 };
         return { type: 'ignored', confidence: 1.0 };
     }
     const bodyText = source.substring(block.startIndex, block.endIndex);
@@ -82,6 +89,57 @@ function classifyPythonDisposition(block, source) {
     }
     return { type: 'wrapped', confidence: 0.5 };
 }
+function isIntentionalNoopExcept(exceptNode, source) {
+    const block = exceptNode.children.find((child) => child.type === 'block');
+    const headerEnd = block?.startIndex ?? exceptNode.endIndex;
+    const exceptTypes = parseExceptTypes(source.substring(exceptNode.startIndex, headerEnd));
+    if (exceptTypes.length === 0)
+        return false;
+    const trySource = exceptNode.parent ? source.substring(exceptNode.parent.startIndex, exceptNode.startIndex) : '';
+    const tryBody = trySource
+        .split('\n')
+        .map((line) => line.trim())
+        .filter((line) => line && !line.startsWith('#') && !/^try\s*:/.test(line));
+    const hasOnly = (allowed) => exceptTypes.every((t) => allowed.includes(t));
+    if (hasOnly(['ProcessLookupError']) && tryBody.length === 1 && /\bos\.kill\s*\(/.test(tryBody[0]))
+        return true;
+    if (hasOnly(['ChildProcessError']) && tryBody.length === 1 && /\bos\.waitpid\s*\(/.test(tryBody[0]))
+        return true;
+    if (hasOnly(['FileNotFoundError']) &&
+        tryBody.length === 1 &&
+        /\b(os\.)?(unlink|remove|rmdir)\s*\(/.test(tryBody[0])) {
+        return true;
+    }
+    if (hasOnly(['OSError']) && tryBody.length === 1 && /\bos\.close\s*\(/.test(tryBody[0]))
+        return true;
+    if (hasOnly(['OSError']) &&
+        tryBody.length > 0 &&
+        tryBody.every((line) => /^(\w+\s*=\s*)?fcntl\.fcntl\s*\(/.test(line))) {
+        return true;
+    }
+    if (hasOnly(['BrokenPipeError']) && tryBody.length === 1 && /\.(write|flush|close)\s*\(/.test(tryBody[0]))
+        return true;
+    if (hasOnly(['AttributeError', 'ImportError', 'ValueError']) &&
+        tryBody.length === 1 &&
+        /\b(importlib|faulthandler\.register|signal\.SIG[A-Z0-9_]+|getattr|hasattr|ctypes|fcntl)\b/.test(tryBody[0])) {
+        return true;
+    }
+    return false;
+}
+function parseExceptTypes(line) {
+    const match = line.trim().match(/^except\s*(?:\(([\s\S]*?)\)|([A-Za-z_][\w.]*))?/);
+    if (!match)
+        return [];
+    const raw = match[1] ?? match[2] ?? '';
+    return raw
+        .split(',')
+        .map((part) => part
+        .trim()
+        .replace(/\s+as\s+\w+$/, '')
+        .split('.')
+        .pop() ?? '')
+        .filter(Boolean);
+}
 function extractRaiseType(node) {
     // raise ValueError("...") → "ValueError"
     const callNode = node.namedChildren.find((c) => c.type === 'call');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kernlang/review-python",
-  "version": "3.5.2-canary.154.1.c8074966",
+  "version": "3.5.2",
   "description": "Python concept mapper for kern review — tree-sitter based",
   "type": "module",
   "main": "dist/index.js",
@@ -8,8 +8,8 @@
   "dependencies": {
     "tree-sitter": "^0.25.0",
     "tree-sitter-python": "^0.25.0",
-    "@kernlang/core": "3.5.2-canary.154.1.c8074966",
-    "@kernlang/review": "3.5.2-canary.154.1.c8074966"
+    "@kernlang/core": "3.5.2",
+    "@kernlang/review": "3.5.2"
   },
   "devDependencies": {
     "ts-morph": "^28.0.0",

package/src/mapper/extractors/error.ts

@@ -39,7 +39,7 @@ export function extractErrorHandle(
   // except clauses
   walkNodes(root, 'except_clause', (node) => {
     const block = node.children.find((c) => c.type === 'block');
-    const disposition = classifyPythonDisposition(block, source);
+    const disposition = classifyPythonDisposition(node, block, source);
     const errorVar = extractExceptVar(node);
 
     nodes.push({
@@ -60,6 +60,7 @@ export function extractErrorHandle(
 }
 
 function classifyPythonDisposition(
+  exceptNode: Parser.SyntaxNode,
   block: Parser.SyntaxNode | undefined,
   source: string,
 ): { type: ErrorHandlePayload['disposition']; confidence: number } {
@@ -69,17 +70,22 @@ function classifyPythonDisposition(
 
   // except: pass → ignored
   if (children.length === 1 && children[0].type === 'pass_statement') {
+    if (isIntentionalNoopExcept(exceptNode, source)) return { type: 'wrapped', confidence: 0.55 };
     return { type: 'ignored', confidence: 1.0 };
   }
 
   // except: ... (ellipsis) → ignored
   if (children.length === 1 && children[0].type === 'expression_statement') {
     const text = source.substring(children[0].startIndex, children[0].endIndex).trim();
-    if (text === '...') return { type: 'ignored', confidence: 1.0 };
+    if (text === '...') {
+      if (isIntentionalNoopExcept(exceptNode, source)) return { type: 'wrapped', confidence: 0.55 };
+      return { type: 'ignored', confidence: 1.0 };
+    }
   }
 
   // Empty block
   if (children.length === 0) {
+    if (isIntentionalNoopExcept(exceptNode, source)) return { type: 'wrapped', confidence: 0.55 };
     return { type: 'ignored', confidence: 1.0 };
   }
 
@@ -108,6 +114,66 @@ function classifyPythonDisposition(
   return { type: 'wrapped', confidence: 0.5 };
 }
 
+function isIntentionalNoopExcept(exceptNode: Parser.SyntaxNode, source: string): boolean {
+  const block = exceptNode.children.find((child) => child.type === 'block');
+  const headerEnd = block?.startIndex ?? exceptNode.endIndex;
+  const exceptTypes = parseExceptTypes(source.substring(exceptNode.startIndex, headerEnd));
+  if (exceptTypes.length === 0) return false;
+
+  const trySource = exceptNode.parent ? source.substring(exceptNode.parent.startIndex, exceptNode.startIndex) : '';
+  const tryBody = trySource
+    .split('\n')
+    .map((line) => line.trim())
+    .filter((line) => line && !line.startsWith('#') && !/^try\s*:/.test(line));
+  const hasOnly = (allowed: readonly string[]) => exceptTypes.every((t) => allowed.includes(t));
+
+  if (hasOnly(['ProcessLookupError']) && tryBody.length === 1 && /\bos\.kill\s*\(/.test(tryBody[0])) return true;
+  if (hasOnly(['ChildProcessError']) && tryBody.length === 1 && /\bos\.waitpid\s*\(/.test(tryBody[0])) return true;
+  if (
+    hasOnly(['FileNotFoundError']) &&
+    tryBody.length === 1 &&
+    /\b(os\.)?(unlink|remove|rmdir)\s*\(/.test(tryBody[0])
+  ) {
+    return true;
+  }
+  if (hasOnly(['OSError']) && tryBody.length === 1 && /\bos\.close\s*\(/.test(tryBody[0])) return true;
+  if (
+    hasOnly(['OSError']) &&
+    tryBody.length > 0 &&
+    tryBody.every((line) => /^(\w+\s*=\s*)?fcntl\.fcntl\s*\(/.test(line))
+  ) {
+    return true;
+  }
+  if (hasOnly(['BrokenPipeError']) && tryBody.length === 1 && /\.(write|flush|close)\s*\(/.test(tryBody[0]))
+    return true;
+  if (
+    hasOnly(['AttributeError', 'ImportError', 'ValueError']) &&
+    tryBody.length === 1 &&
+    /\b(importlib|faulthandler\.register|signal\.SIG[A-Z0-9_]+|getattr|hasattr|ctypes|fcntl)\b/.test(tryBody[0])
+  ) {
+    return true;
+  }
+
+  return false;
+}
+
+function parseExceptTypes(line: string): string[] {
+  const match = line.trim().match(/^except\s*(?:\(([\s\S]*?)\)|([A-Za-z_][\w.]*))?/);
+  if (!match) return [];
+  const raw = match[1] ?? match[2] ?? '';
+  return raw
+    .split(',')
+    .map(
+      (part) =>
+        part
+          .trim()
+          .replace(/\s+as\s+\w+$/, '')
+          .split('.')
+          .pop() ?? '',
+    )
+    .filter(Boolean);
+}
+
 function extractRaiseType(node: Parser.SyntaxNode): string | undefined {
   // raise ValueError("...") → "ValueError"
   const callNode = node.namedChildren.find((c) => c.type === 'call');