@kernhq/module-quire 0.10.5 → 0.10.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kernhq/module-quire",
-  "version": "0.10.5",
+  "version": "0.10.7",
   "description": "Kern Quire: collaborative documents, spaces and page trees",
   "homepage": "https://github.com/KernAIO/module-quire#readme",
   "license": "AGPL-3.0-only",

package/src/client/components/SidebarSpaces.svelte

@@ -10,6 +10,7 @@ import {
   session,
 } from '@kernhq/ui'
 import { createQuery, useQueryClient } from '@tanstack/svelte-query'
+import { untrack } from 'svelte'
 import { getQuireApi } from '../api-instance.js'
 import { t } from '../i18n.js'
 import { buildPageTree, type PageTreeNode } from '../index.js'
@@ -76,18 +77,31 @@ const matches = $derived(
   query ? nodes.filter((n) => (n.title || t('untitled')).toLowerCase().includes(query)) : [],
 )
 
-/** A page opened from a link may be nested; its ancestors have to be open for it to be visible. */
+/**
+ * A page opened from a link may be nested; its ancestors have to be open for it to be visible.
+ *
+ * `expanded` is read through `untrack` because this effect also writes it. Tracked, the write makes
+ * the effect its own trigger: collapsing an ancestor of the open page removed it from the set, the
+ * effect re-ran and put it straight back, and the disclosure was inert — click it, press Enter on
+ * it, nothing moves. That is the "effect that reads a flag it also clears" trap already written
+ * down in shell's CLAUDE.md, and it was invisible until `navigation.params.page` started arriving:
+ * with `activePageId` permanently null the loop never ran at all.
+ *
+ * What genuinely selects this effect is which page is open and what the tree contains. Whether a
+ * disclosure is open is the *result*, and a result must not be an input.
+ */
 $effect(() => {
   if (!activePageId || nodes.length === 0) return
   const byId = new Map(nodes.map((n) => [n.id, n]))
-  const next = new Set(expanded)
+  const current = untrack(() => expanded)
+  const next = new Set(current)
   let cursor = byId.get(activePageId)?.parentId ?? null
   let guard = 0
   while (cursor && guard++ < 100) {
     next.add(cursor)
     cursor = byId.get(cursor)?.parentId ?? null
   }
-  if (next.size !== expanded.size) expanded = next
+  if (next.size !== current.size) expanded = next
 })
 
 function toggle(id: string) {

package/src/client/mock.ts

@@ -33,6 +33,21 @@ const iso = (msAgo = 0) => new Date(now - msAgo).toISOString()
 
 const uid = (n: number) => `01920000-0000-7000-8000-0000000${String(n).padStart(5, '0')}`
 
+/**
+ * The people the app's own mock signs you in as.
+ *
+ * Written out rather than derived: this module cannot see the shell's mock, and a comment with
+ * nobody's id on it loses the delete control only its author is offered — so the margin would look
+ * complete and be missing the one action that belongs to you.
+ *
+ * Declared here, above every factory that reads them, rather than beside the comment seed that used
+ * to own them: the page factory now stamps an author too, and it is called while the module body is
+ * still running. A `const` further down the same scope is in its temporal dead zone at that point,
+ * so the whole mock throws on import and every Quire screen renders nothing.
+ */
+const ME = '01920000-0000-7000-8000-000000000001'
+const COLLEAGUE = '01920000-0000-7000-8000-000000000002'
+
 interface Row extends Page {
   /** the mock keeps trashed rows in the same list, as the server does */
   _order: string
@@ -106,8 +121,16 @@ export function createMockQuireApi() {
     coverUrl: null,
     publishedVersionId: null,
     hasUnpublishedChanges: false,
-    createdBy: null,
-    updatedBy: null,
+    /*
+     * A seeded page has an author, because the byline reads one.
+     *
+     * These were both null, so `PageView` took its "author unknown" fallback on every page in the
+     * demo — the one environment where the byline is ever looked at — and the named path it now
+     * has shipped without anything rendering it. `ME` is the demo's signed-in member, so it
+     * resolves through `core.workspaces.members.list` like a comment's author does.
+     */
+    createdBy: ME as Page['createdBy'],
+    updatedBy: ME as Page['updatedBy'],
     createdAt: iso(9e7),
     updatedAt: iso(36e5),
     archivedAt: null,
@@ -246,16 +269,6 @@ export function createMockQuireApi() {
     pages.push(row)
   }
 
-  /**
-   * The people the app's own mock signs you in as.
-   *
-   * Written out rather than derived: this module cannot see the shell's mock, and a comment with
-   * nobody's id on it loses the delete control only its author is offered — so the margin would
-   * look complete and be missing the one action that belongs to you.
-   */
-  const ME = '01920000-0000-7000-8000-000000000001'
-  const COLLEAGUE = '01920000-0000-7000-8000-000000000002'
-
   /**
    * What the pages used to say, and what people have asked about them.
    *

package/src/client/pages/PageView.svelte

@@ -301,7 +301,18 @@ async function trash() {
     </div>
 
     <div class="byline">
-      <Avatar id={doc.updatedBy} name={editor?.name} src={editor?.avatarUrl ?? undefined} size={24} />
+      <!--
+        No avatar for an author nobody can name.
+
+        `Avatar` with no `name` draws a "?" disc whose `title` is empty, so an unresolved author put
+        a meaningless glyph at the head of the one line whose job is to say who touched the page —
+        and a screen reader read it out as "question mark". `updatedBy` is null for every page the
+        demo seeds and for any row written before the column existed, so this is the common path,
+        not the edge. The sentence beside it already falls back to wording that claims no author.
+      -->
+      {#if editor}
+        <Avatar id={doc.updatedBy} name={editor.name} src={editor.avatarUrl ?? undefined} size={24} />
+      {/if}
       <span>
         {editor
           ? t('edited_ago_by', { when: relativeTime(doc.updatedAt), who: editor.name })