@kernel-sig/console 0.1.0 → 0.1.1

package/backend/tests/test_review_summary.py

@@ -0,0 +1,244 @@
+"""评审情况汇总。
+
+这里钉的是几条**判断**，不是实现细节：
+
+1. 作者自己的回复不算「提了意见」—— 否则作者几乎总排第一，评审名单被淹。
+2. 整条评论只有一个评审指令（``/lgtm``）不算意见 —— 实测这类评论占评审
+   评论的多数，混进来会把真正写了话的人挤下去。
+3. 名册里查不到的人照样出现在支持名单里。外部贡献者也能给 LGTM，
+   不能因为查不到身份就把人抹掉；只是标不出 Committer 而已。
+4. 「还需评审」是子系统负责人减去已表态的人，不是全体 Committer ——
+   125 个人的名单没有信息量。
+
+用一个假 session 喂数据：这几条规则的输入是四张表的内容，与 SQL 怎么写无关。
+"""
+
+import uuid
+from datetime import UTC, datetime, timedelta
+
+import pytest
+
+from app.domain.review import EventType
+from app.models.classification import Classification, SubjectType
+from app.models.pull_request import PRComment, PRState, PullRequest, ReviewEvent
+from app.models.sig import SIGMember, SubsystemOwner
+from app.services.review_service import build_review_summary
+
+T0 = datetime(2026, 9, 1, 10, 0, tzinfo=UTC)
+REPO_ID = uuid.uuid4()
+
+
+class _FakeResult:
+    def __init__(self, rows: list) -> None:
+        self._rows = rows
+
+    def __iter__(self):
+        return iter(self._rows)
+
+    def all(self) -> list:
+        return self._rows
+
+
+class _FakeSession:
+    """按 ORM 实体返回预置行。
+
+    真实查询带 where 子句，但被测逻辑不依赖过滤 —— 过滤是数据库的事，
+    这里关心的是拿到行之后怎么聚合。
+
+    键必须是**类对象本身**，不能用字符串：调用方拿到的
+    ``stmt.column_descriptions[0]["entity"]`` 是类，字符串键永远查不中，
+    而查不中的表现是"名册为空"，测试会以错误的原因失败。
+    """
+
+    def __init__(self, by_entity: dict[type, list] | None = None) -> None:
+        self._by_entity = by_entity or {}
+
+    @staticmethod
+    def _entity(stmt):
+        return stmt.column_descriptions[0]["entity"]
+
+    async def scalars(self, stmt):
+        return _FakeResult(list(self._by_entity.get(self._entity(stmt), [])))
+
+    async def scalar(self, stmt):
+        rows = self._by_entity.get(self._entity(stmt), [])
+        return rows[0] if rows else None
+
+
+def _pull(author: str = "alice") -> PullRequest:
+    return PullRequest(
+        id=uuid.uuid4(),
+        repository_id=REPO_ID,
+        number=27766,
+        title="gpio: add support",
+        body=None,
+        state=PRState.OPEN,
+        author_login=author,
+        target_branch="OLK-6.6",
+    )
+
+
+def _event(actor: str, kind: EventType = EventType.LGTM, minutes: int = 0) -> ReviewEvent:
+    return ReviewEvent(
+        pull_request_id=uuid.uuid4(),
+        event_type=kind,
+        actor_login=actor,
+        source="comment",
+        occurred_at=T0 + timedelta(minutes=minutes),
+    )
+
+
+def _comment(actor: str, body: str, minutes: int = 0) -> PRComment:
+    return PRComment(
+        pull_request_id=uuid.uuid4(),
+        comment_id=str(uuid.uuid4()),
+        author_login=actor,
+        body=body,
+        atomgit_created_at=T0 + timedelta(minutes=minutes),
+    )
+
+
+def _member(login: str, role: str = "committer") -> SIGMember:
+    return SIGMember(name=login, atomgit_id=login, role=role, roles=[role])
+
+
+async def _summarise(pull, events, comments, members=(), owners=(), classification=None):
+    session = _FakeSession(
+        {
+            SIGMember: list(members),
+            SubsystemOwner: list(owners),
+            Classification: [classification] if classification else [],
+        }
+    )
+    return await build_review_summary(session, pull, events, comments, ["mm/foo.c"])
+
+
+@pytest.mark.asyncio
+async def test_author_replies_are_not_opinions():
+    pull = _pull(author="alice")
+    summary = await _summarise(
+        pull,
+        [],
+        [_comment("alice", "谢谢，已改"), _comment("bob", "这里有个并发问题")],
+    )
+    assert [c.login for c in summary.commenters] == ["bob"]
+
+
+@pytest.mark.asyncio
+async def test_command_only_comment_is_not_an_opinion():
+    """`/lgtm /approve` 是给机器看的指令，不是意见。"""
+    pull = _pull()
+    summary = await _summarise(
+        pull,
+        [],
+        [_comment("bob", "/lgtm /approve"), _comment("carol", "mmap 路径漏了加锁")],
+    )
+    assert [c.login for c in summary.commenters] == ["carol"]
+
+
+@pytest.mark.asyncio
+async def test_command_with_trailing_words_still_counts():
+    """带说明的同一个指令算意见 —— 判据是整条评论只有指令。"""
+    pull = _pull()
+    summary = await _summarise(pull, [], [_comment("bob", "/lgtm 但请补一下 commit log")])
+    assert [c.login for c in summary.commenters] == ["bob"]
+
+
+@pytest.mark.asyncio
+async def test_unknown_reviewer_is_kept_without_committer_flag():
+    pull = _pull()
+    summary = await _summarise(
+        pull,
+        [_event("outsider")],
+        [],
+        members=[_member("insider")],
+    )
+    assert [a.login for a in summary.supported] == ["outsider"]
+    assert summary.supported[0].is_committer is False
+    assert summary.committer_support == 0
+
+
+@pytest.mark.asyncio
+async def test_committer_support_is_counted():
+    pull = _pull()
+    summary = await _summarise(
+        pull,
+        [_event("insider"), _event("outsider")],
+        [],
+        members=[_member("insider")],
+    )
+    assert summary.committer_support == 1
+
+
+@pytest.mark.asyncio
+async def test_pending_excludes_those_who_already_spoke():
+    """还需评审 = 该子系统的 Committer 减去已表态的人。"""
+    pull = _pull()
+    owner = SubsystemOwner(
+        module="mm",
+        section="kernel core",
+        paths=["mm/"],
+        committer_logins=["has_said", "has_not"],
+        sequence=0,
+    )
+    summary = await _summarise(
+        pull,
+        [_event("has_said")],
+        [],
+        members=[_member("has_said"), _member("has_not")],
+        owners=[owner],
+    )
+    assert summary.subsystems == ["mm"]
+    assert [a.login for a in summary.pending] == ["has_not"]
+
+
+@pytest.mark.asyncio
+async def test_pending_matches_by_changed_file_path():
+    """分类没跑过时，用变更文件的路径前缀也能定位子系统。"""
+    pull = _pull()
+    owner = SubsystemOwner(
+        module="mm",
+        section="kernel core",
+        paths=["mm/"],
+        committer_logins=["reviewer"],
+        sequence=0,
+    )
+    summary = await _summarise(pull, [], [], members=[_member("reviewer")], owners=[owner])
+    assert summary.subsystems == ["mm"]
+    assert [a.login for a in summary.pending] == ["reviewer"]
+
+
+@pytest.mark.asyncio
+async def test_latest_comment_wins_the_excerpt():
+    pull = _pull()
+    summary = await _summarise(
+        pull,
+        [],
+        [_comment("bob", "第一条意见", minutes=0), _comment("bob", "第二条意见", minutes=10)],
+    )
+    assert summary.commenters[0].comments == 2
+    assert summary.commenters[0].latest_excerpt == "第二条意见"
+
+
+@pytest.mark.asyncio
+async def test_classification_subsystem_also_matches():
+    """分类给出的 subsystem 名与路径匹配是两条并行的路，任一命中即可。"""
+    pull = _pull()
+    owner = SubsystemOwner(
+        module="ub",
+        section="kernel core",
+        paths=["drivers/ub/"],
+        committer_logins=["ub_owner"],
+        sequence=0,
+    )
+    classification = Classification(
+        subject_type=SubjectType.PULL_REQUEST,
+        subject_id=pull.id,
+        subsystem="ub",
+        source="rule",
+        confidence=1.0,
+    )
+    summary = await _summarise(
+        pull, [], [], members=[_member("ub_owner")], owners=[owner], classification=classification
+    )
+    assert summary.subsystems == ["ub"]

package/frontend/src/api/pulls.ts

@@ -62,10 +62,50 @@ export interface PRCommit {
   sha: string
   sequence: number
   subject: string
+  /** 完整提交信息。评审要看正文里的 bugzilla / CVE / Reference 这些行。 */
+  message: string
   author_name: string | null
   author_email: string | null
   committed_at: string | null
   signed_off_bys: string[] | null
+  /** null 表示没取到，0 表示确实没改 —— 含义不同，不能混用。 */
+  additions: number | null
+  deletions: number | null
+}
+
+export interface ReviewActor {
+  login: string
+  events: number
+  last_at: string | null
+  role: string | null
+  is_committer: boolean
+}
+
+export interface ReviewCommenter {
+  login: string
+  comments: number
+  last_at: string | null
+  latest_excerpt: string | null
+}
+
+export interface ReviewSummary {
+  supported: ReviewActor[]
+  commenters: ReviewCommenter[]
+  pending: ReviewActor[]
+  /** 命中的子系统模块名，pending 就是从它们推出来的 */
+  subsystems: string[]
+  /** 已有几个 Committer 表过态 */
+  committer_support: number
+}
+
+export interface LinkedIssue {
+  number: number
+  title: string | null
+  issue_state: string | null
+  issue_type: string | null
+  html_url: string | null
+  /** atomgit_link（上游显式登记）/ pr_body（正文里写的链接） */
+  source: string
 }
 
 export interface PRFile {
@@ -122,6 +162,8 @@ export interface PullDetail extends PullSummary {
   ready_to_merge: boolean
   lgtm_actors: string[]
   labels: PRLabel[]
+  linked_issues: LinkedIssue[]
+  review_summary: ReviewSummary | null
   commits: PRCommit[]
   files: PRFile[]
   review_events: ReviewEvent[]

package/frontend/src/api/repositories.ts

@@ -70,6 +70,9 @@ export const repositoriesApi = {
     api_base_url?: string
   }) => api.post<Repository>('/repositories', payload),
 
+  update: (repositoryId: string, payload: { credential_id?: string }) =>
+    api.patch<Repository>(`/repositories/${repositoryId}`, payload),
+
   sync: (repositoryId: string, detailLimit = 50) =>
     api.post<SyncRun[]>(
       `/repositories/${repositoryId}/sync?detail_limit=${detailLimit}`,