@kenkaiiii/ggcoder 5.72.0 → 5.74.0

package/dist/core/agent-session.d.ts

@@ -1,4 +1,4 @@
-import { type AgentTool } from "@kenkaiiii/gg-agent";
+import { type AgentTool, type ToolExecuteResult } from "@kenkaiiii/gg-agent";
 import { type Message, type MessageProvenance, type Provider, type Usage, type ThinkingLevel } from "@kenkaiiii/gg-ai";
 import { EventBus } from "./event-bus.js";
 import { type CompletionReview } from "./completion-review.js";
@@ -122,7 +122,7 @@ export interface AgentSessionOptions {
      * UI. Omitted by callers that don't want plan mode (CLI wires its own).
      */
     onEnterPlan?: (reason?: string) => void | Promise<void>;
-    onExitPlan?: (planPath: string) => Promise<string>;
+    onExitPlan?: (planPath: string) => Promise<ToolExecuteResult>;
     /**
      * If provided, the session's tool set is filtered to ONLY these tool names
      * after `createTools()` runs, and the system prompt's Tools section lists only

package/dist/core/agent-session.js

@@ -24,7 +24,7 @@ import { ensureAppDirs } from "../config.js";
 import { buildSubAgentSystemPrompt, buildSystemPrompt, } from "../system-prompt.js";
 import { createTools, createWebSearchTool, } from "../tools/index.js";
 import { partitionToolsByTier } from "../tools/tool-tiers.js";
-import { autoBackgroundedId } from "../tools/bash.js";
+import { autoBackgroundedId, REVIEW_REJECTED_BEFORE_START } from "../tools/bash.js";
 import { buildProcessCompletionFollowUp } from "./process-gate.js";
 import { buildSubAgentCompletionFollowUp } from "./subagent-manager.js";
 import { applyAsyncSubagentPolicy } from "./subagent-policy.js";
@@ -69,6 +69,7 @@ import crypto from "node:crypto";
 import fs from "node:fs/promises";
 import os from "node:os";
 import path from "node:path";
+import { editTargetPaths } from "../tools/edit-targets.js";
 /**
  * A run whose tool calls fail more often than this is thrashing, not
  * progressing — refuse to extend its turn budget.
@@ -1212,20 +1213,29 @@ export class AgentSession {
                 let verificationChanged = false;
                 if (!event.isError && args) {
                     if (name === "edit" || name === "write") {
-                        const filePath = String(args.file_path ?? "");
                         // Check-owning files (tsconfig.json, pytest.ini, vitest.config.ts …)
                         // are tracked even when they are not source code: editing one
-                        // invalidates earlier check results.
-                        if (filePath && (isCodeFilePath(filePath) || isCheckOwnFile(filePath))) {
-                            this.verificationGate.recordMutation(filePath);
-                            verificationChanged = true;
+                        // invalidates earlier check results. A multi-file edit records every file.
+                        for (const filePath of editTargetPaths(args)) {
+                            if (isCodeFilePath(filePath) || isCheckOwnFile(filePath)) {
+                                this.verificationGate.recordMutation(filePath);
+                                verificationChanged = true;
+                            }
                         }
                     }
                 }
                 if (args && call && name === "bash") {
                     const command = typeof args.command === "string" ? args.command : "";
                     const classification = classifyVerificationCommand(command);
-                    if (classification.accepted || classification.snapshotEligible) {
+                    if (args.review === true && event.result === REVIEW_REJECTED_BEFORE_START) {
+                        // The core tool rejected its arguments BEFORE spawning. Never mint
+                        // a pass, or poison the failed-check ledger with an unexecuted check.
+                        // A child's output cannot match: bash always prefixes it with Exit code.
+                        this.verificationGate.recordRejectedCheck(command, REVIEW_REJECTED_BEFORE_START);
+                        delete call.sourceSnapshot;
+                        verificationChanged = true;
+                    }
+                    else if (classification.accepted || classification.snapshotEligible) {
                         // A foreground check that outlived the default budget was moved to
                         // the background, not failed: track it to its real exit the same way.
                         const autoBackgroundId = event.isError ? undefined : autoBackgroundedId(event.result);