@kenkaiiii/ggcoder 5.23.2 → 5.23.3

package/dist/utils/process.js

@@ -1,19 +1,77 @@
+import { spawnSync } from "node:child_process";
+import path from "node:path";
+const DEFAULT_TASKKILL_TIMEOUT_MS = 5_000;
+function getEnvCaseInsensitive(env, name) {
+    const wanted = name.toLowerCase();
+    return Object.entries(env).find(([key]) => key.toLowerCase() === wanted)?.[1];
+}
 /**
- * Kill a process and all its children by sending SIGKILL to the process group.
- * Falls back to killing just the process if process group kill fails.
+ * Absolute path to `taskkill.exe`.
+ *
+ * Bare `"taskkill"` depends on `System32` being on PATH — not guaranteed for a
+ * GUI-launched app whose PATH we also mutate — and is spoofable by a
+ * `taskkill.exe` sitting in the project cwd. Resolve it from `SystemRoot`
+ * (falling back to `WINDIR`, then `C:\Windows`), rejecting anything that isn't
+ * a plain drive-rooted path.
  */
-export function killProcessTree(pid) {
-    try {
-        // Kill the entire process group (negative pid)
-        process.kill(-pid, "SIGKILL");
-    }
-    catch {
+export function resolveWindowsTaskkillPath(env = process.env) {
+    const normalize = (value) => {
+        if (value === undefined)
+            return undefined;
+        const root = value.trim();
+        const unsafe = [...root].some((ch) => ch === ";" || ch.charCodeAt(0) <= 31);
+        if (!/^[A-Za-z]:[\\/]/.test(root) || unsafe)
+            return undefined;
+        return path.win32.normalize(root);
+    };
+    const systemRoot = normalize(getEnvCaseInsensitive(env, "SystemRoot")) ??
+        normalize(getEnvCaseInsensitive(env, "WINDIR")) ??
+        "C:\\Windows";
+    return path.win32.join(systemRoot, "System32", "taskkill.exe");
+}
+/**
+ * Kill a process and every descendant.
+ *
+ * POSIX: SIGKILL the process group (negative pid), falling back to the single
+ * pid. Windows has no process groups and negative pids are invalid there — the
+ * POSIX path silently left the whole child tree running, so a timed-out or
+ * cancelled `bash` command kept its `npm`/`node`/`pnpm` descendants alive
+ * forever. Use `taskkill /T /F` instead, falling back to the direct pid.
+ */
+export function killProcessTree(pid, options = {}) {
+    const platform = options.platform ?? process.platform;
+    const kill = options.kill ?? process.kill;
+    if (platform !== "win32") {
         try {
-            process.kill(pid, "SIGKILL");
+            kill(-pid, "SIGKILL");
+            return;
         }
         catch {
-            // Process already exited
+            killSingleProcess(pid, kill);
+            return;
         }
     }
+    const executable = resolveWindowsTaskkillPath(options.env);
+    try {
+        const result = (options.spawnSync ?? spawnSync)(executable, ["/PID", String(pid), "/T", "/F"], {
+            stdio: "ignore",
+            windowsHide: true,
+            timeout: options.taskkillTimeoutMs ?? DEFAULT_TASKKILL_TIMEOUT_MS,
+        });
+        if (result.status === 0 && result.error === undefined)
+            return;
+    }
+    catch {
+        // Fall through to the direct-pid fallback below.
+    }
+    killSingleProcess(pid, kill);
+}
+function killSingleProcess(pid, kill) {
+    try {
+        kill(pid, "SIGKILL");
+    }
+    catch {
+        // Process already exited.
+    }
 }
 //# sourceMappingURL=process.js.map

package/dist/utils/process.js.map

@@ -1 +1 @@
-{"version":3,"file":"process.js","sourceRoot":"","sources":["../../src/utils/process.ts"],"names":[],"mappings":"AAAA;;;GAGG;AACH,MAAM,UAAU,eAAe,CAAC,GAAW;IACzC,IAAI,CAAC;QACH,+CAA+C;QAC/C,OAAO,CAAC,IAAI,CAAC,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC;IAChC,CAAC;IAAC,MAAM,CAAC;QACP,IAAI,CAAC;YACH,OAAO,CAAC,IAAI,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC;QAC/B,CAAC;QAAC,MAAM,CAAC;YACP,yBAAyB;QAC3B,CAAC;IACH,CAAC;AACH,CAAC"}
+{"version":3,"file":"process.js","sourceRoot":"","sources":["../../src/utils/process.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,MAAM,oBAAoB,CAAC;AAC/C,OAAO,IAAI,MAAM,WAAW,CAAC;AAU7B,MAAM,2BAA2B,GAAG,KAAK,CAAC;AAE1C,SAAS,qBAAqB,CAAC,GAAsB,EAAE,IAAY;IACjE,MAAM,MAAM,GAAG,IAAI,CAAC,WAAW,EAAE,CAAC;IAClC,OAAO,MAAM,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,EAAE,EAAE,CAAC,GAAG,CAAC,WAAW,EAAE,KAAK,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;AAChF,CAAC;AAED;;;;;;;;GAQG;AACH,MAAM,UAAU,0BAA0B,CAAC,MAAyB,OAAO,CAAC,GAAG;IAC7E,MAAM,SAAS,GAAG,CAAC,KAAyB,EAAsB,EAAE;QAClE,IAAI,KAAK,KAAK,SAAS;YAAE,OAAO,SAAS,CAAC;QAC1C,MAAM,IAAI,GAAG,KAAK,CAAC,IAAI,EAAE,CAAC;QAC1B,MAAM,MAAM,GAAG,CAAC,GAAG,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,KAAK,GAAG,IAAI,EAAE,CAAC,UAAU,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC;QAC5E,IAAI,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,MAAM;YAAE,OAAO,SAAS,CAAC;QAC9D,OAAO,IAAI,CAAC,KAAK,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC;IACpC,CAAC,CAAC;IACF,MAAM,UAAU,GACd,SAAS,CAAC,qBAAqB,CAAC,GAAG,EAAE,YAAY,CAAC,CAAC;QACnD,SAAS,CAAC,qBAAqB,CAAC,GAAG,EAAE,QAAQ,CAAC,CAAC;QAC/C,aAAa,CAAC;IAChB,OAAO,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,UAAU,EAAE,UAAU,EAAE,cAAc,CAAC,CAAC;AACjE,CAAC;AAED;;;;;;;;GAQG;AACH,MAAM,UAAU,eAAe,CAAC,GAAW,EAAE,UAAkC,EAAE;IAC/E,MAAM,QAAQ,GAAG,OAAO,CAAC,QAAQ,IAAI,OAAO,CAAC,QAAQ,CAAC;IACtD,MAAM,IAAI,GAAG,OAAO,CAAC,IAAI,IAAI,OAAO,CAAC,IAAI,CAAC;IAE1C,IAAI,QAAQ,KAAK,OAAO,EAAE,CAAC;QACzB,IAAI,CAAC;YACH,IAAI,CAAC,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC;YACtB,OAAO;QACT,CAAC;QAAC,MAAM,CAAC;YACP,iBAAiB,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC;YAC7B,OAAO;QACT,CAAC;IACH,CAAC;IAED,MAAM,UAAU,GAAG,0BAA0B,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC;IAC3D,IAAI,CAAC;QACH,MAAM,MAAM,GAAG,CAAC,OAAO,CAAC,SAAS,IAAI,SAAS,CAAC,CAAC,UAAU,EAAE,CAAC,MAAM,EAAE,MAAM,CAAC,GAAG,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,EAAE;YAC7F,KAAK,EAAE,QAAQ;YACf,WAAW,EAAE,IAAI;YACjB,OAAO,EAAE,OAAO,CAAC,iBAAiB,IAAI,2BAA2B;SAClE,CAAC,CAAC;QACH,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,IAAI,MAAM,CAAC,KAAK,KAAK,SAAS;YAAE,OAAO;IAChE,CAAC;IAAC,MAAM,CAAC;QACP,iDAAiD;IACnD,CAAC;IACD,iBAAiB,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC;AAC/B,CAAC;AAED,SAAS,iBAAiB,CAAC,GAAW,EAAE,IAAyB;IAC/D,IAAI,CAAC;QACH,IAAI,CAAC,GAAG,EAAE,SAAS,CAAC,CAAC;IACvB,CAAC;IAAC,MAAM,CAAC;QACP,0BAA0B;IAC5B,CAAC;AACH,CAAC"}

package/dist/utils/process.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=process.test.d.ts.map

package/dist/utils/process.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"process.test.d.ts","sourceRoot":"","sources":["../../src/utils/process.test.ts"],"names":[],"mappings":""}

package/dist/utils/process.test.js

@@ -0,0 +1,42 @@
+import { describe, expect, it, vi } from "vitest";
+import { killProcessTree, resolveWindowsTaskkillPath } from "./process.js";
+describe("resolveWindowsTaskkillPath", () => {
+    it("resolves taskkill from SystemRoot", () => {
+        expect(resolveWindowsTaskkillPath({ SystemRoot: "C:\\Windows" })).toBe("C:\\Windows\\System32\\taskkill.exe");
+    });
+    it("is case-insensitive about the env var name and falls back to WINDIR", () => {
+        expect(resolveWindowsTaskkillPath({ systemroot: "D:/Win" })).toBe("D:\\Win\\System32\\taskkill.exe");
+        expect(resolveWindowsTaskkillPath({ WINDIR: "E:\\W" })).toBe("E:\\W\\System32\\taskkill.exe");
+    });
+    it("rejects relative or injected roots and falls back to C:\\Windows", () => {
+        expect(resolveWindowsTaskkillPath({ SystemRoot: "windows" })).toBe("C:\\Windows\\System32\\taskkill.exe");
+        expect(resolveWindowsTaskkillPath({ SystemRoot: "C:\\Win;C:\\evil" })).toBe("C:\\Windows\\System32\\taskkill.exe");
+        expect(resolveWindowsTaskkillPath({})).toBe("C:\\Windows\\System32\\taskkill.exe");
+    });
+});
+describe("killProcessTree", () => {
+    it("kills the whole tree with taskkill on Windows (never a negative pid)", () => {
+        const spawnSync = vi.fn().mockReturnValue({ status: 0 });
+        const kill = vi.fn();
+        killProcessTree(4242, {
+            platform: "win32",
+            kill,
+            spawnSync: spawnSync,
+            env: { SystemRoot: "C:\\Windows" },
+        });
+        expect(spawnSync).toHaveBeenCalledWith("C:\\Windows\\System32\\taskkill.exe", ["/PID", "4242", "/T", "/F"], expect.objectContaining({ windowsHide: true }));
+        expect(kill).not.toHaveBeenCalled();
+    });
+    it("falls back to the direct pid when taskkill fails", () => {
+        const spawnSync = vi.fn().mockReturnValue({ status: 1 });
+        const kill = vi.fn();
+        killProcessTree(7, { platform: "win32", kill, spawnSync: spawnSync, env: {} });
+        expect(kill).toHaveBeenCalledWith(7, "SIGKILL");
+    });
+    it("signals the process group on POSIX", () => {
+        const kill = vi.fn();
+        killProcessTree(99, { platform: "darwin", kill });
+        expect(kill).toHaveBeenCalledWith(-99, "SIGKILL");
+    });
+});
+//# sourceMappingURL=process.test.js.map

package/dist/utils/process.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"process.test.js","sourceRoot":"","sources":["../../src/utils/process.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAElD,OAAO,EAAE,eAAe,EAAE,0BAA0B,EAAE,MAAM,cAAc,CAAC;AAE3E,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;IAC1C,EAAE,CAAC,mCAAmC,EAAE,GAAG,EAAE;QAC3C,MAAM,CAAC,0BAA0B,CAAC,EAAE,UAAU,EAAE,aAAa,EAAE,CAAC,CAAC,CAAC,IAAI,CACpE,qCAAqC,CACtC,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;QAC7E,MAAM,CAAC,0BAA0B,CAAC,EAAE,UAAU,EAAE,QAAQ,EAAE,CAAC,CAAC,CAAC,IAAI,CAC/D,iCAAiC,CAClC,CAAC;QACF,MAAM,CAAC,0BAA0B,CAAC,EAAE,MAAM,EAAE,OAAO,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,+BAA+B,CAAC,CAAC;IAChG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kEAAkE,EAAE,GAAG,EAAE;QAC1E,MAAM,CAAC,0BAA0B,CAAC,EAAE,UAAU,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC,IAAI,CAChE,qCAAqC,CACtC,CAAC;QACF,MAAM,CAAC,0BAA0B,CAAC,EAAE,UAAU,EAAE,kBAAkB,EAAE,CAAC,CAAC,CAAC,IAAI,CACzE,qCAAqC,CACtC,CAAC;QACF,MAAM,CAAC,0BAA0B,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,qCAAqC,CAAC,CAAC;IACrF,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,iBAAiB,EAAE,GAAG,EAAE;IAC/B,EAAE,CAAC,sEAAsE,EAAE,GAAG,EAAE;QAC9E,MAAM,SAAS,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC,EAAE,MAAM,EAAE,CAAC,EAAE,CAAC,CAAC;QACzD,MAAM,IAAI,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QAErB,eAAe,CAAC,IAAI,EAAE;YACpB,QAAQ,EAAE,OAAO;YACjB,IAAI;YACJ,SAAS,EAAE,SAAkB;YAC7B,GAAG,EAAE,EAAE,UAAU,EAAE,aAAa,EAAE;SACnC,CAAC,CAAC;QAEH,MAAM,CAAC,SAAS,CAAC,CAAC,oBAAoB,CACpC,qCAAqC,EACrC,CAAC,MAAM,EAAE,MAAM,EAAE,IAAI,EAAE,IAAI,CAAC,EAC5B,MAAM,CAAC,gBAAgB,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC,CAC/C,CAAC;QACF,MAAM,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACtC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kDAAkD,EAAE,GAAG,EAAE;QAC1D,MAAM,SAAS,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC,EAAE,MAAM,EAAE,CAAC,EAAE,CAAC,CAAC;QACzD,MAAM,IAAI,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QAErB,eAAe,CAAC,CAAC,EAAE,EAAE,QAAQ,EAAE,OAAO,EAAE,IAAI,EAAE,SAAS,EAAE,SAAkB,EAAE,GAAG,EAAE,EAAE,EAAE,CAAC,CAAC;QAExF,MAAM,CAAC,IAAI,CAAC,CAAC,oBAAoB,CAAC,CAAC,EAAE,SAAS,CAAC,CAAC;IAClD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oCAAoC,EAAE,GAAG,EAAE;QAC5C,MAAM,IAAI,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QACrB,eAAe,CAAC,EAAE,EAAE,EAAE,QAAQ,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC;QAClD,MAAM,CAAC,IAAI,CAAC,CAAC,oBAAoB,CAAC,CAAC,EAAE,EAAE,SAAS,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kenkaiiii/ggcoder",
-  "version": "5.23.2",
+  "version": "5.23.3",
   "type": "module",
   "description": "CLI coding agent with OAuth authentication for Anthropic, OpenAI, and Gemini",
   "license": "MIT",
@@ -114,9 +114,9 @@
     "typescript-language-server": "^5.3.0",
     "wrap-ansi": "^10.0.0",
     "zod": "^4.4.3",
-    "@kenkaiiii/gg-core": "5.23.2",
-    "@kenkaiiii/gg-agent": "5.23.2",
-    "@kenkaiiii/gg-ai": "5.23.2"
+    "@kenkaiiii/gg-agent": "5.23.3",
+    "@kenkaiiii/gg-core": "5.23.3",
+    "@kenkaiiii/gg-ai": "5.23.3"
   },
   "optionalDependencies": {
     "@huggingface/transformers": "^3.6.0",