@kenkaiiii/ggcoder 5.22.2 → 5.22.4

package/assets/skills/evidence-led-ui/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: evidence-led-ui
-description: Use for web/mobile UI changes or evaluation: pages, components, dashboards, design systems, responsiveness, accessibility, or visual polish, even without explicit design request. Exclude database/API schemas, CLI output, copy-only work, standalone image/SVG generation, and description-only tasks.
+description: Use for broad or design-sensitive web/mobile UI work: net-new pages/screens, redesigns, design-system work, visual polish, responsive or accessibility overhauls, and UI quality review/critique. Do NOT use for small UI edits that follow existing patterns (bug fixes, minor styling tweaks, wiring, copy changes, small component additions matching neighbors); just match the surrounding code for those. Also exclude database/API schemas, CLI output, standalone image/SVG generation, and description-only tasks.
 license: See LICENSES.md
 compatibility: Full review requires filesystem inspection and rendered screenshots; web research and browser/device tooling are optional and unavailable checks must be reported honestly.
 ---

package/dist/app-sidecar.js

@@ -21,6 +21,7 @@ import { parseArgs } from "node:util";
 import { environmentSecrets, formatError, redactValue, } from "@kenkaiiii/gg-ai";
 import { runJsonMode } from "./modes/json-mode.js";
 import { runSubagentWorkerMode } from "./modes/subagent-worker-mode.js";
+import { setStreamDiagnostic } from "@kenkaiiii/gg-agent";
 import { AgentSession } from "./core/agent-session.js";
 import { RunLifecycle } from "./core/run-lifecycle.js";
 import { CHAT_AGENT_IDS, chatAgentSessionsDir, createChatAgent, parseChatAgentId, switchChatAgent, } from "./chat-agents/index.js";
@@ -47,6 +48,7 @@ import { SettingsManager } from "./core/settings-manager.js";
 import { getModel, getDefaultThinkingLevel, getContextWindow, MODELS, } from "./core/model-registry.js";
 import { resolveStartOrFallback } from "./core/resolve-start.js";
 import { getGitBranch, getGitDirtyFileCount, isGitRepo } from "./utils/git.js";
+import { getGitHubOpenCounts, getGitHubRepoSlug } from "./utils/github.js";
 import { extractPlanSteps } from "./utils/plan-steps.js";
 import { getNextThinkingLevel, getSupportedThinkingLevels, isThinkingLevelSupported, } from "./core/thinking-level.js";
 import { PROMPT_COMMANDS } from "./core/prompt-commands.js";
@@ -518,6 +520,31 @@ async function main() {
     // ~/.gg/debug.log (initLogger truncates on each start).
     const sidecarLog = path.join(paths.agentDir, "gg-app-sidecar.log");
     initLogger(sidecarLog);
+    // The desktop sidecar previously omitted the stream diagnostic hook used by
+    // the CLI, leaving device-specific provider stalls impossible to distinguish from
+    // event-loop starvation or a broken streaming network path. Keep routine
+    // phases lightweight; timeout phases include non-sensitive runtime context.
+    setStreamDiagnostic((phase, data) => {
+        const includeRuntime = phase === "idle_timeout_fired" ||
+            phase === "hard_timeout_fired" ||
+            phase === "stall_exhausted";
+        log("INFO", "stream", phase, {
+            ...(data ?? {}),
+            ...(includeRuntime
+                ? {
+                    platform: process.platform,
+                    arch: process.arch,
+                    osRelease: os.release(),
+                    node: process.version,
+                    logicalCpus: os.cpus().length,
+                    totalMemoryMb: Math.round(os.totalmem() / 1024 / 1024),
+                    freeMemoryMb: Math.round(os.freemem() / 1024 / 1024),
+                    rssMb: Math.round(process.memoryUsage().rss / 1024 / 1024),
+                    processUptimeSec: Math.round(process.uptime()),
+                }
+                : {}),
+        });
+    });
     // Global last-resort guards, installed as early as the logger allows so they
     // cover the WHOLE lifecycle — including startup/initialize, the phase the
     // "sidecar did not start in time" bug lives in. The sidecar is a long-lived
@@ -576,11 +603,14 @@ async function main() {
     });
     const usageCache = new Map();
     const usageRequests = new Map();
-    // 429 backoff: when the provider rate-limits the usage endpoint, hold the
-    // error result until this timestamp instead of re-polling (and re-logging a
-    // WARN) every 60s — the old cadence hammered a limited endpoint for hours.
+    // 429 backoff: quota endpoints are auxiliary UI data. Honor Retry-After when
+    // provided; otherwise retain the unavailable snapshot for 30 minutes. Clamp
+    // the provider value so a malformed header can neither hammer the endpoint
+    // nor suppress usage data forever.
     const usageRateLimitedUntil = new Map();
-    const USAGE_RATE_LIMIT_BACKOFF_MS = 5 * 60_000;
+    const USAGE_RATE_LIMIT_FALLBACK_BACKOFF_MS = 30 * 60_000;
+    const USAGE_RATE_LIMIT_MIN_BACKOFF_MS = 60_000;
+    const USAGE_RATE_LIMIT_MAX_BACKOFF_MS = 24 * 60 * 60_000;
     async function fetchUsageProvider(provider) {
         const displayName = provider === "anthropic" ? "Anthropic" : provider === "openai" ? "Codex" : "Kimi";
         // Kimi plan usage is tracked on the OAuth credential specifically — the
@@ -619,10 +649,16 @@ async function main() {
             if (shouldCaptureUsagePollingError(error)) {
                 captureSidecarError(error, "app-sidecar.usage.fetch", { provider });
             }
-            log("WARN", "app-sidecar", "subscription usage fetch failed", { provider, message });
+            let backoffMs;
             if (error instanceof SubscriptionUsageError && error.status === 429) {
-                usageRateLimitedUntil.set(provider, Date.now() + USAGE_RATE_LIMIT_BACKOFF_MS);
+                backoffMs = Math.min(USAGE_RATE_LIMIT_MAX_BACKOFF_MS, Math.max(USAGE_RATE_LIMIT_MIN_BACKOFF_MS, error.retryAfterMs ?? USAGE_RATE_LIMIT_FALLBACK_BACKOFF_MS));
+                usageRateLimitedUntil.set(provider, Date.now() + backoffMs);
             }
+            log("WARN", "app-sidecar", "subscription usage fetch failed", {
+                provider,
+                message,
+                ...(backoffMs !== undefined && { backoffMs: String(backoffMs) }),
+            });
             const connected = await auth.hasProviderAuth(authKey);
             return {
                 provider,
@@ -1183,14 +1219,20 @@ async function createSession(deps, opts) {
     // Workspace extras (context window, git status, background tasks). Git state
     // is resolved once at startup and refreshed after every run; the context
     // window follows the active model.
-    const [initialGitBranch, initialGitIsRepo, initialDirtyFileCount] = await Promise.all([
+    const [initialGitBranch, initialGitIsRepo, initialDirtyFileCount, initialGitHubSlug] = await Promise.all([
         getGitBranch(cwd).catch(() => null),
         isGitRepo(cwd).catch(() => false),
         getGitDirtyFileCount(cwd).catch(() => 0),
+        getGitHubRepoSlug(cwd).catch(() => null),
     ]);
     let gitBranch = initialGitBranch;
     let gitIsRepo = initialGitIsRepo;
     let gitDirtyFileCount = initialDirtyFileCount;
+    // Open issue/PR counts for the origin repo's GitHub slug, via the `gh` CLI's
+    // auth. null = unknown (gh missing/unauthed, non-GitHub origin) → chips hidden.
+    const gitHubSlug = initialGitHubSlug;
+    let gitHubIssues = null;
+    let gitHubPRs = null;
     function currentContextWindow() {
         const st = session.getState();
         return getContextWindow(st.model, { provider: st.provider, accountId: st.accountId });
@@ -1203,9 +1245,26 @@ async function createSession(deps, opts) {
             gitBranch,
             isGitRepo: gitIsRepo,
             gitDirtyFileCount,
+            gitHubIssues,
+            gitHubPRs,
+            gitHubRepoUrl: gitHubSlug ? `https://github.com/${gitHubSlug}` : null,
             tasks: session.listBackgroundProcesses(),
         };
     }
+    // Refresh the GitHub counts and broadcast only on change. Transient failures
+    // keep the last-known numbers so the chips don't flicker off on a timeout.
+    async function refreshGitHubCounts() {
+        if (!gitHubSlug)
+            return;
+        const counts = await getGitHubOpenCounts(gitHubSlug);
+        if (!counts)
+            return;
+        if (counts.issues !== gitHubIssues || counts.prs !== gitHubPRs) {
+            gitHubIssues = counts.issues;
+            gitHubPRs = counts.prs;
+            broadcast("extras", footerExtras());
+        }
+    }
     // tool_call_end carries no tool name (only the id), so remember each call's
     // name from tool_call_start to log a useful line on completion. Mirrors the
     // CLI's logging so the app sidecar's ~/.gg/gg-app-sidecar.log records tool
@@ -1641,6 +1700,9 @@ async function createSession(deps, opts) {
                 isGitRepo(cwd).catch(() => gitIsRepo),
                 getGitDirtyFileCount(cwd).catch(() => gitDirtyFileCount),
             ]);
+            // A run may have opened/closed issues or PRs — refresh fire-and-forget so
+            // teardown isn't delayed by the network. Broadcasts itself on change.
+            void refreshGitHubCounts();
             // Serialize behind any marker/tool-triggered refresh so the terminal
             // progress snapshot uses the live plan file. Once every canonical step
             // is complete, remove the approved plan from future system prompts and
@@ -2093,6 +2155,20 @@ async function createSession(deps, opts) {
         gitPoll.unref?.();
     };
     scheduleGitPoll(5000);
+    // GitHub issue/PR counts change outside the app (web UI, teammates), so poll
+    // on a slow cadence. Network-bound, so keep it well under the search API's
+    // rate budget (2 calls per tick). No-op when the origin isn't a GitHub repo.
+    let gitHubPoll;
+    let gitHubPollStopped = false;
+    const scheduleGitHubPoll = (delay) => {
+        if (gitHubPollStopped)
+            return;
+        gitHubPoll = setTimeout(() => {
+            void refreshGitHubCounts().finally(() => scheduleGitHubPoll(60_000));
+        }, delay);
+        gitHubPoll.unref?.();
+    };
+    scheduleGitHubPoll(2000);
     function readBody(req, res) {
         return readCappedBody(req, res);
     }
@@ -3786,6 +3862,9 @@ async function createSession(deps, opts) {
         gitPollStopped = true;
         if (gitPoll)
             clearTimeout(gitPoll);
+        gitHubPollStopped = true;
+        if (gitHubPoll)
+            clearTimeout(gitHubPoll);
         // Stop the Telegram serve loop + dispose its per-chat sessions.
         if (serveController)
             await serveController.stop().catch(() => { });