@kenkaiiii/ggcoder 5.22.0 → 5.22.2

package/dist/app-sidecar.js

@@ -35,6 +35,7 @@ import { validateKenModelPref, effectiveKenModel } from "./core/ken-model.js";
 import { normalizeAutopilotMarkersForHistory, normalizeAppMarkersForHistory, normalizeKenTurnsForHistory, restoreUserRow, restoreAssistantTexts, autopilotMarkerCopySeed, } from "./core/session-history.js";
 import { AuthStorage } from "./core/auth-storage.js";
 import { cleanupToolOutputs } from "./tools/overflow.js";
+import { readCappedBody } from "./utils/http-body.js";
 import { fetchSubscriptionUsage, MOONSHOT_OAUTH_KEY, SubscriptionUsageError, XIAOMI_CREDITS_KEY, } from "@kenkaiiii/gg-core";
 import { loginAnthropic } from "./core/oauth/anthropic.js";
 import { loginOpenAI } from "./core/oauth/openai.js";
@@ -240,6 +241,9 @@ async function prepareAttachments(cwd, attachments) {
     return out;
 }
 const FILE_SEARCH_LIMIT = 20;
+// Upper bound on files walked per search (baseline #8 memory cap). Far above the
+// 20-result output limit, so relevance/recency ranking is unaffected in practice.
+const FILE_SEARCH_SCAN_CAP = 50_000;
 /** Score a candidate path against a lowercased query. Higher is better; a
  *  negative score means "no match". Basename hits beat path hits; prefix beats
  *  substring; shorter paths break ties. */
@@ -292,8 +296,13 @@ async function searchProjectFiles(cwd, rawQuery) {
     }
     const ig = ignore.default().add(gitignore);
     // `stats: true` gives mtime without a second stat pass, so the empty-query
-    // "recent files" path is a single walk.
-    const entries = await fg.default("**/*", {
+    // "recent files" path is a single walk. Stream + hard scan cap (baseline #8):
+    // collecting the full result array retained ~0.9 MB per 1k files (18.5 MB at
+    // 20k), unbounded. Bail after FILE_SEARCH_SCAN_CAP entries so a giant repo
+    // can't balloon RSS; the newest/most-relevant matches still surface because
+    // the cap is far above the 20-result output limit.
+    const entries = [];
+    const scanStream = fg.default.stream("**/*", {
         cwd,
         dot: false,
         onlyFiles: true,
@@ -302,6 +311,17 @@ async function searchProjectFiles(cwd, rawQuery) {
         followSymbolicLinks: false,
         stats: true,
     });
+    for await (const entry of scanStream) {
+        entries.push(entry);
+        if (entries.length >= FILE_SEARCH_SCAN_CAP) {
+            scanStream.destroy();
+            log("DEBUG", "app-sidecar", "file search scan cap hit", {
+                cap: String(FILE_SEARCH_SCAN_CAP),
+                cwd,
+            });
+            break;
+        }
+    }
     const files = entries.filter((e) => !ig.ignores(e.path));
     if (!query) {
         return files
@@ -469,13 +489,8 @@ async function runJsonModeIfRequested() {
 // ── Daemon-level HTTP helpers (shared by the session-management routes) ─────
 // The per-session route table has its own local copies; these serve the
 // daemon's own POST /session / DELETE /session routes.
-function daemonReadBody(req) {
-    return new Promise((resolve, reject) => {
-        const chunks = [];
-        req.on("data", (c) => chunks.push(c));
-        req.on("end", () => resolve(Buffer.concat(chunks).toString("utf-8")));
-        req.on("error", reject);
-    });
+function daemonReadBody(req, res) {
+    return readCappedBody(req, res);
 }
 function daemonJson(res, status, body) {
     res.writeHead(status, {
@@ -679,7 +694,9 @@ async function main() {
         // ── Daemon-level routes (session lifecycle) ──────────────────────────
         // Create a session for a window: { mode?, cwd, sessionPath? } → { sessionId }.
         if (method === "POST" && url === "/session") {
-            void daemonReadBody(req).then(async (raw) => {
+            void daemonReadBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let body = {};
                 try {
                     body = raw ? JSON.parse(raw) : {};
@@ -777,6 +794,8 @@ async function main() {
         // Radio playback is app-wide (one stream across all windows), so it stops
         // at the daemon level, not per session.
         stopRadio();
+        // Close the ~/.gg progress fs.watch handle (baseline #8 leak fix).
+        progress.dispose();
         await Promise.all([...sessions.values()].map((c) => c.dispose().catch(() => { })));
         server.close();
         process.exit(0);
@@ -914,6 +933,7 @@ async function createProgressManager(agentDir, broadcastAll) {
     // Watch ~/.gg (dir watch survives the atomic tmp+rename) for progress.json
     // writes from other daemon processes; debounce, reload read-only, dedupe by nonce.
     let watchDebounce = null;
+    let progressWatcher = null;
     try {
         const watcher = fsWatch(agentDir, (_event, filename) => {
             if (filename !== "progress.json")
@@ -935,6 +955,7 @@ async function createProgressManager(agentDir, broadcastAll) {
             }, 150);
         });
         watcher.unref();
+        progressWatcher = watcher;
     }
     catch (err) {
         captureSidecarError(err, "app-sidecar.progress.watch");
@@ -942,7 +963,22 @@ async function createProgressManager(agentDir, broadcastAll) {
             message: err instanceof Error ? err.message : String(err),
         });
     }
-    return { snapshot, awardRun };
+    // Dispose closes the fs.watch handle (baseline #8: it was previously never
+    // closed — a per-daemon leak) and clears any pending debounce timer.
+    function dispose() {
+        if (watchDebounce) {
+            clearTimeout(watchDebounce);
+            watchDebounce = null;
+        }
+        try {
+            progressWatcher?.close();
+        }
+        catch {
+            // Already closed / never opened — nothing to do.
+        }
+        progressWatcher = null;
+    }
+    return { snapshot, awardRun, dispose };
 }
 /**
  * Build one in-process agent session: its AgentSession, SSE client set, event
@@ -2057,13 +2093,8 @@ async function createSession(deps, opts) {
         gitPoll.unref?.();
     };
     scheduleGitPoll(5000);
-    function readBody(req) {
-        return new Promise((resolve, reject) => {
-            const chunks = [];
-            req.on("data", (c) => chunks.push(c));
-            req.on("end", () => resolve(Buffer.concat(chunks).toString("utf-8")));
-            req.on("error", reject);
-        });
+    function readBody(req, res) {
+        return readCappedBody(req, res);
     }
     function json(res, status, body) {
         const payload = JSON.stringify(redactValue(body, { secrets: environmentSecrets(process.env) }));
@@ -2204,7 +2235,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/settings") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let projectsRoot;
                 try {
                     projectsRoot = JSON.parse(raw).projectsRoot ?? "";
@@ -2227,7 +2260,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/create-project") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let name;
                 try {
                     name = JSON.parse(raw).name ?? "";
@@ -2640,7 +2675,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/prompt") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let text;
                 let attachments;
                 let meta;
@@ -2767,7 +2804,9 @@ async function createSession(deps, opts) {
                 json(res, 404, { error: "Ken is not available in GG Chat." });
                 return;
             }
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let text;
                 try {
                     text = JSON.parse(raw).text ?? "";
@@ -2826,7 +2865,9 @@ async function createSession(deps, opts) {
                 json(res, 404, { error: "Autopilot is not available in GG Chat." });
                 return;
             }
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let enabled;
                 try {
                     enabled = Boolean(JSON.parse(raw).enabled);
@@ -2847,7 +2888,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/enhance") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let text;
                 try {
                     text = JSON.parse(raw).text ?? "";
@@ -2896,7 +2939,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/radio/volume") {
-            void readBody(req).then((raw) => {
+            void readBody(req, res).then((raw) => {
+                if (raw === null)
+                    return;
                 let volume;
                 try {
                     volume = Number(JSON.parse(raw).volume);
@@ -2919,7 +2964,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/radio") {
-            void readBody(req).then((raw) => {
+            void readBody(req, res).then((raw) => {
+                if (raw === null)
+                    return;
                 let station;
                 try {
                     station = JSON.parse(raw).station ?? "";
@@ -2943,7 +2990,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/tasks/run") {
-            void readBody(req).then((raw) => {
+            void readBody(req, res).then((raw) => {
+                if (raw === null)
+                    return;
                 let id;
                 let all;
                 try {
@@ -2965,7 +3014,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/tasks/delete") {
-            void readBody(req).then((raw) => {
+            void readBody(req, res).then((raw) => {
+                if (raw === null)
+                    return;
                 let id;
                 try {
                     id = JSON.parse(raw).id ?? "";
@@ -3003,7 +3054,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/model") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let modelId;
                 try {
                     modelId = JSON.parse(raw).model ?? "";
@@ -3072,7 +3125,9 @@ async function createSession(deps, opts) {
         // to BOTH Ken sessions (chat + autopilot reviewer); a switch landing while
         // either is mid-run defers via the pending-model mechanics.
         if (method === "POST" && url === "/ken/model") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let modelId;
                 try {
                     const parsed = JSON.parse(raw).model;
@@ -3116,7 +3171,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/kill") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let id;
                 try {
                     id = JSON.parse(raw).id ?? "";
@@ -3237,7 +3294,9 @@ async function createSession(deps, opts) {
         //   3. session_reset tells the webview to clear its transcript; it then runs
         //      the "implement it now" prompt in the clean session.
         if (method === "POST" && url === "/plan/accept") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let planPath;
                 try {
                     planPath = JSON.parse(raw).planPath || undefined;
@@ -3289,7 +3348,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/auth/apikey") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let provider = "";
                 let key;
                 let variant;
@@ -3332,7 +3393,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/auth/oauth/start") {
-            void readBody(req).then((raw) => {
+            void readBody(req, res).then((raw) => {
+                if (raw === null)
+                    return;
                 let provider = "";
                 try {
                     provider = JSON.parse(raw).provider ?? "";
@@ -3389,7 +3452,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/auth/oauth/code") {
-            void readBody(req).then((raw) => {
+            void readBody(req, res).then((raw) => {
+                if (raw === null)
+                    return;
                 let code;
                 try {
                     code = JSON.parse(raw).code ?? "";
@@ -3409,7 +3474,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/auth/logout") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let provider;
                 try {
                     provider = JSON.parse(raw).provider ?? "";
@@ -3448,7 +3515,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/telegram") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let botTokenInput;
                 let userIdInput;
                 try {
@@ -3552,7 +3621,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/mcp/add") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let line;
                 let scopeValue;
                 let bodyCwd;
@@ -3609,7 +3680,9 @@ async function createSession(deps, opts) {
             return;
         }
         if (method === "POST" && url === "/mcp/remove") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let name;
                 let scopeValue;
                 let bodyCwd;
@@ -3646,7 +3719,9 @@ async function createSession(deps, opts) {
         // `mcp_auth_error`. Responds 202 immediately and runs the flow in the
         // background (the browser round-trip can take a while).
         if (method === "POST" && url === "/mcp/login") {
-            void readBody(req).then(async (raw) => {
+            void readBody(req, res).then(async (raw) => {
+                if (raw === null)
+                    return;
                 let name;
                 let scopeValue;
                 let bodyCwd;