@kendoo.agentdesk/agentdesk 0.22.0 → 0.22.1

package/CHANGELOG.md

@@ -13,6 +13,9 @@ Internal refactors, infrastructure changes, and architectural notes are not list
 ### Added
 - `[UI]` Private-session sharing flow. When someone visits a session URL they don't own, they now see a friendly "Shh… this one's private" page with a one-click "Request access" button instead of a blank error. The session owner sees pending requests in a new header inbox and can grant viewer access for just that session or the whole project. Viewer-granted sessions show up in the teammate's sidebar tagged as a viewer.
 
+### Changed
+- `[Both]` Security improvements and hardening. No action required.
+
 ## [0.22.0] — 2026-05-23
 
 ### Changed

package/cli/tracker-check.mjs

@@ -1,7 +1,12 @@
 // Verify tracker API permissions before starting a session
 // Checks: read tasks, create tasks, update tasks
 
-import { execSync } from "child_process";
+import { execFileSync } from "child_process";
+
+// AD-29: any external string (repo name, ref, etc.) must be regex-validated
+// before it goes into a child process. Even with execFile, an upstream caller
+// passing "../../etc" or similar can trip path semantics in the called tool.
+const GITHUB_REPO_RE = /^[A-Za-z0-9._-]+\/[A-Za-z0-9._-]+$/;
 
 const LINEAR_API = "https://api.linear.app/graphql";
 
@@ -187,18 +192,25 @@ async function checkGitHub({ repo }, creds) {
   const env = { ...process.env };
   if (creds?.GITHUB_TOKEN) env.GH_TOKEN = creds.GITHUB_TOKEN;
 
-  // Check if gh CLI is available
+  // AD-29: refuse anything that isn't a clean owner/repo before going near a
+  // subprocess. `repo` comes from server-pushed project settings, which an
+  // attacker could control via a chained takeover.
+  if (!GITHUB_REPO_RE.test(repo)) {
+    return { ok: false, errors: [`Invalid GitHub repo format: ${JSON.stringify(repo)} (expected "owner/name")`] };
+  }
+
+  // Check if gh CLI is available. execFileSync (no shell) — argv is static.
   try {
-    execSync("gh --version", { stdio: "pipe" });
+    execFileSync("gh", ["--version"], { stdio: "pipe" });
   } catch {
     return { ok: false, errors: ["GitHub CLI (gh) is not installed — install it from https://cli.github.com"] };
   }
 
   // Check auth status and grab the authenticated login
   try {
-    execSync("gh auth status", { stdio: "pipe", env });
+    execFileSync("gh", ["auth", "status"], { stdio: "pipe", env });
     try {
-      const who = execSync(`gh api user --jq '{login: .login, name: .name}'`, { stdio: "pipe", encoding: "utf-8", env }).trim();
+      const who = execFileSync("gh", ["api", "user", "--jq", "{login: .login, name: .name}"], { stdio: "pipe", encoding: "utf-8", env }).trim();
       const j = JSON.parse(who);
       identity = { name: j.name || j.login, login: j.login };
     } catch {}
@@ -206,9 +218,9 @@ async function checkGitHub({ repo }, creds) {
     return { ok: false, errors: ["GitHub CLI is not authenticated — run 'gh auth login', or paste a GITHUB_TOKEN"] };
   }
 
-  // Check repo access and permissions
+  // Check repo access and permissions — argv form, no shell, repo already validated.
   try {
-    const result = execSync(`gh api repos/${repo} --jq ".permissions"`, { stdio: "pipe", encoding: "utf-8", env });
+    const result = execFileSync("gh", ["api", `repos/${repo}`, "--jq", ".permissions"], { stdio: "pipe", encoding: "utf-8", env });
     const perms = JSON.parse(result.trim());
 
     if (!perms.pull) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kendoo.agentdesk/agentdesk",
-  "version": "0.22.0",
+  "version": "0.22.1",
   "description": "AI team orchestrator for Claude Code — run collaborative agent sessions from your terminal",
   "type": "module",
   "bin": {
@@ -22,7 +22,7 @@
     "server": "node server/index.mjs",
     "build": "vite build",
     "preview": "vite preview",
-    "test": "node --test tests/server.test.mjs tests/agents.test.mjs tests/homepage.test.mjs tests/sessionUtils.test.mjs tests/tracker-url.test.mjs tests/session-preflight.test.mjs tests/access.test.mjs",
+    "test": "node --test tests/server.test.mjs tests/agents.test.mjs tests/homepage.test.mjs tests/sessionUtils.test.mjs tests/tracker-url.test.mjs tests/session-preflight.test.mjs tests/access.test.mjs tests/project-ownership.test.mjs tests/random-hex.test.mjs",
     "lint:changelog": "node scripts/lint-changelog.mjs",
     "prepublishOnly": "node scripts/lint-changelog.mjs"
   },