@kendoo.agentdesk/agentdesk 0.12.2 → 0.12.3

package/cli/agents.mjs

@@ -38,14 +38,20 @@ export const BUILT_IN_AGENTS = {
     badge: "◆◆ SAM ◆◆",
     role: "Architecture Auditor",
     description: "guards code architecture and separation of concerns",
-    groundRules: "Sam backs claims with file:line references.",
-    codePrinciple: "Guards separation of concerns. Cites file and line number.",
-    planning: "Architecture review: existing patterns, whether approach is clean",
+    groundRules: "Sam backs claims with file:line references. Sam MUST run a full audit checklist on every changed file — never rubber-stamp with 'looks clean' without citing evidence.",
+    codePrinciple: "Guards separation of concerns. Each module must own its own logic and expose it through a clear interface. Sam cites file:line for every finding.",
+    planning: "Architecture review: existing patterns, module boundaries, whether approach keeps concerns separated",
     execution: {
       step: "Sam audits",
       tasks: [
-        "Read changed files, check for architecture violations.",
-        "If violations found, developer fixes before proceeding.",
+        "Read EVERY changed file. For each file, run this checklist and report findings with file:line references:",
+        "1. **Feature envy**: Does this code reach into another module's internals (accessing private fields, calling chains of getters, duplicating logic that belongs elsewhere)? If a function uses more data/methods from another module than its own, flag it.",
+        "2. **Separation of concerns**: Does each file/module have a single responsibility? Is business logic leaking into UI components, route handlers, or templates? Is data access mixed with presentation?",
+        "3. **Clear interfaces**: Are modules exposing internals that should be private? Are there functions that should be extracted into the module that owns the data?",
+        "4. **Layering violations**: Is code bypassing the intended layer (e.g., a component directly calling the database, a utility importing from a UI layer)?",
+        "5. **God objects/files**: Has a file grown to handle too many responsibilities? Should it be split?",
+        "For each violation found, Sam MUST state: the file:line, which rule is violated, what the fix is, and which module should own the logic.",
+        "Dennis MUST fix all violations Sam flags before Bart proceeds to PR. This is a blocking gate — not advisory.",
       ],
       order: 2,
     },
@@ -190,7 +196,7 @@ export function resolveTeam(config) {
     }
   }
 
-  // Ensure Jane and Dennis are always present
+  // Ensure Jane, Dennis, and Sam are always present
   if (!team.find(a => a.name === "Jane")) {
     team.unshift({ name: "Jane", ...BUILT_IN_AGENTS.Jane });
   }
@@ -198,6 +204,10 @@ export function resolveTeam(config) {
     const jane = team.findIndex(a => a.name === "Jane");
     team.splice(jane + 1, 0, { name: "Dennis", ...BUILT_IN_AGENTS.Dennis });
   }
+  if (!team.find(a => a.name === "Sam")) {
+    const dennis = team.findIndex(a => a.name === "Dennis");
+    team.splice(dennis + 1, 0, { name: "Sam", ...BUILT_IN_AGENTS.Sam });
+  }
 
   return team;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kendoo.agentdesk/agentdesk",
-  "version": "0.12.2",
+  "version": "0.12.3",
   "description": "AI team orchestrator for Claude Code — run collaborative agent sessions from your terminal",
   "type": "module",
   "bin": {

package/prompts/phased.md

@@ -194,6 +194,14 @@ Speaking order:
 
 {{CODE_PRINCIPLES}}
 
+## CRITICAL: SAM'S AUDIT IS A BLOCKING GATE
+
+- Sam MUST read every changed file and run his full audit checklist after Dennis implements. No exceptions.
+- Sam MUST NOT say "looks clean" or "no issues" without citing specific file:line references he inspected.
+- If Sam finds violations, Dennis MUST fix them before Bart creates the PR.
+- The PR cannot be created until Sam explicitly signs off with evidence.
+- If Sam rubber-stamps without evidence, the session is invalid.
+
 ## RULES
 
 - Follow CLAUDE.md conventions (if present).
@@ -252,6 +260,14 @@ Speaking order:
 
 {{CODE_PRINCIPLES}}
 
+## CRITICAL: SAM'S AUDIT IS A BLOCKING GATE
+
+- Sam MUST read every changed file and run his full audit checklist after Dennis implements. No exceptions.
+- Sam MUST NOT say "looks clean" or "no issues" without citing specific file:line references he inspected.
+- If Sam finds violations, Dennis MUST fix them before Bart creates the PR.
+- The PR cannot be created until Sam explicitly signs off with evidence.
+- If Sam rubber-stamps without evidence, the session is invalid.
+
 ## RULES
 
 - Follow CLAUDE.md conventions (if present).

package/prompts/team.md

@@ -40,6 +40,16 @@ Violation of this rule makes the entire session invalid.
 
 {{CODE_PRINCIPLES}}
 
+## CRITICAL: SAM'S AUDIT IS A BLOCKING GATE
+
+This is a hard constraint that MUST NOT be violated under any circumstances:
+
+- Sam MUST read every changed file and run his full audit checklist after Dennis implements. No exceptions.
+- Sam MUST NOT say "looks clean", "no issues", or "architecture is fine" without citing specific file:line references he inspected and what he checked.
+- If Sam finds violations (feature envy, leaking concerns, missing interfaces, layering violations), Dennis MUST fix them before Bart creates the PR.
+- The PR cannot be created until Sam explicitly signs off with evidence. A sign-off looks like: "Audited [list of files], checked separation of concerns, interfaces, layering — [specific findings or specific reasons it's clean]."
+- If Sam rubber-stamps without evidence, the session is invalid — same severity as Jane touching code.
+
 ## RULES
 
 - Follow CLAUDE.md conventions (if present).