@kelceyp/caw-server 1.0.290 → 1.1.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kelceyp/caw-server",
-  "version": "1.0.290",
+  "version": "1.1.0",
   "description": "CAW server - REST API, MCP server and core features",
   "type": "module",
   "main": "dist/main.js",
@@ -19,13 +19,12 @@
     "build": "bash scripts/bun-build.sh",
     "build:client": "cd ../client && bun run build",
     "build:cli": "cd ../cli && bun run build && cp dist/cli.js ../server/dist/",
-    "build:all": "bun run clean && bun run generate:applyPojo && bun run build:client && bun run build && cp src/core/services/embedding-worker.js dist/embedding-worker.js && cp src/core/agents/pty-wrapper.mjs dist/pty-wrapper.mjs && cp src/core/agents/pty-deferred-teardown.mjs dist/pty-deferred-teardown.mjs && cp src/core/agents/pty-emit-result.mjs dist/pty-emit-result.mjs && cp src/core/agents/teardownReasons.mjs dist/teardownReasons.mjs && cp src/core/agents/pty-non-interactive-setup.mjs dist/pty-non-interactive-setup.mjs && cp src/core/agents/transcript-tailer.mjs dist/transcript-tailer.mjs && cp src/core/agents/prompt-rejection-detector.mjs dist/prompt-rejection-detector.mjs && cp src/core/agents/claude-config-dir-guard.mjs dist/claude-config-dir-guard.mjs && bun run build:cli",
+    "build:all": "bun run clean && bun run generate:applyPojo && bun run build:client && bun run build && cp src/core/services/embedding-worker.js dist/embedding-worker.js && cp src/core/agents/claude-config-dir-guard.mjs dist/claude-config-dir-guard.mjs && bun run build:cli",
     "dev": "STATIC_PATH=../client/src bun --define __BUILTIN_POSTHOG_KEY__=null run src/main.js",
     "start": "node dist/main.js",
     "test": "bun test --define __BUILTIN_POSTHOG_KEY__=null test/unit test/integration test/component test/cli test/investigation && (cd ../client && bun test)",
     "test:e2e": "bun test --define __BUILTIN_POSTHOG_KEY__=null test/e2e",
-    "perf:updateStoryState": "bun run test/perf/updateStoryState.perf.js",
-    "postinstall": "find node_modules/node-pty -name spawn-helper -exec chmod +x {} + 2>/dev/null || true"
+    "perf:updateStoryState": "bun run test/perf/updateStoryState.perf.js"
   },
   "keywords": [
     "caw",
@@ -52,7 +51,6 @@
     "is_js": "^0.9.0",
     "kysely": "^0.29.0",
     "multer": "^2.1.1",
-    "node-pty": "^1.1.0",
     "posthog-node": "^5.48.1",
     "safe-regex": "^2.1.1",
     "ws": "^8.21.0",

package/dist/prompt-rejection-detector.mjs

@@ -1,158 +0,0 @@
-// prompt-rejection-detector.mjs — PromptRejectionDetector module.
-//
-// Evaluates JSONL transcript entries handed to it by the wrapper (Task 6
-// wiring) and, on a first conjunctive-predicate match, emits the failure line
-// on stdout exactly once. Unimported sibling of `pty-wrapper.mjs` at this
-// task's end-of-task; wired in at Task 6.
-//
-// Instance-owned mutable state — no module-level mutables. Two instances
-// constructed in the same test file do not share state. The `getEmissionState`
-// / `setEmissionState` callbacks are stored **by reference** so the coupling
-// with the wrapper's `resultEmitted`/`failureEmitted` variables stays live at
-// Task 6 — the detector never snapshots them at construction.
-
-// Anchored, case-sensitive, whitespace-trim-only. Any drift here breaks
-// downstream Task 7 drift-guard lockstep.
-const NORMALISED_REJECTION_TEXT = /^Prompt is too long$/;
-
-export function createPromptRejectionDetector({ log, getEmissionState, setEmissionState, tailer } = {}) {
-    const emit = typeof log === 'function'
-        ? log
-        : (message) => { process.stderr.write(message + '\n'); };
-
-    const state = {
-        oneShotFired: false,
-        transcriptUnresolvedFired: false,
-        boundaryUnusableFired: false,
-        boundaryUnusableCause: null,
-    };
-
-    function noteTranscriptUnresolved() {
-        if (state.transcriptUnresolvedFired) return;
-        state.transcriptUnresolvedFired = true;
-        emit('prompt-rejection: refused, reason=transcript-unresolved');
-    }
-
-    // First-writer-wins on cause: second and later note calls are no-ops (item
-    // 13-style idempotency without a separate flag — the state tuple stays
-    // {oneShotFired, transcriptUnresolvedFired, boundaryUnusableFired,
-    // boundaryUnusableCause}). The distinct `boundaryUnusableFired` flag
-    // guards the leg's own once-per-turn emit so a subsequent noteBoundaryUnusable
-    // call cannot squelch the leg (test (h)).
-    function noteBoundaryUnusable(cause) {
-        if (state.boundaryUnusableCause !== null) return;
-        state.boundaryUnusableCause = cause;
-    }
-
-    function textBlockMatches(block) {
-        if (!block || block.type !== 'text') return false;
-        if (typeof block.text !== 'string') return false;
-        return NORMALISED_REJECTION_TEXT.test(block.text.trim());
-    }
-
-    function findMatchingText(content) {
-        for (const block of content) {
-            if (textBlockMatches(block)) return block.text;
-        }
-        return null;
-    }
-
-    function consider(entry) {
-        const uuid = entry && typeof entry === 'object' ? entry.uuid : undefined;
-        const uuidField = uuid !== undefined ? `uuid=${uuid}` : 'uuid=undefined';
-
-        // Leg 1: missing-flag
-        if (!entry || entry.isApiErrorMessage !== true) {
-            const code = entry && entry.error !== undefined ? entry.error : 'null';
-            emit(`prompt-rejection: refused, reason=missing-flag ${uuidField} error=${code}`);
-            return;
-        }
-
-        // Leg 2: wrong-typed-code (top-level entry.error, NOT entry.message.error)
-        if (entry.error !== 'invalid_request') {
-            const code = entry.error !== undefined ? entry.error : 'null';
-            emit(`prompt-rejection: refused, reason=wrong-typed-code ${uuidField} error=${code}`);
-            return;
-        }
-
-        // Leg 3: content-shape
-        const content = entry.message && entry.message.content;
-        if (!Array.isArray(content)) {
-            emit(`prompt-rejection: refused, reason=content-shape ${uuidField} contentType=${typeof content}`);
-            return;
-        }
-
-        // Leg 4: text-mismatch
-        const matchedText = findMatchingText(content);
-        if (matchedText === null) {
-            emit(`prompt-rejection: refused, reason=text-mismatch ${uuidField} error=invalid_request`);
-            return;
-        }
-
-        // Leg 5: boundary-unusable (at most once per turn, mirrors the tailer's
-        // own one-shot boundary-unusable line)
-        if (tailer && tailer.unusable === true) {
-            if (!state.boundaryUnusableFired) {
-                state.boundaryUnusableFired = true;
-                const cause = state.boundaryUnusableCause !== null
-                    ? state.boundaryUnusableCause
-                    : 'unknown';
-                emit(`prompt-rejection: refused, reason=boundary-unusable path=${tailer.path} cause=${cause}`);
-            }
-            return;
-        }
-
-        // Leg 6: no-uuid
-        if (!uuid) {
-            emit(`prompt-rejection: refused, reason=no-uuid error=invalid_request`);
-            return;
-        }
-
-        // Leg 7: pre-baseline (defensive — the tailer already suppresses these)
-        if (tailer && tailer.preBaselineUUIDs && tailer.preBaselineUUIDs.has(uuid)) {
-            emit(`prompt-rejection: refused, reason=pre-baseline uuid=${uuid}`);
-            return;
-        }
-
-        // Match survived every predicate leg. Apply the one-shot emission guard
-        // immediately before writing to stdout so a concurrent Stop-hook
-        // emitResult() cannot squeeze in between the check and the write.
-        if (state.oneShotFired) {
-            emit(`prompt-rejection: refused, reason=already-emitted uuid=${uuid}`);
-            return;
-        }
-        const emissionState = typeof getEmissionState === 'function' ? getEmissionState() : null;
-        if (emissionState === 'result' || emissionState === 'failure') {
-            emit(`prompt-rejection: refused, reason=already-emitted uuid=${uuid}`);
-            return;
-        }
-
-        // Detection log line — inside the guard, between the check and the
-        // stdout write, so the log line matches the emission 1:1.
-        emit(
-            `prompt-rejection: matched entry uuid=${uuid} error=invalid_request `
-            + `boundary=post-baseline — emitting failure and killing pty`
-        );
-
-        // stdout write MUST happen before setEmissionState('failure') returns
-        // (load-bearing ordering invariant, item 10). A racing observer that
-        // reads state after seeing the stdout line always finds `failure`.
-        const failureLine = JSON.stringify({
-            type: 'error',
-            error: 'prompt_too_long',
-            message: matchedText,
-        }) + '\n';
-        process.stdout.write(failureLine);
-
-        if (typeof setEmissionState === 'function') {
-            setEmissionState('failure');
-        }
-        state.oneShotFired = true;
-    }
-
-    return {
-        consider,
-        noteTranscriptUnresolved,
-        noteBoundaryUnusable,
-    };
-}

package/dist/pty-deferred-teardown.mjs

@@ -1,17 +0,0 @@
-import { readFileSync } from 'fs';
-
-export const readSentinelPayload = (sentinelPath) => {
-    try {
-        return JSON.parse(readFileSync(sentinelPath, 'utf-8'));
-    } catch {
-        return null;
-    }
-};
-
-export const hasPendingWork = (payload) => {
-    const tasks = payload?.background_tasks;
-    if (Array.isArray(tasks) && tasks.length > 0) return true;
-    const crons = payload?.session_crons;
-    if (Array.isArray(crons) && crons.length > 0) return true;
-    return false;
-};

package/dist/pty-emit-result.mjs

@@ -1,204 +0,0 @@
-/**
- * Side-effect-free extraction of `emitResult()` from `pty-wrapper.mjs`.
- *
- * The wrapper's `onExit` handler reads the Stop-hook sentinel file, then hands
- * the parsed payload to this function to build either the `type:"result"` or
- * `type:"error"` stdout line. Splitting the branch construction out of the
- * wrapper mirrors `pty-deferred-teardown.mjs` (already extracts
- * `readSentinelPayload` and `hasPendingWork`) so the sentinel-success and
- * error branches can be unit-tested without spawning a real PTY.
- *
- * Inputs are function arguments only — no module-level state, no top-level
- * side effects, no file IO. The caller (the wrapper's delegator) reads the
- * sentinel via `readSentinelPayload()` and passes the parsed payload in as
- * `hookData`; a null / falsy `hookData` is a no-op, mirroring the wrapper's
- * pre-extraction `if (!existsSync(sentinelPath)) return;` guard one level up.
- *
- * Wire. This function writes at most one line, of one of two shapes:
- *   - success line (Stop):
- *     `{ type: 'result', result, metadata, stopFallback }`.
- *   - error line (StopFailure, `hookData.error` truthy):
- *     `{ type: 'error', error, message[, error_details], metadata, stopFallback }`
- *     (As1071 design S4). `error_details` is the StopFailure payload's own
- *     `error_details`, copied verbatim (any JSON type, `null` included) and
- *     only when the payload has the key; it is diagnostic evidence, never a
- *     reset-time source. The success line never carries it.
- * Both lines get `metadata` from the one builder, `buildMetadata()`, so the two
- * cannot drift: `{ sessionId, transcriptPath, permissionMode[, durationMs][, teardownReason] }`
- * (`durationMs` when both timestamps are given, `teardownReason` when the
- * wrapper passes one, omitted rather than `null` otherwise; fallback chains
- * `hookData.session_id || effectiveSessionId`,
- * `hookData.transcript_path || transcriptPath || null`,
- * `hookData.permission_mode || null`). On a real StopFailure turn the wrapper
- * passes `teardownReason: 'stop-failure'` and both timestamps, so the error
- * line meets `teardownReasons.mjs` contract point 2 too.
- * `stopFallback` (As1072) is appended as the LAST top-level key of both lines
- * and is not a `metadata` key. The success line is the pre-As1072 line with
- * that one key added before its closing brace. The no-op paths
- * (`alreadyEmitted`, a falsy `hookData`, and the `catch` below) write no line
- * at all.
- *
- * The double-emit guard (previously `if (resultEmitted || failureEmitted) return;`
- * at `pty-wrapper.mjs:401`) is preserved via the `alreadyEmitted` input: the
- * caller passes the current flag state, and the function no-ops when true.
- * The return value `{ emitted: 'result' | 'error' | null }` lets the caller
- * translate a successful call back into its module-level `resultEmitted` /
- * `failureEmitted` flags. This is not the wrapper's only writer of
- * `{ type: 'error', ... }` lines: As1080's `prompt-rejection-detector.mjs`
- * writes its own `prompt_too_long` line, which does not pass through here. A
- * vendor StopFailure reaches this function only when the Stop-hook sentinel
- * carries a structured `error` field.
- */
-
-// --- stopFallback vocabulary (As1072) ---
-//
-// What happened to the Stop-hook `last_assistant_message` fallback on a turn.
-// The wrapper writes the value on its own terminal line, so the component that
-// holds `hookData` is the one that decides it:
-//   - `present` / `empty` / `absent` / `invalid` — written by `emitResult()` on
-//     both lines, from `deriveStopFallback()`;
-//   - `suppressed` — written by `emitResult()` on the success line only, when
-//     the CAW_PTY_SUPPRESS_STOP_FALLBACK test override is set;
-//   - `not-emitted` — NEVER written by the wrapper. No terminal line exists to
-//     carry it, so only `claude-session.js` derives it, from the absence of a
-//     `result` / `error` line.
-// `unknown` is deliberately in NEITHER export below. It is the record layer's
-// sentinel (`sentinels.js`) with one writer, `JobService.updateJobMetadata`,
-// which uses it when no value reached the record. Adding it here would create
-// a second writer.
-// The vocabulary lives in this module, the only wrapper-side writer, so the
-// wrapper's import closure (and with it `build:all` and `Dockerfile.session`)
-// does not grow.
-
-export const STOP_FALLBACK = Object.freeze({
-    PRESENT:     'present',
-    EMPTY:       'empty',
-    ABSENT:      'absent',
-    INVALID:     'invalid',
-    SUPPRESSED:  'suppressed',
-    NOT_EMITTED: 'not-emitted',   // derived by claude-session.js; never written by the wrapper
-});
-
-// Exactly the values a wrapper line may carry; claude-session.js accepts only these.
-// A frozen array, not a Set: Object.freeze does not stop Set.prototype.add/delete.
-export const STOP_FALLBACK_WIRE_VALUES = Object.freeze([
-    STOP_FALLBACK.PRESENT,
-    STOP_FALLBACK.EMPTY,
-    STOP_FALLBACK.ABSENT,
-    STOP_FALLBACK.INVALID,
-    STOP_FALLBACK.SUPPRESSED,
-]);
-
-export const isStopFallbackWireValue = (value) =>
-    typeof value === 'string' && STOP_FALLBACK_WIRE_VALUES.includes(value);
-
-/**
- * Classify the Stop / StopFailure payload's `last_assistant_message` by own-key
- * presence, not truthiness. First match wins:
- *   1. `suppressFallback` set                            → `suppressed`
- *   2. not an own key, or own with value `undefined`     → `absent`
- *   3. not a string (`null` included)                    → `invalid`
- *   4. `''`                                              → `empty`
- *   5. any other string (whitespace-only included)       → `present`
- *
- * An own `undefined` is `absent` (As1072 KD3): `hookData` is parsed JSON, which
- * cannot carry one, and the vendor serialises an `undefined` value as a missing
- * key. Total: an omitted options argument means no override; a `hookData` that
- * cannot hold the own key (`undefined`, `null`, a primitive, an array) is
- * `absent`; it never throws and only returns wire values. `emitResult()` passes
- * `suppressFallback` on the success branch only.
- */
-export const deriveStopFallback = (hookData, options) => {
-    if (options?.suppressFallback) return STOP_FALLBACK.SUPPRESSED;
-    if (hookData === null || hookData === undefined) return STOP_FALLBACK.ABSENT;
-    if (!Object.hasOwn(hookData, 'last_assistant_message')) return STOP_FALLBACK.ABSENT;
-    const value = hookData.last_assistant_message;
-    if (value === undefined) return STOP_FALLBACK.ABSENT;
-    if (typeof value !== 'string') return STOP_FALLBACK.INVALID;
-    if (value === '') return STOP_FALLBACK.EMPTY;
-    return STOP_FALLBACK.PRESENT;
-};
-
-const defaultWrite = (line) => process.stdout.write(line);
-const defaultLog = () => {};
-
-// The one `metadata` builder both lines use (As1071 S4). Field order is part
-// of the success line's wire, which must stay byte-identical.
-const buildMetadata = ({ hookData, transcriptPath, effectiveSessionId, startedAt, endedAt, teardownReason }) => {
-    const metadata = {
-        sessionId: hookData.session_id || effectiveSessionId,
-        transcriptPath: hookData.transcript_path || transcriptPath || null,
-        permissionMode: hookData.permission_mode || null
-    };
-    if (startedAt !== null && endedAt !== null) {
-        metadata.durationMs = endedAt - startedAt;
-    }
-    // As1033 Task 6: append teardownReason ('stop' | 'watchdog' |
-    // 'stop-failure' | ...) so the downstream stream handler and the
-    // JobRunner classifier gate can distinguish a clean Stop finish from a
-    // watchdog force-kill. Omitted, never `null`, when the wrapper passes
-    // none (`teardownReasons.mjs` contract point 3).
-    if (teardownReason !== null) {
-        metadata.teardownReason = teardownReason;
-    }
-    return metadata;
-};
-
-export function emitResult({
-    hookData,
-    transcriptPath = null,
-    effectiveSessionId = null,
-    startedAt = null,
-    endedAt = null,
-    teardownReason = null,
-    alreadyEmitted = false,
-    suppressFallback = false,
-    write = defaultWrite,
-    log = defaultLog
-} = {}) {
-    if (alreadyEmitted) return { emitted: null };
-    if (!hookData) return { emitted: null };
-
-    try {
-        const metadataInputs = { hookData, transcriptPath, effectiveSessionId, startedAt, endedAt, teardownReason };
-
-        if (hookData.error) {
-            const line = {
-                type: 'error',
-                error: hookData.error,
-                message: hookData.last_assistant_message || ''
-            };
-            // Present-only and verbatim (As1071 S4): own-key presence, not
-            // truthiness, so `null`, `false`, `0` and `''` are copied as-is.
-            if (Object.hasOwn(hookData, 'error_details')) {
-                line.error_details = hookData.error_details;
-            }
-            line.metadata = buildMetadata(metadataInputs);
-            // No override on this branch (KD7): the line records the payload's
-            // real state, never `suppressed`.
-            line.stopFallback = deriveStopFallback(hookData);
-            write(JSON.stringify(line) + '\n');
-            return { emitted: 'error' };
-        }
-
-        const metadata = buildMetadata(metadataInputs);
-        // D11 test-only override: when the wrapper's CAW_PTY_SUPPRESS_STOP_FALLBACK
-        // gate is set, blank the `result` field on the success branch only. The
-        // line still declares itself (As1072): `stopFallback: 'suppressed'`,
-        // whatever the payload held, so the record can tell the override from a
-        // real payload. `result` is still `''`, so the As1005 D11 transcript-tail
-        // + override combination still reaches the loud empty-turn failure
-        // downstream. `metadata` is untouched.
-        const result = suppressFallback ? '' : (hookData.last_assistant_message || '');
-        write(JSON.stringify({
-            type: 'result',
-            result,
-            metadata,
-            stopFallback: deriveStopFallback(hookData, { suppressFallback })
-        }) + '\n');
-        return { emitted: 'result' };
-    } catch (err) {
-        log(`Error reading sentinel: ${err.message}`);
-        return { emitted: null };
-    }
-}