@keepsnappy/agent 0.1.0-alpha.14 → 0.1.0-alpha.15

package/dist/appium-driver.js

@@ -348,6 +348,10 @@ class Driver {
     }
     return value;
   }
+  async attribute(el, name) {
+    const value = await this.cmd("GET", `/element/${el}/attribute/${name}`);
+    return value === this.platform.absentAttributeText ? null : value;
+  }
   async start(capabilities) {
     const value = await this.cmd("POST", "/session", { capabilities: { alwaysMatch: capabilities } });
     this.sessionId = value.sessionId;
@@ -427,7 +431,7 @@ class Driver {
           break;
         let resourceId;
         try {
-          resourceId = String(await this.cmd("GET", `/element/${el}/attribute/resource-id`));
+          resourceId = String(await this.attribute(el, "resource-id") ?? "");
         } catch (e) {
           if (e instanceof WdError && e.wdError === "stale element reference")
             continue;
@@ -530,6 +534,7 @@ var IOS = {
     "appium:newCommandTimeout": NEW_COMMAND_TIMEOUT_S,
     "appium:waitForIdleTimeout": NO_WAIT_MS
   }),
+  absentAttributeText: null,
   settings: { animationCoolOffTimeout: NO_WAIT_MS, waitForIdleTimeout: NO_WAIT_MS, shouldUseCompactResponses: true },
   locators: (sel) => [locator(sel)],
   keyboardShown: async (driver) => Boolean(await driver.findShown(id("Return"))),
@@ -548,7 +553,7 @@ async function iosCommand(driver, link, cmd, n, state, waitMs) {
   for (;; ) {
     const el = await driver.find("-ios predicate string", want);
     if (el)
-      return driver.cmd("GET", `/element/${el}/attribute/label`).then(String).catch(() => {
+      return driver.attribute(el, "label").then(String).catch(() => {
         driver.log.push({ ...driver.context, cmd: `${cmd}-ack-label`, t: driver.now(), ms: 0, status: 1 });
         return `${cmd}:${n} ok`;
       });
@@ -568,6 +573,7 @@ var ANDROID = {
     "appium:autoGrantPermissions": true,
     "appium:newCommandTimeout": NEW_COMMAND_TIMEOUT_S
   }),
+  absentAttributeText: "null",
   settings: { waitForIdleTimeout: NO_WAIT_MS, actionAcknowledgmentTimeout: NO_WAIT_MS, waitForSelectorTimeout: NO_WAIT_MS, enableMultiWindows: true, ignoreUnimportantViews: true },
   locators: androidLocators,
   appArg: (appId) => ({ appId }),
@@ -778,6 +784,7 @@ var FLUSH_MARGIN_MS = 30000;
 var FLUSH_WAIT_MS = SDK_FLUSH_WORST_CASE_MS + FLUSH_MARGIN_MS;
 var FLUSH_POLL_MS = 500;
 var FLUSH_RESEND_MS = 90000;
+var ACTIVATION_SETTLE_MS = 2000;
 var FLUSH_NOT_ACKNOWLEDGED = "not acknowledged (re-sent once)";
 var FLUSH_UNREADABLE = "not acknowledged (unreadable answer)";
 var FLUSH_STATUSES = new Set(["ok", "error", "off"]);
@@ -1182,7 +1189,9 @@ class Session {
     this.pendingReady = null;
     await this.relaunch();
     await this.waitVisible(home, 30000);
-    return this.openLink(activationLink(this.scheme, token, args));
+    const alert = await this.openLink(activationLink(this.scheme, token, args));
+    await this.driver.sleep(ACTIVATION_SETTLE_MS);
+    return alert;
   }
   lastFlush = null;
   flushSeq = 0;
@@ -1226,8 +1235,8 @@ class Session {
       if (!el && flush.fallback && poll % FLUSH_FALLBACK_EVERY === 0)
         el = await this.findFallback(flush.fallback);
       if (el) {
-        const label = await this.driver.cmd("GET", `/element/${el}/attribute/${flush.statusAttribute}`).catch(() => null);
-        const raw = await this.driver.cmd("GET", `/element/${el}/attribute/${flush.detailAttribute}`).then((value) => ({ value }), () => null);
+        const label = await this.driver.attribute(el, flush.statusAttribute).catch(() => null);
+        const raw = await this.driver.attribute(el, flush.detailAttribute).then((value) => ({ value }), () => null);
         const detail = typeof raw?.value === "string" ? raw.value : null;
         const echoed = detail === null ? null : ACK_ECHO.exec(detail);
         if (raw === null) {

package/dist/keepsnappy.js

@@ -5063,6 +5063,7 @@ var STATE_WORDS = {
   "no-change": "No change",
   "cant-tell": "Can’t tell"
 };
+var INFO_WORDS = { heat: "Phone heated up" };
 var NOT_BLOCKING = "not blocking";
 // packages/present/dist/src/values.js
 var NO_VALUE = "–";
@@ -5166,6 +5167,13 @@ function summarize(input) {
 // apps/agent/src/remote.ts
 var isBlocking = (s) => !!s?.verdicts && (s.verdicts.blocking ?? s.verdicts.state === "worse");
 var midLine = (label, metric) => !metric.startsWith("component:") && /^[A-Z][a-z]*(\s|$)/.test(label) ? `${label[0].toLowerCase()}${label.slice(1)}` : label;
+function heatNote(sc) {
+  const n = sc.heated_runs ?? 0;
+  if (!n)
+    return null;
+  const phone = sc.device ? `${sc.device.model}${sc.device.os ? ` · ${sc.device.os}` : ""}` : "unknown phone";
+  return `${INFO_WORDS.heat} in ${n} of ${sc.runs.valid + sc.runs.invalid} runs · ${sc.scenario ?? "journey"} · ${phone}`;
+}
 function movedItems(v, sc) {
   const flat = v.items.filter((i) => i.scenario === sc.scenario && (!sc.device || !i.device_id || i.device_id === sc.device.id));
   const h = sc.headline;
@@ -5263,11 +5271,16 @@ function formatRunSet(s, top = 5) {
       lines.push(`  ${FEW_RUNS}`);
     if (sc.role !== "adhoc" && !noCounts(movedCounts(sc)))
       lines.push(`  ${countsLine(movedCounts(sc))}`);
-    const moved = movedItems(v, sc).sort((a, b) => Number(b.state === "worse") - Number(a.state === "worse") || Number(a.grade === "warn") - Number(b.grade === "warn")).slice(0, top);
+    if (heatNote(sc))
+      lines.push(`  ${heatNote(sc)}`);
+    const allMoved = movedItems(v, sc).sort((a, b) => Number(b.state === "worse") - Number(a.state === "worse") || Number(a.grade === "warn") - Number(b.grade === "warn"));
+    const moved = allMoved.slice(0, top);
     for (const i of moved) {
       const what = i.label_text ? `${i.step && i.step !== "*" ? `${placeLabel(i.step)}: ` : ""}${i.label_text}` : i.step ? `${placeLabel(i.step)}: ${fieldWord(i.metric)}` : plainMetric(i.metric);
       lines.push(`  ${stateWord(i.state === "worse" && i.grade === "warn" ? "warn" : i.state).padEnd(WORD_WIDTH)} ${what}${i.change_text ? `: ${i.change_text}` : change(i.metric, i.baseline, i.candidate)}`);
     }
+    if (allMoved.length > moved.length)
+      lines.push(`  ${allMoved.length - moved.length} more`);
     if (sc.dashboard_url)
       lines.push(`  ${sc.dashboard_url}`);
   }
@@ -5288,6 +5301,7 @@ Runs uploaded for \`${fallback.branch}\`. The result appears on the dashboard: [
 `;
   }
   const v = s.verdicts;
+  const heated = v.scenarios.flatMap((sc) => heatNote(sc) ?? []);
   const rows = v.scenarios.map((sc) => {
     const c = movedCounts(sc);
     return `| ${sc.scenario ?? "-"} | ${sc.device ? sc.device.model : "-"} | ${word(sc.state, sc.word, sc.headline)}${sc.low_data ? ` (${FEW_RUNS})` : ""} | ${noCounts(c) ? "–" : `${c.worse} / ${c.warnings} / ${c.better} / ${c.noChange} / ${c.inconclusive}`} | ${sc.dashboard_url ? `[open](${sc.dashboard_url})` : "-"} |`;
@@ -5301,6 +5315,7 @@ Runs uploaded for \`${fallback.branch}\`. The result appears on the dashboard: [
     `| Journey | Device | Result | ${STATE_WORDS.worse} / ${STATE_WORDS.warning} / ${STATE_WORDS.better} / ${STATE_WORDS["no-change"]} / ${STATE_WORDS["cant-tell"]} | Details |`,
     "|---|---|---|---|---|",
     ...rows,
+    ...heated.length ? ["", ...heated.map((note) => `${note}.`)] : [],
     "",
     `[Open the dashboard](${s.dashboard_url})`,
     ""
@@ -9548,6 +9563,7 @@ var ANDROID = {
     "appium:autoGrantPermissions": true,
     "appium:newCommandTimeout": NEW_COMMAND_TIMEOUT_S
   }),
+  absentAttributeText: "null",
   settings: { waitForIdleTimeout: NO_WAIT_MS, actionAcknowledgmentTimeout: NO_WAIT_MS, waitForSelectorTimeout: NO_WAIT_MS, enableMultiWindows: true, ignoreUnimportantViews: true },
   locators: androidLocators,
   appArg: (appId) => ({ appId }),
@@ -9623,7 +9639,7 @@ import { existsSync, readFileSync, statSync } from "node:fs";
 import { dirname as dirname2, join as join11, relative as relative2, resolve as resolve4 } from "node:path";
 import { fileURLToPath } from "node:url";
 function driverVersion() {
-  const built = "0.1.0-alpha.14";
+  const built = "0.1.0-alpha.15";
   if (built)
     return built;
   let dir = dirname2(fileURLToPath(import.meta.url));
@@ -9685,8 +9701,6 @@ function metricWord(item) {
   return measureDef(item.metric)?.short ?? item.metric.replace(/_/g, " ");
 }
 function change2(item) {
-  if (item.metric === HEAT_METRIC && item.baseline !== null && item.candidate !== null)
-    return `+${Math.round((item.candidate - item.baseline) * 100)} pp`;
   if (item.change_text)
     return item.change_text.replace(/ \(.*\)$/, "");
   const { baseline: b, candidate: c } = item;
@@ -9699,7 +9713,7 @@ function change2(item) {
 }
 var size = (i) => i.baseline === null || i.candidate === null ? 0 : i.baseline === 0 ? i.candidate === 0 ? 0 : Number.POSITIVE_INFINITY : Math.abs(Math.log(Math.max(i.candidate, 0.000000001) / i.baseline));
 var bySize = (a, b) => size(a) === size(b) ? 0 : size(a) > size(b) ? -1 : 1;
-var worseOrder = (a, b) => Number(a.grade === "warn") - Number(b.grade === "warn") || Number(b.metric === HEAT_METRIC) - Number(a.metric === HEAT_METRIC) || bySize(a, b);
+var worseOrder = (a, b) => Number(a.grade === "warn") - Number(b.grade === "warn") || bySize(a, b);
 var isWorse = (i) => i.state === "worse";
 var isBetter = (i) => i.state === "better";
 var differs = (sc) => sc?.headline?.measured_differently ?? [];
@@ -9765,13 +9779,20 @@ function slackMessage(s, ctx) {
   const worse = items.filter(isWorse).sort(worseOrder);
   const better = items.filter(isBetter).sort(bySize);
   const commit = commitLine(ctx);
+  const heated = v.scenarios.filter((sc) => heatNote(sc));
+  const heat = heated.map((sc) => context(heatNote(sc)));
   const errorRows = worse.filter((i) => i.grade !== "warn");
   const warningRows = worse.filter((i) => i.grade === "warn");
   const errors = placeCount(errorRows);
   const warns = placeCount(worse) - errors;
   if (isPr) {
-    if (!worse.length)
-      return null;
+    if (!worse.length) {
+      if (!heat.length)
+        return null;
+      const head = `⚪ ${ctx.branch}: ${INFO_WORDS.heat}`;
+      const blocks = [section(`*${head}*`), ...heat, ...commit ? [context(commit)] : [], section(`\uD83D\uDC49 <${heated[0].dashboard_url ?? s.dashboard_url}|View the comparison>`)];
+      return { text: head, attachments: [{ color: COLOR.none, blocks }] };
+    }
     const red = worse.some((i) => isRed(i, scenarioOf(i)));
     const graded = worse.some((i) => i.grade);
     const notBlocking = errors > 0 && !red;
@@ -9797,17 +9818,19 @@ _Measured differently (${differs(sc).join(", ")})${scenarioBlocks(sc) ? "" : `
 ${prTable(rows, sc)}`));
     }
     const more = worse.length - shown;
+    blocks.push(...heat);
     if (commit)
       blocks.push(context(commit));
     blocks.push(section(`\uD83D\uDC49 <${groups.keys().next().value?.dashboard_url ?? s.dashboard_url}|View the comparison>${more > 0 ? ` · ${more} more` : ""}`));
     return { text: head, attachments: [{ color: red ? COLOR.error : COLOR.warn, blocks }] };
   }
-  if (!worse.length && !better.length && !ctx.always)
+  const improved = better.length > 0 || v.state === "better";
+  if (!worse.length && !improved && !ctx.always && !heat.length)
     return null;
   const parts = [errors ? `${errors} ${STATE_WORDS.worse.toLowerCase()}` : "", warns ? `${warns} ${STATE_WORDS.warning.toLowerCase()}` : "", better.length ? `${placeCount(better)} ${STATE_WORDS.better.toLowerCase()}` : ""].filter(Boolean);
-  const quiet = (v.state === null || v.state === "inconclusive") && v.word ? v.word : STATE_WORDS["no-change"].toLowerCase();
-  const status = parts.length ? `${ctx.branch}: ${parts.join(", ")}` : quiet.startsWith("Main: ") && ctx.branch === "main" ? quiet : `${ctx.branch}: ${quiet}`;
-  const head = `${worse.length ? worse.some((i) => isRed(i, scenarioOf(i))) ? "\uD83D\uDD34" : "\uD83D\uDFE0" : better.length ? "\uD83D\uDFE2" : "⚪"} ${status}`;
+  const quiet = improved ? STATE_WORDS.better.toLowerCase() : (v.state === null || v.state === "inconclusive") && v.word ? v.word : STATE_WORDS["no-change"].toLowerCase();
+  const status = parts.length ? `${ctx.branch}: ${parts.join(", ")}` : !improved && heat.length && !ctx.always ? `${ctx.branch}: ${INFO_WORDS.heat}` : quiet.startsWith("Main: ") && ctx.branch === "main" ? quiet : `${ctx.branch}: ${quiet}`;
+  const head = `${worse.length ? worse.some((i) => isRed(i, scenarioOf(i))) ? "\uD83D\uDD34" : "\uD83D\uDFE0" : improved ? "\uD83D\uDFE2" : "⚪"} ${status}`;
   const journeys = new Set(v.scenarios.map((sc) => `${sc.scenario}|${sc.device?.id}`)).size;
   const blocks = [section(`*${head}*
 ${journeys} journey${journeys === 1 ? "" : "s"} checked`)];
@@ -9823,10 +9846,11 @@ ${mainCard(i)}`));
     }
   }
   const more = worse.length + better.length - shown;
+  blocks.push(...heat);
   if (commit)
     blocks.push(context(commit));
   blocks.push(section(`\uD83D\uDC49 <${s.dashboard_url}|Open KeepSnappy>${more > 0 ? ` · ${more} more changes` : ""}`));
-  const color = worse.length ? worse.some((i) => isRed(i, scenarioOf(i))) ? COLOR.error : COLOR.warn : better.length ? COLOR.better : COLOR.none;
+  const color = worse.length ? worse.some((i) => isRed(i, scenarioOf(i))) ? COLOR.error : COLOR.warn : improved ? COLOR.better : COLOR.none;
   return { text: head, attachments: [{ color, blocks }] };
 }
 async function postToSlack(url, payload, fetchImpl = fetch) {
@@ -11034,10 +11058,10 @@ function formatFinding(f, opts = {}) {
     line("Layer", `${f.layer.id} · ${f.layer.name} (${f.certificate ? "certified" : "uncertified"})${f.limits.length ? `; limits: ${f.limits.join("; ")}` : ""}`),
     line("Id", f.id)
   ];
-  if (f.why.components.length > 1) {
+  if (f.why.components.length) {
     out.push(line("Components", ""));
     for (const c of f.why.components) {
-      out.push(`    ${c.component}: ${c.self_ms_before} → ${c.self_ms_after} ms own time, renders ${c.renders_before} → ${c.renders_after}${c.cause ? `; ${c.cause}` : ""}${c.flagged ? "" : " (not certain)"}`);
+      out.push(`    ${c.component}: ${c.self_ms_before ?? "–"} → ${c.self_ms_after} ms own time, renders ${c.renders_before ?? "–"} → ${c.renders_after ?? "–"}${c.cause ? `; ${c.cause}` : ""}${c.flagged ? "" : " (not certain)"}`);
     }
   }
   if (opts.prompt)
@@ -11075,16 +11099,16 @@ function measuredLine(l) {
 function countsLine2(l) {
   const c = l.counts;
   const parts = [
-    c.worse ? `${c.worse} worse${c.not_blocking ? ` (${c.not_blocking} not blocking)` : ""}` : "",
-    c.warn ? plural(c.warn, "warning") : "",
-    c.better ? `${c.better} better` : ""
+    c.worse ? `${c.worse} ${STATE_WORDS.worse.toLowerCase()}${c.not_blocking ? ` (${c.not_blocking} not blocking)` : ""}` : "",
+    c.warn ? `${c.warn} ${STATE_WORDS.warning.toLowerCase()}` : "",
+    c.better ? `${c.better} ${STATE_WORDS.better.toLowerCase()}` : ""
   ].filter(Boolean);
   const state = l.filters.state;
   const unjudged = l.measured.lanes.filter((x) => !x.judged);
-  const head = parts.length ? `${parts.join(", ")}${state === "all" ? "" : `, ${STATE_WORDS2[state] ?? state}`}` : state !== "present" && state !== "all" ? `No finding ${STATE_WORDS2[state] ?? state}` : unjudged.length === l.measured.lanes.length ? `No finding, but nothing was compared yet (${[...new Set(unjudged.map((x) => x.word))].join(", ")}): measure again before calling it clean` : "Nothing worse, no warning, nothing better";
+  const head = parts.length ? `${parts.join(", ")}${state === "all" ? "" : `, ${STATE_WORDS2[state] ?? state}`}` : state !== "present" && state !== "all" ? `No finding ${STATE_WORDS2[state] ?? state}` : unjudged.length === l.measured.lanes.length ? `No finding, but nothing was compared yet (${[...new Set(unjudged.map((x) => x.word))].join(", ")}): measure again before calling it clean` : `Nothing ${STATE_WORDS.worse.toLowerCase()}, nothing ${STATE_WORDS.warning.toLowerCase()}, nothing ${STATE_WORDS.better.toLowerCase()}`;
   const heated = c.heat_runs ?? 0;
   const more = [
-    heated ? `${plural(heated, "run")} heated up the phone (run health, layer 3)` : "",
+    heated ? `${INFO_WORDS.heat.toLowerCase()} in ${plural(heated, "run")} (run health, layer 3)` : "",
     state === "present" && l.states.not_judged ? `${l.states.not_judged} more not judged in the newest run set (state not-judged)` : ""
   ].filter(Boolean);
   const line = `${head}${more.length ? `; ${more.join("; ")}` : ""}.`;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@keepsnappy/agent",
-  "version": "0.1.0-alpha.14",
+  "version": "0.1.0-alpha.15",
   "description": "KeepSnappy CLI: runs your app journeys, measures from inside the app and reports More work / Less work / No change per step.",
   "type": "module",
   "license": "UNLICENSED",