@keep-network/tbtc-v2 1.0.0-dev.3 → 1.0.0-dev.5

package/contracts/bridge/BridgeGovernanceParameters.sol

@@ -384,16 +384,6 @@ library BridgeGovernanceParameters {
         self.depositDustThresholdChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewDepositDustThreshold(DepositData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newDepositDustThreshold;
-    }
-
     /// @notice Begins the deposit treasury fee divisor amount update process.
     /// @param _newDepositTreasuryFeeDivisor New deposit treasury fee divisor amount.
     function beginDepositTreasuryFeeDivisorUpdate(
@@ -430,18 +420,7 @@ library BridgeGovernanceParameters {
         self.depositTreasuryFeeDivisorChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewDepositTreasuryFeeDivisor(DepositData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newDepositTreasuryFeeDivisor;
-    }
-
     /// @notice Begins the deposit tx max fee amount update process.
-
     /// @param _newDepositTxMaxFee New deposit tx max fee amount.
     function beginDepositTxMaxFeeUpdate(
         DepositData storage self,
@@ -472,16 +451,6 @@ library BridgeGovernanceParameters {
         self.depositTxMaxFeeChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewDepositTxMaxFee(DepositData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newDepositTxMaxFee;
-    }
-
     /// @notice Begins the deposit reveal ahead period update process.
     /// @param _newDepositRevealAheadPeriod New deposit reveal ahead period.
     function beginDepositRevealAheadPeriodUpdate(
@@ -516,16 +485,6 @@ library BridgeGovernanceParameters {
         self.depositRevealAheadPeriodChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewDepositRevealAheadPeriod(DepositData storage self)
-        internal
-        view
-        returns (uint32)
-    {
-        return self.newDepositRevealAheadPeriod;
-    }
-
     // --- Redemption
 
     /// @notice Begins the redemption dust threshold amount update process.
@@ -562,16 +521,6 @@ library BridgeGovernanceParameters {
         self.redemptionDustThresholdChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewRedemptionDustThreshold(RedemptionData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newRedemptionDustThreshold;
-    }
-
     /// @notice Begins the redemption treasury fee divisor amount update process.
     /// @param _newRedemptionTreasuryFeeDivisor New redemption treasury fee divisor
     ///         amount.
@@ -609,16 +558,6 @@ library BridgeGovernanceParameters {
         self.redemptionTreasuryFeeDivisorChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewRedemptionTreasuryFeeDivisor(RedemptionData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newRedemptionTreasuryFeeDivisor;
-    }
-
     /// @notice Begins the redemption tx max fee amount update process.
     /// @param _newRedemptionTxMaxFee New redemption tx max fee amount.
     function beginRedemptionTxMaxFeeUpdate(
@@ -653,16 +592,6 @@ library BridgeGovernanceParameters {
         self.redemptionTxMaxFeeChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewRedemptionTxMaxFee(RedemptionData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newRedemptionTxMaxFee;
-    }
-
     /// @notice Begins the redemption tx max total fee amount update process.
     /// @param _newRedemptionTxMaxTotalFee New redemption tx max total fee amount.
     function beginRedemptionTxMaxTotalFeeUpdate(
@@ -697,16 +626,6 @@ library BridgeGovernanceParameters {
         self.redemptionTxMaxTotalFeeChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewRedemptionTxMaxTotalFee(RedemptionData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newRedemptionTxMaxTotalFee;
-    }
-
     /// @notice Begins the redemption timeout amount update process.
     /// @param _newRedemptionTimeout New redemption timeout amount.
     function beginRedemptionTimeoutUpdate(
@@ -742,16 +661,6 @@ library BridgeGovernanceParameters {
         self.redemptionTimeoutChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewRedemptionTimeout(RedemptionData storage self)
-        internal
-        view
-        returns (uint32)
-    {
-        return self.newRedemptionTimeout;
-    }
-
     /// @notice Begins the redemption timeout slashing amount update process.
     /// @param _newRedemptionTimeoutSlashingAmount New redemption timeout slashing
     ///         amount.
@@ -790,16 +699,6 @@ library BridgeGovernanceParameters {
         self.redemptionTimeoutSlashingAmountChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewRedemptionTimeoutSlashingAmount(RedemptionData storage self)
-        internal
-        view
-        returns (uint96)
-    {
-        return self.newRedemptionTimeoutSlashingAmount;
-    }
-
     /// @notice Begins the redemption timeout notifier reward multiplier amount
     ///         update process.
     /// @param _newRedemptionTimeoutNotifierRewardMultiplier New redemption
@@ -840,14 +739,6 @@ library BridgeGovernanceParameters {
         self.redemptionTimeoutNotifierRewardMultiplierChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewRedemptionTimeoutNotifierRewardMultiplier(
-        RedemptionData storage self
-    ) internal view returns (uint32) {
-        return self.newRedemptionTimeoutNotifierRewardMultiplier;
-    }
-
     // --- Moving funds
 
     /// @notice Begins the moving funds tx max total fee amount update process.
@@ -884,16 +775,6 @@ library BridgeGovernanceParameters {
         self.movingFundsTxMaxTotalFeeChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewMovingFundsTxMaxTotalFee(MovingFundsData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newMovingFundsTxMaxTotalFee;
-    }
-
     /// @notice Begins the moving funds dust threshold amount update process.
     /// @param _newMovingFundsDustThreshold New moving funds dust threshold amount.
     function beginMovingFundsDustThresholdUpdate(
@@ -928,16 +809,6 @@ library BridgeGovernanceParameters {
         self.movingFundsDustThresholdChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewMovingFundsDustThreshold(MovingFundsData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newMovingFundsDustThreshold;
-    }
-
     /// @notice Begins the moving funds timeout reset delay amount update process.
     /// @param _newMovingFundsTimeoutResetDelay New moving funds timeout reset
     ///         delay amount.
@@ -975,16 +846,6 @@ library BridgeGovernanceParameters {
         self.movingFundsTimeoutResetDelayChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewMovingFundsTimeoutResetDelay(MovingFundsData storage self)
-        internal
-        view
-        returns (uint32)
-    {
-        return self.newMovingFundsTimeoutResetDelay;
-    }
-
     /// @notice Begins the moving funds timeout amount update process.
     /// @param _newMovingFundsTimeout New moving funds timeout amount.
     function beginMovingFundsTimeoutUpdate(
@@ -1019,16 +880,6 @@ library BridgeGovernanceParameters {
         self.movingFundsTimeoutChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewMovingFundsTimeout(MovingFundsData storage self)
-        internal
-        view
-        returns (uint32)
-    {
-        return self.newMovingFundsTimeout;
-    }
-
     /// @notice Begins the moving funds timeout slashing amount update process.
     /// @param _newMovingFundsTimeoutSlashingAmount New moving funds timeout slashing amount.
     function beginMovingFundsTimeoutSlashingAmountUpdate(
@@ -1066,14 +917,6 @@ library BridgeGovernanceParameters {
         self.movingFundsTimeoutSlashingAmountChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewMovingFundsTimeoutSlashingAmount(
-        MovingFundsData storage self
-    ) external view returns (uint96) {
-        return self.newMovingFundsTimeoutSlashingAmount;
-    }
-
     /// @notice Begins the moving funds timeout notifier reward multiplier amount
     ///         update process.
     /// @param _newMovingFundsTimeoutNotifierRewardMultiplier New moving funds
@@ -1115,14 +958,6 @@ library BridgeGovernanceParameters {
         self.movingFundsTimeoutNotifierRewardMultiplierChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewMovingFundsTimeoutNotifierRewardMultiplier(
-        MovingFundsData storage self
-    ) internal view returns (uint32) {
-        return self.newMovingFundsTimeoutNotifierRewardMultiplier;
-    }
-
     /// @notice Begins the moving funds commitment gas offset update process.
     /// @param _newMovingFundsCommitmentGasOffset New moving funds commitment
     ///        gas offset.
@@ -1161,16 +996,6 @@ library BridgeGovernanceParameters {
         self.movingFundsCommitmentGasOffsetChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewMovingFundsCommitmentGasOffset(MovingFundsData storage self)
-        internal
-        view
-        returns (uint16)
-    {
-        return self.newMovingFundsCommitmentGasOffset;
-    }
-
     /// @notice Begins the moved funds sweep tx max total fee amount update process.
     /// @param _newMovedFundsSweepTxMaxTotalFee New moved funds sweep tx max total
     ///         fee amount.
@@ -1209,16 +1034,6 @@ library BridgeGovernanceParameters {
         self.movedFundsSweepTxMaxTotalFeeChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewMovedFundsSweepTxMaxTotalFee(MovingFundsData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newMovedFundsSweepTxMaxTotalFee;
-    }
-
     /// @notice Begins the moved funds sweep timeout amount update process.
     /// @param _newMovedFundsSweepTimeout New moved funds sweep timeout amount.
     function beginMovedFundsSweepTimeoutUpdate(
@@ -1253,16 +1068,6 @@ library BridgeGovernanceParameters {
         self.movedFundsSweepTimeoutChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewMovedFundsSweepTimeout(MovingFundsData storage self)
-        internal
-        view
-        returns (uint32)
-    {
-        return self.newMovedFundsSweepTimeout;
-    }
-
     /// @notice Begins the moved funds sweep timeout slashing amount update
     ///         process.
     /// @param _newMovedFundsSweepTimeoutSlashingAmount New moved funds sweep
@@ -1304,14 +1109,6 @@ library BridgeGovernanceParameters {
         self.movedFundsSweepTimeoutSlashingAmountChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewMovedFundsSweepTimeoutSlashingAmount(
-        MovingFundsData storage self
-    ) internal view returns (uint96) {
-        return self.newMovedFundsSweepTimeoutSlashingAmount;
-    }
-
     /// @notice Begins the moved funds sweep timeout notifier reward multiplier
     ///         amount update process.
     /// @param _newMovedFundsSweepTimeoutNotifierRewardMultiplier New moved funds
@@ -1354,14 +1151,6 @@ library BridgeGovernanceParameters {
         self.movedFundsSweepTimeoutNotifierRewardMultiplierChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewMovedFundsSweepTimeoutNotifierRewardMultiplier(
-        MovingFundsData storage self
-    ) internal view returns (uint32) {
-        return self.newMovedFundsSweepTimeoutNotifierRewardMultiplier;
-    }
-
     // --- Wallet params
 
     /// @notice Begins the wallet creation period amount update process.
@@ -1398,16 +1187,6 @@ library BridgeGovernanceParameters {
         self.walletCreationPeriodChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewWalletCreationPeriod(WalletData storage self)
-        external
-        view
-        returns (uint32)
-    {
-        return self.newWalletCreationPeriod;
-    }
-
     /// @notice Begins the wallet creation min btc balance amount update process.
     /// @param _newWalletCreationMinBtcBalance New wallet creation min btc balance
     ///         amount.
@@ -1445,16 +1224,6 @@ library BridgeGovernanceParameters {
         self.walletCreationMinBtcBalanceChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewWalletCreationMinBtcBalance(WalletData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newWalletCreationMinBtcBalance;
-    }
-
     /// @notice Begins the wallet creation max btc balance amount update process.
     /// @param _newWalletCreationMaxBtcBalance New wallet creation max btc balance
     ///         amount.
@@ -1492,16 +1261,6 @@ library BridgeGovernanceParameters {
         self.walletCreationMaxBtcBalanceChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewWalletCreationMaxBtcBalance(WalletData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newWalletCreationMaxBtcBalance;
-    }
-
     /// @notice Begins the wallet closure min btc balance amount update process.
     /// @param _newWalletClosureMinBtcBalance New wallet closure min btc balance amount.
     function beginWalletClosureMinBtcBalanceUpdate(
@@ -1538,16 +1297,6 @@ library BridgeGovernanceParameters {
         self.walletClosureMinBtcBalanceChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewWalletClosureMinBtcBalance(WalletData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newWalletClosureMinBtcBalance;
-    }
-
     /// @notice Begins the wallet max age amount update process.
     /// @param _newWalletMaxAge New wallet max age amount.
     function beginWalletMaxAgeUpdate(
@@ -1579,16 +1328,6 @@ library BridgeGovernanceParameters {
         self.walletMaxAgeChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewWalletMaxAge(WalletData storage self)
-        internal
-        view
-        returns (uint32)
-    {
-        return self.newWalletMaxAge;
-    }
-
     /// @notice Begins the wallet max btc transfer amount update process.
     /// @param _newWalletMaxBtcTransfer New wallet max btc transfer amount.
     function beginWalletMaxBtcTransferUpdate(
@@ -1623,16 +1362,6 @@ library BridgeGovernanceParameters {
         self.walletMaxBtcTransferChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewWalletMaxBtcTransfer(WalletData storage self)
-        internal
-        view
-        returns (uint64)
-    {
-        return self.newWalletMaxBtcTransfer;
-    }
-
     /// @notice Begins the wallet closing period amount update process.
     /// @param _newWalletClosingPeriod New wallet closing period amount.
     function beginWalletClosingPeriodUpdate(
@@ -1667,16 +1396,6 @@ library BridgeGovernanceParameters {
         self.walletClosingPeriodChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewWalletClosingPeriod(WalletData storage self)
-        internal
-        view
-        returns (uint32)
-    {
-        return self.newWalletClosingPeriod;
-    }
-
     // --- Fraud
 
     /// @notice Begins the fraud challenge deposit amount update process.
@@ -1715,16 +1434,6 @@ library BridgeGovernanceParameters {
         self.fraudChallengeDepositAmountChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewFraudChallengeDepositAmount(FraudData storage self)
-        internal
-        view
-        returns (uint96)
-    {
-        return self.newFraudChallengeDepositAmount;
-    }
-
     /// @notice Begins the fraud challenge defeat timeout amount update process.
     /// @param _newFraudChallengeDefeatTimeout New fraud challenge defeat timeout
     ///         amount.
@@ -1762,16 +1471,6 @@ library BridgeGovernanceParameters {
         self.fraudChallengeDefeatTimeoutChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewFraudChallengeDefeatTimeout(FraudData storage self)
-        internal
-        view
-        returns (uint32)
-    {
-        return self.newFraudChallengeDefeatTimeout;
-    }
-
     /// @notice Begins the fraud slashing amount update process.
     /// @param _newFraudSlashingAmount New fraud slashing amount.
     function beginFraudSlashingAmountUpdate(
@@ -1806,16 +1505,6 @@ library BridgeGovernanceParameters {
         self.fraudSlashingAmountChangeInitiated = 0;
     }
 
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewFraudSlashingAmount(FraudData storage self)
-        internal
-        view
-        returns (uint96)
-    {
-        return self.newFraudSlashingAmount;
-    }
-
     /// @notice Begins the fraud notifier reward multiplier amount update process.
     /// @param _newFraudNotifierRewardMultiplier New fraud notifier reward multiplier
     ///         amount.
@@ -1882,14 +1571,4 @@ library BridgeGovernanceParameters {
         self.newTreasury = address(0);
         self.treasuryChangeInitiated = 0;
     }
-
-    // https://github.com/crytic/slither/issues/1265
-    // slither-disable-next-line dead-code
-    function getNewFraudNotifierRewardMultiplier(FraudData storage self)
-        internal
-        view
-        returns (uint32)
-    {
-        return self.newFraudNotifierRewardMultiplier;
-    }
 }

package/deploy/06_deploy_bridge.ts

@@ -14,7 +14,8 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
   // For local tests use `1`.
   const txProofDifficultyFactor =
     deployments.getNetworkName() === "hardhat" ||
-    deployments.getNetworkName() === "development"
+    deployments.getNetworkName() === "development" ||
+    deployments.getNetworkName() === "system_tests"
       ? 1
       : 6