@kashscript/hudhud 0.1.0 → 0.2.0

package/src/sop/service.ts

@@ -20,8 +20,15 @@ export interface SopCompilerServiceOptions {
   /** Seam for the deferred LLM decomposer wire-up (not yet invoked). */
   readonly llmProvider?: LLMProvider;
   readonly llmModel?: string;
+  /** Override the `institutionDid` acceptance policy (default: canonical
+   *  `did:kash`). A consumer with structured institution DIDs injects its own —
+   *  DID-string shape is an identity-method policy the consumer owns. */
+  readonly isValidInstitutionDid?: (did: string) => boolean;
 }
 
+/** Default DID acceptance policy: the canonical `did:kash:<base58btc>` shape. */
+const isCanonicalKashDid = (did: string): boolean => KASH_DID_PATTERN.test(did);
+
 export interface CompiledCorporateManual {
   readonly taskDag: TaskDag;
   readonly sopSha256: string;
@@ -36,9 +43,11 @@ const SEMVER_PATTERN = /^\d+\.\d+\.\d+$/;
 
 export class SopCompilerService {
   private readonly llmBackendActive: boolean;
+  private readonly isValidInstitutionDid: (did: string) => boolean;
 
   constructor(opts: SopCompilerServiceOptions = {}) {
     this.llmBackendActive = opts.llmProvider !== undefined;
+    this.isValidInstitutionDid = opts.isValidInstitutionDid ?? isCanonicalKashDid;
   }
 
   /** Whether an LLM provider seam is plumbed. */
@@ -54,16 +63,22 @@ export class SopCompilerService {
     version: string,
   ): Promise<CompiledCorporateManual> {
     if (typeof institutionDid !== "string" || institutionDid.length === 0) {
-      throw new SopCompilationError("institutionDid is required (non-empty did:kash:… identifier)");
+      throw new SopCompilationError("institutionDid is required (non-empty did:kash:… identifier)", {
+        kind: "invalid-institution-did",
+      });
     }
-    if (!KASH_DID_PATTERN.test(institutionDid)) {
-      throw new SopCompilationError("institutionDid is not a valid did:kash:… identifier");
+    if (!this.isValidInstitutionDid(institutionDid)) {
+      throw new SopCompilationError("institutionDid is not a valid did:kash:… identifier", {
+        kind: "invalid-institution-did",
+      });
     }
     if (typeof version !== "string" || version.length === 0 || !SEMVER_PATTERN.test(version)) {
-      throw new SopCompilationError("version must be a semver MAJOR.MINOR.PATCH string");
+      throw new SopCompilationError("version must be a semver MAJOR.MINOR.PATCH string", {
+        kind: "invalid-version",
+      });
     }
     if (typeof rawText !== "string") {
-      throw new SopCompilationError("rawText is required and must be a string");
+      throw new SopCompilationError("rawText is required and must be a string", { kind: "invalid-input" });
     }
 
     // Structural compile (throws SopCompilationError on empty / no steps).
@@ -80,8 +95,18 @@ export class SopCompilerService {
 
     const cycle = detectCycle(structural.nodes, allEdges);
     if (cycle !== null) {
+      // The offending goto lives on the source line of the node whose edge
+      // closes the cycle — surface it so a consumer can point at the raw line.
+      const closingNode = structural.nodes.find((n) => n.id === cycle.closingFrom);
       throw new SopCompilationError(
         `SOP TaskDAG contains a cycle: ${cycle.path.join(" → ")} (closing edge ${cycle.closingFrom} → ${cycle.closingTo})`,
+        {
+          kind: "cycle",
+          cyclePath: cycle.path,
+          closingFrom: cycle.closingFrom,
+          closingTo: cycle.closingTo,
+          lineIndex: closingNode?.sourceLine ?? null,
+        },
       );
     }