@karmaniverous/jeeves-watcher 0.8.3 → 0.8.5

package/dist/cli/jeeves-watcher/index.js

@@ -621,18 +621,23 @@ class ValuesManager extends JsonFileStore {
         index[ruleName] ??= {};
         const ruleValues = index[ruleName];
         for (const [key, value] of Object.entries(metadata)) {
-            if (!this.isTrackable(value))
-                continue;
-            ruleValues[key] ??= [];
-            const arr = ruleValues[key];
-            if (!arr.includes(value)) {
-                arr.push(value);
-                arr.sort((a, b) => {
-                    if (typeof a === typeof b) {
-                        return String(a).localeCompare(String(b));
-                    }
-                    return typeof a < typeof b ? -1 : 1;
-                });
+            // Decompose arrays into individual trackable elements so that
+            // array-typed fields (e.g. domains: ["email"]) are indexed.
+            const items = Array.isArray(value) ? value : [value];
+            for (const item of items) {
+                if (!this.isTrackable(item))
+                    continue;
+                ruleValues[key] ??= [];
+                const arr = ruleValues[key];
+                if (!arr.includes(item)) {
+                    arr.push(item);
+                    arr.sort((a, b) => {
+                        if (typeof a === typeof b) {
+                            return String(a).localeCompare(String(b));
+                        }
+                        return typeof a < typeof b ? -1 : 1;
+                    });
+                }
             }
         }
         this.save();
@@ -1491,6 +1496,31 @@ function validateSchemaCompleteness(schema, ruleName) {
         }
     }
 }
+/** Types that can produce trackable facet values. */
+const FACETABLE_TYPES = new Set([
+    'string',
+    'number',
+    'boolean',
+    'integer',
+    'array',
+]);
+/**
+ * Validate that uiHint and enum are only applied to facetable property types.
+ * Throws if a non-facetable type (e.g. object) declares uiHint or enum.
+ *
+ * @param schema - Resolved schema to validate.
+ * @param ruleName - Name of the rule (for error messages).
+ */
+function validateFacetTypes(schema, ruleName) {
+    for (const [propName, propDef] of Object.entries(schema.properties)) {
+        if (!propDef.type)
+            continue;
+        if (!FACETABLE_TYPES.has(propDef.type) &&
+            (propDef.uiHint !== undefined || propDef.enum !== undefined)) {
+            throw new Error(`Property "${propName}" in rule "${ruleName}" has type "${propDef.type}" with uiHint/enum. Facet hints are only valid on string, number, boolean, integer, or array types.`);
+        }
+    }
+}
 
 /**
  * @module rules/apply
@@ -1557,6 +1587,7 @@ async function applyRules(compiledRules, attributes, options = {}) {
                     });
                     // Validate schema completeness
                     validateSchemaCompleteness(mergedSchema, rule.name);
+                    validateFacetTypes(mergedSchema, rule.name);
                     // Resolve and coerce metadata
                     const schemaOutput = resolveAndCoerce(mergedSchema, attributes, hbs);
                     merged = { ...merged, ...schemaOutput };
@@ -2668,6 +2699,7 @@ function validateInferenceRuleSchemas(parsed) {
                 globalSchemas: parsed.schemas,
             });
             validateSchemaCompleteness(merged, rule.name);
+            validateFacetTypes(merged, rule.name);
         }
         catch (error) {
             return [
@@ -2748,6 +2780,9 @@ function computeRulesHash(rules) {
  * A property is facetable if it declares `uiHint` or `enum`.
  */
 function isFacetable(prop) {
+    // Reject non-primitive types that can never produce trackable values.
+    if (prop.type === 'object')
+        return false;
     return prop.uiHint !== undefined || prop.enum !== undefined;
 }
 /**
@@ -5987,6 +6022,9 @@ class JeevesWatcher {
         const { templateEngine, customMapLib } = await buildTemplateEngineAndCustomMapLib(this.config, configDir);
         this.helperIntrospection = await introspectHelpers(this.config, configDir);
         const processorConfig = createProcessorConfig(this.config, configDir, customMapLib);
+        const stateDir = this.config.stateDir ?? this.config.metadataDir ?? '.jeeves-metadata';
+        this.issuesManager = new IssuesManager(stateDir, logger);
+        this.valuesManager = new ValuesManager(stateDir, logger);
         const processor = this.factories.createDocumentProcessor({
             config: processorConfig,
             embeddingProvider,
@@ -5994,6 +6032,8 @@ class JeevesWatcher {
             compiledRules,
             logger,
             templateEngine,
+            issuesManager: this.issuesManager,
+            valuesManager: this.valuesManager,
         });
         this.processor = processor;
         this.queue = this.factories.createEventQueue({
@@ -6002,9 +6042,6 @@ class JeevesWatcher {
             rateLimitPerMinute: this.config.embedding.rateLimitPerMinute,
         });
         this.watcher = createWatcher(this.config, this.factories, this.queue, processor, logger, this.runtimeOptions);
-        const stateDir = this.config.stateDir ?? this.config.metadataDir ?? '.jeeves-metadata';
-        this.issuesManager = new IssuesManager(stateDir, logger);
-        this.valuesManager = new ValuesManager(stateDir, logger);
         this.server = await this.startApiServer();
         this.watcher.start();
         this.startConfigWatch();

package/dist/index.js

@@ -846,6 +846,31 @@ function validateSchemaCompleteness(schema, ruleName) {
         }
     }
 }
+/** Types that can produce trackable facet values. */
+const FACETABLE_TYPES = new Set([
+    'string',
+    'number',
+    'boolean',
+    'integer',
+    'array',
+]);
+/**
+ * Validate that uiHint and enum are only applied to facetable property types.
+ * Throws if a non-facetable type (e.g. object) declares uiHint or enum.
+ *
+ * @param schema - Resolved schema to validate.
+ * @param ruleName - Name of the rule (for error messages).
+ */
+function validateFacetTypes(schema, ruleName) {
+    for (const [propName, propDef] of Object.entries(schema.properties)) {
+        if (!propDef.type)
+            continue;
+        if (!FACETABLE_TYPES.has(propDef.type) &&
+            (propDef.uiHint !== undefined || propDef.enum !== undefined)) {
+            throw new Error(`Property "${propName}" in rule "${ruleName}" has type "${propDef.type}" with uiHint/enum. Facet hints are only valid on string, number, boolean, integer, or array types.`);
+        }
+    }
+}
 
 /**
  * @module rules/apply
@@ -912,6 +937,7 @@ async function applyRules(compiledRules, attributes, options = {}) {
                     });
                     // Validate schema completeness
                     validateSchemaCompleteness(mergedSchema, rule.name);
+                    validateFacetTypes(mergedSchema, rule.name);
                     // Resolve and coerce metadata
                     const schemaOutput = resolveAndCoerce(mergedSchema, attributes, hbs);
                     merged = { ...merged, ...schemaOutput };
@@ -2359,6 +2385,7 @@ function validateInferenceRuleSchemas(parsed) {
                 globalSchemas: parsed.schemas,
             });
             validateSchemaCompleteness(merged, rule.name);
+            validateFacetTypes(merged, rule.name);
         }
         catch (error) {
             return [
@@ -2439,6 +2466,9 @@ function computeRulesHash(rules) {
  * A property is facetable if it declares `uiHint` or `enum`.
  */
 function isFacetable(prop) {
+    // Reject non-primitive types that can never produce trackable values.
+    if (prop.type === 'object')
+        return false;
     return prop.uiHint !== undefined || prop.enum !== undefined;
 }
 /**
@@ -3509,18 +3539,23 @@ class ValuesManager extends JsonFileStore {
         index[ruleName] ??= {};
         const ruleValues = index[ruleName];
         for (const [key, value] of Object.entries(metadata)) {
-            if (!this.isTrackable(value))
-                continue;
-            ruleValues[key] ??= [];
-            const arr = ruleValues[key];
-            if (!arr.includes(value)) {
-                arr.push(value);
-                arr.sort((a, b) => {
-                    if (typeof a === typeof b) {
-                        return String(a).localeCompare(String(b));
-                    }
-                    return typeof a < typeof b ? -1 : 1;
-                });
+            // Decompose arrays into individual trackable elements so that
+            // array-typed fields (e.g. domains: ["email"]) are indexed.
+            const items = Array.isArray(value) ? value : [value];
+            for (const item of items) {
+                if (!this.isTrackable(item))
+                    continue;
+                ruleValues[key] ??= [];
+                const arr = ruleValues[key];
+                if (!arr.includes(item)) {
+                    arr.push(item);
+                    arr.sort((a, b) => {
+                        if (typeof a === typeof b) {
+                            return String(a).localeCompare(String(b));
+                        }
+                        return typeof a < typeof b ? -1 : 1;
+                    });
+                }
             }
         }
         this.save();
@@ -5965,6 +6000,9 @@ class JeevesWatcher {
         const { templateEngine, customMapLib } = await buildTemplateEngineAndCustomMapLib(this.config, configDir);
         this.helperIntrospection = await introspectHelpers(this.config, configDir);
         const processorConfig = createProcessorConfig(this.config, configDir, customMapLib);
+        const stateDir = this.config.stateDir ?? this.config.metadataDir ?? '.jeeves-metadata';
+        this.issuesManager = new IssuesManager(stateDir, logger);
+        this.valuesManager = new ValuesManager(stateDir, logger);
         const processor = this.factories.createDocumentProcessor({
             config: processorConfig,
             embeddingProvider,
@@ -5972,6 +6010,8 @@ class JeevesWatcher {
             compiledRules,
             logger,
             templateEngine,
+            issuesManager: this.issuesManager,
+            valuesManager: this.valuesManager,
         });
         this.processor = processor;
         this.queue = this.factories.createEventQueue({
@@ -5980,9 +6020,6 @@ class JeevesWatcher {
             rateLimitPerMinute: this.config.embedding.rateLimitPerMinute,
         });
         this.watcher = createWatcher(this.config, this.factories, this.queue, processor, logger, this.runtimeOptions);
-        const stateDir = this.config.stateDir ?? this.config.metadataDir ?? '.jeeves-metadata';
-        this.issuesManager = new IssuesManager(stateDir, logger);
-        this.valuesManager = new ValuesManager(stateDir, logger);
         this.server = await this.startApiServer();
         this.watcher.start();
         this.startConfigWatch();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@karmaniverous/jeeves-watcher",
-  "version": "0.8.3",
+  "version": "0.8.5",
   "author": "Jason Williscroft",
   "description": "Filesystem watcher that keeps a Qdrant vector store in sync with document changes",
   "license": "BSD-3-Clause",
@@ -84,22 +84,22 @@
     "zod": "^4.3.6"
   },
   "devDependencies": {
-    "@dotenvx/dotenvx": "^1.52.0",
+    "@dotenvx/dotenvx": "^1.54.1",
     "@rollup/plugin-alias": "^6.0.0",
-    "@rollup/plugin-commonjs": "^29.0.0",
+    "@rollup/plugin-commonjs": "^29.0.2",
     "@rollup/plugin-json": "^6.1.0",
     "@rollup/plugin-node-resolve": "^16.0.3",
     "@rollup/plugin-typescript": "^12.3.0",
     "@types/fs-extra": "^11.0.4",
     "@types/js-yaml": "*",
-    "@types/node": "^25.3.0",
+    "@types/node": "^25.3.5",
     "@types/picomatch": "^4.0.2",
     "@types/uuid": "*",
     "@vitest/coverage-v8": "^4.0.18",
     "auto-changelog": "^2.5.0",
     "cross-env": "^10.1.0",
-    "fs-extra": "^11.3.3",
-    "happy-dom": "^20.7.0",
+    "fs-extra": "^11.3.4",
+    "happy-dom": "^20.8.3",
     "knip": "^5.85.0",
     "release-it": "^19.2.4",
     "rollup": "^4.59.0",