@karaplay/file-coder 1.3.4 → 1.3.5

package/README.md

@@ -14,8 +14,8 @@ A comprehensive library for encoding/decoding karaoke files (.emk, .kar, MIDI) w
 - ⚛️ Next.js compatible (both client and server side)
 - 🌐 **NEW**: Browser-compatible API for client-side processing
 - 🇹🇭 Thai language support (TIS-620 encoding)
-- ✅ **VERIFIED v1.3.3**: Thai text fully readable in client-side conversions!
-- ✅ 134 tests - 100% pass rate (including Thai text verification tests)
+- ✅ **FIXED v1.3.2**: Client-side EMK decoder now works correctly!
+- ✅ 131 tests - 100% pass rate (including integration tests with real files)
 
 ## Installation
 
@@ -220,49 +220,7 @@ Contributions are welcome! Please feel free to submit a Pull Request.
 
 ## Changelog
 
-### v1.3.4 (Latest)
-**🔧 Fix: Next.js 15 Import Paths**
-
-- **Fixed**: `Module not found: Can't resolve '@karaplay/file-coder/dist/client'` error in Next.js 15
-- **Added**: Export path `./dist/client` for direct dist imports
-- **Added**: Wildcard export `./dist/*` for flexible imports
-- **Verified**: All 4 import methods now work correctly
-- **Compatible**: Next.js 13, 14, 15 and standard Node.js
-
-**Working import paths:**
-```typescript
-// Method 1: Standard (recommended)
-import { convertEmkToKar } from '@karaplay/file-coder';
-
-// Method 2: Client-side (recommended for Next.js)
-import { convertEmkFileToKar } from '@karaplay/file-coder/client';
-
-// Method 3: Direct dist path (now fixed!)
-import { convertEmkFileToKar } from '@karaplay/file-coder/dist/client';
-
-// Method 4: Wildcard dist access
-import * as client from '@karaplay/file-coder/dist/client';
-```
-
-### v1.3.3
-**✅ Verification: Thai Text Readability in Client-Side**
-
-- **Verified**: Thai text is fully readable throughout client-side processing (EMK decode → KAR conversion)
-- **Added**: 3 comprehensive Thai text verification tests for client-side
-- **Tested**: EMK decode preserves 100+ Thai characters correctly
-- **Tested**: EMK to KAR conversion preserves 50+ Thai characters in output
-- **Tested**: 100% Thai word match rate between EMK and KAR
-- **Result**: Complete confidence in Thai language support for client-side conversions
-
-**Test results:**
-```typescript
-// Thai characters in EMK decode: 100+ ✅
-// Thai characters in KAR output: 50+ ✅
-// Thai word match rate: 100% ✅
-// 134/134 tests passing (+3 Thai verification tests) ✅
-```
-
-### v1.3.2
+### v1.3.2 (Latest)
 **🔧 Critical Fix: Client-Side EMK Decoder**
 
 - **Fixed**: Client-side EMK decoder was failing with "Invalid EMK structure: expected at least 3 zlib blocks, found 0"

package/RELEASE_v1.3.5.md

@@ -0,0 +1,84 @@
+# Release v1.3.5
+
+**Release Date:** December 19, 2025
+
+## Bug Fixes
+
+### Fixed Error Handling for Corrupted MIDI Data
+
+**Issue:** When converting EMK files with corrupted MIDI data, the error message was showing as "undefined" because the `midi-file` library throws string errors instead of Error objects.
+
+**Root Cause:** The EMK to KAR conversion function was catching errors and trying to access `error.message`, but when third-party libraries throw string errors (not Error objects), the `.message` property is undefined.
+
+**Solution:** Updated error handling in `convertEmkToKar` to properly handle both Error objects and string errors:
+
+```typescript
+// Handle both Error objects and string errors (some libraries throw strings)
+const errorMessage = typeof error === 'string' 
+  ? error 
+  : error?.message || String(error) || 'Unknown error';
+
+throw new Error(`EMK to KAR conversion failed: ${errorMessage}`);
+```
+
+**Impact:**
+- ✅ Error messages are now always informative and actionable
+- ✅ Users will see the actual MIDI parsing error (e.g., "Bad MIDI file. Expected 'MTrk', got: 'iF'")
+- ✅ No more "undefined" error messages
+- ✅ Better debugging for corrupted EMK files
+
+## Test Coverage
+
+Added comprehensive test suite `emk-error-handling.test.ts` with 4 test cases:
+
+1. ✅ Handles corrupted MIDI data with proper error message
+2. ✅ Handles string errors from third-party libraries
+3. ✅ Handles missing input files with proper error
+4. ✅ Provides informative errors for corrupted EMK structure
+
+**All 135 tests pass**, including the new error handling tests.
+
+## Example
+
+**Before (v1.3.2):**
+```
+Error: EMK to KAR conversion failed: undefined
+```
+
+**After (v1.3.3):**
+```
+Error: EMK to KAR conversion failed: Bad MIDI file. Expected 'MTrk', got: 'iF'
+```
+
+## Technical Details
+
+### The Corrupted File Case
+
+The test file `tests/emk/failed/failed_convert_emk_to_kar.emk` contains:
+- Valid EMK structure that decodes successfully
+- MIDI data with 8 tracks (format 1, 96 ticks per beat)
+- Track 2 has an incorrect length field (declares 1364 bytes but actually contains 1373 bytes)
+- This causes the MIDI parser to look for the next track at the wrong position
+- The parser encounters 'iF' (part of track data) instead of 'MTrk' (track header)
+
+This is a real-world scenario that can occur with corrupted or improperly encoded EMK files.
+
+## Files Changed
+
+- `src/emk-to-kar.ts` - Improved error handling
+- `tests/emk-error-handling.test.ts` - New comprehensive test suite
+
+## Upgrade Notes
+
+No breaking changes. This is a patch release that improves error messages only.
+
+Upgrade with:
+```bash
+npm update @karaplay/file-coder
+```
+
+Or install specifically:
+```bash
+npm install @karaplay/file-coder@1.3.5
+```
+

package/dist/emk-to-kar.js

@@ -149,7 +149,11 @@ function convertEmkToKar(options) {
         catch {
             // Ignore cleanup errors
         }
-        throw new Error(`EMK to KAR conversion failed: ${error.message}`);
+        // Handle both Error objects and string errors (some libraries throw strings)
+        const errorMessage = typeof error === 'string'
+            ? error
+            : error?.message || String(error) || 'Unknown error';
+        throw new Error(`EMK to KAR conversion failed: ${errorMessage}`);
     }
 }
 /**
@@ -175,7 +179,10 @@ function convertEmkToKarBatch(emkFiles, outputDirectory, options) {
             console.log(`✓ ${baseFileName}: ${result.metadata.title}`);
         }
         catch (error) {
-            console.error(`✗ ${baseFileName}: ${error.message}`);
+            const errorMessage = typeof error === 'string'
+                ? error
+                : error?.message || String(error) || 'Unknown error';
+            console.error(`✗ ${baseFileName}: ${errorMessage}`);
             results.push({
                 success: false,
                 outputKar,
@@ -183,7 +190,7 @@ function convertEmkToKarBatch(emkFiles, outputDirectory, options) {
                     title: 'Error',
                     artist: 'Error'
                 },
-                warnings: [error.message]
+                warnings: [errorMessage]
             });
         }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@karaplay/file-coder",
-  "version": "1.3.4",
+  "version": "1.3.5",
   "description": "A comprehensive library for encoding/decoding karaoke files (.emk, .kar, MIDI) with Next.js support. Convert EMK to KAR, read/write karaoke files, full browser and server support.",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -15,14 +15,6 @@
     "./client": {
       "types": "./dist/client.d.ts",
       "default": "./dist/client.js"
-    },
-    "./dist/client": {
-      "types": "./dist/client.d.ts",
-      "default": "./dist/client.js"
-    },
-    "./dist/*": {
-      "types": "./dist/*.d.ts",
-      "default": "./dist/*.js"
     }
   },
   "scripts": {

package/test-exports.js

@@ -1,39 +0,0 @@
-// Test different import paths
-console.log('Testing exports paths...\n');
-
-// Test 1: Standard import
-try {
-  const pkg1 = require('@karaplay/file-coder');
-  console.log('✅ require("@karaplay/file-coder") works');
-  console.log('   Exports:', Object.keys(pkg1).slice(0, 5).join(', '), '...');
-} catch (e) {
-  console.log('❌ require("@karaplay/file-coder") failed:', e.message);
-}
-
-// Test 2: Client import
-try {
-  const pkg2 = require('@karaplay/file-coder/client');
-  console.log('✅ require("@karaplay/file-coder/client") works');
-  console.log('   Exports:', Object.keys(pkg2).slice(0, 5).join(', '), '...');
-} catch (e) {
-  console.log('❌ require("@karaplay/file-coder/client") failed:', e.message);
-}
-
-// Test 3: Dist client import
-try {
-  const pkg3 = require('@karaplay/file-coder/dist/client');
-  console.log('✅ require("@karaplay/file-coder/dist/client") works');
-  console.log('   Exports:', Object.keys(pkg3).slice(0, 5).join(', '), '...');
-} catch (e) {
-  console.log('❌ require("@karaplay/file-coder/dist/client") failed:', e.message);
-}
-
-// Test 4: Direct dist import
-try {
-  const pkg4 = require('@karaplay/file-coder/dist/index');
-  console.log('✅ require("@karaplay/file-coder/dist/index") works');
-} catch (e) {
-  console.log('❌ require("@karaplay/file-coder/dist/index") failed:', e.message);
-}
-
-console.log('\n✅ All export paths working!');