@kapeta/local-cluster-service 0.70.11 → 0.70.12

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [0.70.12](https://github.com/kapetacom/local-cluster-service/compare/v0.70.11...v0.70.12) (2024-09-13)
+
+
+### Bug Fixes
+
+* wait for image resources on disk [CORE-3467] ([#249](https://github.com/kapetacom/local-cluster-service/issues/249)) ([934d9f4](https://github.com/kapetacom/local-cluster-service/commit/934d9f400ae917559a4ede08d3f3e5644b3b5053))
+
 ## [0.70.11](https://github.com/kapetacom/local-cluster-service/compare/v0.70.10...v0.70.11) (2024-09-12)
 
 

package/dist/cjs/src/storm/PageGenerator.js

@@ -242,13 +242,18 @@ class PageQueue extends node_events_1.EventEmitter {
         }
         this.images.set(prompt.url, prompt.description);
         const result = await stormClient_1.stormClient.createImage(`Create an image for the url "${prompt.url}" with this description: ${prompt.description}`.trim());
-        //console.log('Adding image prompt', prompt);
+        let imageEvent = null;
         result.on('data', (event) => {
             if (event.type === 'IMAGE') {
-                this.emit('image', event, prompt);
+                imageEvent = event;
             }
         });
         await result.waitForDone();
+        if (!imageEvent) {
+            throw new Error('No image was generated');
+        }
+        await (0, page_utils_1.writeImageToDisk)(this.systemId, imageEvent, prompt);
+        this.emit('image', imageEvent, prompt);
     }
     async generate(prompt, conversationId) {
         const screenStream = await stormClient_1.stormClient.createUIPage(prompt, conversationId);

package/dist/cjs/src/storm/routes.js

@@ -118,18 +118,6 @@ router.post('/ui/screen', async (req, res) => {
         });
         const promises = [];
         queue.on('page', (data) => (systemId ? sendPageEvent(systemId, data, res) : undefined));
-        queue.on('image', async (screenData, prompt) => {
-            if (!systemId) {
-                return;
-            }
-            try {
-                await handleImageEvent(systemId, screenData, prompt);
-            }
-            catch (e) {
-                console.error('Failed to handle image event', e);
-                throw e;
-            }
-        });
         queue.on('error', (err) => {
             console.error('Failed to process page', err);
             sendError(err, res);
@@ -212,15 +200,6 @@ router.post('/:handle/ui/iterative', async (req, res) => {
             pageQueue.cancel();
         });
         pageQueue.on('page', (screenData) => sendPageEvent(landingPagesStream.getConversationId(), screenData, res));
-        pageQueue.on('image', async (screenData, prompt) => {
-            try {
-                await handleImageEvent(landingPagesStream.getConversationId(), screenData, prompt);
-            }
-            catch (e) {
-                console.error('Failed to handle image event', e);
-                throw e;
-            }
-        });
         pageQueue.on('event', (screenData) => {
             sendEvent(res, screenData);
         });
@@ -374,15 +353,6 @@ router.post('/:handle/ui', async (req, res) => {
             queue.cancel();
         });
         queue.on('page', (screenData) => sendPageEvent(outerConversationId, screenData, res));
-        queue.on('image', async (screenData, prompt) => {
-            try {
-                await handleImageEvent(outerConversationId, screenData, prompt);
-            }
-            catch (e) {
-                console.error('Failed to handle image event', e);
-                throw e;
-            }
-        });
         queue.on('event', (screenData) => {
             sendEvent(res, screenData);
         });
@@ -722,12 +692,4 @@ async function sendPageEvent(mainConversationId, data, res) {
     }
     sendEvent(res, convertPageEvent(data, data.payload.conversationId, mainConversationId));
 }
-async function handleImageEvent(mainConversationId, data, prompt) {
-    try {
-        await (0, page_utils_1.writeImageToDisk)(mainConversationId, data, prompt);
-    }
-    catch (err) {
-        console.error('Failed to write image to disk', err);
-    }
-}
 exports.default = router;

package/dist/esm/src/storm/PageGenerator.js

@@ -242,13 +242,18 @@ class PageQueue extends node_events_1.EventEmitter {
         }
         this.images.set(prompt.url, prompt.description);
         const result = await stormClient_1.stormClient.createImage(`Create an image for the url "${prompt.url}" with this description: ${prompt.description}`.trim());
-        //console.log('Adding image prompt', prompt);
+        let imageEvent = null;
         result.on('data', (event) => {
             if (event.type === 'IMAGE') {
-                this.emit('image', event, prompt);
+                imageEvent = event;
             }
         });
         await result.waitForDone();
+        if (!imageEvent) {
+            throw new Error('No image was generated');
+        }
+        await (0, page_utils_1.writeImageToDisk)(this.systemId, imageEvent, prompt);
+        this.emit('image', imageEvent, prompt);
     }
     async generate(prompt, conversationId) {
         const screenStream = await stormClient_1.stormClient.createUIPage(prompt, conversationId);

package/dist/esm/src/storm/routes.js

@@ -118,18 +118,6 @@ router.post('/ui/screen', async (req, res) => {
         });
         const promises = [];
         queue.on('page', (data) => (systemId ? sendPageEvent(systemId, data, res) : undefined));
-        queue.on('image', async (screenData, prompt) => {
-            if (!systemId) {
-                return;
-            }
-            try {
-                await handleImageEvent(systemId, screenData, prompt);
-            }
-            catch (e) {
-                console.error('Failed to handle image event', e);
-                throw e;
-            }
-        });
         queue.on('error', (err) => {
             console.error('Failed to process page', err);
             sendError(err, res);
@@ -212,15 +200,6 @@ router.post('/:handle/ui/iterative', async (req, res) => {
             pageQueue.cancel();
         });
         pageQueue.on('page', (screenData) => sendPageEvent(landingPagesStream.getConversationId(), screenData, res));
-        pageQueue.on('image', async (screenData, prompt) => {
-            try {
-                await handleImageEvent(landingPagesStream.getConversationId(), screenData, prompt);
-            }
-            catch (e) {
-                console.error('Failed to handle image event', e);
-                throw e;
-            }
-        });
         pageQueue.on('event', (screenData) => {
             sendEvent(res, screenData);
         });
@@ -374,15 +353,6 @@ router.post('/:handle/ui', async (req, res) => {
             queue.cancel();
         });
         queue.on('page', (screenData) => sendPageEvent(outerConversationId, screenData, res));
-        queue.on('image', async (screenData, prompt) => {
-            try {
-                await handleImageEvent(outerConversationId, screenData, prompt);
-            }
-            catch (e) {
-                console.error('Failed to handle image event', e);
-                throw e;
-            }
-        });
         queue.on('event', (screenData) => {
             sendEvent(res, screenData);
         });
@@ -722,12 +692,4 @@ async function sendPageEvent(mainConversationId, data, res) {
     }
     sendEvent(res, convertPageEvent(data, data.payload.conversationId, mainConversationId));
 }
-async function handleImageEvent(mainConversationId, data, prompt) {
-    try {
-        await (0, page_utils_1.writeImageToDisk)(mainConversationId, data, prompt);
-    }
-    catch (err) {
-        console.error('Failed to write image to disk', err);
-    }
-}
 exports.default = router;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@kapeta/local-cluster-service",
-    "version": "0.70.11",
+    "version": "0.70.12",
     "description": "Manages configuration, ports and service discovery for locally running Kapeta systems",
     "type": "commonjs",
     "exports": {

package/src/storm/PageGenerator.ts

@@ -9,7 +9,7 @@ import { ReferenceClassification, StormEvent, StormEventPage, StormImage, UIShel
 import { EventEmitter } from 'node:events';
 import PQueue from 'p-queue';
 
-import { hasPageOnDisk, normalizePath } from './page-utils';
+import { hasPageOnDisk, normalizePath, writeImageToDisk } from './page-utils';
 import * as mimetypes from 'mime-types';
 
 export interface ImagePrompt {
@@ -270,14 +270,20 @@ export class PageQueue extends EventEmitter {
             `Create an image for the url "${prompt.url}" with this description: ${prompt.description}`.trim()
         );
 
-        //console.log('Adding image prompt', prompt);
+        let imageEvent: StormImage | null = null;
         result.on('data', (event: StormEvent) => {
             if (event.type === 'IMAGE') {
-                this.emit('image', event, prompt);
+                imageEvent = event;
             }
         });
 
         await result.waitForDone();
+        if (!imageEvent) {
+            throw new Error('No image was generated');
+        }
+
+        await writeImageToDisk(this.systemId, imageEvent, prompt);
+        this.emit('image', imageEvent, prompt);
     }
 
     public async generate(prompt: UIPagePrompt, conversationId: string) {

package/src/storm/routes.ts

@@ -41,7 +41,6 @@ import {
     resolveReadPath,
     SystemIdHeader,
     writeAssetToDisk,
-    writeImageToDisk,
     writePageToDisk,
 } from './page-utils';
 import { UIServer } from './UIServer';
@@ -165,18 +164,6 @@ router.post('/ui/screen', async (req: KapetaBodyRequest, res: Response) => {
 
         queue.on('page', (data) => (systemId ? sendPageEvent(systemId, data, res) : undefined));
 
-        queue.on('image', async (screenData, prompt) => {
-            if (!systemId) {
-                return;
-            }
-            try {
-                await handleImageEvent(systemId, screenData, prompt);
-            } catch (e) {
-                console.error('Failed to handle image event', e);
-                throw e;
-            }
-        });
-
         queue.on('error', (err) => {
             console.error('Failed to process page', err);
             sendError(err as any, res);
@@ -275,15 +262,6 @@ router.post('/:handle/ui/iterative', async (req: KapetaBodyRequest, res: Respons
             sendPageEvent(landingPagesStream.getConversationId(), screenData, res)
         );
 
-        pageQueue.on('image', async (screenData, prompt) => {
-            try {
-                await handleImageEvent(landingPagesStream.getConversationId(), screenData, prompt);
-            } catch (e) {
-                console.error('Failed to handle image event', e);
-                throw e;
-            }
-        });
-
         pageQueue.on('event', (screenData: StormEvent) => {
             sendEvent(res, screenData);
         });
@@ -470,15 +448,6 @@ router.post('/:handle/ui', async (req: KapetaBodyRequest, res: Response) => {
 
         queue.on('page', (screenData: StormEventPage) => sendPageEvent(outerConversationId, screenData, res));
 
-        queue.on('image', async (screenData, prompt) => {
-            try {
-                await handleImageEvent(outerConversationId, screenData, prompt);
-            } catch (e) {
-                console.error('Failed to handle image event', e);
-                throw e;
-            }
-        });
-
         queue.on('event', (screenData: StormEvent) => {
             sendEvent(res, screenData);
         });
@@ -883,12 +852,4 @@ async function sendPageEvent(mainConversationId: string, data: StormEventPage, r
     sendEvent(res, convertPageEvent(data, data.payload.conversationId, mainConversationId));
 }
 
-async function handleImageEvent(mainConversationId: string, data: StormImage, prompt: ImagePrompt) {
-    try {
-        await writeImageToDisk(mainConversationId, data, prompt);
-    } catch (err) {
-        console.error('Failed to write image to disk', err);
-    }
-}
-
 export default router;