@kapeta/local-cluster-service 0.52.1 → 0.52.3

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [0.52.3](https://github.com/kapetacom/local-cluster-service/compare/v0.52.2...v0.52.3) (2024-06-12)
+
+
+### Bug Fixes
+
+* reject promise on ERROR_INTERNAL ([d796a58](https://github.com/kapetacom/local-cluster-service/commit/d796a58f2a810f5dc14aebac2bd4941badc46b5c))
+
+## [0.52.2](https://github.com/kapetacom/local-cluster-service/compare/v0.52.1...v0.52.2) (2024-06-12)
+
+
+### Bug Fixes
+
+* Avoid leaky temp listeners ([#173](https://github.com/kapetacom/local-cluster-service/issues/173)) ([fdb61b6](https://github.com/kapetacom/local-cluster-service/commit/fdb61b66cc8c2028a66c1ff96989112518349061))
+
 ## [0.52.1](https://github.com/kapetacom/local-cluster-service/compare/v0.52.0...v0.52.1) (2024-06-12)
 
 

package/dist/cjs/src/storm/codegen.js

@@ -451,12 +451,13 @@ class StormCodegen {
                 if (evt.type === 'ERROR_DETAILS') {
                     resolve(evt.payload.files);
                 }
+                reject(new Error("Error details: Unexpected event [" + evt.type + "]"));
             });
             this.out.on('aborted', () => {
                 detailsStream.abort();
+                reject("aborted");
             });
             detailsStream.on('error', (err) => {
-                console.log("error", err);
                 reject(err);
             });
             await detailsStream.waitForDone();
@@ -517,9 +518,11 @@ class StormCodegen {
                 if (evt.type === 'CODE_FIX') {
                     resolve(evt.payload.content.files);
                 }
+                reject(new Error("Error details: Unexpected event [" + evt.type + "]"));
             });
             this.out.on('aborted', () => {
                 fixStream.abort();
+                reject("aborted");
             });
             fixStream.on('error', (err) => {
                 console.log("error", err);

package/dist/cjs/src/storm/routes.js

@@ -121,7 +121,6 @@ router.post('/block/create', async (req, res) => {
         res.send(asset);
     }
     catch (err) {
-        console.error('err');
         res.status(500).send({ error: err.message });
     }
 });
@@ -161,26 +160,14 @@ function sendError(err, res) {
     }
 }
 function waitForStormStream(result) {
-    return new Promise((resolve, reject) => {
-        result.on('error', (err) => {
-            reject(err);
-        });
-        result.on('end', () => {
-            resolve();
-        });
-    });
+    return result.waitForDone();
 }
 function streamStormPartialResponse(result, res) {
-    return new Promise((resolve, reject) => {
+    return new Promise((resolve) => {
         result.on('data', (data) => {
             sendEvent(res, data);
         });
-        result.on('error', (err) => {
-            reject(err);
-        });
-        result.on('end', () => {
-            resolve();
-        });
+        resolve(result.waitForDone());
     });
 }
 function sendEvent(res, evt) {

package/dist/cjs/src/storm/stream.js

@@ -44,12 +44,18 @@ class StormStream extends node_events_1.EventEmitter {
     }
     waitForDone() {
         return new Promise((resolve, reject) => {
-            this.on('error', (err) => {
+            const errorHandler = (err) => {
+                this.removeListener('error', errorHandler);
+                this.removeListener('end', endHandler);
                 reject(err);
-            });
-            this.on('end', () => {
+            };
+            const endHandler = () => {
+                this.removeListener('error', errorHandler);
+                this.removeListener('end', endHandler);
                 resolve();
-            });
+            };
+            this.once('error', errorHandler);
+            this.once('end', endHandler);
         });
     }
     abort() {

package/dist/esm/src/storm/codegen.js

@@ -451,12 +451,13 @@ class StormCodegen {
                 if (evt.type === 'ERROR_DETAILS') {
                     resolve(evt.payload.files);
                 }
+                reject(new Error("Error details: Unexpected event [" + evt.type + "]"));
             });
             this.out.on('aborted', () => {
                 detailsStream.abort();
+                reject("aborted");
             });
             detailsStream.on('error', (err) => {
-                console.log("error", err);
                 reject(err);
             });
             await detailsStream.waitForDone();
@@ -517,9 +518,11 @@ class StormCodegen {
                 if (evt.type === 'CODE_FIX') {
                     resolve(evt.payload.content.files);
                 }
+                reject(new Error("Error details: Unexpected event [" + evt.type + "]"));
             });
             this.out.on('aborted', () => {
                 fixStream.abort();
+                reject("aborted");
             });
             fixStream.on('error', (err) => {
                 console.log("error", err);

package/dist/esm/src/storm/routes.js

@@ -121,7 +121,6 @@ router.post('/block/create', async (req, res) => {
         res.send(asset);
     }
     catch (err) {
-        console.error('err');
         res.status(500).send({ error: err.message });
     }
 });
@@ -161,26 +160,14 @@ function sendError(err, res) {
     }
 }
 function waitForStormStream(result) {
-    return new Promise((resolve, reject) => {
-        result.on('error', (err) => {
-            reject(err);
-        });
-        result.on('end', () => {
-            resolve();
-        });
-    });
+    return result.waitForDone();
 }
 function streamStormPartialResponse(result, res) {
-    return new Promise((resolve, reject) => {
+    return new Promise((resolve) => {
         result.on('data', (data) => {
             sendEvent(res, data);
         });
-        result.on('error', (err) => {
-            reject(err);
-        });
-        result.on('end', () => {
-            resolve();
-        });
+        resolve(result.waitForDone());
     });
 }
 function sendEvent(res, evt) {

package/dist/esm/src/storm/stream.js

@@ -44,12 +44,18 @@ class StormStream extends node_events_1.EventEmitter {
     }
     waitForDone() {
         return new Promise((resolve, reject) => {
-            this.on('error', (err) => {
+            const errorHandler = (err) => {
+                this.removeListener('error', errorHandler);
+                this.removeListener('end', endHandler);
                 reject(err);
-            });
-            this.on('end', () => {
+            };
+            const endHandler = () => {
+                this.removeListener('error', errorHandler);
+                this.removeListener('end', endHandler);
                 resolve();
-            });
+            };
+            this.once('error', errorHandler);
+            this.once('end', endHandler);
         });
     }
     abort() {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@kapeta/local-cluster-service",
-    "version": "0.52.1",
+    "version": "0.52.3",
     "description": "Manages configuration, ports and service discovery for locally running Kapeta systems",
     "type": "commonjs",
     "exports": {

package/src/storm/codegen.ts

@@ -522,12 +522,13 @@ export class StormCodegen {
                 if (evt.type === 'ERROR_DETAILS') {
                     resolve(evt.payload.files);
                 }
+                reject(new Error("Error details: Unexpected event [" + evt.type + "]"));
             });
             this.out.on('aborted', () => {
                 detailsStream.abort();
+                reject("aborted");
             });
             detailsStream.on('error', (err) => {
-                console.log("error", err);
                 reject(err);
             });
             await detailsStream.waitForDone();
@@ -602,9 +603,11 @@ export class StormCodegen {
                 if (evt.type === 'CODE_FIX') {
                     resolve(evt.payload.content.files);
                 }
+                reject(new Error("Error details: Unexpected event [" + evt.type + "]"));
             });
             this.out.on('aborted', () => {
                 fixStream.abort();
+                reject("aborted");
             });
             fixStream.on('error', (err) => {
                 console.log("error", err);

package/src/storm/routes.ts

@@ -156,7 +156,6 @@ router.post('/block/create', async (req: KapetaBodyRequest, res: Response) => {
         const [asset] = await assetManager.createAsset(ymlPath, createRequest.definition);
         res.send(asset);
     } catch (err: any) {
-        console.error('err');
         res.status(500).send({ error: err.message });
     }
 });
@@ -199,30 +198,16 @@ function sendError(err: Error, res: Response) {
     }
 }
 function waitForStormStream(result: StormStream) {
-    return new Promise<void>((resolve, reject) => {
-        result.on('error', (err) => {
-            reject(err);
-        });
-
-        result.on('end', () => {
-            resolve();
-        });
-    });
+    return result.waitForDone();
 }
 
 function streamStormPartialResponse(result: StormStream, res: Response) {
-    return new Promise<void>((resolve, reject) => {
+    return new Promise<void>((resolve) => {
         result.on('data', (data) => {
             sendEvent(res, data);
         });
 
-        result.on('error', (err) => {
-            reject(err);
-        });
-
-        result.on('end', () => {
-            resolve();
-        });
+        resolve(result.waitForDone());
     });
 }
 

package/src/storm/stream.ts

@@ -60,13 +60,18 @@ export class StormStream extends EventEmitter {
 
     waitForDone() {
         return new Promise<void>((resolve, reject) => {
-            this.on('error', (err) => {
+            const errorHandler = (err: any) => {
+                this.removeListener('error', errorHandler);
+                this.removeListener('end', endHandler);
                 reject(err);
-            });
-
-            this.on('end', () => {
+            };
+            const endHandler = () => {
+                this.removeListener('error', errorHandler);
+                this.removeListener('end', endHandler);
                 resolve();
-            });
+            };
+            this.once('error', errorHandler);
+            this.once('end', endHandler);
         });
     }