@kapeta/local-cluster-service 0.10.0 → 0.11.0

package/dist/cjs/src/utils/BlockInstanceRunner.js

@@ -11,7 +11,6 @@ const nodejs_utils_1 = require("@kapeta/nodejs-utils");
 const serviceManager_1 = require("../serviceManager");
 const containerManager_1 = require("../containerManager");
 const LogData_1 = require("./LogData");
-const events_1 = __importDefault(require("events"));
 const clusterService_1 = require("../clusterService");
 const types_1 = require("../types");
 const definitionsManager_1 = require("../definitionsManager");
@@ -100,7 +99,7 @@ class BlockInstanceRunner {
                 processInfo = await this._startLocalProcess(blockInstance, blockUri, env, assetVersion);
             }
             else {
-                processInfo = await this._startDockerProcess(blockInstance, blockUri, env);
+                processInfo = await this._startDockerProcess(blockInstance, blockUri, env, assetVersion);
             }
             if (portTypes.length > 0) {
                 processInfo.portType = portTypes[0];
@@ -133,31 +132,12 @@ class BlockInstanceRunner {
         if (!dockerImage) {
             throw new Error(`Missing docker image information: ${JSON.stringify(localContainer)}`);
         }
-        const containerName = (0, utils_1.getBlockInstanceContainerName)(blockInstance.id);
+        const containerName = (0, utils_1.getBlockInstanceContainerName)(this._systemId, blockInstance.id);
         const startCmd = localContainer.handlers?.onCreate ? localContainer.handlers.onCreate : '';
         const dockerOpts = localContainer.options ?? {};
         const homeDir = localContainer.userHome ? localContainer.userHome : '/root';
         const workingDir = localContainer.workingDir ? localContainer.workingDir : '/workspace';
-        const bindHost = (0, utils_1.getBindHost)();
-        const ExposedPorts = {};
-        const addonEnv = {};
-        const PortBindings = {};
-        const portTypes = getProviderPorts(assetVersion);
-        let port = 80;
-        const promises = portTypes.map(async (portType) => {
-            const publicPort = await serviceManager_1.serviceManager.ensureServicePort(this._systemId, blockInstance.id, portType);
-            const thisPort = port++; //TODO: Not sure how we should handle multiple ports or non-HTTP ports
-            const dockerPort = `${thisPort}/tcp`;
-            ExposedPorts[dockerPort] = {};
-            addonEnv[`KAPETA_LOCAL_SERVER_PORT_${portType.toUpperCase()}`] = '' + thisPort;
-            PortBindings[dockerPort] = [
-                {
-                    HostIp: bindHost,
-                    HostPort: `${publicPort}`,
-                },
-            ];
-        });
-        await Promise.all(promises);
+        const { PortBindings, ExposedPorts, addonEnv } = await this.getDockerPortBindings(blockInstance, assetVersion);
         let HealthCheck = undefined;
         if (localContainer.healthcheck) {
             HealthCheck = containerManager_1.containerManager.toDockerHealth({ cmd: localContainer.healthcheck });
@@ -190,73 +170,7 @@ class BlockInstanceRunner {
             ...dockerOpts,
         });
     }
-    async ensureContainer(opts) {
-        const logs = new LogData_1.LogData();
-        const container = await containerManager_1.containerManager.ensureContainer(opts);
-        try {
-            if (opts.HealthCheck) {
-                await containerManager_1.containerManager.waitForHealthy(container);
-            }
-            else {
-                await containerManager_1.containerManager.waitForReady(container);
-            }
-        }
-        catch (e) {
-            logs.addLog(e.message, 'ERROR');
-        }
-        return this._handleContainer(container, logs);
-    }
-    async _handleContainer(container, logs, deleteOnExit = false) {
-        let localContainer = container;
-        const logStream = (await container.logs({
-            follow: true,
-            stdout: true,
-            stderr: true,
-            tail: LogData_1.LogData.MAX_LINES,
-        }));
-        const outputEvents = new events_1.default();
-        logStream.on('data', (data) => {
-            logs.addLog(data.toString());
-            outputEvents.emit('data', data);
-        });
-        logStream.on('error', (data) => {
-            logs.addLog(data.toString());
-            outputEvents.emit('data', data);
-        });
-        logStream.on('close', async () => {
-            const status = await container.status();
-            const data = status.data;
-            if (deleteOnExit) {
-                try {
-                    await containerManager_1.containerManager.remove(container);
-                }
-                catch (e) { }
-            }
-            outputEvents.emit('exit', data?.State?.ExitCode ?? 0);
-        });
-        return {
-            type: types_1.InstanceType.DOCKER,
-            pid: container.id,
-            output: outputEvents,
-            stop: async () => {
-                if (!localContainer) {
-                    return;
-                }
-                try {
-                    await localContainer.stop();
-                    if (deleteOnExit) {
-                        await containerManager_1.containerManager.remove(localContainer);
-                    }
-                }
-                catch (e) { }
-                localContainer = null;
-            },
-            logs: () => {
-                return logs.getLogs();
-            },
-        };
-    }
-    async _startDockerProcess(blockInstance, blockInfo, env) {
+    async _startDockerProcess(blockInstance, blockInfo, env, assetVersion) {
         const { versionFile } = local_cluster_config_1.default.getRepositoryAssetInfoPath(blockInfo.handle, blockInfo.name, blockInfo.version);
         const versionYml = versionFile;
         if (!node_fs_1.default.existsSync(versionYml)) {
@@ -270,23 +184,28 @@ class BlockInstanceRunner {
         if (!dockerImage) {
             throw new Error(`Missing docker image information: ${JSON.stringify(versionInfo?.artifact?.details)}`);
         }
-        const containerName = (0, utils_1.getBlockInstanceContainerName)(blockInstance.id);
-        const logs = new LogData_1.LogData();
+        const { PortBindings, ExposedPorts, addonEnv } = await this.getDockerPortBindings(blockInstance, assetVersion);
+        const containerName = (0, utils_1.getBlockInstanceContainerName)(this._systemId, blockInstance.id);
         // For windows we need to default to root
         const innerHome = process.platform === 'win32' ? '/root/.kapeta' : local_cluster_config_1.default.getKapetaBasedir();
         return this.ensureContainer({
             Image: dockerImage,
             name: containerName,
+            ExposedPorts,
             Labels: {
                 instance: blockInstance.id,
             },
             Env: [
                 ...DOCKER_ENV_VARS,
                 `KAPETA_LOCAL_CLUSTER_PORT=${clusterService_1.clusterService.getClusterServicePort()}`,
-                ...Object.entries(env).map(([key, value]) => `${key}=${value}`),
+                ...Object.entries({
+                    ...env,
+                    ...addonEnv
+                }).map(([key, value]) => `${key}=${value}`),
             ],
             HostConfig: {
                 Binds: [`${(0, containerManager_1.toLocalBindVolume)(local_cluster_config_1.default.getKapetaBasedir())}:${innerHome}`],
+                PortBindings,
             },
         });
     }
@@ -311,7 +230,8 @@ class BlockInstanceRunner {
             throw new Error(`Provider did not have local image: ${providerRef}`);
         }
         const dockerImage = spec?.local?.image;
-        const containerName = (0, utils_1.getBlockInstanceContainerName)(blockInstance.id);
+        //We only want 1 operator per operator type - across all local systems
+        const containerName = (0, utils_1.getBlockInstanceContainerName)(this._systemId, blockInstance.id);
         const logs = new LogData_1.LogData();
         const bindHost = (0, utils_1.getBindHost)();
         const ExposedPorts = {};
@@ -338,7 +258,7 @@ class BlockInstanceRunner {
             });
         }
         if (spec.local?.mounts) {
-            const mounts = containerManager_1.containerManager.createMounts(blockUri.id, spec.local.mounts);
+            const mounts = await containerManager_1.containerManager.createMounts(this._systemId, blockUri.id, spec.local.mounts);
             Mounts = containerManager_1.containerManager.toDockerMounts(mounts);
         }
         if (spec.local?.health) {
@@ -379,5 +299,39 @@ class BlockInstanceRunner {
         }
         return out;
     }
+    async getDockerPortBindings(blockInstance, assetVersion) {
+        const bindHost = (0, utils_1.getBindHost)();
+        const ExposedPorts = {};
+        const addonEnv = {};
+        const PortBindings = {};
+        const portTypes = getProviderPorts(assetVersion);
+        let port = 80;
+        const promises = portTypes.map(async (portType) => {
+            const publicPort = await serviceManager_1.serviceManager.ensureServicePort(this._systemId, blockInstance.id, portType);
+            const thisPort = port++; //TODO: Not sure how we should handle multiple ports or non-HTTP ports
+            const dockerPort = `${thisPort}/tcp`;
+            ExposedPorts[dockerPort] = {};
+            addonEnv[`KAPETA_LOCAL_SERVER_PORT_${portType.toUpperCase()}`] = '' + thisPort;
+            PortBindings[dockerPort] = [
+                {
+                    HostIp: bindHost,
+                    HostPort: `${publicPort}`,
+                },
+            ];
+        });
+        await Promise.all(promises);
+        return { PortBindings, ExposedPorts, addonEnv };
+    }
+    async ensureContainer(opts) {
+        const container = await containerManager_1.containerManager.ensureContainer(opts);
+        await containerManager_1.containerManager.waitForReady(container);
+        return this._handleContainer(container);
+    }
+    async _handleContainer(container) {
+        return {
+            type: types_1.InstanceType.DOCKER,
+            pid: container.id
+        };
+    }
 }
 exports.BlockInstanceRunner = BlockInstanceRunner;

package/dist/cjs/src/utils/utils.d.ts

@@ -1,4 +1,4 @@
-export declare function getBlockInstanceContainerName(instanceId: string): string;
+export declare function getBlockInstanceContainerName(systemId: string, instanceId: string): string;
 export declare function normalizeKapetaUri(uri: string): string;
 export declare function readYML(path: string): any;
 export declare function isWindows(): boolean;

package/dist/cjs/src/utils/utils.js

@@ -7,8 +7,9 @@ exports.getBindHost = exports.isLinux = exports.isMac = exports.isWindows = expo
 const node_fs_1 = __importDefault(require("node:fs"));
 const yaml_1 = __importDefault(require("yaml"));
 const nodejs_utils_1 = require("@kapeta/nodejs-utils");
-function getBlockInstanceContainerName(instanceId) {
-    return `kapeta-block-instance-${instanceId}`;
+const md5_1 = __importDefault(require("md5"));
+function getBlockInstanceContainerName(systemId, instanceId) {
+    return `kapeta-block-instance-${(0, md5_1.default)(systemId + instanceId)}`;
 }
 exports.getBlockInstanceContainerName = getBlockInstanceContainerName;
 function normalizeKapetaUri(uri) {

package/dist/esm/src/containerManager.d.ts

@@ -1,5 +1,6 @@
 import { Docker } from 'node-docker-api';
 import { Container } from 'node-docker-api/lib/container';
+import { InstanceInfo, LogEntry } from "./types";
 type StringMap = {
     [key: string]: string;
 };
@@ -52,8 +53,8 @@ declare class ContainerManager {
     initialize(): Promise<void>;
     checkAlive(): Promise<boolean>;
     isAlive(): boolean;
-    getMountPoint(kind: string, mountName: string): string;
-    createMounts(kind: string, mountOpts: StringMap): StringMap;
+    getMountPoint(systemId: string, ref: string, mountName: string): string;
+    createMounts(systemId: string, kind: string, mountOpts: StringMap | null | undefined): Promise<StringMap>;
     ping(): Promise<void>;
     docker(): Docker;
     getContainerByName(containerName: string): Promise<ContainerInfo | undefined>;
@@ -67,11 +68,10 @@ declare class ContainerManager {
     };
     private applyHash;
     ensureContainer(opts: any): Promise<Container>;
+    private createOrUpdateContainer;
     startContainer(opts: any): Promise<Container>;
     waitForReady(container: Container, attempt?: number): Promise<void>;
-    waitForHealthy(container: Container, attempt?: number): Promise<void>;
     _isReady(container: Container): Promise<any>;
-    _isHealthy(container: Container): Promise<boolean>;
     remove(container: Container, opts?: {
         force?: boolean;
     }): Promise<void>;
@@ -81,6 +81,7 @@ declare class ContainerManager {
      * @return {Promise<ContainerInfo>}
      */
     get(name: string): Promise<ContainerInfo | null>;
+    getLogs(instance: InstanceInfo): Promise<LogEntry[]>;
 }
 export declare class ContainerInfo {
     private readonly _container;
@@ -105,6 +106,7 @@ export declare class ContainerInfo {
     inspect(): Promise<any>;
     status(): Promise<DockerState>;
     getPorts(): Promise<PortMap | false>;
+    getLogs(): Promise<LogEntry[]>;
 }
 export declare function getExtraHosts(dockerVersion: string): string[] | undefined;
 /**

package/dist/esm/src/containerManager.js

@@ -8,6 +8,7 @@ import { parseKapetaUri } from '@kapeta/nodejs-utils';
 import ClusterConfiguration from '@kapeta/local-cluster-config';
 import uuid from 'node-uuid';
 import md5 from 'md5';
+import { getBlockInstanceContainerName } from "./utils/utils";
 export const CONTAINER_LABEL_PORT_PREFIX = 'kapeta_port-';
 const NANO_SECOND = 1000000;
 const HEALTH_CHECK_INTERVAL = 3000;
@@ -15,8 +16,8 @@ const HEALTH_CHECK_MAX = 20;
 const IMAGE_PULL_CACHE_TTL = 30 * 60 * 1000;
 const IMAGE_PULL_CACHE = {};
 export const HEALTH_CHECK_TIMEOUT = HEALTH_CHECK_INTERVAL * HEALTH_CHECK_MAX * 2;
-const promisifyStream = (stream) => new Promise((resolve, reject) => {
-    stream.on('data', (d) => console.log(d.toString()));
+const promisifyStream = (stream, handler) => new Promise((resolve, reject) => {
+    stream.on('data', handler);
     stream.on('end', resolve);
     stream.on('error', reject);
 });
@@ -95,17 +96,21 @@ class ContainerManager {
     isAlive() {
         return this._alive;
     }
-    getMountPoint(kind, mountName) {
-        const kindUri = parseKapetaUri(kind);
-        return Path.join(this._mountDir, kindUri.handle, kindUri.name, mountName);
+    getMountPoint(systemId, ref, mountName) {
+        const kindUri = parseKapetaUri(ref);
+        const systemUri = parseKapetaUri(systemId);
+        return Path.join(this._mountDir, systemUri.handle, systemUri.name, systemUri.version, kindUri.handle, kindUri.name, kindUri.version, mountName);
     }
-    createMounts(kind, mountOpts) {
+    async createMounts(systemId, kind, mountOpts) {
         const mounts = {};
-        _.forEach(mountOpts, (containerPath, mountName) => {
-            const hostPath = this.getMountPoint(kind, mountName);
-            FSExtra.mkdirpSync(hostPath);
-            mounts[containerPath] = hostPath;
-        });
+        if (mountOpts) {
+            const mountOptList = Object.entries(mountOpts);
+            for (const [mountName, containerPath] of mountOptList) {
+                const hostPath = this.getMountPoint(systemId, kind, mountName);
+                await FSExtra.mkdirp(hostPath);
+                mounts[containerPath] = hostPath;
+            }
+        }
         return mounts;
     }
     async ping() {
@@ -156,12 +161,14 @@ class ContainerManager {
             return false;
         }
         console.log('Pulling image: %s', image);
-        await this.docker()
+        const stream = await this.docker()
             .image.create({}, {
             fromImage: imageName,
             tag: tag,
-        })
-            .then((stream) => promisifyStream(stream));
+        });
+        await promisifyStream(stream, (chunk) => {
+            console.log('Data from docker: "%s"', chunk.toString());
+        });
         IMAGE_PULL_CACHE[image] = Date.now();
         console.log('Image pulled: %s', image);
         return true;
@@ -198,6 +205,11 @@ class ContainerManager {
         dockerOpts.Labels.HASH = hash;
     }
     async ensureContainer(opts) {
+        const container = await this.createOrUpdateContainer(opts);
+        await this.waitForReady(container);
+        return container;
+    }
+    async createOrUpdateContainer(opts) {
         let imagePulled = false;
         try {
             imagePulled = await this.pull(opts.Image);
@@ -277,28 +289,6 @@ class ContainerManager {
             }, HEALTH_CHECK_INTERVAL);
         });
     }
-    async waitForHealthy(container, attempt) {
-        if (!attempt) {
-            attempt = 0;
-        }
-        if (attempt >= HEALTH_CHECK_MAX) {
-            throw new Error('Container did not become healthy within the timeout');
-        }
-        if (await this._isHealthy(container)) {
-            return;
-        }
-        return new Promise((resolve, reject) => {
-            setTimeout(async () => {
-                try {
-                    await this.waitForHealthy(container, (attempt ?? 0) + 1);
-                    resolve();
-                }
-                catch (err) {
-                    reject(err);
-                }
-            }, HEALTH_CHECK_INTERVAL);
-        });
-    }
     async _isReady(container) {
         let info;
         try {
@@ -312,16 +302,12 @@ class ContainerManager {
         if (state?.Status === 'exited' || state?.Status === 'removing' || state?.Status === 'dead') {
             throw new Error('Container exited unexpectedly');
         }
-        return infoData?.State?.Running ?? false;
-    }
-    async _isHealthy(container) {
-        try {
-            const info = await container.status();
-            const infoData = info?.data;
-            return infoData?.State?.Health?.Status === 'healthy';
+        if (infoData?.State?.Health) {
+            // If container has health info - wait for it to become healthy
+            return infoData.State.Health.Status === 'healthy';
         }
-        catch (err) {
-            return false;
+        else {
+            return infoData?.State?.Running ?? false;
         }
     }
     async remove(container, opts) {
@@ -351,6 +337,19 @@ class ContainerManager {
         }
         return new ContainerInfo(dockerContainer);
     }
+    async getLogs(instance) {
+        const containerName = getBlockInstanceContainerName(instance.systemId, instance.instanceId);
+        const containerInfo = await this.getContainerByName(containerName);
+        if (!containerInfo) {
+            return [{
+                    source: "stdout",
+                    level: "ERROR",
+                    time: Date.now(),
+                    message: "Container not found"
+                }];
+        }
+        return containerInfo.getLogs();
+    }
 }
 export class ContainerInfo {
     _container;
@@ -434,6 +433,62 @@ export class ContainerInfo {
         });
         return ports;
     }
+    async getLogs() {
+        const logStream = await this.native.logs({
+            stdout: true,
+            stderr: true,
+            follow: false,
+            tail: 100,
+            timestamps: true,
+        });
+        const out = [];
+        await promisifyStream(logStream, (data) => {
+            const buf = data;
+            let offset = 0;
+            while (offset < buf.length) {
+                try {
+                    // Read the docker log format - explained here:
+                    // https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach
+                    // or here : https://ahmet.im/blog/docker-logs-api-binary-format-explained/
+                    // First byte is stream type
+                    const streamTypeInt = buf.readInt8(offset);
+                    const streamType = streamTypeInt === 1 ? 'stdout' : 'stderr';
+                    // Bytes 4-8 is frame size
+                    const messageLength = buf.readInt32BE(offset + 4);
+                    // After that is the message - with the message length
+                    const dataWithoutStreamType = buf.subarray(offset + 8, offset + 8 + messageLength);
+                    const raw = dataWithoutStreamType.toString();
+                    // Split the message into date and message
+                    const firstSpaceIx = raw.indexOf(' ');
+                    const dateString = raw.substring(0, firstSpaceIx);
+                    const line = raw.substring(firstSpaceIx + 1);
+                    offset = offset + messageLength + 8;
+                    if (!dateString) {
+                        continue;
+                    }
+                    out.push({
+                        time: new Date(dateString).getTime(),
+                        message: line,
+                        level: 'INFO',
+                        source: streamType,
+                    });
+                }
+                catch (err) {
+                    console.error('Error parsing log entry', err);
+                    offset = buf.length;
+                }
+            }
+        });
+        if (out.length === 0) {
+            out.push({
+                time: Date.now(),
+                message: 'No logs found for container',
+                level: 'INFO',
+                source: 'stdout',
+            });
+        }
+        return out;
+    }
 }
 export function getExtraHosts(dockerVersion) {
     if (process.platform !== 'darwin' && process.platform !== 'win32') {

package/dist/esm/src/definitionsManager.d.ts

@@ -5,6 +5,7 @@ declare class DefinitionsManager {
     clearCache(): void;
     private doCached;
     getDefinitions(kindFilter?: string | string[]): DefinitionInfo[];
+    exists(ref: string): boolean;
     getProviderDefinitions(): DefinitionInfo[];
 }
 export declare const definitionsManager: DefinitionsManager;

package/dist/esm/src/definitionsManager.js

@@ -1,4 +1,5 @@
 import ClusterConfiguration from '@kapeta/local-cluster-config';
+import { parseKapetaUri } from "@kapeta/nodejs-utils";
 const CACHE_TTL = 60 * 1000; // 1 min
 class DefinitionsManager {
     cache = {};
@@ -31,6 +32,12 @@ class DefinitionsManager {
         const key = this.getKey(kindFilter);
         return this.doCached(key, () => ClusterConfiguration.getDefinitions(kindFilter));
     }
+    exists(ref) {
+        const uri = parseKapetaUri(ref);
+        return !!this.getDefinitions().find((d) => {
+            return parseKapetaUri(`${d.definition.metadata.name}:${d.version}`).id === uri.id;
+        });
+    }
     getProviderDefinitions() {
         return this.doCached('providers', () => ClusterConfiguration.getProviderDefinitions());
     }

package/dist/esm/src/instanceManager.d.ts

@@ -1,4 +1,4 @@
-import { InstanceInfo } from './types';
+import { InstanceInfo, LogEntry } from './types';
 export declare class InstanceManager {
     private _interval;
     private readonly _instances;
@@ -7,6 +7,7 @@ export declare class InstanceManager {
     getInstances(): InstanceInfo[];
     getInstancesForPlan(systemId: string): InstanceInfo[];
     getInstance(systemId: string, instanceId: string): InstanceInfo | undefined;
+    getLogs(systemId: string, instanceId: string): Promise<LogEntry[]>;
     saveInternalInstance(instance: InstanceInfo): Promise<InstanceInfo>;
     /**
      * Method is called when instance is started from the Kapeta SDKs (e.g. NodeJS SDK)

package/dist/esm/src/instanceManager.js

@@ -50,6 +50,31 @@ export class InstanceManager {
         systemId = normalizeKapetaUri(systemId);
         return this._instances.find((i) => i.systemId === systemId && i.instanceId === instanceId);
     }
+    async getLogs(systemId, instanceId) {
+        const instance = this.getInstance(systemId, instanceId);
+        if (!instance) {
+            throw new Error(`Instance ${systemId}/${instanceId} not found`);
+        }
+        switch (instance.type) {
+            case InstanceType.DOCKER:
+                return await containerManager.getLogs(instance);
+            case InstanceType.UNKNOWN:
+                return [{
+                        level: 'INFO',
+                        message: 'Instance is starting...',
+                        time: Date.now(),
+                        source: 'stdout',
+                    }];
+            case InstanceType.LOCAL:
+                return [{
+                        level: 'INFO',
+                        message: 'Instance started outside Kapeta - logs not available...',
+                        time: Date.now(),
+                        source: 'stdout',
+                    }];
+        }
+        return [];
+    }
     async saveInternalInstance(instance) {
         instance.systemId = normalizeKapetaUri(instance.systemId);
         if (instance.ref) {
@@ -100,7 +125,6 @@ export class InstanceManager {
                 }
                 instance.desiredStatus = info.desiredStatus;
                 instance.owner = info.owner;
-                instance.internal = undefined;
                 instance.status = InstanceStatus.STARTING;
                 instance.startedAt = Date.now();
             }
@@ -199,7 +223,7 @@ export class InstanceManager {
         this.save();
         try {
             if (instance.type === 'docker') {
-                const containerName = getBlockInstanceContainerName(instance.instanceId);
+                const containerName = getBlockInstanceContainerName(instance.systemId, instance.instanceId);
                 const container = await containerManager.getContainerByName(containerName);
                 if (container) {
                     try {
@@ -275,7 +299,7 @@ export class InstanceManager {
             name: blockAsset.data.metadata.name,
             desiredStatus: DesiredInstanceStatus.RUN,
             owner: InstanceOwner.INTERNAL,
-            type: InstanceType.UNKNOWN,
+            type: existingInstance?.type ?? InstanceType.UNKNOWN,
             status: InstanceStatus.STARTING,
             startedAt: Date.now(),
         };
@@ -295,41 +319,6 @@ export class InstanceManager {
         const startTime = Date.now();
         try {
             const processInfo = await runner.start(blockRef, instanceId, instanceConfig);
-            //emit stdout/stderr via sockets
-            processInfo.output.on('data', (data) => {
-                const payload = {
-                    source: 'stdout',
-                    level: 'INFO',
-                    message: data.toString(),
-                    time: Date.now(),
-                };
-                this.emitInstanceEvent(systemId, instanceId, EVENT_INSTANCE_LOG, payload);
-            });
-            processInfo.output.on('exit', (exitCode) => {
-                const timeRunning = Date.now() - startTime;
-                const instance = this.getInstance(systemId, instanceId);
-                if (instance?.status === InstanceStatus.READY) {
-                    //It's already been running
-                    return;
-                }
-                if (exitCode === 143 || exitCode === 137) {
-                    //Process got SIGTERM (143) or SIGKILL (137)
-                    //TODO: Windows?
-                    return;
-                }
-                if (exitCode !== 0 || timeRunning < MIN_TIME_RUNNING) {
-                    const instance = this.getInstance(systemId, instanceId);
-                    if (instance) {
-                        instance.status = InstanceStatus.FAILED;
-                        this.save();
-                    }
-                    this.emitSystemEvent(systemId, EVENT_INSTANCE_EXITED, {
-                        error: 'Failed to start instance',
-                        status: EVENT_INSTANCE_EXITED,
-                        instanceId: blockInstance.id,
-                    });
-                }
-            });
             instance.status = InstanceStatus.READY;
             return this.saveInternalInstance({
                 ...instance,
@@ -338,10 +327,6 @@ export class InstanceManager {
                 health: null,
                 portType: processInfo.portType,
                 status: InstanceStatus.READY,
-                internal: {
-                    logs: processInfo.logs,
-                    output: processInfo.output,
-                },
             });
         }
         catch (e) {
@@ -387,9 +372,7 @@ export class InstanceManager {
     save() {
         try {
             storageService.put('instances', this._instances.map((instance) => {
-                const copy = { ...instance };
-                delete copy.internal;
-                return copy;
+                return { ...instance };
             }));
         }
         catch (e) {
@@ -491,7 +474,7 @@ export class InstanceManager {
     }
     async getExternalStatus(instance) {
         if (instance.type === InstanceType.DOCKER) {
-            const containerName = getBlockInstanceContainerName(instance.instanceId);
+            const containerName = getBlockInstanceContainerName(instance.systemId, instance.instanceId);
             const container = await containerManager.getContainerByName(containerName);
             if (!container) {
                 // If the container doesn't exist, we consider the instance stopped