@kalyx/core 1.0.0-rc.11 → 1.0.0-rc.12

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @kalyx/core
 
+## 1.0.0-rc.12
+
+### Patch Changes
+
+- 0556886: fix(core): validate inputs to `to12Hour` and `to24Hour`
+
+  `to12Hour(hours24)` and `to24Hour(hours12, period)` are public exports from `@kalyx/core` but had no input validation. The previous silent arithmetic mapped invalid inputs onto plausible-looking but wrong outputs and hid caller bugs:
+  - `to12Hour(24)` returned `{ hours12: 12, period: 'PM' }` (because `24 % 12 = 0` → mapped to 12)
+  - `to12Hour(-1)` returned `{ hours12: -1, period: 'AM' }`
+  - `to24Hour(13, 'PM')` returned `25`
+  - `to24Hour(0, 'AM')` returned `0` (but `0` is not a valid 12-hour clock value — midnight is `12 AM`)
+
+  Both functions now throw `RangeError` with a clear message when the input is outside its valid integer range (`[0, 23]` for `to12Hour`, `[1, 12]` for `to24Hour`). `Number.isInteger` guards non-integers and `NaN`. No `@kalyx/react` callers ever passed invalid values, so the internal contracts are unchanged; only direct `@kalyx/core` users who relied on the silent-wrong behaviour see the new exception.
+
 ## 1.0.0-rc.11
 
 ### Minor Changes

package/dist/index.cjs

@@ -477,12 +477,18 @@ function formatTimeString(time, withSeconds = false) {
   return `${hh}:${mm}`;
 }
 function to12Hour(hours24) {
+  if (!Number.isInteger(hours24) || hours24 < 0 || hours24 > 23) {
+    throw new RangeError(`[to12Hour] hours24 must be an integer in [0, 23], got ${hours24}`);
+  }
   const period = hours24 >= 12 ? "PM" : "AM";
   let hours12 = hours24 % 12;
   if (hours12 === 0) hours12 = 12;
   return { hours12, period };
 }
 function to24Hour(hours12, period) {
+  if (!Number.isInteger(hours12) || hours12 < 1 || hours12 > 12) {
+    throw new RangeError(`[to24Hour] hours12 must be an integer in [1, 12], got ${hours12}`);
+  }
   if (period === "AM") {
     return hours12 === 12 ? 0 : hours12;
   }

package/dist/index.d.cts

@@ -218,7 +218,13 @@ declare function parseTimeString(input: string): TimeValue | null;
 declare function formatTimeString(time: TimeValue, withSeconds?: boolean): string;
 /**
  * Converts a 24-hour value to 12-hour form.
- * 0 → 12 AM, 12 → 12 PM
+ *
+ * - `0` → `{ hours12: 12, period: 'AM' }` (midnight)
+ * - `12` → `{ hours12: 12, period: 'PM' }` (noon)
+ *
+ * Throws if `hours24` isn't an integer in `[0, 23]`. The previous silent
+ * modulo behaviour mapped invalid inputs (e.g. `24`, `25`, `-1`) onto
+ * arbitrary valid-looking outputs, which masked caller bugs.
  */
 declare function to12Hour(hours24: number): {
     hours12: number;
@@ -226,6 +232,10 @@ declare function to12Hour(hours24: number): {
 };
 /**
  * Converts a 12-hour value to 24-hour form.
+ *
+ * Throws if `hours12` isn't an integer in `[1, 12]`. The previous silent
+ * arithmetic produced out-of-range outputs (e.g. `to24Hour(13, 'PM')` → `25`).
+ * `period` is constrained at the type level to `'AM' | 'PM'`.
  */
 declare function to24Hour(hours12: number, period: 'AM' | 'PM'): number;
 /**

package/dist/index.d.ts

@@ -218,7 +218,13 @@ declare function parseTimeString(input: string): TimeValue | null;
 declare function formatTimeString(time: TimeValue, withSeconds?: boolean): string;
 /**
  * Converts a 24-hour value to 12-hour form.
- * 0 → 12 AM, 12 → 12 PM
+ *
+ * - `0` → `{ hours12: 12, period: 'AM' }` (midnight)
+ * - `12` → `{ hours12: 12, period: 'PM' }` (noon)
+ *
+ * Throws if `hours24` isn't an integer in `[0, 23]`. The previous silent
+ * modulo behaviour mapped invalid inputs (e.g. `24`, `25`, `-1`) onto
+ * arbitrary valid-looking outputs, which masked caller bugs.
  */
 declare function to12Hour(hours24: number): {
     hours12: number;
@@ -226,6 +232,10 @@ declare function to12Hour(hours24: number): {
 };
 /**
  * Converts a 12-hour value to 24-hour form.
+ *
+ * Throws if `hours12` isn't an integer in `[1, 12]`. The previous silent
+ * arithmetic produced out-of-range outputs (e.g. `to24Hour(13, 'PM')` → `25`).
+ * `period` is constrained at the type level to `'AM' | 'PM'`.
  */
 declare function to24Hour(hours12: number, period: 'AM' | 'PM'): number;
 /**

package/dist/index.js

@@ -426,12 +426,18 @@ function formatTimeString(time, withSeconds = false) {
   return `${hh}:${mm}`;
 }
 function to12Hour(hours24) {
+  if (!Number.isInteger(hours24) || hours24 < 0 || hours24 > 23) {
+    throw new RangeError(`[to12Hour] hours24 must be an integer in [0, 23], got ${hours24}`);
+  }
   const period = hours24 >= 12 ? "PM" : "AM";
   let hours12 = hours24 % 12;
   if (hours12 === 0) hours12 = 12;
   return { hours12, period };
 }
 function to24Hour(hours12, period) {
+  if (!Number.isInteger(hours12) || hours12 < 1 || hours12 > 12) {
+    throw new RangeError(`[to24Hour] hours12 must be an integer in [1, 12], got ${hours12}`);
+  }
   if (period === "AM") {
     return hours12 === 12 ? 0 : hours12;
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kalyx/core",
-  "version": "1.0.0-rc.11",
+  "version": "1.0.0-rc.12",
   "description": "Kalyx core — platform-agnostic date logic, IANA timezone helpers, and the DateAdapter contract used by @kalyx/react",
   "license": "MIT",
   "author": "jiji-hoon96",