@kaitranntt/ccs 2.4.4 → 2.4.5

package/README.md

@@ -108,7 +108,7 @@ export CCS_CLAUDE_PATH="/path/to/claude"              # Unix
 $env:CCS_CLAUDE_PATH = "D:\Tools\Claude\claude.exe"   # Windows
 ```
 
-**See [Troubleshooting Guide](./docs/troubleshooting.md#claude-cli-in-non-standard-location) for detailed setup instructions.**
+**See [Troubleshooting Guide](./docs/en/troubleshooting.md#claude-cli-in-non-standard-location) for detailed setup instructions.**
 
 ---
 
@@ -235,7 +235,9 @@ ccs --uninstall  # Remove CCS commands and skills from ~/.claude/
 
 ---
 
-### 🗑️ Uninstall
+### 🗑️ Official Uninstall
+
+**The recommended way to completely remove CCS:**
 
 **macOS / Linux**:
 ```bash
@@ -247,6 +249,16 @@ curl -fsSL ccs.kaitran.ca/uninstall | bash
 irm ccs.kaitran.ca/uninstall | iex
 ```
 
+> 💡 **Why use the official uninstaller?**
+> - Removes all CCS files and configurations
+> - Cleans up PATH modifications
+> - Removes Claude CLI commands/skills
+> - Handles edge cases we've tested
+
+**Alternative methods** (if official uninstaller fails):
+- **npm**: `npm uninstall -g @kaitranntt/ccs`
+- **Manual**: See [troubleshooting guide](./docs/en/troubleshooting.md#manual-uninstall)
+
 ---
 
 ## 🎯 Philosophy
@@ -260,17 +272,17 @@ irm ccs.kaitran.ca/uninstall | iex
 ## 📖 Documentation
 
 **Complete documentation in [docs/](./docs/)**:
-- [Installation Guide](./docs/installation.md)
-- [Configuration](./docs/configuration.md)
-- [Usage Examples](./docs/usage.md)
-- [Troubleshooting](./docs/troubleshooting.md)
-- [Contributing](./docs/contributing.md)
+- [Installation Guide](./docs/en/installation.md)
+- [Configuration](./docs/en/configuration.md)
+- [Usage Examples](./docs/en/usage.md)
+- [Troubleshooting](./docs/en/troubleshooting.md)
+- [Contributing](./docs/en/contributing.md)
 
 ---
 
 ## 🤝 Contributing
 
-We welcome contributions! Please see our [Contributing Guide](./docs/contributing.md) for details.
+We welcome contributions! Please see our [Contributing Guide](./docs/en/contributing.md) for details.
 
 ---
 
@@ -284,6 +296,6 @@ CCS is licensed under the [MIT License](LICENSE).
 
 **Made with ❤️ for developers who hit rate limits too often**
 
-[⭐ Star this repo](https://github.com/kaitranntt/ccs) | [🐛 Report issues](https://github.com/kaitranntt/ccs/issues) | [📖 Read docs](./docs/)
+[⭐ Star this repo](https://github.com/kaitranntt/ccs) | [🐛 Report issues](https://github.com/kaitranntt/ccs/issues) | [📖 Read docs](./docs/en/)
 
 </div>

package/README.vi.md

@@ -234,7 +234,9 @@ ccs --uninstall  # Gỡ bỏ lệnh và kỹ năng CCS khỏi ~/.claude/
 
 ---
 
-### 🗑️ Gỡ Cài Đặt
+### 🗑️ Gỡ Cài Đặt Chính Thức
+
+**Cách được khuyến nghị để gỡ bỏ hoàn toàn CCS:**
 
 **macOS / Linux**:
 ```bash
@@ -246,6 +248,16 @@ curl -fsSL ccs.kaitran.ca/uninstall | bash
 irm ccs.kaitran.ca/uninstall | iex
 ```
 
+> 💡 **Tại sao dùng uninstaller chính thức?**
+> - Gỡ bỏ tất cả file và cấu hình CCS
+> - Dọn dẹp PATH modifications
+> - Gỡ bỏ commands/skills Claude CLI
+> - Xử lý các trường hợp đặc biệt đã test
+
+**Phương pháp thay thế** (nếu uninstaller chính thức thất bại):
+- **npm**: `npm uninstall -g @kaitranntt/ccs`
+- **Thủ công**: Xem [hướng dẫn khắc phục](./docs/vi/troubleshooting.vi.md#gỡ-cài-đặt-thủ-công)
+
 ---
 
 ## 🎯 Triết Lý

package/VERSION

@@ -1 +1 @@
-2.4.4
+2.4.5

package/bin/ccs.js

@@ -4,35 +4,24 @@
 const { spawn } = require('child_process');
 const path = require('path');
 const fs = require('fs');
-const { showError, colors } = require('./helpers');
+const { error } = require('./helpers');
 const { detectClaudeCli, showClaudeNotFoundError } = require('./claude-detector');
 const { getSettingsPath } = require('./config-manager');
 
 // Version (sync with package.json)
 const CCS_VERSION = require('../package.json').version;
 
-// Helper: Get spawn options for claude execution
-// On Windows, .cmd/.bat/.ps1 files need shell: true
-function getSpawnOptions(claudePath) {
-  const isWindows = process.platform === 'win32';
-  const needsShell = isWindows && /\.(cmd|bat|ps1)$/i.test(claudePath);
-
-  return {
-    stdio: 'inherit',
-    shell: needsShell,
-    windowsHide: true  // Hide the console window on Windows
-  };
-}
-
-// Helper: Escape arguments for shell execution to prevent security vulnerabilities
-function escapeShellArg(arg) {
-  if (process.platform !== 'win32') {
-    // Unix-like systems: escape single quotes and wrap in single quotes
-    return "'" + arg.replace(/'/g, "'\"'\"'") + "'";
-  } else {
-    // Windows: escape double quotes and wrap in double quotes
-    return '"' + arg.replace(/"/g, '""') + '"';
-  }
+// Execute Claude CLI with unified spawn logic
+function execClaude(claudeCli, args) {
+  const child = spawn(claudeCli, args, { stdio: 'inherit', windowsHide: true });
+  child.on('exit', (code, signal) => {
+    if (signal) process.kill(process.pid, signal);
+    else process.exit(code || 0);
+  });
+  child.on('error', () => {
+    showClaudeNotFoundError();
+    process.exit(1);
+  });
 }
 
 // Special command handlers
@@ -51,39 +40,12 @@ function handleVersionCommand() {
 
 function handleHelpCommand(remainingArgs) {
   const claudeCli = detectClaudeCli();
-
-  // Check if claude was found
   if (!claudeCli) {
     showClaudeNotFoundError();
     process.exit(1);
   }
 
-  // Execute claude --help
-  const spawnOpts = getSpawnOptions(claudeCli);
-  let claudeArgs, child;
-
-  if (spawnOpts.shell) {
-    // When shell is required, escape arguments properly
-    claudeArgs = [claudeCli, '--help', ...remainingArgs].map(escapeShellArg).join(' ');
-    child = spawn(claudeArgs, spawnOpts);
-  } else {
-    // When no shell needed, use arguments array directly
-    claudeArgs = ['--help', ...remainingArgs];
-    child = spawn(claudeCli, claudeArgs, spawnOpts);
-  }
-
-  child.on('exit', (code, signal) => {
-    if (signal) {
-      process.kill(process.pid, signal);
-    } else {
-      process.exit(code || 0);
-    }
-  });
-
-  child.on('error', (err) => {
-    showClaudeNotFoundError();
-    process.exit(1);
-  });
+  execClaude(claudeCli, ['--help', ...remainingArgs]);
 }
 
 function handleInstallCommand() {
@@ -91,9 +53,7 @@ function handleInstallCommand() {
   console.log('[Installing CCS Commands and Skills]');
   console.log('Feature not yet implemented in Node.js standalone');
   console.log('Use traditional installer for now:');
-  console.log(process.platform === 'win32'
-    ? '  irm ccs.kaitran.ca/install | iex'
-    : '  curl -fsSL ccs.kaitran.ca/install | bash');
+  console.log('  curl -fsSL ccs.kaitran.ca/install | bash');
   process.exit(0);
 }
 
@@ -151,40 +111,12 @@ function main() {
   // Special case: "default" profile just runs claude directly
   if (profile === 'default') {
     const claudeCli = detectClaudeCli();
-
-    // Check if claude was found
     if (!claudeCli) {
       showClaudeNotFoundError();
       process.exit(1);
     }
 
-    // Execute claude with args
-    const spawnOpts = getSpawnOptions(claudeCli);
-    let claudeArgs, child;
-
-    if (spawnOpts.shell) {
-      // When shell is required, escape arguments properly
-      claudeArgs = [claudeCli, ...remainingArgs].map(escapeShellArg).join(' ');
-      child = spawn(claudeArgs, spawnOpts);
-    } else {
-      // When no shell needed, use arguments array directly
-      claudeArgs = remainingArgs;
-      child = spawn(claudeCli, claudeArgs, spawnOpts);
-    }
-
-    child.on('exit', (code, signal) => {
-      if (signal) {
-        process.kill(process.pid, signal);
-      } else {
-        process.exit(code || 0);
-      }
-    });
-
-    child.on('error', (err) => {
-      showClaudeNotFoundError();
-      process.exit(1);
-    });
-
+    execClaude(claudeCli, remainingArgs);
     return;
   }
 
@@ -201,32 +133,7 @@ function main() {
   }
 
   // Execute claude with --settings
-  const claudeArgsList = ['--settings', settingsPath, ...remainingArgs];
-  const spawnOpts = getSpawnOptions(claudeCli);
-  let claudeArgs, child;
-
-  if (spawnOpts.shell) {
-    // When shell is required, escape arguments properly
-    claudeArgs = [claudeCli, ...claudeArgsList].map(escapeShellArg).join(' ');
-    child = spawn(claudeArgs, spawnOpts);
-  } else {
-    // When no shell needed, use arguments array directly
-    claudeArgs = claudeArgsList;
-    child = spawn(claudeCli, claudeArgs, spawnOpts);
-  }
-
-  child.on('exit', (code, signal) => {
-    if (signal) {
-      process.kill(process.pid, signal);
-    } else {
-      process.exit(code || 0);
-    }
-  });
-
-  child.on('error', (err) => {
-    showClaudeNotFoundError();
-    process.exit(1);
-  });
+  execClaude(claudeCli, ['--settings', settingsPath, ...remainingArgs]);
 }
 
 // Run main

package/bin/claude-detector.js

@@ -2,7 +2,7 @@
 
 const fs = require('fs');
 const { execSync } = require('child_process');
-const { showError, expandPath } = require('./helpers');
+const { expandPath } = require('./helpers');
 
 // Detect Claude CLI executable
 function detectClaudeCli() {
@@ -60,40 +60,11 @@ function detectClaudeCli() {
   return null;
 }
 
-// Show Claude not found error with diagnostics
+// Show Claude not found error
 function showClaudeNotFoundError() {
-  const isWindows = process.platform === 'win32';
-  const pathDirs = (process.env.PATH || '').split(isWindows ? ';' : ':');
-
-  const errorMsg = `Claude CLI not found in PATH
-
-CCS requires Claude CLI to be installed and available in your PATH.
-
-[i] Diagnostic Info:
-    Platform: ${process.platform}
-    PATH directories: ${pathDirs.length}
-    Looking for: claude${isWindows ? '.exe' : ''}
-
-Solutions:
-  1. Install Claude CLI:
-     https://docs.claude.com/en/docs/claude-code/installation
-
-  2. Verify installation:
-     ${isWindows ? 'Get-Command claude' : 'command -v claude'}
-
-  3. If installed but not in PATH, add it:
-     # Find Claude installation
-     ${isWindows ? 'where.exe claude' : 'which claude'}
-
-     # Or set custom path
-     ${isWindows
-       ? '$env:CCS_CLAUDE_PATH = \'C:\\path\\to\\claude.exe\''
-       : 'export CCS_CLAUDE_PATH=\'/path/to/claude\''
-     }
-
-Restart your terminal after installation.`;
-
-  showError(errorMsg);
+  console.error('ERROR: Claude CLI not found in PATH');
+  console.error('Install from: https://docs.claude.com/en/docs/claude-code/installation');
+  process.exit(1);
 }
 
 module.exports = {

package/bin/config-manager.js

@@ -3,7 +3,7 @@
 const fs = require('fs');
 const path = require('path');
 const os = require('os');
-const { showError, expandPath, validateProfileName } = require('./helpers');
+const { error, expandPath } = require('./helpers');
 
 // Get config file path
 function getConfigPath() {
@@ -16,30 +16,7 @@ function readConfig() {
 
   // Check config exists
   if (!fs.existsSync(configPath)) {
-    const isWindows = process.platform === 'win32';
-    showError(`Config file not found: ${configPath}
-
-Solutions:
-  1. Reinstall CCS (auto-creates config):
-     npm install -g @kaitranntt/ccs --force
-
-  2. Or use traditional installer:
-     ${isWindows ? 'irm ccs.kaitran.ca/install | iex' : 'curl -fsSL ccs.kaitran.ca/install | bash'}
-
-  3. Or create manually:
-     mkdir -p ~/.ccs
-     cat > ~/.ccs/config.json << 'EOF'
-{
-  "profiles": {
-    "glm": "~/.ccs/glm.settings.json",
-    "default": "~/.claude/settings.json"
-  }
-}
-EOF
-
-  Note: If you installed with npm --ignore-scripts, configs weren't created.
-        Reinstall without that flag: npm install -g @kaitranntt/ccs --force`);
-    process.exit(1);
+    error(`Config file not found: ${configPath}`);
   }
 
   // Read and parse JSON
@@ -48,23 +25,12 @@ EOF
     const configContent = fs.readFileSync(configPath, 'utf8');
     config = JSON.parse(configContent);
   } catch (e) {
-    const isWindows = process.platform === 'win32';
-    showError(`Invalid JSON in ${configPath}
-
-Fix the JSON syntax or reinstall:
-  ${isWindows ? 'irm ccs.kaitran.ca/install | iex' : 'curl -fsSL ccs.kaitran.ca/install | bash'}`);
-    process.exit(1);
+    error(`Invalid JSON in ${configPath}: ${e.message}`);
   }
 
   // Validate config has profiles object
   if (!config.profiles || typeof config.profiles !== 'object') {
-    const isWindows = process.platform === 'win32';
-    showError(`Config must have 'profiles' object
-
-See config.example.json for correct format
-Or reinstall:
-  ${isWindows ? 'irm ccs.kaitran.ca/install | iex' : 'curl -fsSL ccs.kaitran.ca/install | bash'}`);
-    process.exit(1);
+    error(`Config must have 'profiles' object in ${configPath}`);
   }
 
   return config;
@@ -74,24 +40,12 @@ Or reinstall:
 function getSettingsPath(profile) {
   const config = readConfig();
 
-  // Validate profile name
-  if (!validateProfileName(profile)) {
-    showError(`Invalid profile name: ${profile}
-
-Use only alphanumeric characters, dash, or underscore.`);
-    process.exit(1);
-  }
-
   // Get settings path
   const settingsPath = config.profiles[profile];
 
   if (!settingsPath) {
-    const availableProfiles = Object.keys(config.profiles).map(p => `  - ${p}`).join('\n');
-    showError(`Profile '${profile}' not found in ${getConfigPath()}
-
-Available profiles:
-${availableProfiles}`);
-    process.exit(1);
+    const availableProfiles = Object.keys(config.profiles).join(', ');
+    error(`Profile '${profile}' not found. Available: ${availableProfiles}`);
   }
 
   // Expand path
@@ -99,14 +53,7 @@ ${availableProfiles}`);
 
   // Validate settings file exists
   if (!fs.existsSync(expandedPath)) {
-    const isWindows = process.platform === 'win32';
-    showError(`Settings file not found: ${expandedPath}
-
-Solutions:
-  1. Create the settings file for profile '${profile}'
-  2. Update the path in ${getConfigPath()}
-  3. Or reinstall: ${isWindows ? 'irm ccs.kaitran.ca/install | iex' : 'curl -fsSL ccs.kaitran.ca/install | bash'}`);
-    process.exit(1);
+    error(`Settings file not found: ${expandedPath}`);
   }
 
   // Validate settings file is valid JSON
@@ -114,15 +61,7 @@ Solutions:
     const settingsContent = fs.readFileSync(expandedPath, 'utf8');
     JSON.parse(settingsContent);
   } catch (e) {
-    showError(`Invalid JSON in ${expandedPath}
-
-Details: ${e.message}
-
-Solutions:
-  1. Validate JSON at https://jsonlint.com
-  2. Or reset to template: echo '{"env":{}}' > ${expandedPath}
-  3. Or reinstall CCS`);
-    process.exit(1);
+    error(`Invalid JSON in ${expandedPath}: ${e.message}`);
   }
 
   return expandedPath;

package/bin/helpers.js

@@ -15,15 +15,11 @@ const colors = useColors ? {
   reset: '\x1b[0m'
 } : { red: '', yellow: '', cyan: '', green: '', bold: '', reset: '' };
 
-// Error formatting
-function showError(message) {
-  console.error('');
-  console.error(colors.red + colors.bold + '╔═════════════════════════════════════════════╗' + colors.reset);
-  console.error(colors.red + colors.bold + '║  ERROR                                      ║' + colors.reset);
-  console.error(colors.red + colors.bold + '╚═════════════════════════════════════════════╝' + colors.reset);
-  console.error('');
-  console.error(colors.red + message + colors.reset);
-  console.error('');
+// Simple error formatting
+function error(message) {
+  console.error(`ERROR: ${message}`);
+  console.error('Try: npm install -g @kaitranntt/ccs --force');
+  process.exit(1);
 }
 
 // Path expansion (~ and env vars)
@@ -45,21 +41,9 @@ function expandPath(pathStr) {
   return path.normalize(pathStr);
 }
 
-// Validate profile name (alphanumeric, dash, underscore only)
-function validateProfileName(profile) {
-  return /^[a-zA-Z0-9_-]+$/.test(profile);
-}
-
-// Validate path safety (prevent injection)
-function isPathSafe(pathStr) {
-  // Allow: alphanumeric, path separators, space, dash, underscore, dot, colon, tilde
-  return !/[;|&<>`$*?\[\]'"()]/.test(pathStr);
-}
 
 module.exports = {
   colors,
-  showError,
-  expandPath,
-  validateProfileName,
-  isPathSafe
+  error,
+  expandPath
 };