@kaddo/mcp 3.124.3 → 3.124.4

package/dist/index.js

@@ -10406,16 +10406,25 @@ function buildGuardHistory(dir) {
 // ../cli/src/core/reporting-evidence.ts
 function graphHintFinding(hint) {
   const affected = [hint.artifact_id, ...hint.path ? [hint.path] : []];
+  const semantics = {
+    "work-item": { classification: "coverage_gap", priority: "medium", action: "Review whether the active Work Item needs the missing declared relationship." },
+    decision: { classification: "coverage_gap", priority: "low", action: "Review whether this decision should declare governed code paths." },
+    capability: { classification: "coverage_gap", priority: "low", action: "Review whether this capability should connect to existing Work Items; the relationship is optional." },
+    "knowledge-capsule": { classification: "review_hint", priority: "low", action: "Confirm whether this capsule is intended for direct contextual use or Work Item relationships." }
+  };
+  const semantic = semantics[hint.artifact_type];
   return {
     id: `graph-hint:${hint.artifact_id}:${hint.missing.join(",")}`,
     category: "topology",
+    classification: semantic.classification,
+    resolution_status: "open",
     source: "graph-hints",
     affected_artifacts: affected,
-    // Graph Hints are intentionally informational; review is useful but not a blocking error.
-    priority: "medium",
+    // Graph Hints are intentionally non-blocking; their type determines priority and meaning.
+    priority: semantic.priority,
     evidence: hint.reason,
     explanation: hint.message,
-    suggested_action: `Review the declared relationships for ${hint.artifact_id}${hint.path ? ` at ${hint.path}` : ""}.`
+    suggested_action: semantic.action
   };
 }
 function reportingProjectContext(dir) {
@@ -10635,9 +10644,11 @@ function buildImpactReport(dir, opts = {}, now = /* @__PURE__ */ new Date()) {
     findings.push({
       id: `knowledge-health:${layer2.toLowerCase()}`,
       category: "knowledge",
+      classification: "coverage_gap",
+      resolution_status: "open",
       source: "knowledge-health",
       affected_artifacts: [layer2],
-      priority: status === "Missing" ? "high" : "medium",
+      priority: status === "Missing" ? "medium" : "low",
       evidence: `${layer2} knowledge maturity is ${status}.`,
       explanation: `This assesses documented ${layer2} knowledge, not the quality of the product or implementation.`,
       suggested_action: `Review ${layer2} knowledge coverage and the artifacts or relationships available for it.`
@@ -10647,12 +10658,29 @@ function buildImpactReport(dir, opts = {}, now = /* @__PURE__ */ new Date()) {
     findings.push({
       id: `ownership:${gap.id}`,
       category: "delivery",
+      classification: "coverage_gap",
+      resolution_status: "open",
       source: "work-item-ownership",
       affected_artifacts: [gap.id, gap.path],
       priority: "medium",
       evidence: "A corrective Work Item has no declared code ownership.",
       explanation: gap.title,
-      suggested_action: gap.suggested_action
+      suggested_action: "Review and add relevant code ownership declarations."
+    });
+  }
+  for (const wi of completedWis) {
+    if (!wi.validationStatus || !["not-started", "in-progress", "partial", "failed", "blocked"].includes(wi.validationStatus)) continue;
+    findings.push({
+      id: `completion-validation:${wi.id || wi.title}`,
+      category: "delivery",
+      classification: "review_hint",
+      resolution_status: "open",
+      source: "work-item-lifecycle",
+      affected_artifacts: [wi.id || wi.title, wi.relPath],
+      priority: "medium",
+      evidence: `Lifecycle is completed while persisted validation is ${wi.validationStatus}.`,
+      explanation: "This requires review against the Work Item completion contract; it is not automatically a failed or invalid completion.",
+      suggested_action: "Review the validation evidence and confirm whether the completed lifecycle state is consistent with the Work Item completion contract."
     });
   }
   findings.push(...graphHintEntries.map(graphHintFinding));
@@ -10695,7 +10723,6 @@ function buildImpactReport(dir, opts = {}, now = /* @__PURE__ */ new Date()) {
   else if (g.scope === "active" && g.quality === "empty") actions.push("Run `kaddo impact --scope all` to measure accumulated knowledge impact.");
   if (exp.roadmap.remaining > 0) actions.push(`Materialize the ${exp.roadmap.remaining} remaining roadmap candidate(s) with \`kaddo create --from roadmap\`.`);
   for (const a2 of [
-    groupedAction(gaps.missing_code_ownership, "Add `code:` ownership to"),
     groupedAction(gaps.missing_source, "Add `source`/`source_id` to")
   ]) if (a2) actions.push(a2);
   if (gaps.broad_ownership_globs.length > 0) actions.push(`Narrow ${gaps.broad_ownership_globs.length} broad ownership glob(s) into specific paths.`);
@@ -10783,7 +10810,7 @@ function buildImpactReport(dir, opts = {}, now = /* @__PURE__ */ new Date()) {
 function ratio(have, total) {
   return `${have}/${total}`;
 }
-function renderImpactMarkdown(r2) {
+function renderImpactMarkdown(r2, opts = {}) {
   const L = [];
   L.push("# Kaddo Knowledge Impact Report", "");
   L.push(`Generated at: ${r2.generated_at}`);
@@ -10805,10 +10832,10 @@ function renderImpactMarkdown(r2) {
   if (r2.findings.length === 0) L.push("No current findings detected by the executed deterministic checks.");
   if (r2.findings.length > 0) {
     const cell = (value) => value.replace(/\|/g, "\\|").replace(/\r?\n/g, " ");
-    L.push("| Priority | Source | Affected | Finding | Suggested action |");
-    L.push("|---|---|---|---|---|");
+    L.push("| Classification | Priority | Status | Source | Affected | Finding | Suggested action |");
+    L.push("|---|---|---|---|---|---|---|");
     for (const finding of r2.findings) {
-      L.push(`| ${finding.priority} | ${cell(finding.source)} | ${cell(finding.affected_artifacts.join(", ") || "not available")} | ${cell(finding.explanation)} Evidence: ${cell(finding.evidence)} | ${cell(finding.suggested_action)} |`);
+      L.push(`| ${finding.classification} | ${finding.priority} | ${finding.resolution_status} | ${cell(finding.source)} | ${cell(finding.affected_artifacts.join(", ") || "not available")} | ${cell(finding.explanation)} Evidence: ${cell(finding.evidence)} | ${cell(finding.suggested_action)} |`);
     }
   }
   L.push("");
@@ -10920,9 +10947,9 @@ function renderImpactMarkdown(r2) {
     }
     L.push("");
   };
-  gapSection("Work Items missing source", gp.missing_source);
-  gapSection("Work Items missing code ownership", gp.missing_code_ownership);
-  if (gp.broad_ownership_globs.length > 0) {
+  if (opts.details) gapSection("Work Items missing source", gp.missing_source);
+  if (opts.details) gapSection("Work Items missing code ownership", gp.missing_code_ownership);
+  if (opts.details && gp.broad_ownership_globs.length > 0) {
     L.push("### Broad ownership globs", "");
     for (const b2 of gp.broad_ownership_globs) {
       L.push(`- ${b2.id} \u2014 ${b2.title}`);
@@ -10933,16 +10960,26 @@ function renderImpactMarkdown(r2) {
   }
   if (gp.ownership_overlaps.length > 0) {
     L.push("### Shared code-path history (review only)", "");
-    for (const o2 of gp.ownership_overlaps) {
-      L.push(`- \`${o2.code_path}\``);
-      L.push(`  - Owned by: ${o2.work_items.join(", ")}`);
-      L.push(`  - Suggested action: ${o2.suggested_action}`);
+    if (opts.details) {
+      for (const o2 of gp.ownership_overlaps) {
+        L.push(`- \`${o2.code_path}\``);
+        L.push(`  - Owned by: ${o2.work_items.join(", ")}`);
+        L.push(`  - Suggested action: ${o2.suggested_action}`);
+      }
+    } else {
+      L.push(`- ${gp.ownership_overlaps.length} shared path declaration(s) detected. These are historical relationships, not necessarily ownership conflicts.`);
+      const areas = gp.ownership_overlaps.slice(0, 3).map((o2) => `\`${o2.code_path}\``);
+      if (areas.length > 0) L.push(`- Most involved paths: ${areas.join(", ")}.`);
+      L.push("- Run `kaddo impact --details` for the complete shared-path inventory.");
     }
     L.push("");
   }
   const anyGaps = gp.missing_source.length + gp.missing_code_ownership.length + gp.broad_ownership_globs.length;
   if (anyGaps === 0) {
     L.push("No actionable knowledge gaps detected. \u{1F389}", "");
+  } else if (!opts.details) {
+    L.push("- Current actionable items are listed in Key Findings. Run `kaddo impact --details` for the full artifact inventory.");
+    L.push("");
   }
   const historical = [
     ["knowledge level", gp.missing_knowledge_level],
@@ -11205,7 +11242,7 @@ function renderSavingsMarkdown(r2) {
   L.push("");
   L.push("## Evidence Used", "");
   const e = r2.evidence;
-  L.push(`- Knowledge Impact Score: ${e.knowledge_impact_score ?? "not available"}${e.knowledge_impact_score !== null ? "/100" : ""}`);
+  L.push(`- Legacy Knowledge Impact Score: ${e.knowledge_impact_score ?? "not available"}${e.knowledge_impact_score !== null ? "/100" : ""} (deprecated; informational only and not used for confidence)`);
   L.push(`- Completed Work Items: ${e.completed_work_items}`);
   L.push(`- Ownership coverage: ${e.ownership_coverage_percent}%`);
   L.push(`- Work Items with Acceptance Criteria: ${e.work_items_with_acceptance_criteria}`);
@@ -11280,7 +11317,15 @@ function buildDriftReport(dir, now = /* @__PURE__ */ new Date()) {
   const workItems = discoverWorkItems(dir);
   const verificationEvidence = workItems.filter((wi) => wi.validationStatus && wi.validationStatus !== "not-started");
   const plans = getDeprecationPlans(dir);
-  const deprecationFindings = plans.flatMap((plan) => getDeprecationPlan(dir, plan.id)?.targets.flatMap(validateTarget) ?? []);
+  const planDetails = plans.map((plan) => getDeprecationPlan(dir, plan.id)).filter((plan) => plan !== null);
+  const plansWithoutTargets = planDetails.filter((plan) => plan.targets.length === 0);
+  const plansWithTargets = planDetails.filter((plan) => plan.targets.length > 0);
+  const targetFindingsByPlan = new Map(plansWithTargets.map((plan) => [
+    plan.id,
+    plan.targets.flatMap(validateTarget)
+  ]));
+  const deprecationFindings = [...targetFindingsByPlan.values()].flat();
+  const plansWithoutStructuralFindings = plansWithTargets.filter((plan) => (targetFindingsByPlan.get(plan.id) ?? []).length === 0);
   const config = loadConfig(dir);
   const topology = config ? buildGraph(dir, config, { scope: "all" }, now) : null;
   const graphHints = topology ? buildGraphHints(dir, topology, now) : null;
@@ -11290,13 +11335,27 @@ function buildDriftReport(dir, now = /* @__PURE__ */ new Date()) {
     ...deprecationFindings.map((finding, index) => ({
       id: `deprecation-target:${index + 1}`,
       category: "consistency",
+      classification: "consistency_violation",
+      resolution_status: "open",
       source: "deprecation-target-validation",
-      affected_artifacts: [],
-      priority: "medium",
-      evidence: String(finding),
+      affected_artifacts: finding.target ? [finding.target] : [],
+      priority: finding.severity === "error" ? "high" : "medium",
+      evidence: finding.message,
       explanation: "A deterministic deprecation target consistency check reported a finding.",
       suggested_action: "Review the affected deprecation target and its declared lifecycle evidence."
-    }))
+    })),
+    ...h2.available && h2.total_runs >= 2 ? h2.threads.filter((thread) => thread.status === "open").map((thread) => ({
+      id: `guard-history:${thread.code_path}`,
+      category: "consistency",
+      classification: "historical_drift",
+      resolution_status: "open",
+      source: "guard-history",
+      affected_artifacts: [thread.code_path, ...thread.related_artifacts],
+      priority: "medium",
+      evidence: `Recorded Guard observations from ${thread.first_detected} through ${thread.last_seen} remain unresolved.`,
+      explanation: "Comparable Guard runs observed a possible code/knowledge drift thread over time.",
+      suggested_action: "Review the recorded drift thread and update the relevant knowledge or ownership evidence."
+    })) : []
   ];
   const actions = [];
   if (!h2.available) {
@@ -11313,12 +11372,17 @@ function buildDriftReport(dir, now = /* @__PURE__ */ new Date()) {
     consistency_evidence: [
       { id: "guard-current-consistency", label: "Current Guard consistency", classification: h2.available ? "observed" : "unknown", reason: h2.available ? `${h2.total_runs} recorded Guard run(s) provide deterministic consistency evidence.` : "No recorded Guard history is available." },
       { id: "lifecycle-consistency", label: "Lifecycle evidence consistency", classification: verificationEvidence.length > 0 ? "observed" : "unknown", reason: verificationEvidence.length > 0 ? `${verificationEvidence.length} Work Item(s) persist an implementation validation status.` : "No persisted Work Item validation status is available." },
-      { id: "deprecation-consistency", label: "Deprecation consistency", classification: plans.length === 0 ? "not_applicable" : deprecationFindings.length === 0 ? "derived" : "observed", reason: plans.length === 0 ? "No deprecation plans exist in this project." : deprecationFindings.length === 0 ? `${plans.length} plan(s) passed deterministic target consistency checks.` : `${deprecationFindings.length} deterministic deprecation consistency finding(s) were detected.` },
+      { id: "deprecation-consistency", label: "Deprecation consistency", classification: plans.length === 0 ? "not_applicable" : plansWithTargets.length === 0 ? "unknown" : deprecationFindings.length === 0 ? "derived" : "observed", reason: plans.length === 0 ? "No deprecation plans exist in this project." : plansWithTargets.length === 0 ? `${plansWithoutTargets.length} plan(s) have no targets, so target consistency was not evaluated.` : deprecationFindings.length === 0 ? `${plansWithTargets.length} plan(s) with targets passed deterministic target consistency checks; ${plansWithoutTargets.length} plan(s) remain unevaluated because they have no targets.` : `${deprecationFindings.length} deterministic deprecation consistency finding(s) were detected.` },
       { id: "topology-consistency", label: "Knowledge topology consistency", classification: topology === null ? "unknown" : topologyHints === 0 ? "derived" : "observed", reason: topology === null ? "No project configuration is available to construct the topology." : topologyHints === 0 ? `The in-memory topology has ${topology.nodes.length} node(s) and no open deterministic hints.` : `The in-memory topology has ${topologyHints} open deterministic hint(s).` }
     ],
     current_consistency_findings: currentConsistencyFindings,
     structural_consistency: {
-      deprecation_target_checks: plans.length === 0 ? "not_applicable" : deprecationFindings.length === 0 ? "passed" : "findings_detected",
+      deprecation_target_checks: plans.length === 0 ? "not_applicable" : plansWithTargets.length === 0 ? "not_evaluated" : deprecationFindings.length === 0 ? "passed" : "findings_detected",
+      plans_discovered: plans.length,
+      plans_without_targets: plansWithoutTargets.length,
+      plans_with_targets_evaluated: plansWithTargets.length,
+      structural_findings: deprecationFindings.length,
+      plans_without_structural_findings: plansWithoutStructuralFindings.length,
       note: plans.length === 0 ? "No deprecation plans exist in this project." : "Target consistency checks validate declared structural state only; they do not verify operational removal from infrastructure, production or external consumers."
     },
     guard_history: {
@@ -11346,22 +11410,41 @@ function renderDriftMarkdown(r2) {
   L.push("## Consistency Evidence", "");
   for (const item of r2.consistency_evidence) L.push(`- ${item.label}: ${item.classification} \u2014 ${item.reason}`);
   L.push("");
-  L.push("## Current Consistency Findings", "");
-  if (r2.current_consistency_findings.length === 0) {
-    L.push("No findings detected by the executed consistency checks.");
-    L.push("");
+  const findingGroups = [
+    { classification: "consistency_violation", title: "Consistency Violations" },
+    { classification: "coverage_gap", title: "Coverage Gaps" },
+    { classification: "review_hint", title: "Review Hints" },
+    { classification: "historical_drift", title: "Historical Drift" }
+  ];
+  L.push("## Current Findings Summary", "");
+  for (const group of findingGroups) {
+    const count = r2.current_consistency_findings.filter((finding) => finding.classification === group.classification).length;
+    const unavailable = group.classification === "historical_drift" && !r2.guard_history.available;
+    L.push(`- ${group.title}: ${unavailable ? "not available \u2014 no recorded Guard runs" : count}`);
   }
-  if (r2.current_consistency_findings.length > 0) {
-    const cell = (value) => value.replace(/\|/g, "\\|").replace(/\r?\n/g, " ");
-    L.push("| Priority | Source | Affected | Finding | Suggested action |");
-    L.push("|---|---|---|---|---|");
-    for (const finding of r2.current_consistency_findings) {
-      L.push(`| ${finding.priority} | ${cell(finding.source)} | ${cell(finding.affected_artifacts.join(", ") || "not available")} | ${cell(finding.explanation)} Evidence: ${cell(finding.evidence)} | ${cell(finding.suggested_action)} |`);
+  L.push("");
+  L.push("## Current Consistency Findings", "");
+  if (r2.current_consistency_findings.length === 0) L.push("No findings detected by the executed consistency checks.", "");
+  const cell = (value) => value.replace(/\|/g, "\\|").replace(/\r?\n/g, " ");
+  for (const group of findingGroups) {
+    const findings = r2.current_consistency_findings.filter((finding) => finding.classification === group.classification);
+    if (findings.length === 0) continue;
+    L.push(`### ${group.title}`, "");
+    L.push("| Classification | Priority | Status | Source | Affected | Finding | Suggested action |");
+    L.push("|---|---|---|---|---|---|---|");
+    for (const finding of findings) {
+      L.push(`| ${finding.classification} | ${finding.priority} | ${finding.resolution_status} | ${cell(finding.source)} | ${cell(finding.affected_artifacts.join(", ") || "not available")} | ${cell(finding.explanation)} Evidence: ${cell(finding.evidence)} | ${cell(finding.suggested_action)} |`);
     }
     L.push("");
   }
   L.push("## Structural Consistency Boundaries", "");
   L.push(`- Deprecation target checks: ${r2.structural_consistency.deprecation_target_checks}`);
+  L.push(`- Plans discovered: ${r2.structural_consistency.plans_discovered}`);
+  L.push(`- Plans without targets: ${r2.structural_consistency.plans_without_targets}`);
+  L.push(`- Plans with targets evaluated: ${r2.structural_consistency.plans_with_targets_evaluated}`);
+  L.push(`- Structural findings: ${r2.structural_consistency.structural_findings}`);
+  L.push(`- Plans without structural findings: ${r2.structural_consistency.plans_without_structural_findings}`);
+  if (r2.structural_consistency.plans_without_targets > 0) L.push("- Target consistency for plans without targets: not evaluated \u2014 no targets defined.");
   L.push(`- Note: ${r2.structural_consistency.note}`);
   L.push("");
   if (!r2.guard_history.available) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kaddo/mcp",
-  "version": "3.124.3",
+  "version": "3.124.4",
   "description": "MCP server for Kaddo project knowledge: read-only resources/tools/prompts plus safe derived generation under .kaddo/.",
   "license": "MIT",
   "repository": {