@kaddo/cli 3.13.0 → 3.13.2

package/dist/index.js

@@ -2214,10 +2214,12 @@ A refined Work Item intended to be saved under the lifecycle workspace:
    Keep \`chore\` for maintenance/tooling/config/infra work \u2014 never upgrade a chore to a feature.
 4. Validate the Knowledge Level (K0\u2013K4) and propose a different one if needed.
 5. Propose acceptance criteria.
-6. Propose Out of scope and Validation sections.
-7. Propose a Definition of Done.
-8. Identify open questions and assumptions.
-9. Suggest ownership candidates (code globs) if evident.
+6. Propose an Out of scope section.
+7. Propose **how to test it** \u2014 concrete validation steps (commands to run, manual steps, or
+   test cases) that prove the change works once implemented. This is mandatory.
+8. Propose a Definition of Done.
+9. Identify open questions and assumptions.
+10. Suggest ownership candidates (code globs) if evident.
 
 ## Constraints
 
@@ -2241,7 +2243,11 @@ A refined Work Item intended to be saved under the lifecycle workspace:
 
 **Out of scope:**
 
-**Validation:**
+**How to test it (validation):**
+<!-- concrete steps to verify once implemented, e.g.:
+1. \`pnpm test path/to/spec\`  (or the project's test command)
+2. Manual: <action> \u2192 expected <result>
+3. \`kaddo guard\` shows no unexpected drift -->
 
 **Definition of Done:**
 
@@ -2261,13 +2267,7 @@ and \`blocked\` as active work; \`completed\` and \`archived\` are historical kn
 When the Work Item is refined and ready to build, **hand off to the implementation-agent**.
 You do **not** suggest branches, commits or pull requests \u2014 implementation (including any Git
 branch suggestion) is the implementation-agent's responsibility, and only by respecting the
-project Git strategy. Your job ends at a clear, traceable Work Item.
-
-## Git boundaries
-
-Never run Git. Do not create or switch branches, create worktrees, stash, commit, push or merge.
-Work only inside the currently selected workspace. If a workspace or branch change is required,
-stop and ask the human.
+project Git strategy. Your job ends at a clear, traceable Work Item that **states how to test it**.
 
 ## Quality Checklist
 
@@ -2275,7 +2275,8 @@ stop and ask the human.
 - Large candidates are split.
 - Knowledge Level is justified.
 - Acceptance criteria are testable.
-- Out of scope and Validation are stated.
+- Out of scope is stated.
+- **How to test it** is concrete (commands, manual steps, or test cases).
 - Open questions are explicit.
 - Handoff: next step is the implementation-agent (never a branch or commit).
 `;
@@ -2828,16 +2829,16 @@ Conventional Commit message \u2014 as suggestions, never executed.
 4. Suggest running \`kaddo owners suggest\` and confirm the \`code:\` globs.
 5. Suggest running \`kaddo guard\` before committing to detect knowledge drift.
 6. Update affected knowledge (ADR / capabilities.md / current-state.md).
-7. Suggest a Conventional Commit message and **wait for explicit human confirmation**. Never
+7. **Explain how to test it** \u2014 the exact commands and/or manual steps to verify the change works
+   (run the Work Item's "How to test it" steps and report the result).
+8. Suggest a Conventional Commit message and **wait for explicit human confirmation**. Never
    commit, push or merge on your own.
 
 ## Constraints
 
 - Never run Git. Never commit, push or merge \u2014 suggest and wait for the human.
-- **Do not create branches, switch branches, create worktrees, or stash changes.** You may
-  *suggest* a branch name; the human creates the branch and selects the workspace.
-- **Work only inside the currently selected workspace** (repository root or the active Git
-  worktree). If a branch or workspace change is required, stop and ask the human.
+- **Do not create or switch branches, or stash changes.** You may *suggest* a branch name; the
+  human creates the branch. If a branch change is required, stop and ask the human.
 - Respect \`knowledge/tech/git-strategy.md\` when it exists.
 - Keep knowledge in sync with the code you change.
 - Do not invent business facts.
@@ -2853,6 +2854,9 @@ Conventional Commit message \u2014 as suggestions, never executed.
 
 ## Tests
 
+## How to test it
+<!-- exact commands and/or manual steps to verify, e.g. run the test suite, start the app then <action> -->
+
 ## Knowledge to update
 
 ## Suggested commit (await human confirmation)
@@ -2866,6 +2870,7 @@ Code, tests and migrations live in the repository. Knowledge updates go under \`
 
 - A branch is suggested per the Git strategy (never executed).
 - Tests accompany the change.
+- **How to test it** is stated (exact commands / manual steps to verify).
 - \`kaddo scan\` / \`owners suggest\` / \`guard\` are suggested at the right moments.
 - Affected knowledge is updated.
 - Commit is suggested and awaits human confirmation \u2014 never run automatically.
@@ -5081,42 +5086,6 @@ function assessPhase(input) {
   return { phase, reasons, recommendedAgents: recommendedAgents2, nextStep };
 }
 
-// src/core/workspace.ts
-import { dirname, resolve, basename } from "path";
-function findGitEntry(startDir) {
-  let cur = resolve(startDir);
-  while (true) {
-    const g = join(cur, ".git");
-    if (exists(g)) return { dir: cur, gitPath: g };
-    const parent = dirname(cur);
-    if (parent === cur) return null;
-    cur = parent;
-  }
-}
-function readBranch(gitDir) {
-  try {
-    const head = readFile(join(gitDir, "HEAD")).trim();
-    const m = head.match(/^ref:\s*refs\/heads\/(.+)$/);
-    if (m) return m[1].trim();
-    return head ? head.slice(0, 12) : null;
-  } catch {
-    return null;
-  }
-}
-function detectWorkspace(startDir) {
-  const found = findGitEntry(startDir);
-  if (!found) return { isGitRepo: false, root: null, branch: null, isWorktree: false };
-  const { dir, gitPath } = found;
-  if (!isFile(gitPath)) {
-    return { isGitRepo: true, root: dir, branch: readBranch(gitPath), isWorktree: false };
-  }
-  let gitDir = gitPath;
-  const m = readFile(gitPath).match(/gitdir:\s*(.+)/);
-  if (m) gitDir = m[1].trim();
-  const isWorktree = basename(dirname(gitDir)) === "worktrees";
-  return { isGitRepo: true, root: dir, branch: readBranch(gitDir), isWorktree };
-}
-
 // src/core/knowledge-discovery.ts
 var KNOWLEDGE = "knowledge";
 var CONSOLIDATED_TYPE = {
@@ -5166,7 +5135,7 @@ function layerFromPath(filePath) {
   if (p2.includes(`/${KNOWLEDGE}/delivery/`)) return "Delivery";
   return null;
 }
-function basename2(p2) {
+function basename(p2) {
   return p2.replace(/\\/g, "/").split("/").pop() ?? p2;
 }
 function discoverLayers(dir) {
@@ -5183,9 +5152,9 @@ function discoverLayers(dir) {
     const layer2 = layerForType(type) ?? layerFromPath(a.filePath);
     if (!layer2) continue;
     const slot = acc[layer2];
-    slot.detected.add(basename2(a.filePath));
+    slot.detected.add(basename(a.filePath));
     if (layer2 === "Delivery") {
-      if (type === "roadmap" || basename2(a.filePath) === "roadmap.md") slot.hasRoadmap = true;
+      if (type === "roadmap" || basename(a.filePath) === "roadmap.md") slot.hasRoadmap = true;
       if (WORK_ITEM_TYPES2.has(type) || a.filePath.replace(/\\/g, "/").includes("/delivery/work-items/")) {
         if (a.filePath.replace(/\\/g, "/").includes("/delivery/work-items/")) slot.hasWorkItem = true;
       }
@@ -5368,7 +5337,6 @@ function buildProjectExplanation(dir) {
     workItemsMissingOwnership: items.length - withOwnership
   };
   const domains = [...new Set(workItemArtifacts.flatMap((a) => a.domains))].filter(Boolean);
-  const workspace = detectWorkspace(dir);
   const roadmapPath = join(dir, ARCH_DIR4, "delivery", "roadmap.md");
   const roadmapMd = exists(roadmapPath) ? readFile(roadmapPath) : null;
   const roadmap = roadmapStats(roadmapMd, items.length);
@@ -5418,7 +5386,6 @@ function buildProjectExplanation(dir) {
     workItems,
     ownership,
     domains,
-    workspace,
     layers,
     roadmap,
     mappedModules,
@@ -5451,21 +5418,6 @@ function renderExplanationHuman(exp) {
   lines.push(`- Team: ${exp.project.teamSize}`);
   lines.push(`- Structure: ${exp.project.structure}`);
   lines.push("");
-  lines.push("## Workspace");
-  if (exp.workspace.isGitRepo) {
-    lines.push(`- Repository root: ${exp.workspace.root ?? "unknown"}`);
-    lines.push(`- Git worktree: ${exp.workspace.isWorktree ? "yes" : "no"}`);
-    lines.push(`- Active branch: ${exp.workspace.branch ?? "unknown"}`);
-    if (exp.workspace.isWorktree) {
-      lines.push("");
-      lines.push(
-        "> Worktree detected. Run all Kaddo commands (scan, guard, owners suggest, explain) from this worktree while implementation is active, so they observe the same files the agent is changing."
-      );
-    }
-  } else {
-    lines.push("- Not a Git repository");
-  }
-  lines.push("");
   lines.push("## Knowledge Layers");
   lines.push(renderLayersMarkdown(exp.layers));
   lines.push("");
@@ -5956,7 +5908,6 @@ function buildContextPack(dir, config, now = /* @__PURE__ */ new Date()) {
     layers,
     roadmap,
     phase,
-    workspace: detectWorkspace(dir),
     deliveryMix,
     mappedModules,
     missing,
@@ -5994,23 +5945,6 @@ function renderContextPack(pack) {
       `- Structure: ${project.structure}`
     ].join("\n") + "\n"
   );
-  parts.push("## Execution Context\n");
-  if (pack.workspace.isGitRepo) {
-    parts.push(
-      [
-        `- Repository root: ${pack.workspace.root ?? "unknown"}`,
-        `- Current branch: ${pack.workspace.branch ?? "unknown"}`,
-        `- Git worktree: ${pack.workspace.isWorktree ? "yes" : "no"}`
-      ].join("\n") + "\n"
-    );
-    if (pack.workspace.isWorktree) {
-      parts.push(
-        "You are inside a Git worktree. Work only in this workspace; run Kaddo commands from here.\n"
-      );
-    }
-  } else {
-    parts.push("- Not a Git repository\n");
-  }
   parts.push("## Current Phase\n");
   parts.push(`Phase: ${pack.phase.phase}
 `);
@@ -6445,12 +6379,6 @@ function runUnderstand() {
   if (assessment.nextStep) {
     console.log(`Next step: ${assessment.nextStep}`);
   }
-  if (exp.workspace.isWorktree) {
-    console.log("");
-    console.log(`Current implementation workspace: ${exp.workspace.branch ?? "(detached)"}`);
-    console.log("  \u2192 You are inside a Git worktree. Run scan, owners suggest, guard and explain");
-    console.log("    from this worktree so they reflect the code being changed here.");
-  }
   const active = activeWorkItems(dir);
   if (active.length > 0) {
     console.log("");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kaddo/cli",
-  "version": "3.13.0",
+  "version": "3.13.2",
   "description": "Knowledge Driven Development toolkit",
   "license": "MIT",
   "repository": {