@kabmo-labs/kabmo 0.5.2 → 0.5.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kabmo-labs/kabmo",
-  "version": "0.5.2",
+  "version": "0.5.3",
   "description": "Web console and diagnostic workbench for AI coding agents — Elysia + Preact on Bun.",
   "license": "UNLICENSED",
   "author": "Wijanarko Putra Rajeb <wijanarko.rajeb@gmail.com>",

package/src/client/components/mobile/SessionSidebar.tsx

@@ -218,13 +218,11 @@ export function MobileSessionSidebar({
         viewLabel={showingSessions ? 'Sessions' : dock.activePanel?.label ?? 'Panel'}
       />
 
-      {/* The strip appears only once there is something to switch TO: with the
-          rail off, or with nothing placed on it, a row holding one chip would
-          be chrome that never changes. The exception is a stored view that no
-          longer resolves — the body is a notice, and without the strip the
-          session list would be unreachable (the desktop has the same escape in
-          its rail, which always holds Sessions). */}
-      {phoneLeftStripVisible(dock.enabled, dock.placed.length, showingSessions) ? (
+      {/* The strip is the phone's RAIL, so it follows the switch: with the rail
+          on it always draws, exactly like the desktop column's rail (which
+          always holds Sessions). Requiring a second destination made the
+          Settings switch a no-op on a phone with nothing placed. */}
+      {phoneLeftStripVisible(dock.enabled) ? (
         <MobileDockStrip panels={dock.catalog} activeId={activeView} onSelect={dock.setActiveView} />
       ) : null}
 

package/src/client/components/mobile/mobile-session-sidebar/use-dock.ts

@@ -31,8 +31,6 @@ import { SESSIONS_VIEW_ID } from '@/shared/lib/workspace/left-dock';
 export interface MobileDockState {
   /** The strip's chips: `sessions` and every placed panel. */
   catalog: ResolvedPanel[];
-  /** The placed panels only — what makes the strip worth drawing. */
-  placed: ResolvedPanel[];
   activeView: string;
   setActiveView: (id: string) => void;
   /** True while the session list is the view on screen. */
@@ -47,11 +45,9 @@ export function useMobileDock(): MobileDockState {
   const catalog = usePanelCatalog('left');
   const [stored, setStored] = useSessionState<string>('layout.mobileLeftPanel', SESSIONS_VIEW_ID);
   const activeView = useLeftDockView(stored, dock.enabled);
-  const placed = catalog.filter((panel) => panel.id !== SESSIONS_VIEW_ID);
 
   return {
     catalog,
-    placed,
     activeView,
     setActiveView: setStored,
     showingSessions: activeView === SESSIONS_VIEW_ID,

package/src/client/hooks/chat/omp/session-list.test.ts

@@ -158,30 +158,6 @@ async function mountProvider(): Promise<Harness> {
 }
 
 describe('SidebarDataProvider reads both sidebar topics', () => {
-  test('paints the structure from the snapshot, without any fetch', async () => {
-    const { holder, server } = await mountProvider();
-    expect(holder.api?.initializing).toBe(false);
-    expect(holder.api?.folders).toHaveLength(1);
-    expect(holder.api?.folders[0]?.sessions[0]?.title).toBe('A');
-    server.stop();
-  });
-
-  test('merges the volatile status onto the session it belongs to', async () => {
-    const harness = await mountProvider();
-    expect(renderedStatus(harness.holder.api)).toBeUndefined();
-
-    await harness.push(undefined, statusBody('stream'));
-    expect(renderedStatus(harness.holder.api)).toBe('stream');
-
-    // A terminal badge, then cleared — the map is authoritative for removals.
-    await harness.push(undefined, statusBody('finish'));
-    expect(renderedStatus(harness.holder.api)).toBe('finish');
-    await harness.push(undefined, statusBody());
-    expect(renderedStatus(harness.holder.api)).toBeUndefined();
-
-    harness.server.stop();
-  });
-
   test('reports a live run for a session the structure has not scanned yet', async () => {
     // A fresh spawn: omp writes the session file only when the first assistant
     // message settles (measured ~17s), so no structure row exists. The status

package/src/server/lib/bundler/build-errors.test.ts

@@ -66,12 +66,6 @@ describe('describeShellBuildFailure', () => {
     expect(await describeShellBuildFailure(root)).toBeNull();
   });
 
-  test('returns null when there is no shell entrypoint to build', async () => {
-    rmSync(join(root, 'index.html'));
-
-    expect(await describeShellBuildFailure(root)).toBeNull();
-  });
-
   test('loads the plugins named in bunfig.toml, as the route does', async () => {
     // A plugin that fails a file the route would bundle: if the probe ignored
     // bunfig it would report a clean build and hide the real failure.

package/src/server/routes/fs/git-merge.test.ts

@@ -254,17 +254,6 @@ describe('continue_operation', () => {
 });
 
 describe('abort_operation', () => {
-  test('restores the pre-merge state', async () => {
-    const repo = makeConflictingRepo();
-    await post({ actionType: 'merge_branch', repo: '.', root: repo, branch: 'feature' });
-
-    const res = await post({ actionType: 'abort_operation', repo: '.', root: repo });
-    expect(res.body.success).toBe(true);
-    expect((await readGitState(repo)).operation).toBeNull();
-    expect(fs.readFileSync(path.join(repo, 'f.txt'), 'utf8')).toBe('a\nMAIN\n');
-    expect(git(repo, 'status', '--porcelain')).toBe('');
-  });
-
   test('refuses when nothing is in progress', async () => {
     const repo = makeConflictingRepo();
     const res = await post({ actionType: 'abort_operation', repo: '.', root: repo });

package/src/server/routes/panels/routes.test.ts

@@ -132,13 +132,6 @@ describe('the README route', () => {
 
     expect((await call(readmeLoader, { plugin: 'demo', '*': '../outside.md' })).status).toBe(403);
   });
-
-  test('404s a plugin that ships no README', async () => {
-    const dir = writePlugin('demo', getMarketplacePluginsDir());
-    fs.rmSync(join(dir, 'README.md'));
-    invalidatePanelScan();
-    expect((await call(readmeLoader, { plugin: 'demo', '*': 'README.md' })).status).toBe(404);
-  });
 });
 
 describe('the install route', () => {

package/src/shared/lib/workspace/mobile-dock.test.ts

@@ -46,20 +46,14 @@ describe('phoneRightPanels', () => {
 
 describe('phoneLeftStripVisible', () => {
   test('no rail, no strip', () => {
-    expect(phoneLeftStripVisible(false, 2, true)).toBe(false);
+    expect(phoneLeftStripVisible(false)).toBe(false);
   });
 
-  test('a strip holding only Sessions is chrome that never changes', () => {
-    expect(phoneLeftStripVisible(true, 0, true)).toBe(false);
-  });
-
-  test('a placed panel is a second destination, so the strip appears', () => {
-    expect(phoneLeftStripVisible(true, 1, true)).toBe(true);
-  });
-
-  test('a stored view that no longer resolves still gets the strip — its body is a notice', () => {
-    // Without this the drawer would be stuck on a notice with no way back to
-    // the session list: the body has no chips of its own.
-    expect(phoneLeftStripVisible(true, 0, false)).toBe(true);
+  test('the rail being on IS the strip, even with nothing placed', () => {
+    // The bug this pins: the rule used to require a second destination, so the
+    // Settings switch "Show the left activity bar" drew nothing at all on a
+    // phone with no plugin panel placed on the left — a switch whose only
+    // effect was a stored boolean. On a phone the strip is the rail.
+    expect(phoneLeftStripVisible(true)).toBe(true);
   });
 });

package/src/shared/lib/workspace/mobile-dock.ts

@@ -13,6 +13,15 @@
  * the left drawer draws the dock too, so leaving `all` in the right one puts a
  * single panel on two strips of one phone.
  *
+ * **The left drawer's strip follows the rail SWITCH and nothing else.** It used
+ * to need a second destination (a placed panel, or a stored view that no longer
+ * resolves), on the reasoning that a strip holding only `Sessions` is chrome
+ * that never changes. That rule made the Settings switch — "Show the left
+ * activity bar" — a no-op on every phone with no plugin panel placed on the
+ * left: the rail was on, the desktop column drew its `Sessions` button, and the
+ * phone drawer drew nothing, which reads as the switch being broken. On a phone
+ * the strip IS the rail, so it is drawn whenever the rail is on.
+ *
  * Pure, and separate from both components, so the two drawers cannot drift and
  * the rule can be tested without mounting either.
  */
@@ -45,11 +54,11 @@ export function phoneRightPanels<T extends SidedPanel>(
 /**
  * Whether the left drawer draws its chip strip.
  *
- * A strip holding one chip is chrome that never changes, so it needs a second
- * destination — either a placed panel, or a stored view that no longer
- * resolves. The second half is the escape hatch: that body is a notice, and
- * without the strip the session list would be unreachable.
+ * The switch alone: on a phone the strip is the rail, so "Show the left activity
+ * bar" that draws nothing is a control with no effect. The strip holding one
+ * `Sessions` chip is the honest picture of a rail with one view on it — the same
+ * picture the desktop column draws — and it grows the moment a panel is placed.
  */
-export function phoneLeftStripVisible(dockEnabled: boolean, placedCount: number, showingSessions: boolean): boolean {
-  return dockEnabled && (placedCount > 0 || !showingSessions);
+export function phoneLeftStripVisible(dockEnabled: boolean): boolean {
+  return dockEnabled;
 }

package/src/client/components/layout/desktop-layout/left-column.test.tsx

@@ -1,192 +0,0 @@
-/**
- * @license
- * SPDX-License-Identifier: Apache-2.0
- */
-
-/**
- * The left column draws ONE separator, and its chrome spans the WHOLE column.
- *
- * Both `LeftColumn` and `DesktopLayout` rendered a `ResizeHandle` after the
- * dock, and both were mounted — so the column boundary drew two hairlines 3px
- * apart and a reader saw a double rule between the session list and the chat.
- * It was reproduced only when the rail was ON, because that is the layout a
- * screenshotted report came from, though the extra handle was there in both
- * states.
- *
- * A geometry test cannot catch the separator (happy-dom computes no layout), so
- * that assertion is on the STRUCTURE: the group's direct children, in order. The
- * second handle was a sibling — `LeftColumn`'s own sits between the dock and
- * whatever follows — which is exactly what an order comparison shows.
- *
- * The chrome half is structural too, and both cases were reported. The strip
- * lived inside the dock BODY while the rail was a sibling panel, so with the
- * rail on it stopped at the body's left edge and left an empty strip under the
- * rail. And the rail started at the column's top, running up past the title row
- * and under the app's own titlebar. The column is three ROWS — title, then
- * (rail | view), then strip — so both are asserted by the row each one lives in.
- */
-
-import { afterAll, afterEach, beforeEach, describe, expect, test } from 'bun:test';
-import { Window } from 'happy-dom';
-import { h, render } from 'preact';
-import { act } from 'preact/test-utils';
-import { Group } from '@/client/components/layout/desktop-layout/resizer';
-import { LeftColumn } from '@/client/components/layout/desktop-layout/LeftColumn';
-import { SessionStateProvider } from '@/client/components/common/session-state-provider/index';
-import { primeKabmoSettings } from '@/shared/lib/settings/client';
-import { realtimeClient, resetRealtimeClient } from '@/shared/lib/realtime/client';
-import { installDomGlobals, restoreDomGlobals } from '@/test-support/pristine-globals';
-
-let container: HTMLElement | null = null;
-
-/**
- * A socket that never dials.
- *
- * The rail subscribes to the Source Control topic on mount. Left to a REAL
- * socket, its close lands after this file has restored the globals and surfaces
- * as `Unhandled error. (ErrorEvent …)` attributed to whichever suite ran next —
- * measured. This column's subject is its own structure, so the channel is
- * silenced rather than served.
- */
-class SilentSocket {
-  static readonly CLOSING = 2;
-  static readonly CLOSED = 3;
-  readyState = SilentSocket.CLOSED;
-  onopen: (() => void) | null = null;
-  onclose: (() => void) | null = null;
-  onmessage: ((event: { data: string }) => void) | null = null;
-  onerror: (() => void) | null = null;
-  send(): void {}
-  close(): void {}
-}
-
-beforeEach(() => {
-  installDomGlobals(new Window({ url: 'http://127.0.0.1:1' }));
-  realtimeClient.setSocketConstructor(SilentSocket as unknown as typeof WebSocket);
-  primeKabmoSettings({});
-});
-
-afterAll(() => {
-  realtimeClient.setSocketConstructor(null);
-  restoreDomGlobals();
-});
-
-afterEach(() => {
-  // The rail's Source Control dot subscribes to a realtime topic, so the render
-  // opens a socket. Left open, its close lands in the NEXT file's globals once
-  // this one has restored them — measured as `Unhandled error. (ErrorEvent …)`
-  // between tests, attributed to whichever suite happened to run next.
-  resetRealtimeClient();
-  if (container) {
-    render(null, container);
-    container.remove();
-    container = null;
-  }
-  primeKabmoSettings({});
-});
-
-async function mountColumn(railEnabled: boolean) {
-  const host = document.createElement('div');
-  document.body.appendChild(host);
-  container = host;
-
-  await act(async () => {
-    render(
-      h(SessionStateProvider, {
-        sessionId: 'new-separator',
-        children: h(Group, {
-        orientation: 'horizontal',
-        id: 'kabmo-main',
-        children: [
-          h(LeftColumn, {
-            panelRef: { current: null },
-            open: true,
-            railEnabled,
-            view: 'sessions',
-            onSelectView: () => {},
-            onCollapse: () => {},
-            width: 280,
-            minWidth: 264,
-            hasActiveContext: true,
-            refreshKey: 0,
-            onRefresh: () => {},
-            onOpenFile: () => {},
-          }),
-          h('div', { 'data-panel-id': 'main-right-stack' }),
-        ],
-        }),
-      }),
-      host,
-    );
-  });
-  // The dock's view is `lazy()`, so the boundary matters before it resolves:
-  // the separator is a SIBLING of the panel, not part of its content.
-  for (let i = 0; i < 5; i += 1) await act(async () => {});
-}
-
-/** The group's DIRECT children, in order — a separator appears once per entry. */
-const children = (): string[] =>
-  [...(container!.querySelector('[data-panel-group-id="kabmo-main"]')?.children ?? [])].map((child) =>
-    child.hasAttribute('data-separator') ? 'separator' : (child.getAttribute('data-panel-id') ?? child.tagName),
-  );
-
-describe('left column separators', () => {
-  test('one separator with the rail on', async () => {
-    await mountColumn(true);
-    expect(children().filter((entry) => entry === 'separator')).toHaveLength(1);
-  });
-
-  test('one separator with the rail off', async () => {
-    await mountColumn(false);
-    expect(children().filter((entry) => entry === 'separator')).toHaveLength(1);
-  });
-
-  test('the separator is the column boundary — after the dock, not before it', async () => {
-    await mountColumn(true);
-    const kids = children();
-    expect(kids.at(-1)).toBe('main-right-stack');
-    expect(kids.at(-2)).toBe('separator');
-  });
-});
-
-describe('left column chrome', () => {
-  const panel = () => container!.querySelector('[data-panel-id="left-panel"]') as HTMLElement;
-  const rail = () => panel().querySelector('nav[aria-label="Left panel views"]');
-  const title = () => panel().querySelector('.h-10.flex-shrink-0.flex.items-center.justify-between');
-  const footer = () => panel().querySelector('button[aria-label="Settings"]');
-
-  test('the title row, the rail and the strip are three rows, in that order', async () => {
-    await mountColumn(true);
-    const column = panel().firstElementChild as HTMLElement;
-    const rows = [...column.children];
-    expect(rows).toHaveLength(3);
-    // Row 0 is the title, row 1 holds the rail beside the view, row 2 the strip.
-    expect(rows[0].contains(title())).toBe(true);
-    expect(rows[1].contains(rail())).toBe(true);
-    expect(rows[2].contains(footer())).toBe(true);
-  });
-
-  test('the rail starts BELOW the title, never above it', async () => {
-    await mountColumn(true);
-    const column = panel().firstElementChild as HTMLElement;
-    expect(column.children[0].contains(rail())).toBe(false);
-    expect(column.children[1].contains(rail())).toBe(true);
-  });
-
-  test('the strip spans the column, so the rail does not outlive it', async () => {
-    await mountColumn(true);
-    const column = panel().firstElementChild as HTMLElement;
-    expect(column.children[2].contains(rail())).toBe(false);
-    expect(column.children[2].contains(footer())).toBe(true);
-    // Same row container for title and strip: both are full-width rows of the
-    // column, which is what makes the strip run under the rail too.
-    expect(column.children[0].parentElement).toBe(column.children[2].parentElement);
-  });
-
-  test('the strip survives a view that is not the session list', async () => {
-    await mountColumn(true);
-    // The column's furniture is rendered outside `LeftDockView` entirely, so it
-    // is present even while the lazy view is still resolving.
-    expect(footer()).not.toBeNull();
-  });
-});