@kabmo-labs/kabmo 0.28.0 → 0.30.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (232) hide show
  1. package/bunfig.toml +6 -0
  2. package/dist/client/index.html +2 -2
  3. package/dist/client/index.js +481 -472
  4. package/dist/client/static/js/{index-xzvyrxya.js → index-5vjbp04s.js} +1193 -1049
  5. package/dist/client/static/js/index-naa91727.css +1 -0
  6. package/dist/client/static/{manifest-q6h8k9e0.webmanifest → manifest-vdvdqpre.webmanifest} +1 -0
  7. package/package.json +3 -2
  8. package/public/manifest.webmanifest +1 -0
  9. package/src/client/components/common/ComposerTextarea.test.tsx +109 -0
  10. package/src/client/components/common/ComposerTextarea.tsx +6 -0
  11. package/src/client/components/common/ReloadPageButton.test.tsx +14 -0
  12. package/src/client/components/common/ReloadPageButton.tsx +11 -2
  13. package/src/client/components/common/diagram-viewer/read-block.test.ts +71 -0
  14. package/src/client/components/common/diagram-viewer/read-block.ts +40 -16
  15. package/src/client/components/common/file-icon/index.tsx +7 -1
  16. package/src/client/components/common/harness-glyph/brands.ts +7 -1
  17. package/src/client/components/common/image-viewer/index.tsx +37 -165
  18. package/src/client/components/common/picker-search/index.tsx +70 -0
  19. package/src/client/components/common/search-select/index.tsx +2 -7
  20. package/src/client/components/common/zoom-pan-stage/index.tsx +258 -0
  21. package/src/client/components/common/zoom-pan-stage/zoom-pan-stage.test.tsx +87 -0
  22. package/src/client/components/layout/session-sidebar/ClassicView.tsx +1 -1
  23. package/src/client/components/layout/session-sidebar/SessionListNotice.tsx +7 -3
  24. package/src/client/components/layout/session-sidebar/about-modal/HarnessRow.tsx +4 -1
  25. package/src/client/components/layout/session-sidebar/about-modal/HarnessTable.tsx +12 -1
  26. package/src/client/components/layout/session-sidebar/about-modal/UpdateLogLine.test.tsx +82 -0
  27. package/src/client/components/layout/session-sidebar/about-modal/UpdateLogLine.tsx +23 -3
  28. package/src/client/components/layout/session-sidebar/about-modal/index.tsx +1 -0
  29. package/src/client/components/layout/session-sidebar/modern/index.tsx +1 -1
  30. package/src/client/components/layout/session-sidebar/scheduler-modal/TaskList.tsx +6 -4
  31. package/src/client/components/layout/session-sidebar/session-list-states.test.tsx +8 -0
  32. package/src/client/components/mobile/mobile-right-sidebar/EditorSurface.tsx +25 -0
  33. package/src/client/components/mobile/mobile-session-sidebar/ClassicDrawer.tsx +1 -1
  34. package/src/client/components/settings/Sidebar.tsx +6 -8
  35. package/src/client/components/settings/categories/HarnessSettings.tsx +4 -2
  36. package/src/client/components/settings/categories/PanelPluginSettings.tsx +2 -2
  37. package/src/client/components/settings/categories/PluginSettings.tsx +1 -1
  38. package/src/client/components/settings/categories/harness-settings/ConfigForm.tsx +3 -6
  39. package/src/client/components/settings/categories/panel-plugins/GitFreshness.test.tsx +36 -0
  40. package/src/client/components/settings/categories/panel-plugins/Section.tsx +1 -3
  41. package/src/client/components/settings/categories/panel-plugins/Toolbar.tsx +18 -4
  42. package/src/client/components/settings/categories/plugin-settings/MarketplacePane.tsx +64 -61
  43. package/src/client/components/settings/categories/plugin-settings/SidebarList.tsx +15 -4
  44. package/src/client/components/settings/groups.test.tsx +2 -2
  45. package/src/client/components/workspace/chat-timeline/IrcNotice.test.tsx +55 -0
  46. package/src/client/components/workspace/chat-timeline/IrcNotice.tsx +71 -0
  47. package/src/client/components/workspace/chat-timeline/MessageItem.tsx +4 -1
  48. package/src/client/components/workspace/chat-timeline/chat-input/Toolbar.test.ts +19 -0
  49. package/src/client/components/workspace/chat-timeline/chat-input/Toolbar.tsx +8 -3
  50. package/src/client/components/workspace/chat-timeline/chat-input/WaitingDependencyPicker.search.test.tsx +72 -0
  51. package/src/client/components/workspace/chat-timeline/chat-input/WaitingDependencyPicker.tsx +42 -15
  52. package/src/client/components/workspace/chat-timeline/target-picker/ParentSessionPicker.test.tsx +28 -0
  53. package/src/client/components/workspace/chat-timeline/target-picker/ParentSessionPicker.tsx +28 -10
  54. package/src/client/components/workspace/chat-timeline/target-picker/WorkspacePicker.test.tsx +47 -1
  55. package/src/client/components/workspace/chat-timeline/target-picker/WorkspacePicker.tsx +55 -5
  56. package/src/client/components/workspace/chat-timeline/tool-renderers/panels/Wait.tsx +3 -2
  57. package/src/client/components/workspace/editor/FilePane.tsx +32 -0
  58. package/src/client/components/workspace/editor/Toolbar.tsx +4 -0
  59. package/src/client/components/workspace/editor/toolbar-clusters.test.ts +1 -0
  60. package/src/client/components/workspace/editor/toolbar-clusters.tsx +5 -2
  61. package/src/client/components/workspace/editor/viewers/CsvGrid.tsx +52 -5
  62. package/src/client/components/workspace/editor/viewers/DataGrid.tsx +227 -41
  63. package/src/client/components/workspace/editor/viewers/DrawioView.tsx +93 -0
  64. package/src/client/components/workspace/editor/viewers/GridRow.tsx +91 -0
  65. package/src/client/components/workspace/editor/viewers/GridToolbar.tsx +53 -0
  66. package/src/client/components/workspace/editor/viewers/SheetView.tsx +152 -57
  67. package/src/client/components/workspace/editor/viewers/dispatch.tsx +42 -9
  68. package/src/client/components/workspace/editor/viewers/drawio-pages.test.ts +80 -0
  69. package/src/client/components/workspace/editor/viewers/drawio-pages.ts +63 -0
  70. package/src/client/components/workspace/editor/viewers/grid.test.ts +296 -0
  71. package/src/client/components/workspace/editor/viewers/use-cell-edit.ts +64 -0
  72. package/src/client/components/workspace/editor/viewers/use-grid-interaction.ts +216 -0
  73. package/src/client/components/workspace/editor/viewers/viewers.test.ts +47 -2
  74. package/src/client/components/workspace/editor/viewers/workbook.ts +149 -0
  75. package/src/client/components/workspace/file-explorer/ArchiveModals.tsx +262 -0
  76. package/src/client/components/workspace/file-explorer/ContextMenu.tsx +30 -6
  77. package/src/client/components/workspace/file-explorer/Modals.tsx +8 -3
  78. package/src/client/components/workspace/file-explorer/RootOverlays.tsx +60 -0
  79. package/src/client/components/workspace/file-explorer/RowLabel.tsx +6 -2
  80. package/src/client/components/workspace/file-explorer/TreeItem.tsx +39 -49
  81. package/src/client/components/workspace/file-explorer/TreeItemModals.tsx +80 -0
  82. package/src/client/components/workspace/file-explorer/index.tsx +53 -29
  83. package/src/client/components/workspace/file-explorer/selection.test.tsx +109 -0
  84. package/src/client/data/settings/omp-schema.json +169 -22
  85. package/src/client/glass-palette.test.ts +72 -0
  86. package/src/client/glass.css +39 -14
  87. package/src/client/glass.test.ts +28 -67
  88. package/src/client/hooks/chat/composer/history.test.ts +267 -0
  89. package/src/client/hooks/chat/composer/history.ts +146 -0
  90. package/src/client/hooks/chat/timeline/ask-frames.test.ts +54 -0
  91. package/src/client/hooks/chat/timeline/ask-frames.ts +29 -1
  92. package/src/client/hooks/chat/timeline/timeline-rail.test.ts +34 -2
  93. package/src/client/hooks/chat/timeline/user-turns.ts +31 -2
  94. package/src/client/hooks/editor/file-editor-types.ts +15 -0
  95. package/src/client/hooks/editor/save-bytes.ts +79 -0
  96. package/src/client/hooks/editor/use-dirty-tracking.test.ts +73 -0
  97. package/src/client/hooks/editor/use-dirty-tracking.ts +96 -0
  98. package/src/client/hooks/editor/use-file-cache.ts +1 -0
  99. package/src/client/hooks/editor/use-file-editor.test.ts +30 -0
  100. package/src/client/hooks/editor/use-file-editor.ts +20 -17
  101. package/src/client/hooks/editor/use-file-read.ts +21 -2
  102. package/src/client/hooks/editor/use-grid-selection.ts +160 -0
  103. package/src/client/hooks/models/use-harness-update.test.ts +35 -2
  104. package/src/client/hooks/models/use-harness-update.ts +49 -10
  105. package/src/client/hooks/workspace/diff-file.test.ts +72 -0
  106. package/src/client/hooks/workspace/diff-file.ts +12 -6
  107. package/src/client/hooks/workspace/file-archive.ts +220 -0
  108. package/src/client/hooks/workspace/file-clipboard.test.ts +4 -4
  109. package/src/client/hooks/workspace/file-clipboard.ts +37 -26
  110. package/src/client/hooks/workspace/file-selection.test.ts +67 -0
  111. package/src/client/hooks/workspace/file-selection.ts +156 -0
  112. package/src/client/hooks/workspace/file-tree-actions-clipboard.test.ts +5 -5
  113. package/src/client/hooks/workspace/file-tree-actions.ts +36 -8
  114. package/src/client/lib/editor/workbook-drafts.ts +42 -0
  115. package/src/client/lib/launch/file-handlers.ts +2 -2
  116. package/src/client/lib/scrollbar-activity.test.ts +21 -88
  117. package/src/client/lib/scrollbar-activity.ts +71 -73
  118. package/src/client/lib/scrollbar-events.ts +143 -0
  119. package/src/client/lib/scrollbar-input.test.ts +126 -0
  120. package/src/client/lib/scrollbar-probe.test-util.ts +107 -0
  121. package/src/client/tailwind.css +32 -1
  122. package/src/server/db.server.test.ts +50 -1
  123. package/src/server/db.server.ts +36 -3
  124. package/src/server/lib/chat/prompt-history.server.test.ts +92 -0
  125. package/src/server/lib/chat/prompt-history.server.ts +65 -0
  126. package/src/server/lib/chat/schema.server.ts +35 -0
  127. package/src/server/lib/db/schema.ts +3 -0
  128. package/src/server/lib/fs/archive.test.ts +198 -0
  129. package/src/server/lib/fs/archive.ts +278 -0
  130. package/src/server/lib/fs/git-diff.test.ts +26 -1
  131. package/src/server/lib/fs/git-diff.ts +43 -15
  132. package/src/server/lib/harness/launch-table.ts +19 -0
  133. package/src/server/lib/harness/provider-entry.ts +1 -1
  134. package/src/server/lib/harness/provider-file.server.ts +1 -1
  135. package/src/server/lib/harness/provider-sources.server.ts +2 -1
  136. package/src/server/lib/harness/provider-write.server.ts +2 -1
  137. package/src/server/lib/harness/update-job-store.ts +12 -0
  138. package/src/server/lib/harness/update-queue.server.ts +15 -10
  139. package/src/server/lib/omp/rpc/frame-fold-signals.test.ts +5 -1
  140. package/src/server/lib/omp/rpc/frame-fold.test.ts +5 -1
  141. package/src/server/lib/omp/rpc/lifecycle.test.ts +4 -0
  142. package/src/server/lib/omp/session/auto-title.server.test.ts +4 -0
  143. package/src/server/lib/omp/session/delete.server.ts +1 -0
  144. package/src/server/lib/omp/session/goal-driver.test.ts +5 -1
  145. package/src/server/lib/omp/session/goal-settings.test.ts +5 -1
  146. package/src/server/lib/panels/auto-update.server.test.ts +5 -2
  147. package/src/server/lib/panels/git-update.server.test.ts +5 -2
  148. package/src/server/lib/panels/install.server.test.ts +5 -2
  149. package/src/server/lib/panels/remove.server.test.ts +5 -2
  150. package/src/server/routes/agent/command.ts +11 -0
  151. package/src/server/routes/agent/new.ts +5 -0
  152. package/src/server/routes/chat/index.ts +5 -0
  153. package/src/server/routes/chat/prompt-history.test.ts +67 -0
  154. package/src/server/routes/chat/prompt-history.ts +31 -0
  155. package/src/server/routes/chat/stream.test.ts +21 -0
  156. package/src/server/routes/chat/stream.ts +5 -0
  157. package/src/server/routes/fs/action-archive.test.ts +128 -0
  158. package/src/server/routes/fs/action-bulk.ts +106 -0
  159. package/src/server/routes/fs/action-save-bytes.test.ts +59 -0
  160. package/src/server/routes/fs/action-transfer.test.ts +26 -0
  161. package/src/server/routes/fs/action.ts +91 -11
  162. package/src/server/routes/fs/archive.ts +20 -0
  163. package/src/server/routes/fs/grant.test.ts +5 -2
  164. package/src/server/routes/fs/index.ts +2 -0
  165. package/src/server/routes/fs/scope.test.ts +6 -2
  166. package/src/server/routes/harness/import-action.ts +1 -1
  167. package/src/server/routes/harness/root.ts +6 -1
  168. package/src/server/routes/harness/summary.test.ts +50 -0
  169. package/src/server/routes/harness/update-status.ts +41 -2
  170. package/src/server/routes/harness/update.test.ts +56 -2
  171. package/src/server/routes/sessions/delete.test.ts +4 -0
  172. package/src/shared/lib/chat/ask-form/index.ts +39 -31
  173. package/src/shared/lib/chat/ask-form/labels.ts +46 -0
  174. package/src/shared/lib/chat/ask-form/tokens.ts +11 -2
  175. package/src/shared/lib/chat/ask-form.test.ts +57 -0
  176. package/src/shared/lib/chat/ask-questions.ts +31 -0
  177. package/src/shared/lib/chat/composer/history.test.ts +67 -0
  178. package/src/shared/lib/chat/composer/history.ts +61 -0
  179. package/src/shared/lib/chat/irc-notice.ts +42 -0
  180. package/src/shared/lib/chat/timeline/fork-anchor.test.ts +2 -0
  181. package/src/shared/lib/chat/todo/parser.ts +6 -4
  182. package/src/shared/lib/fs/archive.test.ts +101 -0
  183. package/src/shared/lib/fs/archive.ts +191 -0
  184. package/src/shared/lib/fs/clipboard.test.ts +32 -7
  185. package/src/shared/lib/fs/clipboard.ts +59 -14
  186. package/src/shared/lib/fs/csv.test.ts +50 -0
  187. package/src/shared/lib/fs/csv.ts +40 -0
  188. package/src/shared/lib/fs/document-kind.test.ts +13 -6
  189. package/src/shared/lib/fs/document-kind.ts +18 -6
  190. package/src/shared/lib/fs/file-kind-classify.test.ts +4 -0
  191. package/src/shared/lib/fs/file-kind.test.ts +2 -7
  192. package/src/shared/lib/fs/file-kind.ts +4 -2
  193. package/src/shared/lib/fs/grid-edit.test.ts +24 -0
  194. package/src/shared/lib/fs/grid-edit.ts +29 -0
  195. package/src/shared/lib/fs/grid-selection.test.ts +137 -0
  196. package/src/shared/lib/fs/grid-selection.ts +138 -0
  197. package/src/shared/lib/harness/brand-color.ts +5 -0
  198. package/src/shared/lib/harness/catalog.test.ts +22 -0
  199. package/src/shared/lib/harness/catalog.ts +12 -1
  200. package/src/shared/lib/harness/config-fields.test.ts +25 -0
  201. package/src/shared/lib/harness/config-fields.ts +33 -3
  202. package/src/shared/lib/harness/dialects.ts +1 -1
  203. package/src/shared/lib/harness/mcp-facts.ts +4 -0
  204. package/src/shared/lib/harness/provider-contracts.ts +109 -0
  205. package/src/shared/lib/harness/provider-facts.test.ts +2 -1
  206. package/src/shared/lib/harness/provider-facts.ts +24 -115
  207. package/src/shared/lib/harness/provider-lookup.ts +37 -0
  208. package/src/shared/lib/harness/providers.ts +2 -1
  209. package/src/shared/lib/harness/updates.ts +10 -0
  210. package/src/shared/lib/icons/tint-hues.generated.ts +14 -13
  211. package/src/shared/lib/omp/session/mapper.test.ts +31 -0
  212. package/src/shared/lib/omp/session/mapper.ts +17 -0
  213. package/src/shared/lib/omp/session/messages-map-notice.test.ts +68 -0
  214. package/src/shared/lib/omp/session/messages-map.test.ts +1 -35
  215. package/src/shared/lib/omp/session/messages-map.ts +17 -0
  216. package/src/shared/lib/omp/session/wait.ts +10 -1
  217. package/src/shared/lib/settings/sections.ts +8 -4
  218. package/src/shared/lib/ui/picker-filter.test.ts +23 -0
  219. package/src/shared/lib/ui/picker-filter.ts +20 -0
  220. package/src/shared/types/chat.ts +4 -0
  221. package/src/shared/types/harness.ts +5 -1
  222. package/src/shared/types/omp/session.ts +18 -0
  223. package/src/shared/types/settings/state.ts +6 -6
  224. package/src/shared/types/todo.ts +3 -1
  225. package/src/test-support/file-actions.test-util.ts +4 -0
  226. package/src/test-support/file-archive.test-util.ts +41 -0
  227. package/src/test-support/file-clipboard.test-util.ts +9 -6
  228. package/src/test-support/file-editor.test-util.ts +3 -2
  229. package/src/test-support/glass-css.ts +30 -0
  230. package/src/test-support/harness-table.test-util.ts +2 -0
  231. package/src/test-support/preload.ts +46 -0
  232. package/dist/client/static/js/index-81f7berm.css +0 -1
@@ -0,0 +1,91 @@
1
+ /**
2
+ * @license
3
+ * SPDX-License-Identifier: MIT
4
+ */
5
+
6
+ /**
7
+ * One data row of the spreadsheet grid, memoised.
8
+ *
9
+ * The memo is the reason this is a component at all: a 2000-row sheet is
10
+ * 200 000 cells, and a selection change touches only the rows inside the old
11
+ * and new rectangles. Without the memo every pointer move re-rendered the whole
12
+ * table, which is what made dragging a selection feel like the panel had hung.
13
+ * The props are deliberately primitives plus the row's own array, so the
14
+ * shallow compare is exact.
15
+ *
16
+ * Pointer events are NOT handled here: the grid delegates them from one
17
+ * listener and reads `data-row`/`data-col` off the target, so no cell mounts a
18
+ * closure.
19
+ */
20
+
21
+ import { memo } from 'preact/compat';
22
+
23
+ export interface GridRowProps {
24
+ cells: readonly string[];
25
+ rowIndex: number;
26
+ /** First selected column in this row, or -1 when the row is outside the range. */
27
+ selectedLeft: number;
28
+ /** Last selected column in this row, or -1. */
29
+ selectedRight: number;
30
+ /** The active cell's column when it is in this row, else -1. */
31
+ activeCol: number;
32
+ /** The column being edited in this row, else -1. */
33
+ editingCol: number;
34
+ /** The draft text of the cell being edited. */
35
+ editingValue: string;
36
+ }
37
+
38
+ export const GridRow = memo(function GridRow({
39
+ cells,
40
+ rowIndex,
41
+ selectedLeft,
42
+ selectedRight,
43
+ activeCol,
44
+ editingCol,
45
+ editingValue,
46
+ }: GridRowProps) {
47
+ const rowSelected = selectedLeft >= 0;
48
+ return (
49
+ <tr className="odd:bg-ink/[0.02]">
50
+ <th
51
+ data-row-header={rowIndex}
52
+ className={`cursor-pointer border-b border-r border-ink/10 px-2 py-0.5 text-right font-normal tabular-nums ${
53
+ rowSelected ? 'bg-info/10 text-ink/60' : 'text-ink/30'
54
+ }`}
55
+ title={`Select row ${rowIndex + 1}`}
56
+ >
57
+ {rowIndex + 1}
58
+ </th>
59
+ {cells.map((cell, col) => {
60
+ const inRange = rowSelected && col >= selectedLeft && col <= selectedRight;
61
+ const isActive = col === activeCol;
62
+ const isEditing = col === editingCol;
63
+ return (
64
+ <td
65
+ key={col}
66
+ data-row={rowIndex}
67
+ data-col={col}
68
+ title={cell}
69
+ className={`cursor-cell border-b border-ink/10 px-2 py-0.5 text-ink ${
70
+ inRange ? 'bg-info/10' : ''
71
+ } ${isActive ? 'ring-1 ring-inset ring-info' : ''}`}
72
+ >
73
+ {isEditing ? (
74
+ // The editor is an input INSIDE the cell, so the grid keeps its
75
+ // geometry while a value is typed. `data-edit-input` is how the
76
+ // grid's delegated handlers find it.
77
+ <input
78
+ data-edit-input="true"
79
+ value={editingValue}
80
+ spellcheck={false}
81
+ className="w-full min-w-0 bg-transparent font-mono text-[11px] text-ink outline-none"
82
+ />
83
+ ) : (
84
+ <span className="block truncate">{cell}</span>
85
+ )}
86
+ </td>
87
+ );
88
+ })}
89
+ </tr>
90
+ );
91
+ });
@@ -0,0 +1,53 @@
1
+ /**
2
+ * @license
3
+ * SPDX-License-Identifier: MIT
4
+ */
5
+
6
+ /**
7
+ * The strip above the grid: the selection's address, whatever the caller adds
8
+ * (a workbook's Save), and the copy button.
9
+ *
10
+ * Split from `DataGrid` so the grid's own file stays under the repository's
11
+ * line ceiling, and because the strip is the one part of the grid that is pure
12
+ * presentation — it owns no selection and no clipboard state.
13
+ */
14
+
15
+ import type { ComponentChildren } from 'preact';
16
+ import { Check, Copy } from 'lucide-preact';
17
+
18
+ export type CopyState = 'idle' | 'copied' | 'failed' | 'refused';
19
+
20
+ interface GridToolbarProps {
21
+ /** The selection's address and size, or the empty-selection hint. */
22
+ status: string;
23
+ /** A refusal or a warning is drawn in the warning colour. */
24
+ tone?: 'muted' | 'warning';
25
+ /** Caller-owned controls, drawn before the copy button. */
26
+ actions?: ComponentChildren;
27
+ canCopy: boolean;
28
+ copyState: CopyState;
29
+ onCopy: () => void;
30
+ }
31
+
32
+ export function GridToolbar({ status, tone = 'muted', actions, canCopy, copyState, onCopy }: GridToolbarProps) {
33
+ return (
34
+ <div className="flex shrink-0 items-center justify-between gap-2 border-b border-ink/10 bg-canvas px-2 py-1 font-sans text-[11px]">
35
+ <span className={`truncate ${tone === 'warning' ? 'text-warning' : 'text-ink/50'}`}>{status}</span>
36
+ <div className="flex shrink-0 items-center gap-2">
37
+ {actions}
38
+ <button
39
+ type="button"
40
+ onClick={onCopy}
41
+ disabled={!canCopy}
42
+ title="Copy the selected cells as tab-separated text"
43
+ className={`flex items-center gap-1 rounded px-1.5 py-0.5 transition-colors ${
44
+ canCopy ? 'text-ink/60 hover:bg-ink/5 hover:text-ink' : 'cursor-default text-ink/25'
45
+ } ${copyState === 'failed' ? 'text-error' : ''}`}
46
+ >
47
+ {copyState === 'copied' ? <Check size={12} /> : <Copy size={12} />}
48
+ <span>{copyState === 'copied' ? 'Copied' : copyState === 'failed' ? 'Copy failed' : 'Copy'}</span>
49
+ </button>
50
+ </div>
51
+ </div>
52
+ );
53
+ }
@@ -4,67 +4,89 @@
4
4
  */
5
5
 
6
6
  /**
7
- * A workbook (`.xlsx` / `.xlsm`), drawn as a grid with one tab per sheet.
7
+ * A workbook (`.xlsx`, `.xlsm` or legacy `.xls`), drawn as a grid with one tab
8
+ * per sheet.
8
9
  *
9
- * `read-excel-file` rather than SheetJS: it is 55 KB minified for the browser
10
- * entry (SheetJS is 332 KB, and its `xlsx` package on npm is a stale 0.18.5
11
- * with a published advisory), it reads straight from an `ArrayBuffer`, and its
12
- * per-sheet API is exactly the shape a tabbed viewer needs. The whole library
13
- * is reached through the sheet's own static import, so a session that never
14
- * opens a workbook never downloads it.
10
+ * The reader and the writer live in `workbook.ts` (SheetJS, which is the only
11
+ * maintained reader for the legacy BIFF format); this file is the surface: the
12
+ * tab strip, the loading and failure states, the grid, and the save.
15
13
  *
16
- * Values arrive already typed (numbers as numbers, dates as `Date`), so they are
17
- * formatted here rather than parsed: a cell is rendered as the string a
18
- * spreadsheet shows — `true`/`false` for booleans, an ISO date, a number in
19
- * locale form. A formula's cached value is what the reader returns, which is
20
- * what the user sees in Excel too.
14
+ * **Editing is a draft, not a write.** A cell edit goes into the reader's own
15
+ * workbook and into a draft keyed by the file, so switching tabs does not lose
16
+ * it; Save serializes the workbook back into its container and writes the bytes
17
+ * through the tab's own save path. The draft is dropped when the save lands, so
18
+ * a later open re-reads the disk.
21
19
  *
22
- * Read-only: the library reads workbooks, it does not write them, so there is
23
- * no Save and the toolbar hides the write controls for this kind.
20
+ * The tab strip is drawn even for a one-sheet workbook. It is the sheet's NAME
21
+ * — the one piece of the workbook's own structure the grid cannot show — and a
22
+ * strip that appears only at two sheets made the first sheet look like the
23
+ * whole file.
24
+ *
25
+ * **Saving is lossy in one direction, and the surface says so.** SheetJS writes
26
+ * values, formulas and number formats; styling, charts, images and pivot tables
27
+ * are not part of what it reads, so they do not survive a rewrite. The warning
28
+ * is drawn while the workbook is dirty, before the user presses Save.
24
29
  */
25
30
 
26
31
  import { Loader2 } from 'lucide-preact';
27
- import { useState } from 'preact/hooks';
28
- import readXlsxFile from 'read-excel-file/browser';
32
+ import { useEffect, useRef, useState } from 'preact/hooks';
29
33
  import type { ByteSource } from '@/client/components/workspace/editor/viewers/bytes';
30
34
  import { useByteDocument } from '@/client/components/workspace/editor/viewers/use-byte-document';
31
35
  import { ViewerError } from '@/client/components/workspace/editor/viewers/ViewerError';
32
- import { MAX_CSV_COLUMNS, MAX_CSV_ROWS } from '@/shared/lib/fs/csv';
33
- import { DataGrid, type GridCell } from '@/client/components/workspace/editor/viewers/DataGrid';
36
+ import { DataGrid } from '@/client/components/workspace/editor/viewers/DataGrid';
37
+ import { readWorkbook, setWorkbookCell, writeWorkbook, type LoadedWorkbook } from '@/client/components/workspace/editor/viewers/workbook';
38
+ import { draftFor, forgetDraft, rememberDraft } from '@/client/lib/editor/workbook-drafts';
39
+ import { replaceCell } from '@/shared/lib/fs/grid-edit';
34
40
 
35
41
  interface SheetViewProps {
36
42
  source: ByteSource;
37
43
  name: string;
44
+ /** The tab's path, which keys the draft and names the container. */
45
+ path?: string;
38
46
  revision?: number;
47
+ /** Write the edited bytes; absent means the workbook is read-only. */
48
+ onSaveBytes?: (bytes: Uint8Array) => Promise<{ ok: boolean; error?: string | null }>;
49
+ /** Tell the tab whether unsaved edits exist, so closing it can warn. */
50
+ onDirtyChange?: (dirty: boolean) => void;
39
51
  }
40
52
 
41
- /** A sheet as the grid draws it: a header row and typed data rows. */
42
- interface WorkbookSheet {
43
- name: string;
44
- rows: GridCell[][];
45
- }
53
+ type SaveState = 'idle' | 'saving' | 'saved' | 'failed';
46
54
 
47
- /** The string a spreadsheet cell shows, from the typed value the reader returns. */
48
- function cellText(value: unknown): string {
49
- if (value === null || value === undefined) return '';
50
- if (value instanceof Date) return value.toISOString().slice(0, 10);
51
- if (typeof value === 'boolean') return value ? 'TRUE' : 'FALSE';
52
- return String(value);
53
- }
55
+ export function SheetView({ source, name, path, revision = 0, onSaveBytes, onDirtyChange }: SheetViewProps) {
56
+ // The byte source's id is the file's identity (a raw URL or a handle id), so
57
+ // two dropped files that happen to share a name do not share a draft.
58
+ const key = source.id || path || name;
59
+ const { value, loading, error } = useByteDocument(source, (bytes) => readWorkbook(bytes, name), revision);
60
+ const [local, setLocal] = useState<LoadedWorkbook | null>(null);
61
+ const [dirty, setDirty] = useState(() => Boolean(draftFor(key)?.dirty));
62
+ const [saveState, setSaveState] = useState<SaveState>('idle');
63
+ const [saveError, setSaveError] = useState<string | null>(null);
64
+ const [active, setActive] = useState(0);
54
65
 
55
- async function readWorkbook(bytes: ArrayBuffer): Promise<WorkbookSheet[]> {
56
- const sheets = await readXlsxFile(bytes);
57
- return sheets.map((sheet) => ({
58
- name: sheet.sheet,
59
- rows: sheet.data
60
- .slice(0, MAX_CSV_ROWS + 1)
61
- .map((row) => row.slice(0, MAX_CSV_COLUMNS).map(cellText)),
62
- }));
63
- }
66
+ // A fresh read replaces this mount's copy. A draft is NOT replaced: it is the
67
+ // user's unsaved work, and the read that just landed is the older disk copy.
68
+ useEffect(() => {
69
+ setLocal(null);
70
+ }, [value]);
64
71
 
65
- export function SheetView({ source, name, revision = 0 }: SheetViewProps) {
66
- const { value, loading, error } = useByteDocument(source, readWorkbook, revision);
67
- const [active, setActive] = useState(0);
72
+ useEffect(() => {
73
+ if (saveState !== 'saved') return;
74
+ const timer = setTimeout(() => setSaveState('idle'), 1500);
75
+ return () => clearTimeout(timer);
76
+ }, [saveState]);
77
+
78
+ // The tab's dirty flag follows this viewer's, including on mount: a draft
79
+ // that survived a tab switch is still unsaved work, and the close guard has
80
+ // to know that even if the flag was cleared when the tab was closed.
81
+ //
82
+ // The callback is read through a ref so the effect keys on `dirty` alone — a
83
+ // caller passing an inline arrow would otherwise re-report the same value on
84
+ // every render.
85
+ const dirtyCallbackRef = useRef(onDirtyChange);
86
+ dirtyCallbackRef.current = onDirtyChange;
87
+ useEffect(() => {
88
+ dirtyCallbackRef.current?.(dirty);
89
+ }, [dirty]);
68
90
 
69
91
  if (error) return <ViewerError name={name} message={error} />;
70
92
  if (loading || value === null) {
@@ -76,7 +98,8 @@ export function SheetView({ source, name, revision = 0 }: SheetViewProps) {
76
98
  );
77
99
  }
78
100
 
79
- const sheet = value[Math.min(active, value.length - 1)];
101
+ const workbook = local ?? draftFor(key)?.workbook ?? value;
102
+ const sheet = workbook.sheets[Math.min(active, workbook.sheets.length - 1)];
80
103
  if (!sheet) {
81
104
  return (
82
105
  <div className="flex flex-1 items-center justify-center px-6 text-center text-xs text-ink/50">
@@ -85,6 +108,37 @@ export function SheetView({ source, name, revision = 0 }: SheetViewProps) {
85
108
  );
86
109
  }
87
110
 
111
+ const editable = onSaveBytes !== undefined;
112
+
113
+ const applyEdit = (row: number, col: number, text: string) => {
114
+ setWorkbookCell(workbook.book, sheet.name, row, col, text);
115
+ const next: LoadedWorkbook = {
116
+ ...workbook,
117
+ sheets: workbook.sheets.map((entry, index) =>
118
+ index === active ? { ...entry, rows: replaceCell(entry.rows, row, col, text) } : entry,
119
+ ),
120
+ };
121
+ setLocal(next);
122
+ rememberDraft(key, { workbook: next, dirty: true });
123
+ setDirty(true);
124
+ };
125
+
126
+ const save = async () => {
127
+ if (!onSaveBytes) return;
128
+ setSaveState('saving');
129
+ setSaveError(null);
130
+ const outcome = await onSaveBytes(writeWorkbook(workbook.book, workbook.format));
131
+ if (outcome.ok) {
132
+ setSaveState('saved');
133
+ setDirty(false);
134
+ forgetDraft(key);
135
+ setLocal(workbook);
136
+ } else {
137
+ setSaveState('failed');
138
+ setSaveError(outcome.error ?? null);
139
+ }
140
+ };
141
+
88
142
  const [header = [], ...rows] = sheet.rows;
89
143
 
90
144
  return (
@@ -92,24 +146,65 @@ export function SheetView({ source, name, revision = 0 }: SheetViewProps) {
92
146
  {/* Sheet tabs: a workbook's own navigation. One row, scrolled sideways on
93
147
  a narrow panel rather than wrapped — a tab strip is a single line by
94
148
  definition, and wrapping it would shift the grid down per sheet count. */}
95
- {value.length > 1 && (
96
- <div className="flex shrink-0 items-center gap-1 overflow-x-auto border-b border-ink/10 bg-canvas px-2 py-1 no-scrollbar">
97
- {value.map((entry, index) => (
149
+ <div
150
+ role="tablist"
151
+ aria-label="Sheets"
152
+ className="flex shrink-0 items-center gap-1 overflow-x-auto border-b border-ink/10 bg-canvas px-2 py-1 no-scrollbar"
153
+ >
154
+ {workbook.sheets.map((entry, index) => (
155
+ <button
156
+ key={entry.name}
157
+ type="button"
158
+ role="tab"
159
+ aria-selected={index === active}
160
+ onClick={() => setActive(index)}
161
+ className={`shrink-0 rounded px-2 py-0.5 font-sans text-[11px] transition-colors ${
162
+ index === active ? 'bg-ink/10 text-ink' : 'text-ink/50 hover:bg-ink/5 hover:text-ink'
163
+ }`}
164
+ >
165
+ {entry.name}
166
+ </button>
167
+ ))}
168
+ </div>
169
+ {dirty && (
170
+ <div className="shrink-0 border-b border-warning/30 bg-warning/10 px-3 py-1 font-sans text-[11px] text-warning">
171
+ {saveState === 'failed'
172
+ ? (saveError ?? 'Could not save the workbook.')
173
+ : 'Saving rewrites the workbook: values and formulas are kept, styling and charts are not.'}
174
+ </div>
175
+ )}
176
+ {/* Keyed by sheet: a selection belongs to the sheet it was made on, and
177
+ carrying it across a tab switch would highlight cells the user never
178
+ picked. */}
179
+ <DataGrid
180
+ key={sheet.name}
181
+ header={header}
182
+ rows={rows}
183
+ truncated={sheet.truncated}
184
+ label={sheet.name}
185
+ readOnlyNote={
186
+ editable
187
+ ? 'Paste is not supported — double-click a cell to edit it.'
188
+ : 'This workbook is read-only — the viewer cannot write workbooks.'
189
+ }
190
+ onEditCell={editable ? (row, col, text) => applyEdit(row + 1, col, text) : undefined}
191
+ onEditHeader={editable ? (col, text) => applyEdit(0, col, text) : undefined}
192
+ actions={
193
+ editable ? (
98
194
  <button
99
- key={entry.name}
100
195
  type="button"
101
- onClick={() => setActive(index)}
102
- className={`shrink-0 rounded px-2 py-0.5 font-sans text-[11px] transition-colors ${
103
- index === active ? 'bg-ink/10 text-ink' : 'text-ink/50 hover:bg-ink/5 hover:text-ink'
104
- }`}
105
- aria-pressed={index === active}
196
+ onClick={() => void save()}
197
+ disabled={!dirty || saveState === 'saving'}
198
+ title="Write the edited workbook back to disk"
199
+ className={`rounded px-1.5 py-0.5 transition-colors ${
200
+ dirty ? 'text-ink/70 hover:bg-ink/5 hover:text-ink' : 'cursor-default text-ink/25'
201
+ } ${saveState === 'failed' ? 'text-error' : ''}`}
106
202
  >
107
- {entry.name}
203
+ {saveState === 'saving' ? 'Saving…' : saveState === 'saved' ? 'Saved' : saveState === 'failed' ? 'Save failed' : 'Save'}
108
204
  </button>
109
- ))}
110
- </div>
111
- )}
112
- <DataGrid header={header} rows={rows} truncated={sheet.rows.length > MAX_CSV_ROWS} />
205
+ ) : undefined
206
+ }
207
+ />
113
208
  </div>
114
209
  );
115
210
  }
@@ -13,11 +13,10 @@
13
13
  * the same bytes the code surface already has, and the eye toggle switches
14
14
  * between them with no second fetch.
15
15
  *
16
- * Every viewer is `lazy()` at MODULE scope, so its library (mammoth,
17
- * read-excel-file) stays in its own chunk and a session that never opens a
18
- * document never downloads one. Module scope matters: a `lazy()` created in a
19
- * render body is a new component type on every render, which remounts the
20
- * viewer — and the parse — each time.
16
+ * Every viewer is `lazy()` at MODULE scope, so its library (mammoth, SheetJS)
17
+ * is only evaluated when a viewer mounts. Module scope matters: a `lazy()`
18
+ * created in a render body is a new component type on every render, which
19
+ * remounts the viewer — and the parse — each time.
21
20
  */
22
21
 
23
22
  import { Suspense, lazy } from 'preact/compat';
@@ -43,6 +42,9 @@ const SvgPreview = lazy(() =>
43
42
  const ImageView = lazy(() =>
44
43
  import('@/client/components/workspace/editor/viewers/ImageView').then((m) => ({ default: m.ImageView })),
45
44
  );
45
+ const DrawioView = lazy(() =>
46
+ import('@/client/components/workspace/editor/viewers/DrawioView').then((m) => ({ default: m.DrawioView })),
47
+ );
46
48
 
47
49
  /** What a viewer is handed: the file's identity, its bytes and its text. */
48
50
  export interface ViewerProps {
@@ -56,6 +58,12 @@ export interface ViewerProps {
56
58
  content: string;
57
59
  /** Bumped to force a re-parse (a workspace refresh). */
58
60
  revision: number;
61
+ /** Write an edited TEXT buffer back (the CSV grid's cells are text). */
62
+ onContentChange?: (next: string) => void;
63
+ /** Write edited BYTES back (the workbook grid has no text buffer). */
64
+ onSaveBytes?: (bytes: Uint8Array) => Promise<{ ok: boolean; error?: string | null }>;
65
+ /** Report unsaved binary edits so the tab can warn before closing. */
66
+ onDirtyChange?: (dirty: boolean) => void;
59
67
  }
60
68
 
61
69
  /** Whether a file's kind is drawn by a viewer here rather than by the pane. */
@@ -66,7 +74,8 @@ export function hasViewerSurface(kind: ViewerKind): boolean {
66
74
  kind === 'docx' ||
67
75
  kind === 'spreadsheet' ||
68
76
  kind === 'csv' ||
69
- kind === 'svg'
77
+ kind === 'svg' ||
78
+ kind === 'drawio'
70
79
  );
71
80
  }
72
81
 
@@ -83,7 +92,17 @@ function Loading() {
83
92
  * The viewer for `kind`, or null when the kind has no rendered surface here
84
93
  * (code, markdown and image are each drawn by the pane itself).
85
94
  */
86
- export function ViewerSurface({ kind, path, name, source, content, revision }: ViewerProps) {
95
+ export function ViewerSurface({
96
+ kind,
97
+ path,
98
+ name,
99
+ source,
100
+ content,
101
+ revision,
102
+ onContentChange,
103
+ onSaveBytes,
104
+ onDirtyChange,
105
+ }: ViewerProps) {
87
106
  if (kind === 'image') {
88
107
  return (
89
108
  <Suspense fallback={<Loading />}>
@@ -108,14 +127,21 @@ export function ViewerSurface({ kind, path, name, source, content, revision }: V
108
127
  if (kind === 'spreadsheet') {
109
128
  return (
110
129
  <Suspense fallback={<Loading />}>
111
- <SheetView source={source} name={name} revision={revision} />
130
+ <SheetView
131
+ source={source}
132
+ name={name}
133
+ path={path}
134
+ revision={revision}
135
+ onSaveBytes={onSaveBytes}
136
+ onDirtyChange={onDirtyChange}
137
+ />
112
138
  </Suspense>
113
139
  );
114
140
  }
115
141
  if (kind === 'csv') {
116
142
  return (
117
143
  <Suspense fallback={<Loading />}>
118
- <CsvGrid content={content} path={path} />
144
+ <CsvGrid content={content} path={path} onChange={onContentChange} />
119
145
  </Suspense>
120
146
  );
121
147
  }
@@ -126,5 +152,12 @@ export function ViewerSurface({ kind, path, name, source, content, revision }: V
126
152
  </Suspense>
127
153
  );
128
154
  }
155
+ if (kind === 'drawio') {
156
+ return (
157
+ <Suspense fallback={<Loading />}>
158
+ <DrawioView content={content} name={name} />
159
+ </Suspense>
160
+ );
161
+ }
129
162
  return null;
130
163
  }
@@ -0,0 +1,80 @@
1
+ /**
2
+ * @license
3
+ * SPDX-License-Identifier: MIT
4
+ */
5
+
6
+ /**
7
+ * The drawio adapter: what Kabmo decides around the library's rendering.
8
+ *
9
+ * Pure — the library is string → string and needs no DOM — so these run under
10
+ * `bun test` unchanged. The claims are the ones that fail silently: a five-page
11
+ * document showing only page one, a refusal rendered as a blank page, and a
12
+ * placeholder drawn without saying so.
13
+ */
14
+
15
+ import { describe, expect, test } from 'bun:test';
16
+ import { renderDrawioPages } from '@/client/components/workspace/editor/viewers/drawio-pages';
17
+
18
+ const page = (name: string, label: string, style = '') =>
19
+ `<diagram name="${name}"><mxGraphModel><root><mxCell id="0"/><mxCell id="1" parent="0"/>` +
20
+ `<mxCell id="a" value="${label}" ${style ? `style="${style}" ` : ''}vertex="1" parent="1">` +
21
+ `<mxGeometry x="0" y="0" width="80" height="40" as="geometry"/></mxCell>` +
22
+ `</root></mxGraphModel></diagram>`;
23
+
24
+ describe('renderDrawioPages', () => {
25
+ test('draws every page in document order', () => {
26
+ const result = renderDrawioPages(`<mxfile>${page('One', 'First')}${page('Two', 'Second')}</mxfile>`, 'p-');
27
+ expect(result.status).toBe('ready');
28
+ if (result.status !== 'ready') return;
29
+ expect(result.pages.map((p) => p.name)).toEqual(['One', 'Two']);
30
+ expect(result.pages[0].svg).toContain('First');
31
+ expect(result.pages[1].svg).toContain('Second');
32
+ });
33
+
34
+ test('names an unnamed page by its position', () => {
35
+ const result = renderDrawioPages('<mxfile><diagram><mxGraphModel><root><mxCell id="0"/></root></mxGraphModel></diagram></mxfile>', 'p-');
36
+ expect(result.status).toBe('ready');
37
+ if (result.status !== 'ready') return;
38
+ expect(result.pages[0].name).toBe('Page 1');
39
+ });
40
+
41
+ // A shared id namespace makes the second SVG's `url(#…)` resolve to the
42
+ // first one's definitions.
43
+ test('namespaces ids per page and per mount', () => {
44
+ const first = renderDrawioPages(`<mxfile>${page('One', 'A')}</mxfile>`, 'x-');
45
+ const second = renderDrawioPages(`<mxfile>${page('One', 'A')}</mxfile>`, 'y-');
46
+ if (first.status !== 'ready' || second.status !== 'ready') throw new Error('expected pages');
47
+ expect(first.pages[0].svg).toContain('id="x-0-');
48
+ expect(second.pages[0].svg).toContain('id="y-0-');
49
+ });
50
+
51
+ // The refusal is REPORTED with the parser's own sentence, never drawn as an
52
+ // empty page.
53
+ test('reports a file that is not drawio', () => {
54
+ const result = renderDrawioPages('<html><body/></html>', 'p-');
55
+ expect(result.status).toBe('error');
56
+ if (result.status !== 'error') return;
57
+ expect(result.message).toContain('not a draw.io file');
58
+ });
59
+
60
+ test('reports a compressed page that is not base64', () => {
61
+ const result = renderDrawioPages('<mxfile><diagram>!!!not-base64!!!</diagram></mxfile>', 'p-');
62
+ expect(result.status).toBe('error');
63
+ if (result.status !== 'error') return;
64
+ expect(result.message).toContain('base64');
65
+ });
66
+
67
+ // A vendor stencil is drawn as a labelled placeholder; the picture must say
68
+ // so, or the placeholder reads as the file's own content.
69
+ test('carries the renderer warnings through', () => {
70
+ const result = renderDrawioPages(
71
+ `<mxGraphModel><root><mxCell id="0"/><mxCell id="1" parent="0"/>` +
72
+ `<mxCell id="a" value="Lambda" style="shape=mxgraph.aws4.lambda_function;" vertex="1" parent="1">` +
73
+ `<mxGeometry x="0" y="0" width="80" height="40" as="geometry"/></mxCell></root></mxGraphModel>`,
74
+ 'p-',
75
+ );
76
+ expect(result.status).toBe('ready');
77
+ if (result.status !== 'ready') return;
78
+ expect(result.pages[0].warnings.join(' ')).toContain('placeholder');
79
+ });
80
+ });
@@ -0,0 +1,63 @@
1
+ /**
2
+ * @license
3
+ * SPDX-License-Identifier: MIT
4
+ */
5
+
6
+ /**
7
+ * A `.drawio` file → one SVG per page, or the reason it could not be read.
8
+ *
9
+ * Split from `DrawioView` so the part Kabmo owns is testable without a DOM:
10
+ * the library is pure string → string, and the only decisions here are which
11
+ * pages to draw, what to call them, and how a refusal is worded. The component
12
+ * is then just the chrome around this result.
13
+ */
14
+
15
+ import { DrawioError, parseDrawio, render } from '@dskripchenko/drawio';
16
+
17
+ export interface RenderedPage {
18
+ name: string;
19
+ svg: string;
20
+ /** The drawn size, in CSS pixels. The stage fits the whole page against it. */
21
+ width: number;
22
+ height: number;
23
+ warnings: string[];
24
+ }
25
+
26
+ export type DrawioPagesResult =
27
+ | { status: 'ready'; pages: RenderedPage[] }
28
+ | { status: 'error'; message: string };
29
+
30
+ /** The library's error carries where the file is wrong; that is the useful part. */
31
+ function describe(error: unknown): string {
32
+ if (error instanceof DrawioError) {
33
+ const at = error.line > 0 ? ` (line ${error.line}${error.column > 0 ? `, column ${error.column}` : ''})` : '';
34
+ return `${error.message}${at}${error.hint ? ` — ${error.hint}` : ''}`;
35
+ }
36
+ return error instanceof Error ? error.message : String(error);
37
+ }
38
+
39
+ /**
40
+ * Every page of the file, in document order.
41
+ *
42
+ * `prefix` namespaces the ids inside each SVG: a file can be on screen twice
43
+ * (two tabs), and a shared namespace would make the second SVG's `url(#…)`
44
+ * references resolve to the first one's definitions.
45
+ */
46
+ export function renderDrawioPages(content: string, prefix: string): DrawioPagesResult {
47
+ try {
48
+ const file = parseDrawio(content);
49
+ const pages = file.pages.map((page, index) => {
50
+ const result = render(file, { page: index, padding: 16, idPrefix: `${prefix}${index}-` });
51
+ return {
52
+ name: page.name || `Page ${index + 1}`,
53
+ svg: result.svg,
54
+ width: result.width,
55
+ height: result.height,
56
+ warnings: result.warnings,
57
+ };
58
+ });
59
+ return { status: 'ready', pages };
60
+ } catch (error) {
61
+ return { status: 'error', message: describe(error) };
62
+ }
63
+ }