@k8slens/package-build 3.2.0 → 3.4.0

package/src/package-build.ts

@@ -1,105 +1,14 @@
 import { type Plugin, build } from "esbuild";
 import path from "node:path";
 import { readFileSync } from "node:fs";
-import { builtinModules as rawBuiltinModules } from "node:module";
 import yargs from "yargs";
+import { declaredImportsPlugin } from "./declared-imports-plugin";
 import { globImportPlugin } from "./glob-import-plugin";
 import { stylesheetPlugin } from "./stylesheet-plugin";
-import { partition } from "lodash";
 
 const CWD = process.cwd();
 const packageJson = JSON.parse(readFileSync(path.resolve(CWD, "package.json"), "utf-8"));
 
-const isExperimentalModule = (module: string) => module.startsWith("_");
-const alsoAddNodeRefs = (module: string) => [module, `node:${module}`];
-
-const { builtinModules, disallowedBuiltinModules } = (() => {
-  const [disallowed, allowed] = partition(rawBuiltinModules, isExperimentalModule);
-  const disallowedBuiltinModules = new Set(disallowed.flatMap(alsoAddNodeRefs));
-  const builtinModules = new Set(allowed.flatMap(alsoAddNodeRefs));
-
-  return { disallowedBuiltinModules, builtinModules };
-})();
-
-const getPackageName = (path: string) => {
-  const [firstPart, secondPart] = path.split("/");
-
-  if (path.startsWith("@")) {
-    return [firstPart, secondPart].join("/");
-  }
-
-  return firstPart;
-};
-
-const bundleDependency = null;
-
-const ensureCorrectImportsPlugin: Plugin = {
-  name: "ensure-correct-imports",
-  setup: (build) => {
-    build.onResolve({ filter: /^\./ }, (args) => {
-      const fullPath = path.resolve(args.resolveDir, args.path);
-      const relativePathToImporter = path.relative(CWD, args.importer);
-      const relativePath = path.relative(CWD, fullPath);
-
-      if (relativePath.startsWith("..") && !relativePathToImporter.startsWith("..")) {
-        throw new Error(
-          `Tried to import "${args.path}" from "${relativePathToImporter}" but it is outside of the package.`,
-        );
-      }
-
-      return bundleDependency;
-    });
-    build.onResolve({ filter: /^[^.]/ }, async (args) => {
-      // Enforce declared imports only for the package's own sources (.ts/.tsx/.js/.jsx).
-      // Anything imported from outside the package directory — node_modules files or
-      // other workspace packages' dists (whose realpaths live outside node_modules) —
-      // belongs to an already-bundled dependency and must keep bundling freely.
-      const relativePathToImporter = path.relative(CWD, args.importer);
-      const importerIsOwnFile =
-        !relativePathToImporter.startsWith("..") && !relativePathToImporter.split(path.sep).includes("node_modules");
-      const importerIsSourceFile = /\.(t|j)sx?$/.test(args.importer);
-
-      if (!importerIsOwnFile || !importerIsSourceFile) {
-        return bundleDependency;
-      }
-
-      if (disallowedBuiltinModules.has(args.path)) {
-        throw new Error(
-          `Tried to import "${args.path}" from "${args.importer}" but it is a disallowed builtin module.`,
-        );
-      }
-
-      if (builtinModules.has(args.path)) {
-        return {
-          external: true,
-          path: args.path,
-        };
-      }
-
-      const packageName = getPackageName(args.path);
-
-      const isExplicitDependency = packageName in (packageJson.dependencies ?? {});
-      const isExplicitDevDependency = packageName in (packageJson.devDependencies ?? {});
-
-      if (isExplicitDependency) {
-        // Note: Return the full path since we assume that it is a "exports" entry of the dependency found in package.json
-        return {
-          external: true,
-          path: args.path,
-        };
-      }
-
-      if (isExplicitDevDependency) {
-        return bundleDependency;
-      }
-
-      throw new Error(
-        `Tried to import "${args.path}" from "${relativePathToImporter}" but it is not a dependency of the package.`,
-      );
-    });
-  },
-};
-
 const parsedArgs = yargs()
   .options({
     tsconfig: {
@@ -204,7 +113,7 @@ export const packageBuild = async () => {
           packageDirectory: CWD,
           declaredDependencies: new Set(Object.keys(packageJson.dependencies ?? {})),
         }),
-        ensureCorrectImportsPlugin,
+        declaredImportsPlugin({ packageDirectory: CWD, packageJson }),
         externalImagesPlugin,
         globImportPlugin(),
         nativeNodeModulesPlugin,