@k2b/cloud 0.41.0 → 0.42.0

package/src/api/admin-outgoing-mail.ts

@@ -17,15 +17,18 @@ import { type AuthContext, auth, jsonResponse, requiresAdmin } from "../server";
 import { noTransform } from "../server/middleware/no-transform";
 import { audit } from "../services/audit";
 import { outgoingMailLog } from "../services/outgoing-mail/admin";
-import { MAIL_RETENTION_KEYS, readMailRetention } from "../services/outgoing-mail/retention";
+import { MAIL_RETENTION_KEYS, readMailRetentionSettings } from "../services/outgoing-mail/retention";
 import { type MailAuditContext, OutgoingMailError, outgoingMailStore } from "../services/outgoing-mail/store";
 import { outgoingMailTest } from "../services/outgoing-mail/test-send";
 import * as settings from "../services/settings";
 
-const retentionInput = MailRetentionSchema.refine((value) => value.recordDays >= value.contentDays, {
-  message: "Record retention must be at least content retention.",
-  path: ["recordDays"],
-});
+const retentionView = MailRetentionSchema.extend({ unreadable: z.record(z.string(), z.boolean()) });
+const retentionInput = MailRetentionSchema.partial()
+  .extend({ replaceUnreadable: z.array(z.enum(MAIL_RETENTION_KEYS)).optional() })
+  .refine((value) => value.recordDays === undefined || value.contentDays === undefined || value.recordDays >= value.contentDays, {
+    message: "Record retention must be at least content retention.",
+    path: ["recordDays"],
+  });
 
 const validate = <Target extends "param" | "json" | "query", Schema extends z.ZodType>(
   target: Target,
@@ -113,9 +116,9 @@ export const createAdminOutgoingMailRoutes = (authenticate: MiddlewareHandler<Au
         summary: "Read outgoing mail retention",
         tags: ["Outgoing mail"],
         ...requiresAdmin,
-        responses: { 200: jsonResponse(MailRetentionSchema, "Effective retention in days") },
+        responses: { 200: jsonResponse(retentionView, "Effective retention in days") },
       }),
-      async (c) => c.json(await readMailRetention()),
+      async (c) => c.json(await readMailRetentionSettings()),
     )
     .put(
       "/retention",
@@ -124,19 +127,30 @@ export const createAdminOutgoingMailRoutes = (authenticate: MiddlewareHandler<Au
         tags: ["Outgoing mail"],
         ...requiresAdmin,
         responses: {
-          200: jsonResponse(MailRetentionSchema, "Updated retention in days"),
+          200: jsonResponse(retentionView, "Updated retention in days"),
           400: jsonResponse(z.object({ code: z.literal("bad_input"), message: z.string() }), "Invalid retention"),
+          409: jsonResponse(
+            z.object({ code: z.literal("setting_unreadable"), message: z.string() }),
+            "Stored period needs explicit replacement",
+          ),
         },
       }),
       validate("json", retentionInput, "bad_input"),
       async (c) => {
         const next = c.req.valid("json");
-        const old = await readMailRetention();
         await sql.begin(async (tx) => {
-          // complete value from explicit admin input; nothing is merged over a read (#1303)
-          await settings.set(MAIL_RETENTION_KEYS[0], next.contentDays, tx, { replaceUnreadable: true });
-          // complete value from explicit admin input; nothing is merged over a read (#1303)
-          await settings.set(MAIL_RETENTION_KEYS[1], next.recordDays, tx, { replaceUnreadable: true });
+          await tx`SELECT pg_advisory_xact_lock(hashtextextended('outgoing-mail.retention-settings', 0))`;
+          const old = await readMailRetentionSettings(tx);
+          if ((next.recordDays ?? old.recordDays) < (next.contentDays ?? old.contentDays))
+            throw new OutgoingMailError("bad_input", "Record retention must be at least content retention.");
+          if (next.contentDays !== undefined)
+            await settings.set(MAIL_RETENTION_KEYS[0], next.contentDays, tx, {
+              replaceUnreadable: next.replaceUnreadable?.includes(MAIL_RETENTION_KEYS[0]) === true,
+            });
+          if (next.recordDays !== undefined)
+            await settings.set(MAIL_RETENTION_KEYS[1], next.recordDays, tx, {
+              replaceUnreadable: next.replaceUnreadable?.includes(MAIL_RETENTION_KEYS[1]) === true,
+            });
           await audit.record(
             {
               ...context(c),
@@ -149,7 +163,7 @@ export const createAdminOutgoingMailRoutes = (authenticate: MiddlewareHandler<Au
           );
         });
         await settings.invalidateSettingsCache(MAIL_RETENTION_KEYS);
-        return c.json(next);
+        return c.json(await readMailRetentionSettings());
       },
     )
     .get(
@@ -245,7 +259,7 @@ export const createAdminOutgoingMailRoutes = (authenticate: MiddlewareHandler<Au
     .put(
       "/apps/:appId/log-access",
       describeRoute({
-        summary: "Set application mail log access",
+        summary: "Replace application metadata and content mail log access",
         tags: ["Outgoing mail"],
         ...requiresAdmin,
         responses: {

package/src/api/approvals-loader.ts

@@ -3,7 +3,7 @@ import { HTTPException } from "hono/http-exception";
 import { listCapabilities } from "../_internal/registry";
 import { resolveAiChatRequestContext } from "../ai/request-context";
 import type { ApprovalListQuery, ApprovalPage } from "../contracts/approvals";
-import { CapabilityActionCallReviewSchema, capabilityActionPolicy } from "../contracts/capabilities";
+import { CapabilityActionReviewPresentationSchema, capabilityActionPolicy } from "../contracts/capabilities";
 import type { AuthContext } from "../server/middleware/auth";
 import { listPending, presentPendingApproval } from "../services/approvals/list";
 import { logger } from "../services/logging";
@@ -16,8 +16,8 @@ export const loadPendingApprovals = async <T extends AuthContext>(c: Context<T>,
   const apps = getLocalizedRuntimeContext(c).apps;
   const needsPolicy = page.items.some((row) => {
     if (row.storedReview && "sentence" in row.storedReview) return false;
-    const review = CapabilityActionCallReviewSchema.safeParse(row.details);
-    return review.success && !review.data.ask;
+    const review = CapabilityActionReviewPresentationSchema.safeParse(row.details);
+    return review.success && "sentence" in review.data && !review.data.ask;
   });
   const capabilities = needsPolicy
     ? await listCapabilities().catch((error: unknown) => {

package/src/api/approvals.ts

@@ -4,6 +4,7 @@ import { describeRoute } from "hono-openapi";
 import { z } from "zod";
 import { toAiActionFailureResponse } from "../ai/http";
 import { resolveAiChatRequestContext } from "../ai/request-context";
+import { readReviewContent } from "../ai/review-content";
 import { submitAiTurnAction } from "../ai/runtime";
 import { aiConversations } from "../ai/store";
 import {
@@ -14,6 +15,7 @@ import {
   ApprovalListQuerySchema,
   ApprovalPageSchema,
 } from "../contracts/approvals";
+import { CapabilityReviewContentSchema } from "../contracts/capabilities";
 import { ErrorResponseSchema } from "../contracts/shared";
 import { rateLimit } from "../server";
 import { respond } from "../server/api";
@@ -23,6 +25,7 @@ import { jsonResponse, requiresAuth } from "../server/middleware/openapi";
 import { v } from "../server/middleware/validator";
 import { ok } from "../server/services";
 import { approvalDecisionChannel, countPending } from "../services/approvals";
+import { readApprovalContent } from "../services/approvals/content";
 import { decodeApprovalCursor } from "../services/approvals/cursor";
 import { loadPendingApprovals } from "./approvals-loader";
 
@@ -30,6 +33,54 @@ export const approvalRoutes = new Hono<AuthContext>()
   .use("*", noTransform())
   .use(rateLimit())
   .use(auth.requireRole("authenticated"))
+  .get(
+    "/:id/content",
+    describeRoute({
+      tags: ["Approvals"],
+      summary: "Read one complete pending approval snapshot",
+      ...requiresAuth,
+      responses: {
+        200: jsonResponse(CapabilityReviewContentSchema, "Complete reviewed content"),
+        404: jsonResponse(ErrorResponseSchema, "Snapshot unavailable"),
+      },
+    }),
+    v("param", z.object({ id: z.uuid() })),
+    v("query", z.object({ digest: z.string().regex(/^[a-f0-9]{64}$/) }).strict()),
+    async (c) => {
+      const ctx = await resolveAiChatRequestContext(c);
+      if (ctx instanceof Response) return ctx;
+      const content = await readApprovalContent({
+        ...c.req.valid("param"),
+        ...c.req.valid("query"),
+        approverUserId: ctx.ownerUserId,
+        signal: c.req.raw.signal,
+      });
+      c.header("Cache-Control", "private, no-store");
+      return content ? c.json(content) : c.json({ message: "This review is no longer available." }, 404);
+    },
+  )
+  .get(
+    "/conversations/:conversationId/turns/:turnId/reviews/:callId",
+    describeRoute({
+      tags: ["Approvals"],
+      summary: "Read one historical conversation review snapshot",
+      ...requiresAuth,
+      responses: {
+        200: jsonResponse(CapabilityReviewContentSchema, "Complete reviewed content"),
+        404: jsonResponse(ErrorResponseSchema, "Snapshot unavailable"),
+      },
+    }),
+    v("param", z.object({ conversationId: z.uuid(), turnId: z.uuid(), callId: z.string().min(1).max(200) })),
+    v("query", z.object({ digest: z.string().regex(/^[a-f0-9]{64}$/) }).strict()),
+    async (c) => {
+      const ctx = await resolveAiChatRequestContext(c);
+      if (ctx instanceof Response) return ctx;
+      const location = c.req.valid("param");
+      c.header("Cache-Control", "private, no-store");
+      const content = await readReviewContent(location, c.req.valid("query").digest, ctx.ownerUserId, c.req.raw.signal);
+      return content ? c.json(content) : c.json({ message: "This review is no longer available." }, 404);
+    },
+  )
   .get(
     "/",
     describeRoute({

package/src/api/apps.ts

@@ -3,6 +3,8 @@ import { describeRoute } from "hono-openapi";
 import { z } from "zod";
 import { ErrorResponseSchema } from "../contracts";
 import { type AuthContext, auth, jsonResponse, requiresAuth, v } from "../server";
+import { appAccessAuthority } from "../services/app-access";
+import { discoverableApps } from "../services/app-discovery";
 import { visibleNavigationApps } from "../ssr/app-navigation";
 import { getLocalizedRuntimeContext } from "../ssr/runtime";
 
@@ -35,9 +37,9 @@ export const appDiscoveryRoutes = new Hono<AuthContext>().use(auth.requireRole("
     },
   }),
   v("query", AppListQuerySchema),
-  (c) => {
+  async (c) => {
     const search = c.req.valid("query").search?.toLowerCase();
-    const items = visibleNavigationApps(getLocalizedRuntimeContext(c).apps, c.get("user"))
+    const items = visibleNavigationApps(await discoverableApps(appAccessAuthority(c), getLocalizedRuntimeContext(c).apps), c.get("user"))
       .map((app) => ({
         id: app.id,
         name: app.name,