@k2b/cloud 0.40.0 → 0.41.0

package/src/ai/chat/action-question.tsx

@@ -217,6 +217,8 @@ function MessagePreview(props: {
   locale: string;
   timeZone: string;
   readMore?: string;
+  /** Only a question that sends says when the mail goes out; a draft that is created or deleted goes nowhere. */
+  sends: boolean;
 }) {
   const t = () => actionMessages(props.locale);
   const rows = () => {
@@ -233,6 +235,7 @@ function MessagePreview(props: {
   };
   const note = () => {
     const p = props.preview;
+    if (!props.sends) return undefined;
     if (p.sendAt) {
       const [before, after] = t().sendsAt({ at: "\u0000" }).split("\u0000");
       return (
@@ -307,7 +310,15 @@ function ReviewPreviewBody(props: { model: Extract<ActionPreviewModel, { kind: "
     <Chat.Preview>
       <Switch>
         <Match when={preview()?.kind === "message" ? (preview() as Extract<CapabilityPreview, { kind: "message" }>) : undefined}>
-          {(message) => <MessagePreview preview={message()} locale={locale()} timeZone={tz()} readMore={props.readMore} />}
+          {(message) => (
+            <MessagePreview
+              preview={message()}
+              locale={locale()}
+              timeZone={tz()}
+              readMore={props.readMore}
+              sends={props.card.reason.code === "sends"}
+            />
+          )}
         </Match>
         <Match when={preview()?.kind === "event" ? (preview() as Extract<CapabilityPreview, { kind: "event" }>) : undefined}>
           {(event) => (

package/src/ai/chat/action-text.ts

@@ -0,0 +1,288 @@
+import { dates, i18n } from "@k2b/stdlib";
+import { capabilityPersonText, capabilitySentenceText } from "../../_internal/capability-sentences";
+import type { CapabilityAskReason, CapabilityPerson, CapabilitySentence } from "../../contracts/capabilities";
+import { formatBytes } from "../../shared/format";
+import type { ActionCard } from "./action-card";
+import { actionMessages } from "./action-messages";
+
+export type ActionTextRow = { label: string; value: string; format?: "date" | "date-time"; block?: true };
+export type ActionQuestionText = {
+  locale: string;
+  question: string;
+  reason: string;
+  reasonCode: CapabilityAskReason;
+  rows: ActionTextRow[];
+  readMore?: string;
+  confirm: string;
+  decline: string;
+  incomplete: boolean;
+};
+
+const messages = i18n.define({
+  baseLocale: "en",
+  messages: {
+    en: {
+      from: "From",
+      to: "To",
+      cc: "Cc",
+      bcc: "Bcc",
+      subject: "Subject",
+      sendAt: "Send at",
+      warning: "Warning",
+      attachments: "Attachments",
+      text: "Text",
+      when: "When",
+      until: "Until",
+      where: "Where",
+      with: "With",
+      repeats: "Repeats",
+      due: "Due",
+      assignees: "Assignees",
+      status: "Status",
+      checklist: "Checklist",
+      tags: "Tags",
+      folder: "Folder",
+      size: "Size",
+      target: "To",
+      place: "Place",
+      added: "Added",
+      removed: "Removed",
+      starts: "Starts",
+      may: "May",
+      mayAdded: "May (added)",
+      mayRemoved: "May (removed)",
+      also: "Also",
+      readAll: "Read all",
+      title: "Title",
+      name: "Name",
+      note: "Note",
+      before: ({ label }: { label: string }) => `${label} (before)`,
+      more: ({ count }: { count: number }) => `${count.toLocaleString("en")} more`,
+    },
+    de: {
+      from: "Von",
+      to: "An",
+      cc: "Cc",
+      bcc: "Bcc",
+      subject: "Betreff",
+      sendAt: "Senden am",
+      warning: "Warnung",
+      attachments: "Anhänge",
+      text: "Text",
+      when: "Wann",
+      until: "Bis",
+      where: "Wo",
+      with: "Mit",
+      repeats: "Wiederholung",
+      due: "Fällig",
+      assignees: "Zuständig",
+      status: "Status",
+      checklist: "Checkliste",
+      tags: "Tags",
+      folder: "Ordner",
+      size: "Größe",
+      target: "Ziel",
+      place: "Ort",
+      added: "Neu",
+      removed: "Entfernt",
+      starts: "Startet",
+      may: "Darf",
+      mayAdded: "Darf (neu)",
+      mayRemoved: "Darf (entfernt)",
+      also: "Folge",
+      readAll: "Ganz lesen",
+      title: "Titel",
+      name: "Name",
+      note: "Hinweis",
+      before: ({ label }) => `${label} (vorher)`,
+      more: ({ count }) => `${count.toLocaleString("de")} weitere`,
+    },
+  },
+});
+export const checkActionTextMessages = () => messages.check();
+/** The label for a row an old review left without one, where a transport requires labels. */
+export const actionNoteLabel = (locale: string): string => messages.resolve([locale]).t.note;
+
+/** Flatten the question card once. Transport limits and terminal escaping belong to its callers. */
+export const actionCardText = (card: ActionCard): ActionQuestionText => {
+  const t = messages.resolve([card.locale]).t;
+  const rows: ActionTextRow[] = [];
+  let incomplete = false;
+  const row = (label: string, value: string | undefined, extra: Pick<ActionTextRow, "block" | "format"> = {}) => {
+    if (value !== undefined && value !== "") rows.push({ label, value, ...extra });
+  };
+  const list = (values: string[], more = 0) => {
+    if (more > 0) {
+      incomplete = true;
+      values.push(t.more({ count: more }));
+    }
+    return new Intl.ListFormat(card.locale, { type: "conjunction" }).format(values);
+  };
+  const people = (values: CapabilityPerson[] | undefined, more = 0) => list((values ?? []).map(capabilityPersonText), more);
+  // The thing's own name, unless the question already says it.
+  const named = (label: string, value: string) => {
+    if (!card.questionText.includes(value)) row(label, value);
+  };
+  const model = card.preview;
+  if (model?.kind === "legacy") {
+    rows.push(...model.rows);
+    row(t.text, model.markdown, { block: true });
+  } else if (model?.kind === "review") {
+    const context = { locale: card.locale, timeZone: model.timeZone };
+    const sentence = (value: CapabilitySentence) => capabilitySentenceText(value.text, value.slots ?? model.slots ?? {}, context);
+    const preview = model.preview;
+    if (preview && "truncated" in preview && preview.truncated) incomplete = true;
+    switch (preview?.kind) {
+      case "message":
+        row(t.from, preview.from && capabilityPersonText(preview.from));
+        row(t.to, people(preview.to, preview.more?.to));
+        row(t.cc, people(preview.cc, preview.more?.cc));
+        row(t.bcc, people(preview.bcc, preview.more?.bcc));
+        row(t.subject, preview.subject);
+        row(t.sendAt, preview.sendAt, { format: "date-time" });
+        row(t.warning, preview.warnings?.join(" · "));
+        row(
+          t.attachments,
+          list(
+            (preview.attachments ?? []).map((file) =>
+              file.size === undefined ? file.name : `${file.name} (${formatBytes(file.size, { locale: card.locale })})`,
+            ),
+            preview.moreAttachments,
+          ),
+        );
+        row(t.text, preview.body, { block: true });
+        break;
+      case "event": {
+        named(t.title, preview.title);
+        const dateOnly = (value: string) => /^\d{4}-\d{2}-\d{2}$/.test(value);
+        const allDay = preview.allDay === true || dateOnly(preview.start);
+        // Both ends stay typed, so a device shows them in its own zone. An all-day instant becomes its calendar day
+        // in the card's zone first, so no reader's zone moves it to another day.
+        const day = (value: string) =>
+          dateOnly(value)
+            ? value
+            : new Intl.DateTimeFormat("en-CA", { timeZone: model.timeZone, year: "numeric", month: "2-digit", day: "2-digit" }).format(
+                new Date(value),
+              );
+        const format = allDay ? "date" : "date-time";
+        row(t.when, allDay ? day(preview.start) : preview.start, { format });
+        if (preview.end) row(t.until, allDay ? day(preview.end) : preview.end, { format });
+        row(t.where, [preview.place, preview.location].filter(Boolean).join(" · "));
+        row(t.with, people(preview.attendees));
+        row(t.repeats, preview.recurrence);
+        row(t.text, preview.description, { block: true });
+        break;
+      }
+      case "task":
+        named(t.title, preview.title);
+        row(t.place, preview.place);
+        row(t.due, preview.due, { format: /^\d{4}-\d{2}-\d{2}$/.test(preview.due ?? "") ? "date" : "date-time" });
+        row(t.assignees, people(preview.assignees));
+        row(t.status, preview.status);
+        row(t.checklist, preview.checklist?.map((item) => `${item.done ? "☑" : "☐"} ${item.label}`).join(" · "));
+        row(t.tags, preview.tags?.join(", "));
+        row(t.text, preview.description, { block: true });
+        break;
+      case "file":
+        named(t.name, preview.name);
+        row(t.folder, preview.place ?? preview.path);
+        row(t.size, preview.size === undefined ? undefined : formatBytes(preview.size, { locale: card.locale }));
+        row(t.target, preview.to);
+        break;
+      case "page":
+        named(t.title, preview.title);
+        row(t.place, preview.place);
+        row(t.text, preview.body, { block: true });
+        for (const change of preview.changes ?? []) row(change.change === "added" ? t.added : t.removed, change.text);
+        break;
+      case "rule":
+        row(t.starts, sentence(preview.when));
+        row(t.text, preview.does, { block: true });
+        for (const may of preview.may)
+          row(may.mark === "added" ? t.mayAdded : may.mark === "removed" ? t.mayRemoved : t.may, sentence(may));
+        // The card's fixed line: a routine knows only its instruction, never this chat.
+        if (!preview.seesChat) row(t.note, actionMessages(card.locale).ruleBlindToChat);
+        break;
+      case "fields":
+        for (const field of preview.rows) {
+          rows.push({ label: field.label, value: field.value, ...(field.format ? { format: field.format } : {}) });
+          if (field.before !== undefined)
+            rows.push({ label: t.before({ label: field.label }), value: field.before, ...(field.format ? { format: field.format } : {}) });
+        }
+        break;
+    }
+    for (const consequence of model.consequences)
+      row(consequence.mark === "added" ? t.added : consequence.mark === "removed" ? t.removed : t.also, consequence.plain);
+  }
+  // A long question shortens slot values and names at most three people of a slot, then "N more". The text is
+  // complete only when the question or a row shows each value whole; people the app left out are never shown.
+  const shown = [card.questionText, ...rows.map((entry) => entry.value)];
+  const whole = (value: string) => shown.some((text) => text.includes(value));
+  const typed = (value: string, format: "date" | "date-time") =>
+    rows.some((entry) => entry.value === value && (entry.format === "date-time" || entry.format === format));
+  if (
+    card.slotValues?.unlisted ||
+    card.slotValues?.values.some((value) => !whole(value)) ||
+    card.slotValues?.times.some(
+      (time) => !whole(time.text) && !(typed(time.start, time.format) && (!time.end || typed(time.end, time.format))),
+    )
+  )
+    incomplete = true;
+  return {
+    locale: card.locale,
+    question: card.questionText,
+    reason: card.reason.text,
+    reasonCode: card.reason.code,
+    rows,
+    ...(card.readMore ? { readMore: card.readMore } : {}),
+    confirm: card.confirm.label,
+    decline: card.decline,
+    incomplete,
+  };
+};
+
+/** The CLI's plain question block, before terminal-safe sanitizing at the CLI boundary. */
+export const actionQuestionLines = (
+  text: ActionQuestionText,
+  extra: { origin?: string; commands?: { approve: string; reject: string }; timeZone: string },
+): string[] => {
+  const t = messages.resolve([text.locale]).t;
+  const lines = [`? ${text.question}`, `  ${text.reason}`];
+  if (extra.origin) lines.push(`  ${extra.origin}`);
+  const width = Math.max(0, ...text.rows.filter((row) => !row.block && row.label).map((row) => Array.from(row.label).length + 1));
+  let markedIncomplete = false;
+  for (const row of text.rows) {
+    if (row.block) {
+      const body = row.value.split(/\r?\n/);
+      // Cut a long text only when "Read all" can open the whole thing; otherwise the terminal shows all of it.
+      const shown = text.readMore ? body.slice(0, 8) : body;
+      lines.push(...shown.map((line) => `  ${line}`));
+      if (shown.length < body.length || (text.incomplete && !markedIncomplete)) {
+        lines.push("  …");
+        markedIncomplete = true;
+      }
+      continue;
+    }
+    const options = { locale: text.locale, timeZone: extra.timeZone };
+    const value =
+      row.format === "date-time"
+        ? dates.formatDateTime(row.value, options)
+        : row.format === "date"
+          ? dates.formatDate(/^\d{4}-\d{2}-\d{2}$/.test(row.value) ? `${row.value}T12:00:00.000Z` : row.value, {
+              ...options,
+              ...(/^\d{4}-\d{2}-\d{2}$/.test(row.value) ? { timeZone: "UTC" } : {}),
+            })
+          : row.value;
+    lines.push(row.label ? `  ${(row.label + ":").padEnd(width)} ${value}` : `  ${value}`);
+  }
+  if (text.incomplete && !markedIncomplete) lines.push("  …");
+  if (text.readMore) lines.push(`  ${t.readAll}: ${text.readMore}`);
+  if (extra.commands) {
+    const width = Math.max(Array.from(text.confirm).length, Array.from(text.decline).length) + 1;
+    lines.push(
+      `  ${(text.confirm + ":").padEnd(width)} ${extra.commands.approve}`,
+      `  ${(text.decline + ":").padEnd(width)} ${extra.commands.reject}`,
+    );
+  }
+  return lines;
+};

package/src/ai/chat/tool-action-words.ts

@@ -0,0 +1,31 @@
+import { capabilityUnknownText } from "../../_internal/capability-sentences";
+import type { AiTurnBlock } from "../protocol";
+import { toolOutcome } from "../tool-wording";
+import { isRecord } from "./message-utils";
+import { aiChatMessages } from "./messages";
+
+type ToolBlock = Extract<AiTurnBlock, { kind: "tool" }>;
+
+/** The application's own short summary of a result, if it fits on one line. */
+const resultSummary = (block: ToolBlock): string | undefined => {
+  const value = isRecord(block.result) ? block.result.summary : undefined;
+  return typeof value === "string" && value.trim() && value.trim().length <= 500 ? value.trim() : undefined;
+};
+
+/** The words of a call without an app sentence: Cloud's frames around its catalog sentence or title. */
+export const legacyOutcomeWords = (block: ToolBlock, locale: string, timeZone: string) => (subject: string) => {
+  const t = aiChatMessages(locale);
+  const capability = block.presentation?.kind === "capability";
+  return {
+    running: t.receiptRunning({ title: subject }),
+    // The app's done sentence, else its own summary of the call, else Cloud's frame.
+    done:
+      toolOutcome(block, "done", locale, timeZone) ??
+      resultSummary(block) ??
+      (capability ? t.receiptDone({ title: subject }) : t.receiptApproved({ title: subject })),
+    rejected: toolOutcome(block, "rejected", locale, timeZone) ?? t.receiptRejected({ title: subject }),
+    notRun: toolOutcome(block, "notRun", locale, timeZone) ?? t.receiptNotRun({ title: subject, stopped: false }),
+    unknown: capabilityUnknownText(subject, locale),
+    unknownStill: capabilityUnknownText(subject, locale, true),
+  };
+};

package/src/ai/chat/tool-action.tsx

@@ -1,11 +1,9 @@
 import { dates } from "@k2b/stdlib";
 import { Button, ButtonLink, type ChatDecisionState, useLocale } from "@k2b/ui";
 import { createEffect, createMemo, createSignal, For, type JSX, on, onCleanup, Show } from "solid-js";
-import { capabilityUnknownText } from "../../_internal/capability-sentences";
 import { CapabilityActionReceiptSchema } from "../../contracts/capabilities";
 import { AI_TOOL_CHECK_STALE_MS, type AiActionCheck } from "../action-review";
 import type { AiTurnBlock } from "../protocol";
-import { toolOutcome } from "../tool-wording";
 import { type ActionCard, type ActionText, actionReceiptText, toolActionCard } from "./action-card";
 import { actionMessages } from "./action-messages";
 import { type ActionLine, ActionQuestion, ActionReceipt } from "./action-question";
@@ -13,6 +11,7 @@ import { useReaderTimeZone } from "./action-sentences";
 import { useAiChatActions } from "./message-actions";
 import { capabilityErrorDescription, isRecord } from "./message-utils";
 import { aiChatMessages } from "./messages";
+import { legacyOutcomeWords } from "./tool-action-words";
 import type { AiTurnActionState, AiTurnPhase } from "./turn-layout";
 
 type ToolBlock = Extract<AiTurnBlock, { kind: "tool" }>;
@@ -44,30 +43,6 @@ export const toolErrorCode = (result: unknown): string | null => {
 /** The message without its code, so the detail under a line reads as a sentence. */
 const errorDetail = (result: unknown): string => capabilityErrorDescription(result).replace(/^[A-Z][A-Z0-9_]{2,}:\s*/, "");
 
-/** The application's own short summary of a result, if it fits on one line. */
-const resultSummary = (block: ToolBlock): string | undefined => {
-  const value = isRecord(block.result) ? block.result.summary : undefined;
-  return typeof value === "string" && value.trim() && value.trim().length <= 500 ? value.trim() : undefined;
-};
-
-/** The words of a call without an app sentence: Cloud's frames around its catalog sentence or title. */
-export const legacyOutcomeWords = (block: ToolBlock, locale: string, timeZone: string) => (subject: string) => {
-  const t = aiChatMessages(locale);
-  const capability = block.presentation?.kind === "capability";
-  return {
-    running: t.receiptRunning({ title: subject }),
-    // The app's done sentence, else its own summary of the call, else Cloud's frame.
-    done:
-      toolOutcome(block, "done", locale, timeZone) ??
-      resultSummary(block) ??
-      (capability ? t.receiptDone({ title: subject }) : t.receiptApproved({ title: subject })),
-    rejected: toolOutcome(block, "rejected", locale, timeZone) ?? t.receiptRejected({ title: subject }),
-    notRun: toolOutcome(block, "notRun", locale, timeZone) ?? t.receiptNotRun({ title: subject, stopped: false }),
-    unknown: capabilityUnknownText(subject, locale),
-    unknownStill: capabilityUnknownText(subject, locale, true),
-  };
-};
-
 /** The card of one tool block in the reader's locale and zone. */
 export const useToolActionCard = (block: () => ToolBlock): (() => ActionCard) => {
   const locale = useLocale();

package/src/ai/executor.ts

@@ -1055,6 +1055,8 @@ export class AiTurnExecutor {
     const approvalTargets = new Map<string, AiApprovalTarget>();
     const linkedApprovals = new Map<string, string>();
     const freshApprovalRequired = new Set<string>();
+    const capabilityActionReviews = new Map<string, CapabilityActionReviewData>();
+    const storedReviews = new Map<string, AiStoredActionReview>();
     const dynamicToolRuntimeContext = {
       turnId,
       reportToolProgress: (callId: string, message: string) => pipeline.reportToolProgress(callId, message),
@@ -1096,6 +1098,14 @@ export class AiTurnExecutor {
         return "changed";
       },
       describeApproval: (approvalCallId: string, target: AiApprovalTarget) => approvalTargets.set(approvalCallId, target),
+      describeReview: async (approvalCallId: string, review: CapabilityActionReviewData) => {
+        capabilityActionReviews.set(approvalCallId, review);
+        const callId = customApprovalParentCallId(approvalCallId) ?? approvalCallId;
+        const stored = storedActionReview(review);
+        await recordAiToolReview({ conversationId, turnId, callId, review: stored });
+        storedReviews.set(callId, stored);
+        await pipeline.setToolReview(callId, stored);
+      },
     };
     const prepared = prepareAiTools({
       tools: activeTools,
@@ -1105,8 +1115,6 @@ export class AiTurnExecutor {
     });
     let backgroundError: string | null = null;
     const rememberableCapabilityApprovals = new Map<string, string>();
-    const capabilityActionReviews = new Map<string, CapabilityActionReviewData>();
-    const storedReviews = new Map<string, AiStoredActionReview>();
     const onCapabilityReview = async (
       callId: string,
       review: CapabilityActionReviewData,

package/src/ai/firecrawl-tools.ts

@@ -1,10 +1,12 @@
 import { type ToolContext, truncateMiddle } from "@k2b/nessi";
 import { z } from "zod";
+import type { CapabilityActionCallReview } from "../contracts/capabilities";
 import type { RequestActor } from "../server";
 import { coreSettings } from "../services";
 import { isUnsafeNetworkAddress, isUnsafeNetworkHostname, parseNetworkAddress } from "../shared/network-address";
 import { AI_WEBSITE_APPROVAL_TOOL, aiTurnAllowsWebsiteApprovals, aiWebsiteApprovalScope, findRememberedAiToolApproval } from "./approvals";
 import { aiConversations } from "./store";
+import { cloudToolReview } from "./tool-sentences";
 import { defineAiTool } from "./tools";
 import type { AiApprovalTarget, AiWebsiteReceipt } from "./types";
 import { hasWebAddressProvenance, recordWebAddresses, webAddressesIn } from "./web-provenance";
@@ -280,7 +282,7 @@ export type WebReadContext = Pick<ToolContext, "requestApproval"> & {
   conversationId?: string;
   turnId?: string;
   locale?: string;
-  requestApprovalFor?: (message: string, target: AiApprovalTarget) => Promise<boolean>;
+  requestApprovalFor?: (message: string, target: AiApprovalTarget, review?: CapabilityActionCallReview) => Promise<boolean>;
   reportWebsiteReceipts?: (receipts: AiWebsiteReceipt[]) => Promise<void>;
 };
 
@@ -306,7 +308,18 @@ export const authorizeWebRead = async (kind: "page" | "file", url: string, ctx:
     return true;
   }
   const message = webReadApprovalMessage(kind, url, ctx.locale);
-  const approved = ctx.requestApprovalFor ? await ctx.requestApprovalFor(message, target) : await ctx.requestApproval(message);
+  const review = cloudToolReview(kind === "page" ? "web_extract" : "fetch_file", { url }, ctx.locale ?? "en");
+  const question: CapabilityActionCallReview | undefined = review
+    ? {
+        ...review,
+        ask: "sends",
+        consequences: message
+          .split("\n")
+          .slice(1)
+          .map((text) => ({ text })),
+      }
+    : undefined;
+  const approved = ctx.requestApprovalFor ? await ctx.requestApprovalFor(message, target, question) : await ctx.requestApproval(message);
   if (!approved) throw new Error("The person did not allow reading this address. Use an address from their message or a search result.");
   return false;
 };

package/src/ai/index.ts

@@ -262,6 +262,7 @@ export {
   createCloudAiMemoryTool,
 } from "./memory-tool";
 export { migrateCloudAi } from "./migrate";
+export { type AiOpenQuestion, type AiOpenQuestions, listAiOpenQuestions } from "./open-questions";
 export { personalAiModelPolicy } from "./personal-agent";
 export { type AiUserPrefs, aiActorUser, aiPrefsUserId, aiUserPrefs } from "./prefs";
 export {

package/src/ai/migrate.ts

@@ -2297,6 +2297,21 @@ export const migrateCloudAi = async (): Promise<void> => {
     AFTER UPDATE OF status, error, completed_at, cancel_requested_at ON ai.turns
     FOR EACH ROW EXECUTE FUNCTION ai.live_conversation_child_changed('conversation-list,conversation-detail')
   `.simple();
+  // Only questions for the person change the list of open questions; browser tool calls come and go per turn.
+  await sql`DROP TRIGGER IF EXISTS ai_live_pending_actions_changed ON ai.pending_actions`.simple();
+  await sql`DROP TRIGGER IF EXISTS ai_live_pending_actions_removed ON ai.pending_actions`.simple();
+  await sql`
+    CREATE TRIGGER ai_live_pending_actions_changed
+    AFTER INSERT OR UPDATE OF status ON ai.pending_actions
+    FOR EACH ROW WHEN (NEW.kind IN ('approval', 'custom_approval'))
+    EXECUTE FUNCTION ai.live_conversation_child_changed('conversation-list')
+  `.simple();
+  await sql`
+    CREATE TRIGGER ai_live_pending_actions_removed
+    AFTER DELETE ON ai.pending_actions
+    FOR EACH ROW WHEN (OLD.kind IN ('approval', 'custom_approval'))
+    EXECUTE FUNCTION ai.live_conversation_child_changed('conversation-list')
+  `.simple();
   await sql`DROP TRIGGER IF EXISTS ai_live_chat_tasks_changed ON ai.chat_tasks`.simple();
   await sql`
     CREATE TRIGGER ai_live_chat_tasks_changed AFTER INSERT OR UPDATE OR DELETE ON ai.chat_tasks