@k03mad/ip2geo 8.0.0 → 9.0.0

package/app/cli.js

@@ -1,11 +1,14 @@
 #!/usr/bin/env node
 
 import {log, logErrorExit} from '@k03mad/simple-log';
+import chalk from 'chalk';
 
 import {DEFAULT_CACHE_FILE_DIR, DEFAULT_CACHE_FILE_NEWLINE, DEFAULT_CACHE_FILE_SEPARATOR, ip2geo} from './api.js';
 import {pruneCache} from './helpers/cache.js';
 import {codeText, nameText} from './helpers/colors.js';
 
+const {blue, red, green} = chalk;
+
 const args = process.argv.slice(2);
 const argsExtra = args.filter(arg => !arg.startsWith('-'));
 
@@ -42,13 +45,26 @@ if (isPrune) {
     const cacheFolder = argsExtra[0] || DEFAULT_CACHE_FILE_DIR;
 
     try {
-        const {removedEntries} = await pruneCache(
+        const {duplicates, empty, longLinesFiles} = await pruneCache(
             cacheFolder,
             DEFAULT_CACHE_FILE_SEPARATOR,
             DEFAULT_CACHE_FILE_NEWLINE,
         );
 
-        log(`Removed duplicate cache entries: ${removedEntries}`);
+        const message = [
+            `Removed duplicate cache entries: ${green(duplicates)}`,
+            `Removed empty cache entries: ${green(empty)}`,
+        ];
+
+        if (longLinesFiles.size > 0) {
+            message.push(
+                '',
+                red('Something went wrong with these cache files (lines too long):'),
+                ...[...longLinesFiles].map(elem => blue(`— ${elem}`)),
+            );
+        }
+
+        log(message);
     } catch (err) {
         if (err.code !== 'ENOENT') {
             logErrorExit(err);

package/app/helpers/cache.js

@@ -99,7 +99,7 @@ export const writeToFsCache = async (ip, data, cacheDir, cacheFileName, cacheFil
     debug('set to fs cache: %o %o', cacheFileFull, data);
 
     await fs.mkdir(cacheDir, {recursive: true});
-    await fs.appendFile(cacheFileFull, Object.values(data).join(cacheFileSeparator) + cacheFileNewline);
+    await fs.appendFile(cacheFileFull, cacheFileNewline + Object.values(data).join(cacheFileSeparator));
 };
 
 /**
@@ -168,19 +168,35 @@ export const pruneCache = async (cacheDir, cacheFileSeparator, cacheFileNewline)
             .join(''),
     );
 
-    let removedEntries = 0;
+    let duplicates = 0;
+    let empty = 0;
+    const longLinesFiles = new Set();
 
     await Promise.all(files.map(async file => {
         const fullFilePath = path.join(cacheDir, file);
 
         const data = await fs.readFile(fullFilePath, {encoding: 'utf8'});
-        const dataArr = data.split(cacheFileNewline);
+        const dataArr = data.split(cacheFileNewline).filter(Boolean);
 
-        const uniq = [...new Set(dataArr)].sort((a, b) => cacheLineToNum(a) - cacheLineToNum(b));
-        await fs.writeFile(fullFilePath, uniq.join(cacheFileNewline).trim());
+        const dataArrRemoveEmpty = dataArr.filter(elem => {
+            const splitted = elem.split(cacheFileSeparator);
 
-        removedEntries += dataArr.length - uniq.length;
+            if (splitted.length > outputKeys.length) {
+                longLinesFiles.add(fullFilePath);
+            }
+
+            return splitted.filter(Boolean).length > 1;
+        });
+
+        const uniq = [...new Set(dataArrRemoveEmpty)]
+            .sort((a, b) => cacheLineToNum(a) - cacheLineToNum(b));
+
+        const fileContent = uniq.join(cacheFileNewline).trim();
+        await (fileContent ? fs.writeFile(fullFilePath, fileContent) : fs.rm(fullFilePath));
+
+        empty += dataArr.length - dataArrRemoveEmpty.length;
+        duplicates += dataArrRemoveEmpty.length - uniq.length;
     }));
 
-    return {removedEntries};
+    return {duplicates, empty, longLinesFiles};
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@k03mad/ip2geo",
-  "version": "8.0.0",
+  "version": "9.0.0",
   "description": "GeoIP library",
   "maintainers": [
     "Kirill Molchanov <k03.mad@gmail.com"

package/tests/shared/fs.js

@@ -40,5 +40,5 @@ export const checkCacheFile = async ({
     const cacheFile = `${response.ip.split(/\.|:/)[0]}_${cacheFileName}`;
     const data = await fs.readFile(path.join(cacheDir, cacheFile), {encoding: 'utf8'});
 
-    assert.equal(data, Object.values(response).join(cacheFileSeparator) + cacheFileNewline);
+    assert.equal(data, cacheFileNewline + Object.values(response).join(cacheFileSeparator));
 };