@k-int/stripes-kint-components 3.0.0 → 3.0.2

package/CHANGELOG.md

@@ -1,4 +1,10 @@
-## 3.0.0 In progress
+## 3.0.2 2022-09-29
+  * Fixed inconsistency between CustomPropertiesEditCtx and CustomPropertiesViewCtx labelOverrides
+
+## 3.0.1 2022-09-22
+  * Removed unnecessary validate prop on CustomPropertyField, fixed broken out of range validator
+
+## 3.0.0 2022-09-16
   * RichSelect default trigger now uses DropdownButton under the hood -- changed styling
   * ActionList previously added actionListItems directly to cached object--sometimes this caused the react-query cache ITSELF to update, although I'm not sure why here and not anywhere else. Fixed by creating a clone internally in ActionListFieldArray and assigning actionListActions on that.
   * New util function `parseErrorResponse`, used in places where we catch http errors, allows for text only response bodies

package/es/lib/CustomProperties/Edit/CustomPropertyField.js

@@ -94,7 +94,7 @@ var CustomPropertyField = function CustomPropertyField(_ref) {
     if (customProperty.type === CUSTOM_PROPERTY_TYPES.INTEGER_CLASS_NAME) {
       var min = Number.MIN_SAFE_INTEGER;
       var max = Number.MAX_SAFE_INTEGER;
-      return fieldValue && !Number.isInteger(+fieldValue) ? kintIntl.formatKintMessage({
+      return fieldValue && (fieldValue > max || fieldValue < min) ? kintIntl.formatKintMessage({
         id: 'errors.valueNotInRange',
         overrideValue: labelOverrides.valueNotInRangeError
       }, {
@@ -226,10 +226,7 @@ var CustomPropertyField = function CustomPropertyField(_ref) {
           max: max,
           min: min,
           step: 'any',
-          type: 'number',
-          validate: function validate(validateValue) {
-            return (0, _utils.composeValidatorsWithArgs)(_utils.invalidNumber, _utils.rangeOverflow, _utils.rangeUnderflow)(validateValue, min, max, passedIntlKey, passedIntlNS, labelOverrides);
-          }
+          type: 'number'
         };
 
         handleChange = function handleChange(e) {

package/es/lib/CustomProperties/View/CustomPropertiesViewCtx.js

@@ -50,17 +50,19 @@ var CustomPropertiesViewCtx = function CustomPropertiesViewCtx(_ref) {
         id: 'customProperties',
         overrideValue: labelOverrides.noContext
       });
-    } // Label overrides for specific contexts
-
-
-    if (labelOverrides[ctx]) {
-      return labelOverrides[ctx];
-    } // Label override for default title or finally built in default
+    } // Chain formatKintMessages together using provided fallbackMessage to
+    // allow for "If override or translation exists, use it, else use default"
 
 
     return kintIntl.formatKintMessage({
-      id: 'customProperties.defaultTitle',
-      overrideValue: labelOverrides.defaultTitle
+      id: "customProperties.ctx.".concat(ctx),
+      overrideValue: labelOverrides[ctx],
+      fallbackMessage: kintIntl.formatKintMessage({
+        id: 'customProperties.defaultTitle',
+        overrideValue: labelOverrides.defaultTitle
+      }, {
+        ctx: ctx
+      })
     }, {
       ctx: ctx
     });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@k-int/stripes-kint-components",
-  "version": "3.0.0",
+  "version": "3.0.2",
   "description": "Stripes Component library for K-Int specific applications",
   "sideEffects": [
     "*.css"

package/src/lib/CustomProperties/Edit/CustomPropertyField.js

@@ -77,7 +77,7 @@ const CustomPropertyField = ({
       const min = Number.MIN_SAFE_INTEGER;
       const max = Number.MAX_SAFE_INTEGER;
 
-      return (fieldValue && !Number.isInteger(+fieldValue)) ?
+      return (fieldValue && (fieldValue > max || fieldValue < min)) ?
         kintIntl.formatKintMessage({
           id: 'errors.valueNotInRange',
           overrideValue: labelOverrides.valueNotInRangeError
@@ -206,20 +206,6 @@ const CustomPropertyField = ({
           min,
           step: 'any',
           type: 'number',
-          validate: (validateValue) => {
-              return composeValidatorsWithArgs(
-                invalidNumber,
-                rangeOverflow,
-                rangeUnderflow
-              )(
-                validateValue,
-                min,
-                max,
-                passedIntlKey,
-                passedIntlNS,
-                labelOverrides
-              );
-          }
         };
         handleChange = e => {
           onChange({

package/src/lib/CustomProperties/View/CustomPropertiesViewCtx.js

@@ -28,16 +28,16 @@ const CustomPropertiesViewCtx = ({
       );
     }
 
-    // Label overrides for specific contexts
-    if (labelOverrides[ctx]) {
-      return labelOverrides[ctx];
-    }
-
-    // Label override for default title or finally built in default
+    // Chain formatKintMessages together using provided fallbackMessage to
+    // allow for "If override or translation exists, use it, else use default"
     return (
       kintIntl.formatKintMessage({
-        id: 'customProperties.defaultTitle',
-        overrideValue: labelOverrides.defaultTitle
+        id: `customProperties.ctx.${ctx}`,
+        overrideValue: labelOverrides[ctx],
+        fallbackMessage: kintIntl.formatKintMessage({
+          id: 'customProperties.defaultTitle',
+          overrideValue: labelOverrides.defaultTitle
+        }, { ctx })
       }, { ctx })
     );
   };