@jxsuite/studio 8.0.1 → 9.0.0

package/src/surfaces/pane-context.ts

@@ -110,10 +110,12 @@ export interface PaneContextView {
   /** The lens's stated rendering context — "Tablet · français". */
   summary: string;
 
+  /** The Editor axis at all: drawn in the full bar, never in a lens. */
+  editorState: "shown" | "hidden";
   editorMode: "static" | "picker";
   editorLabel: string;
-  editorValue: string;
-  editorOptions: SurfaceOption[];
+  /** The declared editor kinds, one segment each, when there are several to choose between. */
+  editors: PaneContextChoice[];
 
   viewState: "shown" | "hidden";
   views: PaneContextChoice[];
@@ -126,7 +128,10 @@ export interface PaneContextView {
   previewOn: boolean;
   previewHint: string;
 
-  /** "Base · Auto" — what the rendering-context trigger reads before it is opened. */
+  /**
+   * What the More rendering context trigger reads beside its glyph: only what its popover holds and
+   * is not at rest ("français", "No layout"); empty when there is nothing to say.
+   */
   contextSummary: string;
   resolvingState: "shown" | "hidden";
   /** "2 set", or "Defaults". */
@@ -135,6 +140,8 @@ export interface PaneContextView {
   params: PaneContextParam[];
   props: PaneContextProp[];
 
+  /** The size group on the bar: hidden when the project declares no breakpoint to choose. */
+  sizesState: "shown" | "hidden";
   sizes: PaneContextChoice[];
   schemeState: "shown" | "hidden";
   schemes: PaneContextChoice[];
@@ -237,10 +244,10 @@ function project(scope: PaneContextScope, view: PaneContextView): void {
   scope.backHint = view.backHint;
   scope.bannerState = view.bannerState;
   scope.summary = view.summary;
+  scope.editorState = view.editorState;
   scope.editorMode = view.editorMode;
   scope.editorLabel = view.editorLabel;
-  scope.editorValue = view.editorValue;
-  scope.editorOptions = view.editorOptions;
+  scope.editors = view.editors;
   scope.viewState = view.viewState;
   scope.contextState = view.contextState;
   scope.views = view.views;
@@ -254,6 +261,7 @@ function project(scope: PaneContextScope, view: PaneContextView): void {
   scope.params = view.params;
   scope.props = view.props;
   scope.sizes = view.sizes;
+  scope.sizesState = view.sizesState;
   scope.schemeState = view.schemeState;
   scope.schemes = view.schemes;
   scope.localeState = view.localeState;
@@ -281,11 +289,11 @@ export function emptyPaneContextView(): PaneContextView {
     barMode: "full",
     contextRegion: "",
     contextState: "shown",
-    contextSummary: "Base",
+    contextSummary: "",
     editorLabel: "",
     editorMode: "static",
-    editorOptions: [],
-    editorValue: "",
+    editorState: "hidden",
+    editors: [],
     exportState: "hidden",
     featureState: "hidden",
     features: [],
@@ -309,6 +317,7 @@ export function emptyPaneContextView(): PaneContextView {
     resolvingState: "hidden",
     schemes: [],
     schemeState: "hidden",
+    sizesState: "hidden",
     sizes: [],
     summary: "Base",
     views: [],

package/src/surfaces/welcome.ts

@@ -22,6 +22,7 @@
 import { getAccountStatus, getBannerNotices, needsAppInstall } from "../account-status";
 import { runOfferedAction } from "../account/action-flow";
 import { platformSupportsAddRepo } from "../new-project/add-repo-modal";
+import { canOpenProject, getPlatform } from "../platform";
 import { getProjectList } from "../project-list";
 import { reactive } from "../reactivity";
 import { MINUTE, now } from "../services/clock";
@@ -226,7 +227,9 @@ function project(): Omit<WelcomeScope, "run" | "open" | "remove" | "clear" | "no
     // One entry, not two: the starter gallery IS the first step of New Project now, so the
     // Separate "Start from an Example…" button it used to hide behind is gone.
     { icon: "plus", id: "new", title: "New Project…" },
-    { icon: "folder-open", id: "open", title: "Open Project…" },
+    ...(canOpenProject(getPlatform())
+      ? [{ icon: "folder-open", id: "open", title: "Open Project…" } as const]
+      : []),
     ...(platformSupportsClone()
       ? [{ icon: "download-simple", id: "clone", title: "Clone Git Repository…" } as const]
       : []),

package/src/tabs/selection.ts

@@ -42,10 +42,22 @@
  * standing between a mixed selection and a half-applied, unrecorded delete.
  */
 
-import { isNumber } from "@jxsuite/schema/guards";
+import { isAncestor } from "@jxsuite/schema/doc-ops";
 
 import type { JxPath } from "../state";
-import { isAncestor, pathsEqual } from "../state";
+import { pathsEqual } from "../state";
+
+/* The structural-path helpers live beside the doc-op vocabulary, so any host that edits a document
+   the way Studio does orders and filters a batch the same way. Re-exported here, where every
+   Studio caller already imports them. */
+export {
+  comparePaths,
+  isSpliceablePath,
+  spliceCoordinate,
+  structuralBatch,
+  topLevelSelection,
+} from "@jxsuite/schema/doc-ops";
+export type { SpliceCoordinate } from "@jxsuite/schema/doc-ops";
 
 /**
  * The path single-target surfaces address — the most recently added, or `null` when empty.
@@ -171,113 +183,6 @@ export function pruneSelection(selection: readonly JxPath[], removed: JxPath): J
   return clonePaths(selection.filter((p) => !isAncestor(removed, p)));
 }
 
-/**
- * Order two paths the way the document reads: parents before children, siblings by index.
- *
- * Segments are compared pairwise; numbers numerically (so `children/10` follows `children/9`), and
- * anything else by string order. A prefix sorts before what extends it.
- *
- * @param {JxPath} a
- * @param {JxPath} b
- * @returns {number}
- */
-export function comparePaths(a: JxPath, b: JxPath): number {
-  const len = Math.min(a.length, b.length);
-  for (let i = 0; i < len; i++) {
-    const x = a[i]!;
-    const y = b[i]!;
-    if (x === y) {
-      continue;
-    }
-    if (isNumber(x) && isNumber(y)) {
-      return x - y;
-    }
-    return String(x) < String(y) ? -1 : 1;
-  }
-  return a.length - b.length;
-}
-
-/**
- * Drop any path whose ancestor is also selected.
- *
- * Deleting a `<section>` and one of its own paragraphs is one deletion, not two: the paragraph goes
- * with its parent, and a second splice into coordinates that no longer exist is how a batch
- * corrupts a document.
- *
- * @param {readonly JxPath[]} selection
- * @returns {JxPath[]}
- */
-export function topLevelSelection(selection: readonly JxPath[]): JxPath[] {
-  return clonePaths(
-    selection.filter((p) => !selection.some((q) => !pathsEqual(q, p) && isAncestor(q, p))),
-  );
-}
-
-/**
- * Whether `path` names a position a structural verb can splice — a tail of `"children"` + index.
- *
- * Every structural mutator (`mutateRemoveNode`, `mutateDuplicateNode`, `mutateWrapNode`) reaches
- * its parent with `parentElementPath` — drop the last two segments — and its position with
- * `childIndex` — take the last. That produces a splice coordinate for exactly one path shape, and
- * the Outline emits three others as first-class rows: the document element (`[]`), a repeater's map
- * template (`[…, "children", 1, "map"]`) and a `$switch` case (`[…, "cases", "warn"]`). For the
- * template, `parentElementPath` resolves to the enclosing children ARRAY, whose `.children` is
- * `undefined`, so the splice throws mid-transaction; for a case it splices at `NaN` and takes the
- * wrong child.
- *
- * Selecting one of those beside an ordinary element is a single ctrl-click, so this is the
- * invariant that keeps a batch from mutating the document and then throwing before anything is
- * recorded.
- *
- * @param {JxPath} path
- * @returns {boolean}
- */
-export function isSpliceablePath(path: JxPath): boolean {
-  return spliceCoordinate(path) !== null;
-}
-
-/** Where a structural verb splices: the parent element's path and the index in its children. */
-export interface SpliceCoordinate {
-  parentPath: JxPath;
-  index: number;
-}
-
-/**
- * The splice coordinate `path` names, or `null` for no path and for every path
- * {@link isSpliceablePath} refuses.
- *
- * @param {JxPath | null | undefined} path
- * @returns {SpliceCoordinate | null}
- */
-export function spliceCoordinate(path: JxPath | null | undefined): SpliceCoordinate | null {
-  const index = path?.at(-1);
-  return path && path.at(-2) === "children" && isNumber(index)
-    ? { index, parentPath: path.slice(0, -2) }
-    : null;
-}
-
-/**
- * The order a structural batch must run in: contained paths dropped, unspliceable paths dropped,
- * then LAST node first.
- *
- * Descending document order is what makes a loop of splices safe. Removing or duplicating at index
- * `n` renumbers every sibling after `n`, so a batch that starts at the end never touches a
- * coordinate a later step still needs. It is also why duplicating a multi-selection inserts each
- * clone directly after its own original instead of walking the whole run forward.
- *
- * Containment is decided BEFORE spliceability, on the selection the user actually made: a selected
- * repeater template still shadows its own descendants, so selecting the template and something
- * inside it yields nothing rather than quietly deleting the child the user never pointed at.
- *
- * @param {readonly JxPath[]} selection
- * @returns {JxPath[]} Deepest/last first, every entry a splice coordinate.
- */
-export function structuralBatch(selection: readonly JxPath[]): JxPath[] {
-  return topLevelSelection(selection)
-    .filter((path) => isSpliceablePath(path))
-    .toSorted((a, b) => comparePaths(b, a));
-}
-
 /**
  * Deduplicate a list of paths, keeping the FIRST occurrence of each.
  *

package/src/tabs/tab.ts

@@ -132,7 +132,7 @@ export interface StoredLivePreview {
   error: string | null;
 }
 
-interface HistorySnapshot {
+export interface HistorySnapshot {
   /** Full document at this state (checkpoint), or null when the ops describe the transition. */
   document: JxMutableNode | null;
   /** Selection after this state's transaction — the whole set, so a batch undoes back to it. */
@@ -153,6 +153,13 @@ interface HistorySnapshot {
    * back through the prose one pause at a time instead of undoing the edit.
    */
   coalesceKey?: string | null;
+  /**
+   * Who made this step, when it is not the person at the keyboard: the id of the actor whose batch
+   * lane closed it (specs/ai.md §3.3). Absent on a person's own edits.
+   */
+  actor?: string;
+  /** The turn whose batch this step is, beside {@link HistorySnapshot.actor}. */
+  turnId?: string;
 }
 
 /**
@@ -186,6 +193,8 @@ export interface Tab {
   scope: {
     stop: () => void;
     run: <T>(fn: () => T) => T | undefined;
+    /** False once {@link disposeTab} stopped it: how a record that outlives the tab can tell. */
+    readonly active?: boolean;
   };
   doc: {
     document: JxMutableNode;
@@ -304,12 +313,11 @@ function createDefaultUi(canvasMode: string, preview = false): TabUi {
 }
 
 /*
- * `git-diff` is here because a comparison is a MODE of a document, and until now nothing said so.
- * The Source Control panel reached it through the injected `setCanvasMode`, which performs no
- * capability check — so the mode worked while `editorKindsOf` could never report `diff`, the Editor
- * picker could never offer it, and `canvas.setMode { mode: "git-diff" }` threw for every document in
- * the project. Declaring it makes the palette, the assistant and the screenshot runner able to open
- * a comparison by name, and puts Diff on the Editor axis where §18.4 already says it belongs.
+ * `git-diff` is here because a comparison is a MODE of a document: the stage draws a document in
+ * it, `editorKindOf` names it, and a tab moved into it by the Source Control panel is a tab in a
+ * mode it declares. Declaring it does NOT make it a choice. Diff is implicit (§3): nothing offers it
+ * by name, neither the Editor axis (`panels/pane-context.ts` leaves it out) nor `canvas.setMode`
+ * (`SELECTABLE_CANVAS_MODES`), because a comparison is entered by choosing what to compare.
  */
 const ALL_MODES = ["edit", "design", "preview", "source", "stylebook", "git-diff"];