@jxsuite/studio 2.0.0 → 2.1.0

package/src/settings/general-settings.ts

@@ -1,90 +1,235 @@
 /// <reference lib="dom" />
-/** General settings section — favicon, platform adapter, breakpoints, and other site-wide config. */
+/**
+ * Overview — the project's identity: name, description, production URL, favicon, global styles.
+ *
+ * It has lost a field twice for the same reason. Breakpoints were one of **four** places `$media`
+ * could be defined (plan §4.2) and this was the only one that named them; they live in Contexts
+ * now, beside the colour schemes and feature queries they share a map with. The platform adapter
+ * has moved to Deploy in P6.2, because §2 principle 5 says a definition site is a LEVEL, not a
+ * field on some other level's form — and "what this site is" and "where it ships" are two levels.
+ */
 
 import { html, render as litRender, nothing } from "lit-html";
-import { projectState } from "../store";
+import { live } from "lit-html/directives/live.js";
+import { errorMessage } from "@jxsuite/schema/parse";
+import { projectState, updateUi } from "../store";
 import { updateSiteConfig } from "../site-context";
+import { tabOfContainer } from "../canvas/canvas-surface";
 import { getPlatform } from "../platform";
-import { openFileInTab } from "../files/files";
 
-import type { ProjectConfig } from "@jxsuite/schema/types";
+import type { JxHeadEntry, ProjectConfig } from "@jxsuite/schema/types";
+
+/** Which control an error belongs under. `"section"` puts it at the top of the section. */
+type ErrorField = "name" | "description" | "url" | "favicon" | "section";
+
+interface GeneralError {
+  field: ErrorField;
+  message: string;
+}
+
+/**
+ * The last failed write, per rendered section.
+ *
+ * A `project.json` write can fail — the disk is full, the file is read-only, the desktop RPC is
+ * gone — and every other settings editor in the tree drops that rejection on the floor with a bare
+ * `void updateSiteConfig(...)`, so the field silently snaps back to its old value. Every write in
+ * this section goes through {@link persist} instead, which parks the failure here and re-renders so
+ * the user sees it. Keyed by container so two mounted copies (and two tests) never share a
+ * message.
+ */
+const errors = new WeakMap<HTMLElement, GeneralError>();
+
+// ─── Site description ($head meta) ───────────────────────────────────────────
+
+/** True for the `<meta name="description">` entry the site description lives in. */
+function isDescriptionMeta(entry: JxHeadEntry): boolean {
+  return entry.tagName === "meta" && entry.attributes?.name === "description";
+}
+
+/**
+ * The site description. It is not a top-level `project.json` key — the composed project schema is
+ * closed (`unevaluatedProperties: false`) — so it lives where `@jxsuite/create` writes it and where
+ * the browser reads it: the `<meta name="description">` entry of `$head`.
+ */
+function readDescription(config: ProjectConfig): string {
+  const entry = (config.$head ?? []).find((e) => isDescriptionMeta(e));
+  return typeof entry?.attributes?.content === "string" ? entry.attributes.content : "";
+}
+
+/** `$head` with the description meta upserted (or dropped, when cleared). */
+function headWithDescription(head: JxHeadEntry[], text: string): JxHeadEntry[] {
+  const trimmed = text.trim();
+  if (!head.some((e) => isDescriptionMeta(e))) {
+    return trimmed
+      ? [...head, { attributes: { content: trimmed, name: "description" }, tagName: "meta" }]
+      : [...head];
+  }
+  if (!trimmed) {
+    return head.filter((entry) => !isDescriptionMeta(entry));
+  }
+  return head.map((entry) =>
+    isDescriptionMeta(entry)
+      ? { ...entry, attributes: { ...entry.attributes, content: trimmed } }
+      : entry,
+  );
+}
+
+/**
+ * The patch that _removes_ `url`. `undefined` survives the object spread inside `updateSiteConfig`
+ * and `JSON.stringify` then drops the key, so clearing the field clears the setting instead of
+ * persisting an empty string the build would have to special-case (`site-build.ts` gates the
+ * sitemap on `Boolean(url)` but still forwards `""` into the render context). The cast is the price
+ * of `exactOptionalPropertyTypes` — `ProjectConfig["url"]` is `string`, never `string |
+ * undefined`.
+ */
+const CLEAR_URL = { url: undefined } as unknown as Partial<ProjectConfig>;
+
+// ─── Render ──────────────────────────────────────────────────────────────────
 
 /** @param {HTMLElement} container */
 export function renderGeneralSettings(container: HTMLElement) {
   const config = (projectState?.projectConfig || {}) as ProjectConfig;
+  const shown = errors.get(container);
 
-  const onFaviconUpload = async () => {
-    const input = document.createElement("input");
-    input.type = "file";
-    input.accept = "image/*,.ico,.svg";
-    input.addEventListener("change", async () => {
-      const file = input.files?.[0];
-      if (!file) {
-        return;
-      }
-      const platform = getPlatform();
-      await platform.uploadFile("public/favicon.ico", file);
-      await updateSiteConfig({ favicon: "/favicon.ico" });
-      renderGeneralSettings(container);
-    });
-    input.click();
+  /** Persist a patch, surfacing the rejection instead of swallowing it. */
+  const persist = async (patch: Partial<ProjectConfig>, field: ErrorField = "section") => {
+    try {
+      await updateSiteConfig(patch);
+      errors.delete(container);
+    } catch (error) {
+      errors.set(container, {
+        field,
+        message: `Could not save project.json — ${errorMessage(error)}`,
+      });
+    }
+    renderGeneralSettings(container);
   };
 
-  const onAdapterChange = (e: Event) => {
-    void updateSiteConfig({
-      build: { ...config.build, adapter: (e.target as HTMLInputElement).value },
-    });
+  /** Park a validation failure under `field` without writing anything. */
+  const reject = (field: ErrorField, message: string) => {
+    errors.set(container, { field, message });
+    renderGeneralSettings(container);
   };
 
-  const onEditGlobalStyles = async () => {
-    // Lazy import breaks the general-settings ↔ settings-modal module cycle
-    const { closeSettingsModal } = await import("./settings-modal");
-    closeSettingsModal();
-    void openFileInTab("project.json");
-  };
+  /** The error line for one control, if that is where the current failure belongs. */
+  const errorFor = (field: ErrorField) =>
+    shown?.field === field
+      ? html`<p class="settings-field-error" role="alert">${shown.message}</p>`
+      : nothing;
 
-  // ─── Breakpoints ($media) ───────────────────────────────────────────────────
+  // ─── Site identity ─────────────────────────────────────────────────────────
 
-  const media = (config.$media || {}) as Record<string, string>;
-  const mediaEntries = Object.entries(media);
+  const onNameChange = (e: Event) => {
+    const name = (e.target as HTMLInputElement).value.trim();
+    if (!name) {
+      reject("name", "A project name is required.");
+      return;
+    }
+    void persist({ name }, "name");
+  };
 
-  const onMediaValueChange = (key: string) => (e: Event) => {
-    const updated = { ...media, [key]: (e.target as HTMLInputElement).value };
-    void updateSiteConfig({ $media: updated });
+  const onDescriptionChange = (e: Event) => {
+    const text = (e.target as HTMLInputElement).value;
+    void persist({ $head: headWithDescription(config.$head ?? [], text) }, "description");
   };
 
-  const onMediaNameChange = (oldKey: string) => (e: Event) => {
-    const rawName = (e.target as HTMLInputElement).value.trim();
-    const newKey = rawName.startsWith("--") ? rawName : `--${rawName}`;
-    if (newKey === oldKey) {
+  const onUrlChange = (e: Event) => {
+    const url = (e.target as HTMLInputElement).value.trim();
+    if (url && !/^https?:\/\/\S+$/.test(url)) {
+      reject("url", "Enter a full address starting with http:// or https://");
       return;
     }
-    const updated = {} as Record<string, string>;
-    for (const [k, v] of Object.entries(media)) {
-      updated[k === oldKey ? newKey : k] = v;
-    }
-    void updateSiteConfig({ $media: updated });
-    renderGeneralSettings(container);
+    void persist(url ? { url } : CLEAR_URL, "url");
   };
 
-  const onRemoveBreakpoint = (key: string) => () => {
-    const updated = { ...media };
-    delete updated[key];
-    void updateSiteConfig({ $media: updated });
-    renderGeneralSettings(container);
+  // ─── Favicon ───────────────────────────────────────────────────────────────
+
+  const onFaviconUpload = () => {
+    const input = document.createElement("input");
+    input.type = "file";
+    input.accept = "image/*,.ico,.svg";
+    input.addEventListener("change", async () => {
+      const file = input.files?.[0];
+      if (!file) {
+        return;
+      }
+      try {
+        await getPlatform().uploadFile("public/favicon.ico", file);
+      } catch (error) {
+        reject("favicon", `Could not upload the favicon — ${errorMessage(error)}`);
+        return;
+      }
+      await persist({ favicon: "/favicon.ico" }, "favicon");
+    });
+    input.click();
   };
 
-  const onAddBreakpoint = () => {
-    const updated = { ...media, "--new": "(max-width: 480px)" };
-    void updateSiteConfig({ $media: updated });
-    renderGeneralSettings(container);
+  /*
+   * Project Styles is the SAME document in a different editor, so this is a mode switch rather
+   * than a navigation. The predecessor closed the settings modal and opened `project.json` in a
+   * tab — the configuration IA jumping into the document IA, plan §9.3's own example of the split
+   * P6 removes. Nothing closes now, because nothing was covering anything.
+   */
+  const onEditGlobalStyles = () => {
+    // THIS pane's tab. The Project Settings editor is stage content, so a settings document
+    // Open in the side pane used to send the PRIMARY into the Stylebook.
+    updateUi(tabOfContainer(container), "canvasMode", "stylebook");
   };
 
   const currentFavicon = config.favicon;
 
   const tpl = html`
     <div class="settings-section">
-      <h3 class="settings-section-title">General</h3>
+      <h3 class="settings-section-title">Overview</h3>
+      ${errorFor("section")}
+
+      <div class="settings-field">
+        <label class="settings-field-label">Site Name</label>
+        <p class="settings-field-desc">
+          What this site is called — used in page titles and the project list.
+        </p>
+        <sp-textfield
+          size="s"
+          class="settings-site-name"
+          placeholder="My Site"
+          .value=${live(config.name ?? "")}
+          ?invalid=${shown?.field === "name"}
+          @change=${onNameChange}
+        ></sp-textfield>
+        ${errorFor("name")}
+      </div>
+
+      <div class="settings-field">
+        <label class="settings-field-label">Description</label>
+        <p class="settings-field-desc">
+          One or two sentences about the site. Search engines and link previews show this.
+        </p>
+        <sp-textfield
+          multiline
+          size="s"
+          class="settings-site-description"
+          placeholder="A short description of the site"
+          .value=${live(readDescription(config))}
+          @change=${onDescriptionChange}
+        ></sp-textfield>
+        ${errorFor("description")}
+      </div>
+
+      <div class="settings-field">
+        <label class="settings-field-label">Production URL</label>
+        <p class="settings-field-desc">
+          Where the published site lives. Sitemaps and absolute links are built from it.
+        </p>
+        <sp-textfield
+          size="s"
+          class="settings-site-url"
+          placeholder="https://example.com"
+          .value=${live(config.url ?? "")}
+          ?invalid=${shown?.field === "url"}
+          @change=${onUrlChange}
+        ></sp-textfield>
+        ${errorFor("url")}
+      </div>
 
       <div class="settings-field">
         <label class="settings-field-label">Favicon</label>
@@ -112,77 +257,15 @@ export function renderGeneralSettings(container: HTMLElement) {
               : nothing
           }
         </div>
+        ${errorFor("favicon")}
       </div>
 
       <div class="settings-field">
-        <label class="settings-field-label">Platform Adapter</label>
-        <p class="settings-field-desc">Build adapter for deployment target.</p>
-        <sp-picker
-          size="s"
-          label="Platform Adapter"
-          .value=${config.build?.adapter || "static"}
-          @change=${onAdapterChange}
-        >
-          <sp-menu-item value="static">Static</sp-menu-item>
-          <sp-menu-item value="bun">Bun</sp-menu-item>
-          <sp-menu-item value="node">Node</sp-menu-item>
-          <sp-menu-item value="cloudflare-workers">Cloudflare Workers</sp-menu-item>
-          <sp-menu-item value="cloudflare-pages">Cloudflare Pages</sp-menu-item>
-        </sp-picker>
-      </div>
-
-      <div class="settings-field">
-        <label class="settings-field-label">Breakpoints</label>
+        <label class="settings-field-label">Global Styles</label>
         <p class="settings-field-desc">
-          Responsive breakpoints for canvas panels and media query styles.
+          Design tokens and the default element styles that apply across every page. Opens Project
+          Styles over this same document.
         </p>
-        <div class="settings-media-list">
-          ${mediaEntries.map(([key, value]) => {
-            const isBase = key === "--";
-            return html`
-              <div class="settings-media-row">
-                ${
-                  isBase
-                    ? html`<span class="settings-media-name-fixed">Base</span>`
-                    : html`<sp-textfield
-                        size="s"
-                        class="settings-media-name"
-                        .value=${key.replace(/^--/, "")}
-                        placeholder="name"
-                        @change=${onMediaNameChange(key)}
-                      ></sp-textfield>`
-                }
-                <sp-textfield
-                  size="s"
-                  class="settings-media-value"
-                  .value=${value}
-                  placeholder=${isBase ? "1280px" : "(max-width: 768px)"}
-                  @change=${onMediaValueChange(key)}
-                ></sp-textfield>
-                ${
-                  isBase
-                    ? nothing
-                    : html`<sp-action-button
-                        size="s"
-                        quiet
-                        title="Remove breakpoint"
-                        @click=${onRemoveBreakpoint(key)}
-                      >
-                        ×
-                      </sp-action-button>`
-                }
-              </div>
-            `;
-          })}
-        </div>
-        <sp-action-button size="s" style="margin-top:8px" @click=${onAddBreakpoint}>
-          + Add Breakpoint
-        </sp-action-button>
-      </div>
-
-      <div class="settings-field">
-        <label class="settings-field-label">Global Styles</label>
-        <p class="settings-field-desc">Edit default element styles that apply across all pages.</p>
         <sp-action-button size="s" @click=${onEditGlobalStyles}>
           Edit Global Styles
         </sp-action-button>