@jwplayer/jwplayer-react-native 1.3.4 → 1.4.0

package/README.md

@@ -357,6 +357,29 @@ Follow this step to set up advertising with IMA or DAI:
 
 1. In the **Podfile** `ext{}`, add `$RNJWPlayerUseGoogleIMA = true`. This setting will add `GoogleAds-IMA-iOS-SDK` to the pod.
 
+#### Using a Local iOS SDK
+
+To test with a specific version of JWPlayerKit (e.g. a pre-release build provided by JW Player support):
+
+1. Acquire the `JWPlayerKit.xcframework` asset.
+2. Copy it to `ios/frameworks/JWPlayerKit.xcframework` in this repo (this path is gitignored).
+3. Add `$RNJWPlayerUseLocalSDK = true` to your **Podfile**.
+4. Run `pod install`.
+
+To switch back to the published CocoaPod, remove or comment out the `$RNJWPlayerUseLocalSDK` line and run `pod install` again.
+
+#### Using Local Android AARs
+
+To test with a specific version of the JW Player Android SDK (e.g. a pre-release build provided by JW Player support):
+
+1. Acquire the AAR files and copy them to `android/libs/` in this repo (this path is gitignored):
+   - `jwplayer-core.aar`, `jwplayer-common.aar`, `jwplayer-chromecast.aar`
+   - `jwplayer-ima.aar` (if using IMA)
+2. Set `useLocalAARs = true` in `android/build.gradle`.
+3. Rebuild the app.
+
+To switch back to Maven, set `useLocalAARs = false` and rebuild.
+
 <br /><br />
 
 ### Background Audio

package/RNJWPlayer.podspec

@@ -12,7 +12,12 @@ Pod::Spec.new do |s|
   s.platform     = :ios, "15.0"
   s.source       = { :git => "https://github.com/jwplayer/jwplayer-react-native.git", :tag => "v#{s.version}" }
   s.source_files  = "ios/RNJWPlayer/*.{h,m,swift}"
-  s.dependency   'JWPlayerKit', '4.25.1'
+  if defined?($RNJWPlayerUseLocalSDK)
+    Pod::UI.puts "RNJWPlayer: using local JWPlayerKit.xcframework"
+    s.vendored_frameworks = 'ios/frameworks/JWPlayerKit.xcframework'
+  else
+    s.dependency   'JWPlayerKit', '4.25.2'
+  end
   s.dependency   'React-Core'
   s.static_framework = true
   s.info_plist = {

package/android/build.gradle

@@ -95,7 +95,8 @@ allprojects {
     }
 }
 
-def jwPlayerVersion = "4.24.0"
+def jwPlayerVersion = "4.24.1"
+def useLocalAARs = false // Set to false to revert to Maven dependencies
 def exoplayerVersion = "2.18.7" // Deprecated. Use Media3 when targeting JW SDK > 4.16.0
 def media3ExoVersion = "1.4.1"
 
@@ -103,20 +104,28 @@ dependencies {
     implementation 'com.facebook.react:react-native:+'
     implementation 'com.google.code.gson:gson:2.9.0'
 
-    // JWPlayer SDK Core (always required)
-    implementation "com.jwplayer:jwplayer-core:${safeExtGet('jwPlayerVersion', jwPlayerVersion)}"
-    implementation "com.jwplayer:jwplayer-common:${safeExtGet('jwPlayerVersion', jwPlayerVersion)}"
-    implementation "com.jwplayer:jwplayer-chromecast:${safeExtGet('jwPlayerVersion', jwPlayerVersion)}"
-    
-    // Optional: IMA Ads support  
-    if (useIMA) {
-        implementation "com.jwplayer:jwplayer-ima:${safeExtGet('jwPlayerVersion', jwPlayerVersion)}"
-        implementation 'com.google.ads.interactivemedia.v3:interactivemedia:3.36.0'
-        implementation 'com.google.android.gms:play-services-ads-identifier:18.0.1'
-        // Core library desugaring (required for IMA SDK 3.37.0+)
-        // Using version 2.1.5 as recommended by IMA SDK documentation:
-        // https://developers.google.com/interactive-media-ads/docs/sdks/android/client-side/get-started
-        coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.1.5'
+    if (useLocalAARs) {
+        // Local AARs for debugging (built from android-sdk with diagnostic logging)
+        implementation fileTree(dir: 'libs', include: ['jwplayer-core.aar', 'jwplayer-common.aar', 'jwplayer-chromecast.aar'])
+        if (useIMA) {
+            implementation fileTree(dir: 'libs', include: ['jwplayer-ima.aar'])
+            implementation 'com.google.ads.interactivemedia.v3:interactivemedia:3.36.0'
+            implementation 'com.google.android.gms:play-services-ads-identifier:18.0.1'
+            coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.1.5'
+        }
+    } else {
+        // JWPlayer SDK Core from Maven (always required)
+        implementation "com.jwplayer:jwplayer-core:${safeExtGet('jwPlayerVersion', jwPlayerVersion)}"
+        implementation "com.jwplayer:jwplayer-common:${safeExtGet('jwPlayerVersion', jwPlayerVersion)}"
+        implementation "com.jwplayer:jwplayer-chromecast:${safeExtGet('jwPlayerVersion', jwPlayerVersion)}"
+
+        // Optional: IMA Ads support
+        if (useIMA) {
+            implementation "com.jwplayer:jwplayer-ima:${safeExtGet('jwPlayerVersion', jwPlayerVersion)}"
+            implementation 'com.google.ads.interactivemedia.v3:interactivemedia:3.36.0'
+            implementation 'com.google.android.gms:play-services-ads-identifier:18.0.1'
+            coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.1.5'
+        }
     }
 
     // Cast dependencies

package/ios/RNJWPlayer/RCTConvert+RNJWPlayer.swift

@@ -12,12 +12,12 @@ import JWPlayerKit
 extension RCTConvert {
 
     static func JWAdClient(_ value: String) -> JWAdClient {
-        switch value {
+        switch value.lowercased() {
         case "vast":
             return .JWPlayer
-        case "ima":
+        case "ima", "googima":
             return .GoogleIMA
-        case "ima_dai":
+        case "ima_dai", "googimadai":
             return .GoogleIMADAI
         default:
             return .unknown

package/ios/RNJWPlayer/RNJWPlayerView.swift

@@ -47,6 +47,7 @@ class RNJWPlayerView: UIView, JWPlayerDelegate, JWPlayerStateDelegate,
     var isCasting: Bool = false
     var availableDevices: [AnyObject]!
     var onBeforeNextPlaylistItemCompletion: ((JWPlayerItem?) -> ())?
+    var pendingConfigAfterPlaylistItemCallback: [String: Any]?
     
     @objc var onBuffer: RCTDirectEventBlock?
     @objc var onUpdateBuffer: RCTDirectEventBlock?
@@ -234,6 +235,16 @@ class RNJWPlayerView: UIView, JWPlayerDelegate, JWPlayerStateDelegate,
     }
 
     @objc func setConfig(_ config: [String: Any]) {
+        // Defer config changes while a playlist item callback is pending resolution.
+        // React Native re-renders can trigger setConfig during the window between
+        // onBeforeNextPlaylistItem firing and resolveNextPlaylistItem being called.
+        // Reconfiguring the player during this window crashes the SDK.
+        if onBeforeNextPlaylistItemCompletion != nil {
+            print("Warning: setConfig deferred — playlist item callback pending resolution")
+            pendingConfigAfterPlaylistItemCallback = config
+            return
+        }
+
         if (playerFailed) {
             playerFailed = false
             setNewConfig(config: config)
@@ -764,6 +775,11 @@ class RNJWPlayerView: UIView, JWPlayerDelegate, JWPlayerStateDelegate,
                     print("Error serializing playlist item: \(error)")
                     self.onBeforeNextPlaylistItemCompletion?(item) // Call completion handler directly on error
                     self.onBeforeNextPlaylistItemCompletion = nil
+                    // Apply any deferred config change
+                    if let pendingConfig = self.pendingConfigAfterPlaylistItemCallback {
+                        self.pendingConfigAfterPlaylistItemCallback = nil
+                        self.setConfig(pendingConfig)
+                    }
                 }
             } else {
                 print("No onBeforeNextPlaylistItem handler set, calling completion directly")
@@ -1067,8 +1083,7 @@ class RNJWPlayerView: UIView, JWPlayerDelegate, JWPlayerStateDelegate,
             for adItem in adsItem.compactMap({ $0 as? [String: Any] }) {
                 if let offsetString = adItem["offset"] as? String,
                    let tag = adItem["tag"] as? String,
-                   let encodedString = tag.addingPercentEncoding(withAllowedCharacters: .urlFragmentAllowed),
-                   let tagURL = URL(string: encodedString),
+                   let tagURL = URL(string: tag) ?? URL(string: tag.addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed) ?? ""),
                    let offset = JWAdOffset.from(string: offsetString) {
                     let adBreakBuilder = JWAdBreakBuilder()
                     adBreakBuilder.offset(offset)
@@ -1140,7 +1155,7 @@ class RNJWPlayerView: UIView, JWPlayerDelegate, JWPlayerStateDelegate,
             var advertisingConfig: JWAdvertisingConfig?
 
             var jwAdClient = JWAdClient.unknown
-            if let adClientString = ads["adClient"] as? String {
+            if let adClientString = ads["adClient"] as? String ?? ads["client"] as? String {
                 jwAdClient = RCTConvert.JWAdClient(adClientString)
             }
 

package/ios/RNJWPlayer/RNJWPlayerViewManager.swift

@@ -234,13 +234,34 @@ class RNJWPlayerViewManager: RCTViewManager {
             }
             
             if let completion = view.onBeforeNextPlaylistItemCompletion {
+                guard let itemDict = playlistItem as? [String: Any] else {
+                    print("Error: resolveNextPlaylistItem received invalid playlist item data")
+                    completion(nil)
+                    view.onBeforeNextPlaylistItemCompletion = nil
+                    return
+                }
                 do {
-                    let item = try view.getPlayerItem(item: playlistItem as! [String: Any])
-                    completion(item)
+                    let item = try view.getPlayerItem(item: itemDict)
+                    // Ensure completion runs on the main thread — the SDK performs
+                    // UI updates (view hierarchy changes) when loading the next item.
+                    DispatchQueue.main.async {
+                        completion(item)
+                        view.onBeforeNextPlaylistItemCompletion = nil
+
+                        // Apply any config change that was deferred while the callback was pending
+                        if let pendingConfig = view.pendingConfigAfterPlaylistItemCallback {
+                            view.pendingConfigAfterPlaylistItemCallback = nil
+                            view.setConfig(pendingConfig)
+                        }
+                    }
                 } catch {
                     print("Error creating JWPlayerItem: \(error)")
+                    view.onBeforeNextPlaylistItemCompletion = nil
+                    if let pendingConfig = view.pendingConfigAfterPlaylistItemCallback {
+                        view.pendingConfigAfterPlaylistItemCallback = nil
+                        view.setConfig(pendingConfig)
+                    }
                 }
-                view.onBeforeNextPlaylistItemCompletion = nil
             } else {
                 print("Warning: resolveNextPlaylistItem called but no completion handler was set OR completion handler was already called")
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwplayer/jwplayer-react-native",
-  "version": "1.3.4",
+  "version": "1.4.0",
   "description": "React-native Android/iOS plugin for JWPlayer SDK (https://www.jwplayer.com/)",
   "main": "index.js",
   "types": "./index.d.ts",

package/.github/CODEOWNERS

@@ -1,2 +0,0 @@
-# SDK Team
-* @jwplayer/team_sdks

package/.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,48 +0,0 @@
----
-name: Bug report
-about: Create a report to help us improve
-title: "[BUG]"
-labels: "needs-grooming"
-assignees: '@jwplayer/team_sdks'
-
----
-
-**Describe the bug**
-A clear and concise description of what the bug is.
-
-**To Reproduce**
-Use the `Example` application as reference material and a starting place to reproduce any bugs.
-
-***Steps to reproduce the behavior:***
-1. Provide thorough
-2. And complete
-3. Steps for reproduction
-4. That are reliably reproducible
-
-**Expected behavior**
-A clear and concise description of what you expected to happen.
-
-**Screenshots / Visual evidence**
-If applicable, add screenshots or recordings to help explain your problem. (Required if reproduction is not 100% reliable)
-
-**Desktop (please complete the following information):**
-If you are having a build issue, we would like to know about your machine. 
- - Result of `npx react-native info`
-
-**Device(s) affected**
- - Device: [e.g. iPhone6]
- - OS: [e.g. iOS8.1]
- - Version [e.g. 22]
-
-**Additional context**
-Add any other context about the problem here.
-
-**JWP Ticketing**
-To expedite resolution and maintain confidentiality, submit a JWP [request](https://support.jwplayer.com/hc/en-us/requests/new) in addition to this new `Issue`.  A JWP request offers the following benefits:
-* Associates the `Issue` with your company
-* Permits securely share sensitive information related to the bug, request, or question
-* Enhances JWP's ability to track progress and provide timely updates
-* Enables you to track and manage multiple issues through a single platform 
-
-| ℹ️ While `Issues` are valuable for open-source collaboration, a JWP request ensures that you will receive clear timelines and efficient support. |
-|:---|

package/.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,30 +0,0 @@
----
-name: Feature request
-about: Suggest an idea for this project
-title: "[FEAT]"
-labels: 'needs-grooming'
-assignees: '@jwplayer/team_sdks'
-
----
-
-**Is your feature request related to a problem? Please describe.**
-A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
-
-**Describe the solution you'd like**
-A clear and concise description of what you want to happen.
-
-**Describe alternatives you've considered**
-A clear and concise description of any alternative solutions or features you've considered.
-
-**Additional context**
-Add any other context or screenshots about the feature request here.
-
-**JWP Ticketing**
-To expedite resolution and maintain confidentiality, submit a JWP [request](https://support.jwplayer.com/hc/en-us/requests/new) in addition to this new `Issue`.  A JWP request offers the following benefits:
-* Associates the `Issue` with your company
-* Permits securely share sensitive information related to the bug, request, or question
-* Enhances JWP's ability to track progress and provide timely updates
-* Enables you to track and manage multiple issues through a single platform 
-
-| ℹ️ While `Issues` are valuable for open-source collaboration, a JWP request ensures that you will receive clear timelines and efficient support. |
-|:---|

package/.github/ISSUE_TEMPLATE/implement.md

@@ -1,26 +0,0 @@
----
-name: Implementation
-about: Request an implementation of a native feature or upgrade of SDK
-title: "[IMPLEMENT]"
-labels: 'needs-grooming'
-assignees: '@jwplayer/team_sdks'
-
----
-
-**What needs to be implemented**
-
-**How should it be implemented**
-
-**Acceptance Criteria**
-
-**Additional context**
-
-**JWP Ticketing**
-To expedite resolution and maintain confidentiality, submit a JWP [request](https://support.jwplayer.com/hc/en-us/requests/new) in addition to this new `Issue`.  A JWP request offers the following benefits:
-* Associates the `Issue` with your company
-* Permits securely share sensitive information related to the bug, request, or question
-* Enhances JWP's ability to track progress and provide timely updates
-* Enables you to track and manage multiple issues through a single platform 
-
-| ℹ️ While `Issues` are valuable for open-source collaboration, a JWP request ensures that you will receive clear timelines and efficient support. |
-|:---|

package/.github/ISSUE_TEMPLATE/question.md

@@ -1,21 +0,0 @@
----
-name: Question
-about: Ask a question about the project or product
-title: "[ASK]"
-labels: 'needs-grooming'
-assignees: '@jwplayer/team_sdks'
-
----
-
-**What isn't clear?**
-What information are we not providing that you think we should?
-
-**JWP Ticketing**
-To expedite resolution and maintain confidentiality, submit a JWP [request](https://support.jwplayer.com/hc/en-us/requests/new) in addition to this new `Issue`.  A JWP request offers the following benefits:
-* Associates the `Issue` with your company
-* Permits securely share sensitive information related to the bug, request, or question
-* Enhances JWP's ability to track progress and provide timely updates
-* Enables you to track and manage multiple issues through a single platform 
-
-| ℹ️ While `Issues` are valuable for open-source collaboration, a JWP request ensures that you will receive clear timelines and efficient support. |
-|:---|

package/.github/PULL_REQUEST_TEMPLATE.md

@@ -1,15 +0,0 @@
-### What does this Pull Request do?
-
-
-### Why is this Pull Request needed?
-
-
-### Are there any points in the code the reviewer needs to double check?
-
-
-### Are there any Pull Requests open in other repos which need to be merged with this?
-
-
-#### Addresses Issue(s):
-
-[GitHub Issue](https://github.com/jwplayer/jwplayer-react-native/issues/###)

package/CODE_OF_CONDUCT.md

@@ -1,128 +0,0 @@
-# Contributor Covenant Code of Conduct
-
-## Our Pledge
-
-We as members, contributors, and leaders pledge to make participation in our
-community a harassment-free experience for everyone, regardless of age, body
-size, visible or invisible disability, ethnicity, sex characteristics, gender
-identity and expression, level of experience, education, socio-economic status,
-nationality, personal appearance, race, religion, or sexual identity
-and orientation.
-
-We pledge to act and interact in ways that contribute to an open, welcoming,
-diverse, inclusive, and healthy community.
-
-## Our Standards
-
-Examples of behavior that contributes to a positive environment for our
-community include:
-
-* Demonstrating empathy and kindness toward other people
-* Being respectful of differing opinions, viewpoints, and experiences
-* Giving and gracefully accepting constructive feedback
-* Accepting responsibility and apologizing to those affected by our mistakes,
-  and learning from the experience
-* Focusing on what is best not just for us as individuals, but for the
-  overall community
-
-Examples of unacceptable behavior include:
-
-* The use of sexualized language or imagery, and sexual attention or
-  advances of any kind
-* Trolling, insulting or derogatory comments, and personal or political attacks
-* Public or private harassment
-* Publishing others' private information, such as a physical or email
-  address, without their explicit permission
-* Other conduct which could reasonably be considered inappropriate in a
-  professional setting
-
-## Enforcement Responsibilities
-
-Community leaders are responsible for clarifying and enforcing our standards of
-acceptable behavior and will take appropriate and fair corrective action in
-response to any behavior that they deem inappropriate, threatening, offensive,
-or harmful.
-
-Community leaders have the right and responsibility to remove, edit, or reject
-comments, commits, code, wiki edits, issues, and other contributions that are
-not aligned to this Code of Conduct, and will communicate reasons for moderation
-decisions when appropriate.
-
-## Scope
-
-This Code of Conduct applies within all community spaces, and also applies when
-an individual is officially representing the community in public spaces.
-Examples of representing our community include using an official e-mail address,
-posting via an official social media account, or acting as an appointed
-representative at an online or offline event.
-
-## Enforcement
-
-Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported to the community leaders responsible for enforcement at
-conduct@jwplayer.com.
-All complaints will be reviewed and investigated promptly and fairly.
-
-All community leaders are obligated to respect the privacy and security of the
-reporter of any incident.
-
-## Enforcement Guidelines
-
-Community leaders will follow these Community Impact Guidelines in determining
-the consequences for any action they deem in violation of this Code of Conduct:
-
-### 1. Correction
-
-**Community Impact**: Use of inappropriate language or other behavior deemed
-unprofessional or unwelcome in the community.
-
-**Consequence**: A private, written warning from community leaders, providing
-clarity around the nature of the violation and an explanation of why the
-behavior was inappropriate. A public apology may be requested.
-
-### 2. Warning
-
-**Community Impact**: A violation through a single incident or series
-of actions.
-
-**Consequence**: A warning with consequences for continued behavior. No
-interaction with the people involved, including unsolicited interaction with
-those enforcing the Code of Conduct, for a specified period of time. This
-includes avoiding interactions in community spaces as well as external channels
-like social media. Violating these terms may lead to a temporary or
-permanent ban.
-
-### 3. Temporary Ban
-
-**Community Impact**: A serious violation of community standards, including
-sustained inappropriate behavior.
-
-**Consequence**: A temporary ban from any sort of interaction or public
-communication with the community for a specified period of time. No public or
-private interaction with the people involved, including unsolicited interaction
-with those enforcing the Code of Conduct, is allowed during this period.
-Violating these terms may lead to a permanent ban.
-
-### 4. Permanent Ban
-
-**Community Impact**: Demonstrating a pattern of violation of community
-standards, including sustained inappropriate behavior,  harassment of an
-individual, or aggression toward or disparagement of classes of individuals.
-
-**Consequence**: A permanent ban from any sort of public interaction within
-the community.
-
-## Attribution
-
-This Code of Conduct is adapted from the [Contributor Covenant][homepage],
-version 2.0, available at
-https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
-
-Community Impact Guidelines were inspired by [Mozilla's code of conduct
-enforcement ladder](https://github.com/mozilla/diversity).
-
-[homepage]: https://www.contributor-covenant.org
-
-For answers to common questions about this code of conduct, see the FAQ at
-https://www.contributor-covenant.org/faq. Translations are available at
-https://www.contributor-covenant.org/translations.

package/badges/license.svg

@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="78" height="20" role="img" aria-label="license: MIT"><title>license: MIT</title><linearGradient id="s" x2="0" y2="100%"><stop offset="0" stop-color="#bbb" stop-opacity=".1"/><stop offset="1" stop-opacity=".1"/></linearGradient><clipPath id="r"><rect width="78" height="20" rx="3" fill="#fff"/></clipPath><g clip-path="url(#r)"><rect width="47" height="20" fill="#555"/><rect x="47" width="31" height="20" fill="#97ca00"/><rect width="78" height="20" fill="url(#s)"/></g><g fill="#fff" text-anchor="middle" font-family="Verdana,Geneva,DejaVu Sans,sans-serif" text-rendering="geometricPrecision" font-size="110"><text aria-hidden="true" x="245" y="150" fill="#010101" fill-opacity=".3" transform="scale(.1)" textLength="370">license</text><text x="245" y="140" transform="scale(.1)" fill="#fff" textLength="370">license</text><text aria-hidden="true" x="615" y="150" fill="#010101" fill-opacity=".3" transform="scale(.1)" textLength="210">MIT</text><text x="615" y="140" transform="scale(.1)" fill="#fff" textLength="210">MIT</text></g></svg>

package/badges/version.svg

@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="90" height="20" role="img" aria-label="version: 1.3.4"><title>version: 1.3.4</title><linearGradient id="s" x2="0" y2="100%"><stop offset="0" stop-color="#bbb" stop-opacity=".1"/><stop offset="1" stop-opacity=".1"/></linearGradient><clipPath id="r"><rect width="90" height="20" rx="3" fill="#fff"/></clipPath><g clip-path="url(#r)"><rect width="51" height="20" fill="#555"/><rect x="51" width="39" height="20" fill="#007ec6"/><rect width="90" height="20" fill="url(#s)"/></g><g fill="#fff" text-anchor="middle" font-family="Verdana,Geneva,DejaVu Sans,sans-serif" text-rendering="geometricPrecision" font-size="110"><text aria-hidden="true" x="265" y="150" fill="#010101" fill-opacity=".3" transform="scale(.1)" textLength="410">version</text><text x="265" y="140" transform="scale(.1)" fill="#fff" textLength="410">version</text><text aria-hidden="true" x="695" y="150" fill="#010101" fill-opacity=".3" transform="scale(.1)" textLength="290">1.3.4</text><text x="695" y="140" transform="scale(.1)" fill="#fff" textLength="290">1.3.4</text></g></svg>