@jwplayer/jwplayer-react-native 1.3.1 → 1.3.3

package/CLAUDE.md

@@ -0,0 +1,105 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Project Overview
+
+This is `@jwplayer/jwplayer-react-native`, a React Native bridge library for the JW Player native SDKs (JWPlayerKit for iOS and JW SDK 4 for Android). It wraps native video player functionality for use in React Native applications.
+
+## Common Commands
+
+### Library Development
+```bash
+npm run lint                    # Lint the library (index.js and example)
+```
+
+### Example App (from Example/ directory)
+```bash
+cd Example
+yarn                           # Install dependencies
+yarn ios                       # Run iOS app
+yarn android                   # Run Android app
+yarn start                     # Start Metro bundler
+yarn test                      # Run Jest tests
+pod install --project-directory=ios  # Install iOS CocoaPods
+```
+
+### Building for Release
+The library is published to npm as `@jwplayer/jwplayer-react-native`. Version badges are generated with:
+```bash
+npm run badges:version
+npm run badges:license
+```
+
+## Architecture
+
+### Bridge Structure
+- **index.js**: Main React component (`JWPlayer`) that wraps the native view and exposes methods via `NativeModules`
+- **index.d.ts**: TypeScript type definitions for the entire public API
+
+### Native Implementations
+- **iOS** (`ios/RNJWPlayer/`):
+  - `RNJWPlayerView.swift`: Main player view implementation (~89KB, handles player lifecycle, events, config parsing)
+  - `RNJWPlayerViewController.swift`: View controller for fullscreen/PiP support
+  - `RNJWPlayerViewManager.swift` + `.m`: React Native view manager bridge
+  - `RNJWPlayerAds.swift`: Advertising configuration helpers
+
+- **Android** (`android/src/main/java/com/jwplayer/rnjwplayer/`):
+  - `RNJWPlayerView.java`: Main player view implementation
+  - `RNJWPlayerViewManager.java`: React Native view manager
+  - `RNJWPlayerModule.java`: Native module for imperative methods
+  - `RNJWPlayerAds.java`: Ad configuration handling
+  - `ImaHelper.java`: Conditional IMA support (separate source sets in `src/ima/` and `src/noima/`)
+
+### Configuration System
+The library supports two configuration modes:
+1. **Modern Configuration** (recommended): Uses `JWPlayerConfig` type matching JW Player Delivery API format
+2. **Legacy Configuration**: Set `forceLegacyConfig={true}` for older builder patterns
+
+Type definitions are split across:
+- `types/unified-config.d.ts`: Main configuration interface
+- `types/advertising.d.ts`: Ad configuration types (VAST, IMA, IMA DAI)
+- `types/playlist.d.ts`: Playlist and media item types
+- `types/platform-specific.d.ts`: iOS/Android specific options
+
+### Feature Flags (Build-time)
+Features are conditionally compiled via build flags:
+
+**iOS** (in Podfile):
+```ruby
+$RNJWPlayerUseGoogleIMA = true   # Enables IMA ads
+$RNJWPlayerUseGoogleCast = true  # Enables Chromecast
+```
+
+**Android** (in app's build.gradle ext{}):
+```groovy
+RNJWPlayerUseGoogleIMA = true    # Enables IMA ads
+RNJWPlayerUseGoogleCast = true   # Enables Chromecast
+```
+
+### SDK Versions
+- iOS: JWPlayerKit 4.25.0 (defined in `RNJWPlayer.podspec`)
+- Android: JW Player 4.24.0 (defined in `android/build.gradle`)
+
+## Key Implementation Details
+
+### Player State Constants
+Player states differ between platforms:
+- iOS: `JWPlayerStateIOS` (0=Unknown, 1=Idle, 2=Buffering, 3=Playing, 4=Paused, 5=Complete, 6=Error)
+- Android: `JWPlayerStateAndroid` (0=Idle, 1=Buffering, 2=Playing, 3=Paused, 4=Complete, Error=null)
+
+### Event Flow
+Native events flow through React Native's event system. The component forwards events like `onPlayerReady`, `onPlay`, `onPause`, `onTime`, `onComplete`, `onPlayerError`, etc.
+
+### Imperative Methods
+Methods like `play()`, `pause()`, `seekTo()`, `setFullscreen()` are called via `NativeModules` using the player's bridge handle obtained through `findNodeHandle()`.
+
+## Example App Structure
+
+The Example app (`Example/`) demonstrates various use cases:
+- `SingleExample.js`: Basic player setup
+- `DRMExample.js`: Fairplay/Widevine DRM playback
+- `TypeScriptExample.tsx`: Modern TypeScript configuration
+- `GlobalPlayerExample.js`: Player with full-screen and controls
+- `ListExample.js`: Multiple players in a list
+- `YoutubeExample.js`: Playing YouTube content

package/RNJWPlayer.podspec

@@ -12,7 +12,7 @@ Pod::Spec.new do |s|
   s.platform     = :ios, "15.0"
   s.source       = { :git => "https://github.com/jwplayer/jwplayer-react-native.git", :tag => "v#{s.version}" }
   s.source_files  = "ios/RNJWPlayer/*.{h,m,swift}"
-  s.dependency   'JWPlayerKit', '4.25.0'
+  s.dependency   'JWPlayerKit', '4.25.1'
   s.dependency   'React-Core'
   s.static_framework = true
   s.info_plist = {

package/android/src/ima/java/com/jwplayer/rnjwplayer/ImaHelper.java

@@ -21,7 +21,6 @@ import java.util.Objects;
 public class ImaHelper {
     
     public static AdvertisingConfig configureImaOrDai(ReadableMap ads, List<AdBreak> adSchedule) {
-        cd /Users/jmilham/source/sdk/react/jwplayer-react-native/Example && yarn remove @jwplayer/jwplayer-react-native && yarn add file:../ 2>&1 | tail -20        // Check both "client" (JWPlayer JSON format) and "adClient" (RN wrapper format)
         String adClientType = null;
         if (ads.hasKey("adClient")) {
             adClientType = ads.getString("adClient");

package/android/src/main/java/com/jwplayer/rnjwplayer/RNJWPlayerView.java

@@ -243,6 +243,9 @@ public class RNJWPlayerView extends RelativeLayout implements
     // Add completion handler field
     PlaylistItemDecision itemUpdatePromise = null;
 
+    // Flag to prevent race conditions during player destruction
+    private volatile boolean isDestroying = false;
+
     private void doBindService() {
         if (mMediaServiceController != null) {
             if (!isBackgroundAudioServiceRunning()) {
@@ -380,7 +383,22 @@ public class RNJWPlayerView extends RelativeLayout implements
     // }
 
     public void destroyPlayer() {
-        if (mPlayer != null) {
+        if (mPlayer != null && !isDestroying) {
+            isDestroying = true;
+            
+            // Disable touch events immediately to prevent race conditions
+            if (mPlayerView != null) {
+                Handler mainHandler = new Handler(Looper.getMainLooper());
+                mainHandler.post(() -> {
+                    if (mPlayerView != null) {
+                        mPlayerView.setClickable(false);
+                        mPlayerView.setFocusable(false);
+                        mPlayerView.setEnabled(false);
+                        mPlayerView.setOnTouchListener(null);
+                    }
+                });
+            }
+            
             unRegisterReceiver();
 
             // If we are casting we need to break the cast session as there is no simple
@@ -480,6 +498,8 @@ public class RNJWPlayerView extends RelativeLayout implements
             audioManager = null;
 
             doUnbindService();
+            
+            isDestroying = false; // Reset flag for potential reuse
         }
     }
 

package/android/src/main/java/com/jwplayer/rnjwplayer/RNJWPlayerViewManager.java

@@ -1,5 +1,7 @@
 package com.jwplayer.rnjwplayer;
 
+import android.util.Log;
+
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReadableMap;
 import com.facebook.react.common.MapBuilder;
@@ -43,7 +45,14 @@ public class RNJWPlayerViewManager extends SimpleViewManager<RNJWPlayerView> {
     if (view == null || view.mPlayerView == null) {
       return;
     }
-    view.mPlayerView.getPlayer().setControls(controls);
+    // Add null check for getPlayer() to prevent crashes
+    try {
+      if (view.mPlayerView.getPlayer() != null) {
+        view.mPlayerView.getPlayer().setControls(controls);
+      }
+    } catch (Exception e) {
+      Log.w(TAG, "Error setting controls: " + e.getMessage());
+    }
   }
 
   /**
@@ -58,8 +67,15 @@ public class RNJWPlayerViewManager extends SimpleViewManager<RNJWPlayerView> {
     if (view == null || view.mPlayerView == null) {
       return;
     }
-    view.mPlayerView.getPlayer().stop();
-    view.setConfig(config);
+    // Add null check for getPlayer() to prevent crashes
+    try {
+      if (view.mPlayerView.getPlayer() != null) {
+        view.mPlayerView.getPlayer().stop();
+      }
+      view.setConfig(config);
+    } catch (Exception e) {
+      Log.w(TAG, "Error recreating player: " + e.getMessage());
+    }
   }
 
   public Map getExportedCustomBubblingEventTypeConstants() {

package/badges/version.svg

@@ -1 +1 @@
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="90" height="20" role="img" aria-label="version: 1.3.1"><title>version: 1.3.1</title><linearGradient id="s" x2="0" y2="100%"><stop offset="0" stop-color="#bbb" stop-opacity=".1"/><stop offset="1" stop-opacity=".1"/></linearGradient><clipPath id="r"><rect width="90" height="20" rx="3" fill="#fff"/></clipPath><g clip-path="url(#r)"><rect width="51" height="20" fill="#555"/><rect x="51" width="39" height="20" fill="#007ec6"/><rect width="90" height="20" fill="url(#s)"/></g><g fill="#fff" text-anchor="middle" font-family="Verdana,Geneva,DejaVu Sans,sans-serif" text-rendering="geometricPrecision" font-size="110"><text aria-hidden="true" x="265" y="150" fill="#010101" fill-opacity=".3" transform="scale(.1)" textLength="410">version</text><text x="265" y="140" transform="scale(.1)" fill="#fff" textLength="410">version</text><text aria-hidden="true" x="695" y="150" fill="#010101" fill-opacity=".3" transform="scale(.1)" textLength="290">1.3.1</text><text x="695" y="140" transform="scale(.1)" fill="#fff" textLength="290">1.3.1</text></g></svg>
+<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="90" height="20" role="img" aria-label="version: 1.3.3"><title>version: 1.3.3</title><linearGradient id="s" x2="0" y2="100%"><stop offset="0" stop-color="#bbb" stop-opacity=".1"/><stop offset="1" stop-opacity=".1"/></linearGradient><clipPath id="r"><rect width="90" height="20" rx="3" fill="#fff"/></clipPath><g clip-path="url(#r)"><rect width="51" height="20" fill="#555"/><rect x="51" width="39" height="20" fill="#007ec6"/><rect width="90" height="20" fill="url(#s)"/></g><g fill="#fff" text-anchor="middle" font-family="Verdana,Geneva,DejaVu Sans,sans-serif" text-rendering="geometricPrecision" font-size="110"><text aria-hidden="true" x="265" y="150" fill="#010101" fill-opacity=".3" transform="scale(.1)" textLength="410">version</text><text x="265" y="140" transform="scale(.1)" fill="#fff" textLength="410">version</text><text aria-hidden="true" x="695" y="150" fill="#010101" fill-opacity=".3" transform="scale(.1)" textLength="290">1.3.3</text><text x="695" y="140" transform="scale(.1)" fill="#fff" textLength="290">1.3.3</text></g></svg>

package/ios/RNJWPlayer/RNJWPlayerView.swift

@@ -1255,10 +1255,16 @@ class RNJWPlayerView: UIView, JWPlayerDelegate, JWPlayerStateDelegate,
     }
 
     func dismissPlayerViewController() {
-        if (playerViewController != nil) {
-            playerViewController.player.pause() // hack for stop not always stopping on unmount
-            playerViewController.player.stop()
-            playerViewController.enableLockScreenControls = false
+        guard playerViewController != nil else { return }
+        
+        // Ensure UI operations happen on main thread to prevent crashes
+        // when deinit is called from a background thread during unmount
+        let cleanup = { [self] in
+            guard let pvc = self.playerViewController else { return }
+            
+            pvc.player.pause() // hack for stop not always stopping on unmount
+            pvc.player.stop()
+            pvc.enableLockScreenControls = false
 
             // hack for stop not always stopping on unmount
             let configBuilder:JWPlayerConfigurationBuilder! = JWPlayerConfigurationBuilder()
@@ -1266,19 +1272,24 @@ class RNJWPlayerView: UIView, JWPlayerDelegate, JWPlayerStateDelegate,
             
             do {
                 let configuration: JWPlayerConfiguration = try configBuilder.build()
-                playerViewController.player.configurePlayer(with: configuration)
+                pvc.player.configurePlayer(with: configuration)
             } catch {
                 print(error)
             }
             
-
-            playerViewController.parentView = nil
-            playerViewController.setVisibility(.hidden, for:[.pictureInPictureButton])
-            playerViewController.view.removeFromSuperview()
-            playerViewController.removeFromParent()
-            playerViewController.willMove(toParent: nil)
-            playerViewController.removeDelegates()
-            playerViewController = nil
+            pvc.parentView = nil
+            pvc.setVisibility(.hidden, for:[.pictureInPictureButton])
+            pvc.view.removeFromSuperview()
+            pvc.removeFromParent()
+            pvc.willMove(toParent: nil)
+            pvc.removeDelegates()
+            self.playerViewController = nil
+        }
+        
+        if Thread.isMainThread {
+            cleanup()
+        } else {
+            DispatchQueue.main.sync(execute: cleanup)
         }
     }
 
@@ -1330,10 +1341,21 @@ class RNJWPlayerView: UIView, JWPlayerDelegate, JWPlayerStateDelegate,
     }
 
     func removePlayerView() {
-        if (playerView != nil) {
-            playerView.player.stop()
-            playerView.removeFromSuperview()
-            playerView = nil
+        guard playerView != nil else { return }
+        
+        // Ensure UI operations happen on main thread to prevent crashes
+        // when deinit is called from a background thread during unmount
+        let cleanup = { [self] in
+            guard let pv = self.playerView else { return }
+            pv.player.stop()
+            pv.removeFromSuperview()
+            self.playerView = nil
+        }
+        
+        if Thread.isMainThread {
+            cleanup()
+        } else {
+            DispatchQueue.main.sync(execute: cleanup)
         }
     }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwplayer/jwplayer-react-native",
-  "version": "1.3.1",
+  "version": "1.3.3",
   "description": "React-native Android/iOS plugin for JWPlayer SDK (https://www.jwplayer.com/)",
   "main": "index.js",
   "types": "./index.d.ts",