@jwilger/pi-development-system 0.8.7 → 0.8.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.8.7",
+  "version": "0.8.8",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/src/core/commit-command.ts

@@ -6,7 +6,12 @@ export type CommitExtraction =
   | { readonly kind: "not-commit" }
   | { readonly kind: "message"; readonly message: string }
   | { readonly kind: "file"; readonly path: string }
-  | { readonly kind: "unknown"; readonly trailers: readonly string[] };
+  | {
+      readonly kind: "unknown";
+      readonly trailers: readonly string[];
+      /** A `-m` value is a substitution or variable: the message exists but cannot be read. */
+      readonly opaqueMessage: boolean;
+    };
 
 type Options = {
   messages: string[];
@@ -77,9 +82,10 @@ function readOptions(args: readonly string[]): Options {
   return options;
 }
 
-const unknown = (trailers: readonly string[] = []): CommitExtraction => ({
+const unknown = (trailers: readonly string[] = [], opaqueMessage = false): CommitExtraction => ({
   kind: "unknown",
   trailers,
+  opaqueMessage,
 });
 
 const STDIN_PATHS = new Set(["-", "/dev/stdin", "/proc/self/fd/0"]);
@@ -104,7 +110,7 @@ function extractOne(args: readonly string[], heredoc: string | undefined): Commi
   if (options.file !== undefined) return { kind: "file", path: options.file };
   const parts = [...options.messages];
   if (options.opaque) {
-    if (heredoc === undefined) return unknown(options.trailers);
+    if (heredoc === undefined) return unknown(options.trailers, true);
     parts.push(heredoc);
   }
   if (parts.length === 0) return unknown(options.trailers);

package/src/gates/commit-guard.ts

@@ -170,6 +170,12 @@ export function registerCommitGuard(deps: CommitGuardDeps): void {
         why: "the message file cannot be read before the commit runs, so its rationale cannot be checked; use -m or a heredoc",
       });
     }
+    if (extractions.some((e) => e.kind === "unknown" && e.opaqueMessage)) {
+      all.push({
+        gate: RATIONALE,
+        why: "the message is built by a substitution or variable and cannot be checked; use a literal -m or a heredoc",
+      });
+    }
     for (const message of known) {
       for (const need of await needsOf(deps, ctx, message, command)) {
         if (!all.some((n) => n.gate === need.gate)) all.push(need);