@jwilger/pi-development-system 0.8.4 → 0.8.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.8.4",
+  "version": "0.8.5",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/src/core/commit-message.ts

@@ -101,10 +101,15 @@ export function findForbiddenTrailerKeys(text: string): string[] {
   return [...text.matchAll(AI_TRAILER_ANYWHERE)].map((m) => m[0].trim());
 }
 
-const isBullets = (paragraph: string): boolean =>
-  paragraph.split("\n").every((line) => /^\s*(?:[-*+]|\d+[.)])\s/.test(line));
-
+const BULLET = /^\s*(?:[-*+]|\d+[.)])\s+/;
 const wordCount = (text: string): number => text.split(/\s+/).filter((w) => w !== "").length;
+const SHORT_BULLET_WORDS = 5;
+
+/** A list of file names or other terse items; bullets that explain themselves are prose. */
+const isTerseList = (paragraph: string): boolean =>
+  paragraph
+    .split("\n")
+    .every((line) => BULLET.test(line) && wordCount(line.replace(BULLET, "")) < SHORT_BULLET_WORDS);
 
 const PROSE_TRAILER_WORDS = 5;
 
@@ -124,6 +129,6 @@ export function hasRationaleBody(message: string): boolean {
       ?.split("\n") ?? [];
   const proseTrailer = trailers.length > 0 && trailerBlockLines.some(isProseTrailer);
   return (
-    proseTrailer || body.some((paragraph) => !isBullets(paragraph) && wordCount(paragraph) >= 5)
+    proseTrailer || body.some((paragraph) => !isTerseList(paragraph) && wordCount(paragraph) >= 5)
   );
 }

package/src/core/git-intent.ts

@@ -58,14 +58,24 @@ export function splitLines(command: string): string[] {
 
 const isRedirect = (op: string): boolean => /^[<>]/.test(op) && !op.endsWith("(");
 
-/** Tokens of one line grouped into simple commands (operators separate segments). */
+/** Tokens of one line grouped into simple commands (operators separate segments; redirects and their operands are dropped). */
 export function segments(line: string): string[][] {
   const result: string[][] = [[]];
+  let skipOperand = false;
   for (const token of parseShell(line, (name) => `$${name}`)) {
-    if (typeof token === "string") result[result.length - 1]?.push(token);
-    else if ("pattern" in token) result[result.length - 1]?.push(token.pattern);
-    else if ("op" in token && isRedirect(token.op)) continue;
-    else if (!("comment" in token)) result.push([]);
+    const current = result[result.length - 1];
+    if (typeof token === "string" || "pattern" in token) {
+      const text = typeof token === "string" ? token : token.pattern;
+      if (!skipOperand) current?.push(text);
+      skipOperand = false;
+    } else if ("op" in token && isRedirect(token.op)) {
+      // `2>&1`, `>/dev/null`: the file descriptor before it and the target after it are not arguments.
+      if (/^\d+$/.test(current?.at(-1) ?? "")) current?.pop();
+      skipOperand = true;
+    } else if (!("comment" in token)) {
+      result.push([]);
+      skipOperand = false;
+    }
   }
   return result.filter((s) => s.length > 0);
 }

package/src/gates/commit-guard.ts

@@ -63,7 +63,9 @@ function messageNeeds(message: string): Need[] {
 
 /** `-a`/`--all`, or a `git add` in the same command, widen the commit beyond what is staged. */
 const stagesEverything = (command: string): boolean =>
-  /(?:^|\s)(?:-[a-zA-Z]*a[a-zA-Z]*|--all|--include)(?:\s|$)|\bgit\s+add\b/.test(command);
+  /\bgit\b[^;&|\n]*\bcommit\b[^;&|\n]*\s(?:-[a-zA-Z]*a[a-zA-Z]*|--all|--include)(?:\s|$)|\bgit\s+add\s+(?:-A|--all|-u|\.)(?:\s|$)/.test(
+    command,
+  );
 
 /** What is about to be committed: the staged changes, or every tracked change when the commit stages them itself. */
 async function pendingDiff(

package/src/gates/push-guard.ts

@@ -66,7 +66,7 @@ async function pushesTrunk(
 }
 
 /** Whether the unpushed work is a `fix` commit whose diff Jev reads as only repairing the red build. */
-async function repairsRedTrunk(
+async function judgeRepair(
   deps: PushGuardDeps,
   ctx: ExtensionContext,
   config: DevsysConfig,
@@ -94,6 +94,20 @@ async function repairsRedTrunk(
   return judged.ok && judged.value >= FIX_RELATED_THRESHOLD;
 }
 
+/** Fails closed: any exec failure means the push is not shown to repair the red build. */
+async function repairsRedTrunk(
+  deps: PushGuardDeps,
+  ctx: ExtensionContext,
+  config: DevsysConfig,
+  runId: number | undefined,
+): Promise<boolean> {
+  try {
+    return await judgeRepair(deps, ctx, config, runId);
+  } catch {
+    return false;
+  }
+}
+
 type HardStop = {
   readonly ctx: ExtensionContext;
   readonly toolCallId: string;