@jwilger/pi-development-system 0.70.0 → 0.72.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.70.0",
+  "version": "0.72.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/prompts/devsys-plan.md

@@ -9,4 +9,4 @@ Write the plan for the current work with the work-intake-and-slicing skill.
 3. Write each task so that someone who sees only that task could finish it. Never write `TBD`.
 4. Run `devsys_task_check` on every task record you wrote and fix each one until it says ready. Split any that come back too-big.
 5. Stop and ask the user to review the plan before any implementation starts. Do not start a goal yet: a goal tool may continue on its own and begin implementing before the review.
-6. Only after the user approves the plan: call `devsys_begin_work` (so the review and red-first gates are on while the plan is built). Then, if a `create_goal` tool exists in this session, call it with the objective "complete docs/plan/<slug>.md honouring its Constraints and Progress checklist, one increment at a time, stopping after each increment's Release step". Otherwise tell the user the plan path so they can start a goal on it. Do not depend on any goal tool's file format.
+6. Only after the user approves the plan: call `devsys_begin_work` (so the review and red-first gates are on while the plan is built; it does nothing if the work is already implementing). Then, if a `create_goal` tool exists in this session, call it with the objective "complete docs/plan/<slug>.md honouring its Constraints and Progress checklist, one increment at a time, stopping after each increment's Release step". Otherwise tell the user the plan path so they can start a goal on it. Do not depend on any goal tool's file format.

package/prompts/devsys-start.md

@@ -6,6 +6,6 @@ Start new work with the work-intake-and-slicing skill.
 
 1. Call `devsys_intake` with `request` set to: $ARGUMENTS (if empty, ask the user what they want done first).
 2. Show the user the proposed size and artifacts. The tool asks them to confirm or change the size.
-3. Produce the planning artifacts first (brief, journeys, event model, architecture, lens review, in that order, whichever are recommended), then the task record. `review` and `adr-if-needed` are not written up front: review happens on the finished slice, and an ADR when a decision needs one. To skip one, call `devsys_record_departure` with gate `artifact.skipped:<artifact>` and the reason; do not skip silently. The event model and architecture are recommendations, never gates.
-4. For `capability` and `product` the phase stays `planning` while you produce the artifacts; once the user approves them, call `devsys_begin_work` so the review and red-first gates switch on.
+3. Produce the planning artifacts first (brief, decision register, journeys, event model, architecture, lens review, in that order, whichever are recommended), then the task record. `review` and `adr-if-needed` are not written up front: review happens on the finished slice, and an ADR when a decision needs one. To skip one, call `devsys_record_departure` with gate `artifact.skipped:<artifact>` and the reason; do not skip silently. The event model and architecture are recommendations, never gates.
+4. For `capability` and `product` the phase stays `planning` while you produce the artifacts and the plan. The single point where it changes is the user approving the whole plan: then call `devsys_begin_work` so the review and red-first gates switch on (it does nothing if already implementing).
 5. For a confirmed `fix` the user is also asked whether to skip fresh-context review (it is logged if they say yes; if no, the slice needs its review rounds). For `fix` and `change` the phase is already `implementing`: write the task record, then work it test-first.

package/src/planning/begin-tool.ts

@@ -13,7 +13,7 @@ const reply = (text: string, isError = false) => ({
 /**
  * `devsys_begin_work`: the planning → implementing transition. Intake leaves capability and product work in
  * `planning`; the review and red-first gates only run while implementing, so without this step the largest work
- * would get the fewest gates. Call it once the user has approved the plan.
+ * would get the fewest gates. Call it once the user has approved the plan; when already implementing it is a harmless no-op.
  */
 export function createBeginWorkTool(deps: {
   state: SessionState;
@@ -28,6 +28,13 @@ export function createBeginWorkTool(deps: {
     exposure: "direct",
     execute(_id, _params: Static<typeof Parameters>) {
       const { phase, activeSlice } = deps.state.get();
+      if (phase === "implementing" && activeSlice !== undefined) {
+        return Promise.resolve(
+          reply(
+            `Already implementing slice ${activeSlice}; the review and red-first gates are on.`,
+          ),
+        );
+      }
       if (phase !== "planning" || activeSlice === undefined) {
         return Promise.resolve(
           reply(

package/src/tracker/repo-files.ts

@@ -15,8 +15,11 @@ import {
 const ID = /^[a-z0-9][a-z0-9-]*$/;
 const ID_MAX = 60;
 
+/** ASCII id from a title: accents are folded (Résumé → resume); a title with no ASCII letters or digits becomes `item`. */
 const slugOf = (title: string): string =>
   title
+    .normalize("NFD")
+    .replace(/\p{M}+/gu, "")
     .toLowerCase()
     .replace(/[^a-z0-9]+/g, "-")
     .replace(/^-+/, "")
@@ -79,9 +82,8 @@ const save = async (root: string, item: WorkItem): Promise<TrackerResult<WorkIte
   return ok(item);
 };
 
-const freshId = async (root: string, title: string): Promise<string | undefined> => {
-  const base = slugOf(title);
-  if (base === "") return undefined;
+const freshId = async (root: string, title: string): Promise<string> => {
+  const base = slugOf(title) || "item";
   const taken = new Set(await itemIds(root));
   let id = base;
   for (let n = 2; taken.has(id); n++) id = `${base}-${n}`;
@@ -97,10 +99,8 @@ const listItems = async (root: string, filter: ItemFilter): Promise<TrackerResul
 const createItem = async (root: string, input: NewWorkItem): Promise<TrackerResult<WorkItem>> => {
   const problem = unwritable({ title: input.title, labels: input.labels ?? [] });
   if (problem !== undefined) return trackerError(problem);
-  const id = await freshId(root, input.title);
-  if (id === undefined) return trackerError("a work item title needs letters or digits");
   return save(root, {
-    id,
+    id: await freshId(root, input.title),
     title: input.title,
     body: input.body ?? "",
     status: "open",