@jwilger/pi-development-system 0.50.0 → 0.52.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.50.0",
+  "version": "0.52.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"
@@ -59,7 +59,7 @@
     "test:jev": "node --experimental-transform-types --no-warnings --test \"test/live/*.live.ts\"",
     "check:jev": "node scripts/run-jev-fixtures.ts",
     "typecheck": "tsc --noEmit",
-    "lint": "biome check .",
+    "lint": "biome check --error-on-warnings .",
     "lint:fix": "biome check --write .",
     "check:build-gate": "node scripts/build-gate.ts",
     "check:version": "node scripts/check-version.ts",

package/skills/strict-lints/SKILL.md

@@ -39,7 +39,8 @@ A warning is an error that has not been triaged yet. Before every commit:
   working; deny in CI.
 - Vendored code under `src/subagents` is on a ratchet: `test/subagents/nocheck-files.ts`
   lists the files still skipping type checks and may only shrink. A file you touch there
-  is made clean and dropped from the list.
+  is made type-clean and lint-clean, dropped from the list, and removed from the
+  `!src/subagents/...` exclusions in `biome.json`.
 
 ## What the extension does
 

package/src/core/spawn-overrides.ts

@@ -6,8 +6,8 @@ export type ThinkingLevel = (typeof THINKING_LEVELS)[number];
 
 /** Per-spawn choices the coordinator makes; they beat agent-type preferences and inheritance. */
 export type SpawnOverrides = {
-  readonly model?: string;
-  readonly thinkingLevel?: ThinkingLevel;
+  readonly model?: string | undefined;
+  readonly thinkingLevel?: ThinkingLevel | undefined;
 };
 
 export type Settings = {

package/src/core/test-runner.ts

@@ -2,7 +2,7 @@ import { basename, isAssignment, segments, splitLines, WRAPPERS } from "./git-in
 import { redactSecrets } from "./redact.ts";
 
 const PACKAGE_MANAGERS = new Set(["npm", "pnpm", "yarn", "bun"]);
-const DIRECT_RUNNERS = new Set(["vitest", "jest", "pytest", "mocha", "ava"]);
+const DIRECT_RUNNERS = new Set(["vitest", "jest", "pytest", "mocha", "ava", "tap"]);
 const EXEC_PREFIX = new Set(["npx", "bunx", "pnpx"]);
 const SUMMARY_LINES = 3;
 const SUMMARY_MAX = 300;
@@ -63,6 +63,12 @@ export type ResultLike = {
 
 /** A pipe or sequence makes the shell report the last command's status, not the runner's. */
 const NO_TEST_SCRIPT = /Missing script: "?test/;
+/** What npm prints around a missing script; any other line means something else ran or failed. */
+const NPM_MISSING_SCRIPT_NOISE =
+  /^(?:npm (?:error|ERR!)\s*)?(?:$|.*Missing script.*|.*To see a list of scripts.*|.*A complete log of this run.*|.*Did you mean.*|.*npm run.*|Command exited with code \d+)$/;
+const onlyMissingScript = (text: string): boolean =>
+  NO_TEST_SCRIPT.test(text) &&
+  text.split("\n").every((l) => NPM_MISSING_SCRIPT_NOISE.test(l.trim()));
 const MASKS_STATUS = /[|;\n]/;
 const FAILURE_MARKERS =
   /^(?:# |ℹ )fail [1-9]|test result: FAILED|\b[1-9]\d* (?:failed|failing)\b|^FAILED\b|^FAIL\b|\bnot ok\b/m;
@@ -74,7 +80,7 @@ const isRecord = (v: unknown): v is Record<string, unknown> =>
 export function exitCodeOf(result: ResultLike): number {
   // `npm test` in a package without a test script exits 1 but ran no tests, so it is not a RED;
   // but with --workspaces one package may lack the script while another fails for real.
-  if (NO_TEST_SCRIPT.test(result.text) && !FAILURE_MARKERS.test(result.text)) return 0;
+  if (onlyMissingScript(result.text) && !FAILURE_MARKERS.test(result.text)) return 0;
   const reported = reportedExit(result);
   if (reported !== 0) return reported;
   // `npm test | tail` exits 0 whatever the tests did, even in the structured status; trust the output.

package/src/review/digest.ts

@@ -102,7 +102,8 @@ export async function snapshotDiff(
     const hashed = await hashUntracked(exec, cwd, untracked);
     if (!hashed.ok) return hashed;
     const files = { ...tracked.value, ...hashed.value };
-    const names = Object.keys(files).sort((a, b) => a.localeCompare(b));
+    // Code-unit order, not locale order: the digest must not depend on the runtime's collation.
+    const names = Object.keys(files).sort(byCodeUnit);
     const untrackedStat = [
       ...untracked.map((p) => ` ${p} (untracked)`),
       ...nested.map((p) => ` ${p} (nested repository, not reviewable)`),
@@ -118,6 +119,11 @@ export async function snapshotDiff(
   }
 }
 
+const byCodeUnit = (a: string, b: string): number => {
+  if (a === b) return 0;
+  return a < b ? -1 : 1;
+};
+
 /** Content digests (`new:<blob>`) of untracked files; symlinks are hashed by target, not followed. */
 async function hashUntracked(
   exec: Exec,

package/src/subagents/VENDORED.md

@@ -9,7 +9,7 @@
 
 ## Local modifications (keep this list current)
 
-1. Every `*.ts` file starts with `// @ts-nocheck`: upstream compiles under looser options than this repo's strict `tsconfig.json` (`exactOptionalPropertyTypes`, `erasableSyntaxOnly`). `biome.json` excludes `src/subagents`. Both are deliberate: the code is verbatim, and reformatting or retyping it would make upstream diffs unreadable.
+1. Ratchet. Upstream compiles under looser options than this repo's strict `tsconfig.json` (`exactOptionalPropertyTypes`, `erasableSyntaxOnly`). Files not yet retyped keep `// @ts-nocheck` and are excluded from biome in `biome.json`; both lists must match `test/subagents/nocheck-files.ts`, which may only shrink (`test/subagents/ratchet.test.ts`). Any file we touch is retyped, linted at the repo's strict biome rules and removed from the list. Retyped files that keep a rule violation carry a file-level `biome-ignore-all` with a reason.
 2. Relative `.js` import specifiers were rewritten to `.ts` (upstream relies on a TypeScript-aware loader; this repo's tests run under Node's native type stripping).
 3. `prefs/config.ts`: the bundled-agents directory is `../../../agents/` (was `../../agents/`) because the sources moved one level deeper.
 4. Per-spawn pins (I5.2): `types.ts` `AgentType.spawnOverrides` and `ThreadService.spawn` args gain `model`/`thinkingLevel`; `orch/tools.ts` `agent_spawn` schema exposes both; `orch/manager.ts` `spawn` validates them with `src/core/spawn-overrides.ts` and stores them on the cloned type (so saved threads keep them); `orch/runtime.ts` `resolveInitialSettings` skips the type's preference list when a model is pinned (via `modelSource` in `src/core/spawn-overrides.ts`, so resumed threads keep their model), applies the pin last for fresh spawns, and `createDriver` drops model preferences/scope policy when a model is pinned; `ThreadView.pinned` (`types.ts`) is filled in `orch/manager.ts` `view()` so `agent_status` reports the pins. A pin therefore bypasses `/scoped-models`.

package/src/subagents/orch/mailbox.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
 import { randomUUID } from "node:crypto";
 import type { SessionEntry, SessionManager } from "@earendil-works/pi-coding-agent";
 
@@ -94,10 +93,12 @@ const normalizeLegacyQueue = (
   const steering = value.steering;
   const followUp = value.followUp;
   if (
-    !Array.isArray(steering) ||
-    !steering.every((text) => typeof text === "string") ||
-    !Array.isArray(followUp) ||
-    !followUp.every((text) => typeof text === "string")
+    !(
+      Array.isArray(steering) &&
+      steering.every((text) => typeof text === "string") &&
+      Array.isArray(followUp) &&
+      followUp.every((text) => typeof text === "string")
+    )
   ) {
     return undefined;
   }
@@ -137,7 +138,10 @@ export class DurableMailbox {
   private readonly consumed = new Set<string>();
   private readonly enqueued = new Set<string>();
 
-  constructor(private readonly sessionManager: SessionManager) {
+  private readonly sessionManager: SessionManager;
+
+  constructor(sessionManager: SessionManager) {
+    this.sessionManager = sessionManager;
     this.migrateLegacyQueue();
     this.restore();
   }
@@ -166,7 +170,7 @@ export class DurableMailbox {
 
   private consumeAppended(messageEntryId: string, markerSource: unknown): void {
     const id = getMailboxMarker(markerSource)?.id;
-    if (!id || !this.accepted.has(id) || this.consumed.has(id)) return;
+    if (!(id && this.accepted.has(id)) || this.consumed.has(id)) return;
     this.sessionManager.appendCustomEntry(CONSUMED_TYPE, { id, messageEntryId });
     this.consumed.add(id);
     this.enqueued.delete(id);

package/src/subagents/orch/manager.ts

@@ -788,10 +788,16 @@ export class ThreadManager {
     while (this.records.size >= limit) {
       const paths = [...this.records.keys()];
       const victim = paths.find((path) => {
-        const state = this.records.get(path)?.view.state;
+        const held = this.records.get(path);
+        const state = held?.view.state;
         const finished = state === "completed" || state === "failed" || state === "stopped";
+        // A driver still being created would land on a dropped record and never be disposed.
+        const opening =
+          held?.driver === undefined &&
+          (held?.initializing !== undefined || held?.contextReady !== undefined);
         return (
           finished &&
+          !opening &&
           !isDescendant(spawning, path) &&
           !paths.some((other) => isDescendant(other, path))
         );

package/src/subagents/orch/runtime.ts

@@ -1,46 +1,46 @@
-// @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
+// biome-ignore-all lint/complexity/noExcessiveCognitiveComplexity: the flagged functions (driver construction, settings resolution) are long sequences over pi sessions; only the pin and resume paths are covered by test/subagents/spawn-pins.test.ts, so splitting them would move untested behaviour (see src/subagents/VENDORED.md)
+import { existsSync } from "node:fs";
+import { mkdir, readFile, realpath } from "node:fs/promises";
 import path from "node:path";
 import type { AssistantMessage } from "@earendil-works/pi-ai";
 import { clampThinkingLevel } from "@earendil-works/pi-ai/compat";
-import { existsSync } from "node:fs";
-import { mkdir, readFile, realpath } from "node:fs/promises";
 import {
   createAgentSession,
   createCodemodeExtension,
   createToolSearchExtension,
   DefaultResourceLoader,
+  type ExtensionContext,
   getAgentDir,
   ModelRuntime,
   SessionManager,
   SettingsManager,
-  type ExtensionContext,
 } from "@earendil-works/pi-coding-agent";
-import {
-  BOOTSTRAP_MESSAGE,
-  buildBootstrapMessage,
-  buildQueuedUserMessage,
-  buildUpdateDetails,
-  DurableMailbox,
-} from "./mailbox.ts";
-import { selectTools } from "../prefs/config.ts";
-import { TranscriptChannel } from "./transcript.ts";
-import type { InheritedToolSource } from "./inherited-tools.ts";
-import type { ModelSelectionMode, ToolFilteringMode } from "../prefs/settings.ts";
 import { applySpawnOverrides, modelSource } from "../../core/spawn-overrides.ts";
+import { selectTools } from "../prefs/config.ts";
 import {
-  modelIdentity,
   getModelPreferences,
-  selectPreferredModel,
   ModelPreferenceError,
+  modelIdentity,
+  selectPreferredModel,
 } from "../prefs/models.ts";
+import type { ModelSelectionMode, ToolFilteringMode } from "../prefs/settings.ts";
 import {
-  THINKING_LEVELS,
   type AgentType,
-  type ResolvedAgentSettings,
   type DriverFactory,
   type DriverOptions,
+  type ResolvedAgentSettings,
+  THINKING_LEVELS,
   type ThinkingLevel,
 } from "../types.ts";
+import type { InheritedToolSource } from "./inherited-tools.ts";
+import {
+  BOOTSTRAP_MESSAGE,
+  buildBootstrapMessage,
+  buildQueuedUserMessage,
+  buildUpdateDetails,
+  DurableMailbox,
+} from "./mailbox.ts";
+import { TranscriptChannel } from "./transcript.ts";
 
 const BUILTINS = ["read", "bash", "powershell", "edit", "write", "grep", "find", "ls"];
 /** Persisted before transcript messages so older-leaf restores still carry ownership. */
@@ -157,7 +157,7 @@ export function createDriverFactory(
     type: AgentType,
     parentPath?: string | null,
     restored?: ReturnType<SessionManager["buildSessionContext"]>,
-  ): { provider?: string; id?: string; thinkingLevel: ThinkingLevel };
+  ): { provider?: string | undefined; id?: string | undefined; thinkingLevel: ThinkingLevel };
 } {
   // Keep resolved settings even after disposal: descendants inherit settings, not the caller's history.
   const resolved = new Map<string, { provider: string; id: string; thinking: ThinkingLevel }>();
@@ -226,9 +226,9 @@ export function createDriverFactory(
       const candidates = filtering
         ? availableScopedModels(normalizeScopedModels(ctx.scopedModels))
         : availableModelCandidates();
-      ({ provider, id } = parseModelIdentity(
-        selectTypeModelPreference(type, candidates, filtering)!,
-      ));
+      const preferred = selectTypeModelPreference(type, candidates, filtering);
+      if (preferred === undefined) throw new Error("No preferred model is available");
+      ({ provider, id } = parseModelIdentity(preferred));
     } else if (source === "restored" && restored?.model) {
       provider = restored.model.provider;
       id = restored.model.modelId;
@@ -252,7 +252,7 @@ export function createDriverFactory(
     const { provider, id, thinkingLevel } = resolveInitialSettings(type, parentPath);
     const model =
       normalizeScopedModels(ctx.scopedModels).find(
-        ({ model }) => model.provider === provider && model.id === id,
+        (scoped) => scoped.model.provider === provider && scoped.model.id === id,
       )?.model ?? (provider && id ? ctx.modelRegistry.find(provider, id) : undefined);
     if (!model)
       throw new Error(
@@ -381,14 +381,15 @@ export function createDriverFactory(
       modelId: string | undefined,
       scopedModels: readonly ScopedModel[],
     ) => {
-      if (!providerId || !modelId)
+      if (!(providerId && modelId))
         throw new Error(
           `Subagent model ${providerId ?? "(unset)"}/${modelId ?? "(unset)"} is unavailable; select a physical model in the root or agent type`,
         );
       await mirrorRuntimeAuth(providerId);
       const sourceModel =
-        scopedModels.find(({ model }) => model.provider === providerId && model.id === modelId)
-          ?.model ?? ctx.modelRegistry.find(providerId, modelId);
+        scopedModels.find(
+          (scoped) => scoped.model.provider === providerId && scoped.model.id === modelId,
+        )?.model ?? ctx.modelRegistry.find(providerId, modelId);
       if (sourceModel?.api === "pi-virtual") {
         throw new Error(
           `Virtual model ${providerId}/${modelId} cannot be reproduced through the public registry API. Set this agent type's model to a physical provider/model-id.`,
@@ -414,13 +415,16 @@ export function createDriverFactory(
     const rootActive = new Set(inherited.activeNames);
     // Preserve deferred/codemode exposure rather than flooding model declarations with MCP tools.
     const activeToolNames = toolNames.filter(
-      (name) => localNames.has(name) || rootActive.has(name) || options.type.tools?.allow?.includes(name) && toolFiltering === "allowed",
+      (name) =>
+        localNames.has(name) ||
+        rootActive.has(name) ||
+        (options.type.tools?.allow?.includes(name) && toolFiltering === "allowed"),
     );
     const customTools = [...options.tools, ...externalTools].filter(
       (tool) => allowed.has(tool.name) && tool.name !== "codemode" && tool.name !== "tool_search",
     );
     const settingsManager = SettingsManager.inMemory({ cacheWarming: "off" });
-    let parkQueue = () => {};
+    let parkQueue: () => void = () => undefined;
     const pauseBoundary = () => {
       if (!options.shouldPause()) return undefined;
       parkQueue();
@@ -558,7 +562,7 @@ export function createDriverFactory(
       throw error;
     }
     const streamFunction = session.agent.streamFunction;
-    session.agent.streamFunction = async (requestModel, context, streamOptions) => {
+    session.agent.streamFunction = (requestModel, context, streamOptions) => {
       assertScopedRequestAuthorized(
         modelIdentity(requestModel),
         normalizeScopedModels(getRootContext().scopedModels),
@@ -579,7 +583,7 @@ export function createDriverFactory(
       sessionManager.appendMessage(buildBootstrapMessage());
       emit("activity", BOOTSTRAP_MESSAGE);
     };
-    const queueAccepted = async (kind: "steer" | "followUp", content: string) => {
+    const queueAccepted = (kind: "steer" | "followUp", content: string): Promise<void> => {
       assertCurrentModelAuthorized();
       ensurePersistedSession();
       const accepted = mailbox.accept(kind, content);
@@ -587,6 +591,7 @@ export function createDriverFactory(
       if (kind === "followUp") session.agent.followUp(buildQueuedUserMessage(accepted));
       else session.agent.steer(buildQueuedUserMessage(accepted));
       mailbox.markEnqueued(accepted.id);
+      return Promise.resolve();
     };
     const resumePending = async () => {
       for (const accepted of mailbox.replayablePending()) {
@@ -641,7 +646,7 @@ export function createDriverFactory(
       const usage = message.usage;
       const input = usage.input + usage.cacheRead + usage.cacheWrite;
       const output = usage.output;
-      if (!Number.isFinite(input) || !Number.isFinite(output)) return;
+      if (!(Number.isFinite(input) && Number.isFinite(output))) return;
       return { input, output, reported: input + output + usage.totalTokens > 0 };
     };
 
@@ -650,7 +655,7 @@ export function createDriverFactory(
       .find((entry) => entry.type === "custom" && entry.customType === THREAD_OWNERSHIP_TYPE);
     const inheritedMetadata =
       ownership?.type === "custom"
-        ? (ownership.data as { inheritedCount?: unknown })?.inheritedCount
+        ? (ownership.data as { inheritedCount?: unknown }).inheritedCount
         : undefined;
     const inheritedCount =
       typeof inheritedMetadata === "number" &&

package/src/subagents/orch/tools.ts

@@ -1,9 +1,8 @@
-// @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
-import { Type } from "typebox";
 import type { ToolDefinition } from "@earendil-works/pi-coding-agent";
-import type { ThreadManager } from "./manager.ts";
+import { Type } from "typebox";
 import { ModelPreferenceError } from "../prefs/models.ts";
 import type { AgentType, ResolvedAgentSettings, ThreadView } from "../types.ts";
+import type { ThreadManager } from "./manager.ts";
 
 const path = Type.String({ description: "Absolute agent path, or name relative to the caller" });
 const text = Type.String({ minLength: 1 });
@@ -30,8 +29,10 @@ export function agentTools(
   const make = (
     name: string,
     description: string,
+    // biome-ignore-start lint/suspicious/noExplicitAny: the host validates params against the TypeBox schema before execute runs, and each handler reads only fields that schema declares
     parameters: any,
     execute: (params: any, signal?: AbortSignal) => Promise<any> | any,
+    // biome-ignore-end lint/suspicious/noExplicitAny: end of the schema-validated boundary
   ): ToolDefinition => ({
     name,
     label: name,
@@ -53,12 +54,7 @@ export function agentTools(
             return {
               name,
               description,
-              error:
-                error instanceof ModelPreferenceError
-                  ? error.summary
-                  : error instanceof Error
-                    ? error.message
-                    : String(error),
+              error: describeError(error),
             };
           }
         });
@@ -99,7 +95,8 @@ export function agentTools(
         ),
         thinkingLevel: Type.Optional(
           Type.String({
-            description: "Pin this child's thinking level: off, minimal, low, medium, high, xhigh or max.",
+            description:
+              "Pin this child's thinking level: off, minimal, low, medium, high, xhigh or max.",
           }),
         ),
       }),
@@ -175,3 +172,8 @@ export function agentTools(
     ),
   ];
 }
+
+function describeError(error: unknown): string {
+  if (error instanceof ModelPreferenceError) return error.summary;
+  return error instanceof Error ? error.message : String(error);
+}

package/src/subagents/prefs/agent-import.ts

@@ -1,13 +1,12 @@
-// @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
-import { constants, lstatSync, mkdirSync, openSync, closeSync, writeFileSync } from "node:fs";
+import { closeSync, constants, lstatSync, mkdirSync, openSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
 import { fileURLToPath } from "node:url";
 import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { dialogText } from "../ui/dialog.ts";
+import { selectImportAgents } from "../ui/import-picker.ts";
 import { AGENT_COLORS, type ConfigStore } from "./config.ts";
 import { discoverImportCandidates, type ImportCandidate } from "./import-discovery.ts";
-import { selectImportAgents } from "../ui/import-picker.ts";
 import { MIGRATION_INSTRUCTIONS } from "./import-instructions.ts";
-import { dialogText } from "../ui/dialog.ts";
 
 export const IMPORT_REQUEST_PREFIX =
   "Import ONLY the agents I selected in the pi-subagent-manager migration picker.";
@@ -70,7 +69,8 @@ function importWasOffered(agentDir: string): boolean {
 }
 
 export function markImportOffered(agentDir: string): void {
-  const directory = stateDirectory(agentDir, true)!;
+  const directory = stateDirectory(agentDir, true);
+  if (directory === undefined) throw new Error("Import-state directory could not be created");
   const file = join(directory, OFFER_MARKER);
   const stat = statIfPresent(file);
   if (stat) {
@@ -94,11 +94,11 @@ function buildImportPrompt(options: {
   agentDir: string;
   cwd: string;
   includeProject: boolean;
-  existingTypes: { name: string; source?: string; filePath?: string }[];
+  existingTypes: { name: string; source?: string | undefined; filePath?: string | undefined }[];
   scopedModels: readonly string[];
-  scopedModelDetails?: readonly { identity: string; api: string; virtual: boolean }[];
-  parentModel?: string;
-  parentModelApi?: string;
+  scopedModelDetails?: readonly { identity: string; api: string; virtual: boolean }[] | undefined;
+  parentModel?: string | undefined;
+  parentModelApi?: string | undefined;
 }): string {
   return [
     IMPORT_REQUEST_PREFIX,
@@ -159,10 +159,10 @@ export async function offerAgentImport(
       cwd: ctx.cwd,
       agentDir: options.agentDir,
       includeProject: ctx.isProjectTrusted(),
-      homeDir: options.homeDir,
-      extraAgentDirs: options.extraAgentDirs,
+      ...(options.homeDir === undefined ? {} : { homeDir: options.homeDir }),
+      ...(options.extraAgentDirs === undefined ? {} : { extraAgentDirs: options.extraAgentDirs }),
     });
-    if (found.diagnostics.length)
+    if (found.diagnostics.length > 0)
       ctx.ui.notify(dialogText(found.diagnostics.join("\n")), "warning");
     const remember = () => {
       try {
@@ -174,9 +174,9 @@ export async function offerAgentImport(
         );
       }
     };
-    if (!found.candidates.length) {
+    if (found.candidates.length === 0) {
       // Retry an incomplete scan next startup, rather than permanently hiding unreadable definitions.
-      if (!found.diagnostics.length) remember();
+      if (found.diagnostics.length === 0) remember();
       if (!firstRun)
         ctx.ui.notify(
           "No external agent definitions found. Package-provided defaults are not scanned.",
@@ -208,7 +208,7 @@ export async function offerAgentImport(
     }
     const selected = new Set(ids);
     const candidates = found.candidates.filter((candidate) => selected.has(candidate.id));
-    if (!candidates.length) return false;
+    if (candidates.length === 0) return false;
     options.store.reload();
     const prompt = buildImportPrompt({
       candidates,