@jwilger/pi-development-system 0.50.0 → 0.51.1

package/src/subagents/ui/import-picker.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
 import type { ExtensionContext, Theme } from "@earendil-works/pi-coding-agent";
 import {
   CURSOR_MARKER,
@@ -10,10 +9,10 @@ import {
 } from "@earendil-works/pi-tui";
 import {
   DIALOG_OPTIONS,
+  type DialogHost,
   dialogHeight,
   dialogText,
   frameDialog,
-  type DialogHost,
 } from "./dialog.ts";
 
 export interface ImportPickerItem {
@@ -76,12 +75,28 @@ class ImportPicker {
   private viewport = 1;
   private readonly checked = new Set<string>();
 
+  private host: DialogHost;
+
+  private theme: Theme;
+
+  private readonly items: readonly ImportPickerItem[];
+
+  private done: (ids: string[] | undefined) => void;
+
   constructor(
-    private host: DialogHost,
-    private theme: Theme,
-    private readonly items: readonly ImportPickerItem[],
-    private done: (ids: string[] | undefined) => void,
-  ) {}
+    host: DialogHost,
+    theme: Theme,
+    items: readonly ImportPickerItem[],
+    done: (ids: string[] | undefined) => void,
+  ) {
+    this.host = host;
+
+    this.theme = theme;
+
+    this.items = items;
+
+    this.done = done;
+  }
 
   /** Selected ids in source order. Empty until the user toggles a row. */
   getSelectedIds(): string[] {
@@ -99,7 +114,9 @@ class ImportPicker {
     return this.cursor;
   }
 
-  invalidate(): void {}
+  invalidate(): void {
+    // Nothing is cached, so there is nothing to invalidate.
+  }
 
   handleInput(data: string): void {
     const keys = getKeybindings();
@@ -155,8 +172,8 @@ class ImportPicker {
       if (listCount > 0) body.push(this.theme.fg("muted", " No external agents to import"));
     } else {
       const rows = this.items.slice(start, start + listCount);
-      for (let offset = 0; offset < rows.length; offset++)
-        body.push(this.row(rows[offset]!, start + offset === this.cursor));
+      for (const [offset, row] of rows.entries())
+        body.push(this.row(row, start + offset === this.cursor));
     }
     if (gap) body.push("");
     for (const line of detail.slice(0, detailCount)) body.push(this.theme.fg("muted", ` ${line}`));
@@ -164,7 +181,7 @@ class ImportPicker {
   }
 
   private countLine(start: number, shown: number): string {
-    const position = this.items.length ? this.cursor + 1 : 0;
+    const position = this.items.length > 0 ? this.cursor + 1 : 0;
     return this.theme.fg(
       "dim",
       ` ${this.scrollHint(start, shown)}${this.checked.size} selected · ${position}/${this.items.length}`,

package/src/subagents/ui/live-agent-view.ts

@@ -13,7 +13,7 @@ import {
   wrapTextWithAnsi,
 } from "@earendil-works/pi-tui";
 import type { ThreadService, TranscriptSnapshot } from "../types.ts";
-import { dialogText, type DialogHost } from "./dialog.ts";
+import { type DialogHost, dialogText } from "./dialog.ts";
 import { AGENT_PROGRESS_INTERVAL, agentProgressIcon, agentTypeLabel } from "./ui.ts";
 
 /** Transcript detail level cycled by the t key: full → preview → compact. */
@@ -66,7 +66,10 @@ export class LiveAgentView {
   private unsubscribe: (() => void) | undefined;
   private renderTimer: ReturnType<typeof setTimeout> | undefined;
   private progressTimer: ReturnType<typeof setInterval> | undefined;
-  private cache = new WeakMap<object, { width: number; detail: TranscriptDetail; lines: string[] }>();
+  private cache = new WeakMap<
+    object,
+    { width: number; detail: TranscriptDetail; lines: string[] }
+  >();
   private scroll: ScrollView;
   private content: string[] = [];
   private restoreViewport = true;
@@ -188,7 +191,10 @@ export class LiveAgentView {
 
   private syncProgress(): void {
     const state = this.snapshot?.thread?.state;
-    const active = this.nerdFontIcons && !this.disposed && !this.error &&
+    const active =
+      this.nerdFontIcons &&
+      !this.disposed &&
+      !this.error &&
       (state === "starting" || state === "running");
     if (!active) {
       if (this.progressTimer !== undefined) clearInterval(this.progressTimer);
@@ -333,7 +339,11 @@ export class LiveAgentView {
         if (this.detail === "compact")
           return [this.theme.fg("dim", "[Thinking hidden · t cycles view]")];
         // Thinking is model-authored Markdown; preview truncates the rendered lines, not the source.
-        const rendered = this.markdown(String(block.thinking ?? "[redacted thinking]"), width, true);
+        const rendered = this.markdown(
+          String(block.thinking ?? "[redacted thinking]"),
+          width,
+          true,
+        );
         if (this.detail === "full" || rendered.length <= 3) return rendered;
         return [...rendered.slice(0, 3), this.theme.fg("dim", "...")];
       }
@@ -449,7 +459,9 @@ export class LiveAgentView {
       }
       case "ls": {
         const limit = num("limit");
-        lines = [`${title("ls")} ${path ?? "."}${limit != null ? detail(` (limit ${limit})`) : ""}`];
+        lines = [
+          `${title("ls")} ${path ?? "."}${limit != null ? detail(` (limit ${limit})`) : ""}`,
+        ];
         break;
       }
       default:

package/src/subagents/ui/model-picker.ts

@@ -1,9 +1,9 @@
-// @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
-import fuzzysort, { type SnapshotKeys } from "fuzzysort";
+// biome-ignore-all lint/suspicious/noControlCharactersInRegex: vendored upstream TUI/config code with no tests; rewriting it risks behaviour (see src/subagents/VENDORED.md)
+// biome-ignore-all lint/suspicious/useAwait: vendored upstream TUI/config code with no tests; rewriting it risks behaviour (see src/subagents/VENDORED.md)
 import type { Api, Model } from "@earendil-works/pi-ai";
 import {
-  getSelectListTheme,
   type ExtensionCommandContext,
+  getSelectListTheme,
   type ScopedModel,
   type Theme,
 } from "@earendil-works/pi-coding-agent";
@@ -13,14 +13,15 @@ import {
   Input,
   Key,
   matchesKey,
+  type SelectItem,
   SelectList,
   stripTerminalSequences,
-  truncateToWidth,
   Text,
-  type SelectItem,
+  truncateToWidth,
 } from "@earendil-works/pi-tui";
+import fuzzysort, { type SnapshotKeys } from "fuzzysort";
 import { modelIdentity } from "../prefs/models.ts";
-import { dialogHeight, frameDialog, DIALOG_OPTIONS } from "./dialog.ts";
+import { DIALOG_OPTIONS, dialogHeight, frameDialog } from "./dialog.ts";
 
 const MODEL_EDITOR_LAYOUT = {
   minPrimaryColumnWidth: 24,
@@ -44,8 +45,8 @@ interface OrderedModelEditorComponentOptions {
   theme: Theme;
   availableModels: readonly AvailableModel[];
   scopedModels: readonly ScopedModel[];
-  initialModels?: readonly string[];
-  modelSuggestions?: readonly string[];
+  initialModels?: readonly string[] | undefined;
+  modelSuggestions?: readonly string[] | undefined;
   onDone(models: string[]): void;
   onCancel(): void;
 }
@@ -133,7 +134,7 @@ class OrderedModelEditorComponent extends Container {
       this.theme.fg(
         "muted",
         this.withScopeWarning(
-          this.suggestedScores.size
+          this.suggestedScores.size > 0
             ? "Selected first; suggested matches scoped first, then other models; the rest A–Z. Type to search."
             : "Selected first. Search by provider/id or model name; other models A–Z.",
         ),
@@ -244,7 +245,12 @@ class OrderedModelEditorComponent extends Container {
       const next = index + (earlier ? -1 : 1);
       // Consume reorder keys even on unselected models or at a list boundary.
       if (index >= 0 && next >= 0 && next < this.draft.length) {
-        [this.draft[index], this.draft[next]] = [this.draft[next], this.draft[index]];
+        const moved = this.draft[index];
+        const other = this.draft[next];
+        if (moved !== undefined && other !== undefined) {
+          this.draft[index] = other;
+          this.draft[next] = moved;
+        }
         this.refreshPickerList(selected);
         this.tui.requestRender();
       }
@@ -271,6 +277,11 @@ class OrderedModelEditorComponent extends Container {
     this.tui.requestRender();
   }
 
+  private fallbackIndex(focusSearchResult: boolean, previousIndex: number): number {
+    if (focusSearchResult) return 0;
+    return Math.max(0, Math.min(previousIndex, this.currentItems.length - 1));
+  }
+
   private refreshPickerList(selectedValue?: string, focusSearchResult = false): void {
     const previousIndex = this.currentItems.findIndex(
       (item) => item.value === this.selectList.getSelectedItem()?.value,
@@ -314,11 +325,7 @@ class OrderedModelEditorComponent extends Container {
         )
       : this.currentItems.findIndex((item) => item.value === selectedValue);
     list.setSelectedIndex(
-      preferredIndex >= 0
-        ? preferredIndex
-        : focusSearchResult
-          ? 0
-          : Math.max(0, Math.min(previousIndex, this.currentItems.length - 1)),
+      preferredIndex >= 0 ? preferredIndex : this.fallbackIndex(focusSearchResult, previousIndex),
     );
     list.onSelect = (item) => {
       if (this.currentItems.find((row) => row.value === item.value)?.group === ACTIONS_GROUP) {
@@ -380,7 +387,8 @@ class OrderedModelEditorComponent extends Container {
       }
     }
     const bySuggestionScore = (a: AvailableModel, b: AvailableModel) =>
-      this.suggestedScores.get(modelIdentity(b))! - this.suggestedScores.get(modelIdentity(a))!;
+      (this.suggestedScores.get(modelIdentity(b)) ?? 0) -
+      (this.suggestedScores.get(modelIdentity(a)) ?? 0);
     // Stable score sorting preserves alphabetical order for ties. The last
     // tier retains the registry's alphabetical order, irrespective of scope.
     scoped.sort(bySuggestionScore);
@@ -397,7 +405,8 @@ class OrderedModelEditorComponent extends Container {
       ...items(other, "Suggested matches · other models"),
       ...items(
         remaining,
-        scoped.length || other.length ? "All other models · A–Z" : "All models · A–Z",
+
+        scoped.length > 0 || other.length > 0 ? "All other models · A–Z" : "All models · A–Z",
       ),
     ];
   }

package/src/subagents/ui/settings-ui.ts

@@ -1,23 +1,19 @@
-// @ts-nocheck: vendored upstream pi-subagent-manager 0.14.0 compiled under looser options; see src/subagents/VENDORED.md
+// biome-ignore-all lint/complexity/noExcessiveCognitiveComplexity: vendored upstream TUI/config code with no tests; rewriting it risks behaviour (see src/subagents/VENDORED.md)
+// biome-ignore-all lint/suspicious/noUnnecessaryConditions: vendored upstream TUI/config code with no tests; rewriting it risks behaviour (see src/subagents/VENDORED.md)
 import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
 import type { ConfigStore } from "../prefs/config.ts";
-import {
-  canOpenDialog,
-  dialogInput,
-  dialogMenu,
-  withDialogSession,
-} from "./dialog.ts";
 import {
   DEFAULT_MANAGER_SETTINGS,
   loadManagerSaveScope,
-  saveManagerSaveScope,
-  saveManagerSettings,
   type ManagerSettings,
   type ModelSelectionMode,
   type SubagentMode,
+  saveManagerSaveScope,
+  saveManagerSettings,
   type ToolFilteringMode,
   type WidgetMode,
 } from "../prefs/settings.ts";
+import { canOpenDialog, dialogInput, dialogMenu, withDialogSession } from "./dialog.ts";
 import { editAgentTypes } from "./ui.ts";
 
 const FIELDS = [
@@ -138,9 +134,7 @@ export async function configureAgents(
   },
 ): Promise<void> {
   if (!canOpenDialog(ctx)) return;
-  await withDialogSession(ctx, (scoped) =>
-    configureAgentsDialog(scoped, options),
-  );
+  await withDialogSession(ctx, (scoped) => configureAgentsDialog(scoped, options));
 }
 
 async function configureAgentsDialog(
@@ -167,13 +161,13 @@ async function configureAgentsDialog(
         {
           id: "subagentMode",
           label: "Subagent Mode",
-          value: MODE_OPTIONS.find((mode) => mode.id === draft.subagentMode)!.label,
+          value: MODE_OPTIONS.find((mode) => mode.id === draft.subagentMode)?.label,
           help: MODE_HELP,
         },
         {
           id: "toolFiltering",
           label: "Tool Filtering",
-          value: TOOL_FILTERING_OPTIONS.find((mode) => mode.id === draft.toolFiltering)!.label,
+          value: TOOL_FILTERING_OPTIONS.find((mode) => mode.id === draft.toolFiltering)?.label,
           help: TOOL_FILTERING_HELP,
         },
         ...FIELDS.map((field) => ({
@@ -183,13 +177,13 @@ async function configureAgentsDialog(
         {
           id: "modelSelection",
           label: "Model Picking",
-          value: MODEL_SELECTION_OPTIONS.find((mode) => mode.id === draft.modelSelection)!.label,
+          value: MODEL_SELECTION_OPTIONS.find((mode) => mode.id === draft.modelSelection)?.label,
           help: MODEL_SELECTION_HELP,
         },
         {
           id: "widgetMode",
           label: "Status Widget",
-          value: WIDGET_MODE_OPTIONS.find((mode) => mode.id === draft.widgetMode)!.label,
+          value: WIDGET_MODE_OPTIONS.find((mode) => mode.id === draft.widgetMode)?.label,
           help: WIDGET_MODE_HELP,
         },
         {
@@ -225,7 +219,7 @@ async function configureAgentsDialog(
           id: "save",
           label: "Save and apply",
           value: dirty ? "(changes)" : undefined,
-          valueColor: dirty ? "warning" as const : undefined,
+          valueColor: dirty ? ("warning" as const) : undefined,
           help: "Save all values to the selected scope and reload settings now.\nProject overrides still take precedence.\nRunning agents and retained sessions are kept.",
         },
         {
@@ -243,19 +237,13 @@ async function configureAgentsDialog(
     if (!action || action === "cancel") return;
     selectedId = action;
     try {
-      const field = FIELDS.find((field) => field.id === action);
+      const field = FIELDS.find((candidate) => candidate.id === action);
       if (field) {
-        const value = await dialogInput(
-          ctx,
-          field.label,
-          String(draft[field.id]),
-          field.help,
-        );
+        const value = await dialogInput(ctx, field.label, String(draft[field.id]), field.help);
         if (value === undefined) continue;
         const number = Number(value.trim());
         if (
-          !/^\d+$/.test(value.trim()) ||
-          !Number.isSafeInteger(number) ||
+          !(/^\d+$/.test(value.trim()) && Number.isSafeInteger(number)) ||
           number < 1 ||
           (field.id === "maxLevels" && number > 32)
         )
@@ -291,10 +279,7 @@ async function configureAgentsDialog(
         draft.finalRecap = !draft.finalRecap;
       } else if (action === "scope") {
         if (!ctx.isProjectTrusted())
-          ctx.ui.notify(
-            "Project settings require a trusted project; saving globally.",
-            "warning",
-          );
+          ctx.ui.notify("Project settings require a trusted project; saving globally.", "warning");
         else {
           const nextScope = scope === "user" ? "project" : "user";
           saveManagerSaveScope(options.agentDir, nextScope);
@@ -320,10 +305,7 @@ async function configureAgentsDialog(
         return;
       }
     } catch (error) {
-      ctx.ui.notify(
-        error instanceof Error ? error.message : String(error),
-        "error",
-      );
+      ctx.ui.notify(error instanceof Error ? error.message : String(error), "error");
     }
   }
 }