@jwilger/pi-development-system 0.47.0 → 0.48.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@jwilger/pi-development-system",
-  "version": "0.47.0",
+  "version": "0.48.0",
   "description": "A pi extension package representing a seasoned approach to software development using a full AI SDLC.",
   "keywords": [
     "pi-package"

package/skills/strict-lints/SKILL.md

@@ -24,6 +24,23 @@ finding from every later reader, so it must carry its reason.
   clippy; biome recommended-plus; TypeScript `strict`. Loosening a project rule is a
   recorded decision, not an edit.
 
+## No warning stands
+
+A warning is an error that has not been triaged yet. Before every commit:
+
+- Biome, `tsc`, knip and markdownlint pass with nothing reported (lefthook and CI run them).
+- `lens_diagnostics` (pi-lens) shows no warnings for the files you changed. Run it with
+  `mode=full` on those paths after a refresh; a cached finding that looks wrong is a stale
+  cache to refresh (touch the file and re-run), never one to wave off.
+- Each finding is fixed, or suppressed on the line above with a reason
+  (`// pi-lens-ignore: high-fan-out -- composition root: wiring is its job`).
+- Enable stricter rules by the behaviour they prevent (silent failure, panics, shadowing,
+  unreasoned `allow`), not whole categories that contradict each other. Warn while
+  working; deny in CI.
+- Vendored code under `src/subagents` is on a ratchet: `test/subagents/nocheck-files.ts`
+  lists the files still skipping type checks and may only shrink. A file you touch there
+  is made clean and dropped from the list.
+
 ## What the extension does
 
 Editing a file so that it adds `#[allow(`, `#[expect(`, `// biome-ignore`,
@@ -44,3 +61,4 @@ departure naming why a bare one is right. Suppressions already in the file are n
 - [ ] Suppression is one line with a reason of 15+ characters
 - [ ] `expect` used where available
 - [ ] No lint rule loosened in project config without a recorded decision
+- [ ] `lens_diagnostics` shows no warnings on the changed files (refreshed, not cached)

package/src/subagents/prefs/config.ts

@@ -500,7 +500,7 @@ export function diffAgentSettings(base: AgentType, draft: AgentType): AgentSetti
     const after = draft[key];
     if (JSON.stringify(before ?? null) === JSON.stringify(after ?? null)) continue;
     if (after === undefined) override[key] = null as never;
-    else (override[key] as unknown) = structuredClone(after);
+    else Object.assign(override, { [key]: structuredClone(after) });
   }
   void CLEARABLE_OVERRIDE_FIELDS;
   return override;